- Sep 20, 2023
-
-
Oliver Hader authored
This change uses the dependency ordering service in the method `\TYPO3\TestingFramework\Core\Testbase::setUpPackageStates` for test scenarios in functional and acceptance tests. Besides that the following changes were applied: * remove invalid dependency in fixture ext:test_configoverride_second * add `PackageStatesTest` to keep track of extension dependencies * add dependency to ext:frontend in ext:form, since it overrides TCA for the tables tt_content and sys_template (which would result in different ext:impexp results due to table field orderings) * recreate IRRE related XML fixtures for ext:impexp since fixture extensions are now ordered alphabetically (and due to #100734) Resolves: #101809 Releases: main, 12.4 Change-Id: I1f91a75ac8aec9db0291b0f5c8bcf7162d5b0082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81093 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benjamin Kott authored
Resolves: #101953 Releases: main, 12.4 Change-Id: I1b0d715a96ee914dc8f9787089406457b750df2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81066 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
- Sep 19, 2023
-
-
Oliver Hader authored
This change extracts dynamic stylesheets of web components that are attached to the light DOM to a corresponding static file in the directory `Build/Sources/Sass/element/` (it will be merged to `backend.css` during the build process). This change allows to get rid of the `window.litNonce` helper function that was introduced to allow CSP for dynamic styles. Besides that, the shadow DOM component `typo3-backend-spinner` now uses constructed stylesheets directly. In addition, the missing component names have been added to the global map. Resolves: #101744 Releases: main, 12.4 Change-Id: I7cf3cdc31d0ffe685897e48f000f18e9b5b5aca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81080 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Kott authored
To support the right to left reading mode for languages like Arabic, we have adjusted the styles in the backend to use logical instead of physical properties. Resolves: #101902 Releases: main, 12.4 Change-Id: I60936682fbeeb35c676f157e63135137b03106e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81063 Tested-by:
-
Oliver Bartsch authored
FileStorageTreeProvider now considers all file mounts, a user (non-admin) has access to, for the file and folder search in the folder tree. Resolves: #98423 Releases: main, 12.4 Change-Id: Id58665392b4351d0c5ecb46335097027f6bf139e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81062 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Sep 18, 2023
-
-
Oliver Bartsch authored
The @internal update() method of MetaDataRepository now checks the data to be updated against the current database row, preventing updating of the records timestamp in case no actual update needs to be done. Additionally, the method now returns the database row. Resolves: #97775 Releases: main, 12.4 Change-Id: I1429605880ec815deb1d6111bc6b1686558b6f5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81061 Reviewed-by:
-
Oliver Bartsch authored
When copy a file corresponding metadata are now also copied, preserving existing properties like "file" or "uid". Resolves: #70934 Releases: main, 12.4 Change-Id: Ifbc15b1ad2f1baaba48edbc5299d3b89e2755a53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81060 Tested-by:
-
Oliver Klee authored
If the flexforms data is null, there is no point trying to parse that as XML. This avoids type errors when `GeneralUtility` gets native parameter type declarations for `GU::xml2array`, and it should also slightly increase performance. Also fix the corresponding PHPDoc type annotation to reflect that a parameter in reality needs to be nullable. Resolves: #101891 Releases: main, 12.4, 11.5 Change-Id: I39efc1d26300634c0bed74aee1f7ebd444acb8c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81058 Tested-by:
-
Philipp Kitzberger authored
Resolves: #96537 Releases: main, 12.4, 11.5 Change-Id: I0b2b4dbf47d58f21df8ffb3d91a889c22b092280 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81048 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
Resolves: #101925 Releases: main, 12.4, 11.5 Change-Id: Icec9f634ca1e1a9c7ad6b3a55afaf197cfa44acc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81044 Tested-by:
-
Georg Ringer authored
Resolves: #101730 Releases: main, 12.4, 11.5 Change-Id: I9e400e1c582f84602b6aa8ef3cdd9a85f4e5b93e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81056 Tested-by:
-
Sybille Peters authored
- Add unit tests for function ContentObjectRenderer::listNum() - Improve code by renaming function argument ($char => $delimeter) - Make sure arguments are always passed as strings (and not null) (as declared in PHPDoc) - Improve clarity of description in PHPDoc In the future typehints can be added for function arguments and return type. Resolves: #101934 Releases: main, 12.4 Change-Id: Ic748d74350d5ff629e8a292dc058bb93ed167448 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81055 Tested-by:
-
Oliver Bartsch authored
Resolves: #101940 Releases: main, 12.4 Change-Id: Ib8cc5c5bfc886686c1abfe5ed35724e1e268e800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81043 Tested-by:
-
Benjamin Kott authored
Resolves: #101860 Releases: main, 12.4 Change-Id: I069355cf87eaf46ff849367e2870cf51fb44c726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81053 Tested-by:
-
Daniel Siepmann authored
Resolves: #101938 Releases: main, 12.4 Change-Id: I8def061d7188a4d247a832247c01cdddd745c7dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81054 Tested-by:
-
Benjamin Franzke authored
Make sure that all imports are from the package entry point instead of the path to a module as suggested by upstream: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-37.html Note: `LinkActionsView` still needs to be imported from `@ckeditor/ckeditor5-link/src/ui/linkactionsview.js` and `LinkUtils` from `@ckeditor/ckeditor5-link/src/utils.js` as they are not exported as named exports on the package entry points. Resolves: #101916 Releases: main, 12.4 Change-Id: I3171fd44c99984dc9a768122fe2297e1b7b6106f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81036 Tested-by:
-
Benjamin Kott authored
The report overview was adjusted to match other already existing entrypoints like the about module. In the form framework the class is simply dropped as it provided no additional benefit. Resolves: #101926 Releases: main, 12.4 Change-Id: I02341658b69ef5a2a24df507d7df2e78658caef6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81052 Tested-by:
-
- Sep 15, 2023
-
-
Torben Hansen authored
The CKEditor 5 build for TYPO3 contains the "General HTML Support" plugin. It is however not possible to configure the plugin, since the `htmlSupport` configuration key is not added to the CKEditor configuration. With this patch, the `htmlSupport` configuration key is passed through to the general CKEditor configuration. See https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html Resolves: #100861 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ieb4a28bf777632aa2d7e2c68a884f8e7a0174509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81001 Tested-by:
-
Stefan Froemken authored
If the CKEditor is configured with the new v5-style `toolbar.removeItems` option instead of `removeButtons` (v4), the CKEditor5Migrator will now merge`removeItems` with `removeButtons`. Also do not overwrite `toolbar.shouldNotGroupWhenFull`, allowing it to be set to false. Note that v5-style `toolbar.items` where already defined to be used when v4-style `toolbarGroups` are empty, so we do not change this behavior. Resolves: #100829 Resolves: #101869 Releases: main, 12.4 Change-Id: Iebf70567866af13411c3d3b734e2f518dbd0b4e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81000 Tested-by:
-
Benjamin Kott authored
Correct bindings for multi record selection actions. Move draghandle to dedicated button to have a visual difference for elements that are sortable and to not conflict with existing inputs. Avoid console warnings by checking first if an element exists before binding it to events. Resolves: #100858 Releases: main, 12.4 Change-Id: Ia07ab35b0e6b71bbfd9981ca53d333bada928f3d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81023 Tested-by:
-
- Sep 14, 2023
-
-
Benjamin Kott authored
Resolves: #101907 Releases: main, 12.4 Change-Id: I1da8b484411a4add3fb6bee805fd0b76cc45fdf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80998 Tested-by:
-
- Sep 13, 2023
-
-
Benjamin Kott authored
The quick edit features for the page title in the page module and the quick edit feature for scheduler groups do both have buttons with icons only. To increase accessibility and improve the usability with screen readers in the TYPO3 backend, labels are added. Resolves: #101652 Releases: main, 12.4 Change-Id: Icd930d958eaa0c4bcc3274ed29e073bec41a59a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80997 Tested-by:
-
Andreas Fernandez authored
Executed commands: npm install --save jquery@^3.7.1 npm run build Resolves: #101910 Releases: main, 12.4 Change-Id: I9f04b1aa8395a23a16192174f5583cc639dd1911 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81013 Tested-by: -
Benjamin Franzke authored
* Only define type definitions via "types" that need to be globally available. See https://www.typescriptlang.org/tsconfig#types > If `types` is specified, only packages listed will > be included in the global scope Those whose exports are (and can be) imported locally are *not* included globally bot only explicitly via `import` by the typescript modules that make actually use of these dependencies. * Move declarations from global into local scope that were actually only defined and used in specific files (draguploader) or move to inline code (disablePagingAction) or replace by modern code ($.escapeSelector => CSS.escape) * Remove unnecessary `declare module` statements that shadowed type definitions that are avaiable right now: * This means muuri is now type checked, which revealed wrong usage in the dashboard grid and is fixed right away. * Remove `any` where possible and use actual types instead Left for later cleanups are: * The ckeditor5-bundle should ideally be written in TypeScript to avoid the need for a handcrafted .d.ts file and the bundle itself would be compile time type-checked. * chart.js flatpickr and shortcut-buttons-flatpickr usage should be adapted to allow their natively provided types to kick it, but that needs upstream fixes for shortcut-buttons-flatpickr first and we need to stop mapping flatpickr and chart.js to pseudo package names. Resolves: #101896 Releases: main, 12.4 Change-Id: Ifa07dae2f49e617507e2d97a45b6e00b6fd1aafc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80991 Tested-by:
-
Benjamin Kott authored
Releases: main, 12.4 Resolves: #101900 Change-Id: Ieee9275ddbb7fa7cfd688866797456e2294fbe62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80996 Tested-by:
-
- Sep 12, 2023
-
-
Benjamin Kott authored
The svg tree is currently not usable in "rtl" languages, to mitigate the issue and to provide a solution for are forcing the ltr mode for now. This is not intended as a permanent solution but makes the svg tree usable again. Resolves: #101901 Releases: main, 12.4 Change-Id: Ib8505d37f4d0bfbf2d439dcecc5104f112db9045 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80995 Tested-by:
-
Andreas Fernandez authored
This patch adds a new module `@typo3/backend/utility/dom-helper` whose primary use is easing the migration from jQuery in case some native API is missing. As a start, the module contains a custom implementation to get all parent elements matching a specific selector. Resolves: #101882 Releases: main, 12.4 Change-Id: Iba1ce912c1d989246cdc67ab143b1d8a5f142e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80994 Tested-by:
-
Andreas Fernandez authored
The language management module writes into system/settings.php to either enable or disable a language. With the changes made with #98957, the language management should also inform about a write-protected configuration file and remove any options that conflict with this state. This patch removes any option to either enable or disable a language and moves the Fluid partial to a more generic location aimed for multiple usages across several modules. Resolves: #99008 Related: #98957 Releases: main, 12.4 Change-Id: Iae8c75e0727011289c421a66266989f44be76932 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80829 Tested-by:
-
Oliver Hader authored
Reconstituting CSP from string in class `ModelService` falls back to `null` values in case of using invalid backing values for the enums `MutationMode` or `Directive`. This changes uses `[enum]::from()` instead of `[enum]::tryFrom()`, that causes the process to fail early with a better error message. Resolves: #101880 Releases: main, 12.4 Change-Id: If3bc07960ad5e3632d295e82f3ee90669b549c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80979 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Kott authored
Instead of parsing parameters and string replacing parts of it we are now passing all nessesary parts as data attributes. Resolves: #101855 Releases: main, 12.4 Change-Id: I779f9d10f0dd7df6d89fc7b19aa9a36db1bbe3f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80993 Tested-by:
-
Andreas Fernandez authored
This patch removes jQuery from the module `@typo3/backend/ajax-data-handler`. Animations have been, if useful, migrated to CSS animations and transitions. Resolves: #101569 Releases: main, 12.4 Change-Id: I190029b1121736cfef2a92f5c756cac36270f9c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80974 Tested-by:
-
Benni Mack authored
Change-Id: Ifbec918791cf47b39f7d9119c26e7150a98d9123 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80978 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Change-Id: Iff5650d67aec9e2deebe013a0761481158b566e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80977 Tested-by:
-
Benjamin Franzke authored
Avoid using bootstrap modal API directly and instead use the modal infrastructure we already have in place. As a side effect jquery requirement is removed as well. Resolves: #101816 Related: #101820 Releases: main, 12.4 Change-Id: Iad441aaccbdfc9391aec0eb989c65ece457847b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80992 Tested-by:
-
- Sep 11, 2023
-
-
Benjamin Kott authored
Use actions-sort-* icons for table sorting and use accessible elements (button/a) in sorting triggers. Resolves: #101881 Releases: main, 12.4 Change-Id: Ie6de4500bf3819ea2c9b260456d05d9baee35f23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80949 Reviewed-by:
-
Oliver Klee authored
There is no point repeating the name of the extended class in the class PHPDoc comment. This makes creating new fixture classes less of a hassle. This is a separate change in order to make the other changes that get rid of `getMockForAbstractClass` shorter and more focused, following the "one kind of change per change" principle. Resolves: #101665 Related: #101601 Releases: main, 12.4 Change-Id: I7ee95e63149ff90c6f5817438e5b4634d04f4e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80947 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101666 Related: #101601 Releases: main, 12.4 Change-Id: I0263ff7b0639d72ba1d4f30e3bee12276d364591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80946 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101630 Related: #101601 Releases: main, 12.4 Change-Id: I27f526cb7ee4e1f2081c05befd3d70549dd0e2fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80945 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101661 Related: #101601 Releases: main, 12.4 Change-Id: I3b9ba4511620aebf125ff207428adc5483d47154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80944 Reviewed-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101892 Related: #101601 Releases: main, 12.4 Change-Id: Id1977130c5e2a9bdc54fb92aea7dfc63ecf55724 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80952 Tested-by:
-
