- Oct 15, 2023
-
-
Christian Kuhn authored
GeneralUtility::trimExplode() needs a string since #101453 as second argument. TCA type=folder DB values can be null, which can be triggered for instance by bootstrap_package in BackendUtility::getProcessedValue(). Cast the value before feeding it to GU::trimExplode(). Resolves: #102172 Related: #101453 Releases: main, 12.4 Change-Id: I3a742d592efe28324d07b0c941185601cfc14891 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81429 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
There is no point calling addDefaultPermittedLanguageIfNotSet() with $incomingFieldArray as reference. It is more easy to see the method can change $incomingFieldArray when it simply returns the updated array instead. Resolves: #102173 Releases: main Change-Id: If048cc438e53afca7a207200190689074963d2e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81431 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Oct 14, 2023
-
-
Benni Mack authored
Within the FileProcessingService class, various cleanups regarding the configuration array were made in order to avoid duplicate processed files. However, as noted in the existing code, this actually are special cases for specific tasks (ensuring that width and height are actually integers and have max boundaries in ImagePreviewTask for example). There is a culprit though, when moving this to the actual Task Objects (and that might be the reason why it was implemented the way it was): First, there is the ProcessedFile object, which then has a ->getTask() call, which then builds the Task object. The Task object thus needs a ProcessedFile object. But the ProcessedFile object is created AFTER it was checked in the DB based on the given configuration (which needs to be sanitized first to avoid duplicates), so a classic Chicken Egg problem. In the ideal world, the Task object should not hold state anymore, but write everything back to the ProcessedFile (e.g. configuration) as this is still duplicated in the current state. So, to reduce the interwoven situation, the AbstractTask object now has a new option called sanitizeConfiguration() which at a later point should be part of the interface (= breaking), but then also work with the ProcessedFile->getProcessingConfiguration() directly to reduce the duplication of memory everywhere. For the time being, an intermediate (empty) ProcessedFile is created, a Task object is instantiated and the configuration is sanitized (in the ProcessedFileRepository), when checking in the DB if a DB entry is available. The final ProcessedFile object is re-created after the DB query, which contains the sanitized configuration array. This change adds a new method to the Tasks, and adds some checks regarding the method, however this should go in the interface. As the interface will be cleaned up anyways in v13, this will be added separately in the next steps and the breaking change will follow as next patch. Resolves: #102164 Releases: main Change-Id: I01d5bef97a2fa319c1bffacacf28db6ca3f9b7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81153 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Oct 12, 2023
-
-
Christian Kuhn authored
Skip some queries when there are no rows in a table. Resolves: #102152 Releases: main Change-Id: Ia156c654fb4e5d769ea6d99af6225359ac9d7f5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81420 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
There is no point in not adding the XML prologue when using FlexFormTools->flexArray2Xml(). We can remove the second argument to always add it. Resolves: #102151 Releases: main Change-Id: I9baa2e36def97ff8271faebea6ded7ec5e2e9353 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81418 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Nikita Hovratov authored
It is best practice to use permanently visible information to help to fill out forms of any kind. In case of sys_file_storage the placeholder is even partially cut off, so one can't read the whole text. Resolves: #102150 Releases: main, 12.4 Change-Id: I8ad357470b4ff7a42454aba77c14cc8b6a532e8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81416 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Oliver Klee authored
Resolves: #101989 Releases: main Change-Id: Ifb2a68271f8e9dcd0bf37834fc673587a3cbcfcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81129 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
TYPO3_CONF_VARS BE/flexformForceCDATA is an ancient setting introduced 2009 with #19338 in TYPO3 4.3 to work around a weird behavior in libxml at that time. It is the last usage of 'useCDATA' in GU::array2xml() and some others. We can remove both. Resolves: #102146 Related: #19338 Releases: main Change-Id: I11c98c857a0fd85f1b3c9f66ae3b0896d7eec9ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81413 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
This is a pre-patch for introducing a native enum for DuplicationBehavior. In order to prevent changes to the signature of `$conflictMode` two times, we omit the typehint `string` in v13 and will change it in v14 immediately to native enum `DuplicationBehavior`. Resolves: #102149 Related: #101294 Releases: main Change-Id: I536151486b21f72bd2bc3959fc74e1124552af50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81415 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benni Mack authored
This change avoids using the `$this->im` property which is the resource pointer to the `\GdImage` object. In addition, the method `gifBuild()` is the only place to deal with absolute path and the actual path prefix, making `fileName()` easier to understand. This change will then allow to advance with Gdlib, adding support for webp at the next stage. Resolves: #102148 Releases: main Change-Id: I875ad7d8e2ae3a086c457642a363cef671057c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81414 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Oct 11, 2023
-
-
Mehdi Chaouch authored
Releases: main, 12.4 Resolves: #102142 Change-Id: I57661704305c47842e7042f499bb247c9eefef58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81410 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
core-ci <typo3@b13.com>
-
Benni Mack authored
This change moves some logic to calculate width and height based on instructions from an incoming array into a separate DTO, which can be used consistently and type-safe instead of residing in GraphicalFunctions. Some transformation of options ("maxW" vs. "maxWidth") is now moved to this new class as well, in order to centralize the naming of the options. In addition, the special calculation for ImageMagick about the cropH and cropV values is now done directly in the instructions, so the CropArea object can now be used in more places than before. Resolves: #101957 Releases: main Change-Id: I14608f486e4e3bf5cf669528f01d03479b8e6e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81050 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
The ReferenceIndex class with table 'sys_refindex' plays a more and more important role in core when it comes to systematic performance improvements. We've had quite some work on sys_refindex in v11 already, but the main class has not been touched much, yet. It's time to untangle some more to unblock further works. The patch brings some general changes to the @internal marked class ReferenceIndex: * Rely on DI * Set PHP types that can be forced easily * Tame more class state * Streamline the CLI main method used with > bin/typo3 referenceindex:update The changes in updateIndex() improve the overall output of the CLI processing: For instance, tables are now processed alphabetically, and there are changes like more effective calls for tables that have no relations. Resolves: #102141 Releases: main Change-Id: Ied84f0ab6deab65592ebc1e694f1797d81c138f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81408 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Oct 10, 2023
-
-
Oliver Hader authored
This reverts commit bd5a93e1. Due to a changed handling of `extraPlugins`, the editor config of e.g. ext:bootstrap_package v14.0.7 cannot be used anymore. Change-Id: I5d36a9ab0e309833a015fcd5f3221670dc114f06 Resolves: #102136 Reverts: #100784 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81344 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
Recent release for doctrine/dbal containes a php docblock change which helps phpstan to proper determine types. This change upgrades the doctrine/dbal package and removes a now superflous entry from the phpstan baseline. Used command(s): > composer req --no-update \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.1" \ && composer req --no-update \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.1" \ && composer req --no-update \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.1" \ && composer req \ "doctrine/dbal":"^3.7.1" > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102133 Releases: main, 12.4 Change-Id: Iaeba882e0584442c6caac71d3dd1e33ac0a56ef1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81394 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Benjamin Franzke authored
Use JavaScript object destructuring to "remove" all options from the configuration object, that are consumed by our CKEditor5 wrapper. Also cleanup RTE resource and config handling to not write unused options into the configuration array and to avoid resolving legacy (CKEditor4) resource paths which are dropped anyway. As a drive-by, dots are now substituted with '_' in RTE field IDs to avoid the following hassle: Dots are interpreted as CSS classes when the ID value is used in combination with a number sign (#) to create a CSS selector for the respective field ID. That means the selector will not match. The class selector additionally becomes invalid once there is a digit after the dot, as CSS classes need to start with strings. (Example: EXT:styleguide in_flex » tab » rte.2). Resolves: #100784 Resolves: #101437 Releases: main, 12.4 Change-Id: I7f541a39120018027792a2ad978935f743b9b6c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81381 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Fernandez authored
To make our code-base in the Install Tool more sophisticated, types for each AJAX response were added. Resolves: #102068 Releases: main Change-Id: Icae9c4399d0bdf84b84912bab98184c34a7c5257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81299 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Oct 09, 2023
-
-
Chris Müller authored
Resolves: #102120 Releases: main, 12.4, 11.5 Change-Id: I690e880c03ca87ca0d6ed9efaa93e95938f9936d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81379 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Kevin Appelt authored
Resolves: #102124 Releases: main, 12.4 Change-Id: I8b3862f70d5a8eb9779bb72c945bcf4e067d59eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81382 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Hader authored
> composer req --dev composer/composer ^2.6.5 Raised development dependencies, since v2.6.4 fixes CVE-2023-43655 which concerns "web-accessible server where the composer.phar can be executed as a php file" (which is not a security issue for TYPO3 in this case). Resolves: #102128 Releases: main, 12.4, 11.5 Change-Id: I3fd478fa7cee2c875b560f79cab94cb889d2b73a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81385 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
Chris Müller authored
Additionally: - Use "page TSconfig" over "Page TSconfig" - Add captions to make clearer where to store the configuration as an example Resolves: #102126 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/686 Related: #99738 Releases: main, 12.4 Change-Id: I983a9411c3c30ddf040eba0c296a2bee6c0ab509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81383 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Chris Müller authored
The GUI was changed with TYPO3 v12, so the screenshot is adjusted as well. Resolves: #102118 Releases: main, 12.4 Change-Id: I44a4ea5be814ed4d57b6b788254c2b4efe073bcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81376 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Oct 08, 2023
-
-
Chris Müller authored
The todo is obviously outdated, it is therefore removed. Additionally, remove some superfluous spaces in the code example and correct the indentation in the JS section to avoid "quote style" as drive-by. Resolves: #102119 Releases: main, 12.4 Change-Id: I357d878d456bdd7f5666d6982fd42337b4d2f6fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81378 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Andreas Nedbal authored
This setting is only used to determine if GIFBUILDER can be used or not. We can get rid of this configuration if we simply check for the existence of the GDLib classes that have been added in PHP 8.0, mainly the `GdImage` class. Resolves: #102113 Releases: main Change-Id: Ibe8fd29fe159074da5d3c4591bb2a332da79a1ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81373 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su>
-
- Oct 07, 2023
-
-
Christian Kuhn authored
phpunit 10.4.0 brings minor changed type annotations which phpstan isn't happy with. We bump both deps now. > composer req --dev phpstan/phpstan:^1.10.38 > composer req --dev phpunit/phpunit:^10.4.0 -w > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102110 Releases: main, 12.4 Change-Id: I86f6f47162d8e65bb6bf801c037a4e06e35288d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81370 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
Unbundle CKEditor5 in order to be able to load plugins like "font" only if actually configured, allowing TYPO3 core to ship *all* available ckeditor5 modules without having to weigh in the downsides for large modules that we do not want to ship for "every" installation. All @ckeditor scoped npm packages provided by CKEditor5 are bundled into an own small per-package bundle that is loaded (and linked to each other) via our importmap infrastructure. This allows specific modules to be loaded ondemand and has the additional advantage that plugin authors can use modules via packages exports as suggested by upstream documentation. This should lower the the barrier for writing custom plugins. The existing bundle @typo3/ckeditor5-bundle is still in place and acts as wrapper for the split bundles. It is deprecated and will be removed in TYPO3 v13.0. Also worth noting is that terser is now used to shrink the module size. Resolves: #102099 Releases: main, 12.4 Change-Id: I873167a7cb5c04cb7ef34e943830879f3f78eaaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81323 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com>
-
- Oct 06, 2023
-
-
Christian Kuhn authored
Minor patch to streamline types a bit. Resolves: #102109 Releases: main Change-Id: I367bbe5092f225d45c30613e3cb46535ddf0b7f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81368 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
There are two rather obsure TCA 'types' settings not many people are aware of, and even less understand: $GLOBALS['TCA']['someTable']['types']['bitmask_excludelist_bits'] $GLOBALS['TCA']['someTable']['types']['bitmask_value_field'] They are meant to be used to determine table record types based on a bit field. That's probably because they can usually be superseded having a string identifier for type fields. Looking through core and searching TER extension code, both fields have never been used, ever. The patch removes these options from TCA and documents a workaround in the ReST file for those very rare cases a custom extension actually uses this feature. Resolves: #102108 Releases: main Change-Id: I8ff52c4a6aaaf9e65488cb34a8ab05dd34bb0a4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81367 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
Tables with TCA columns set to type="color" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=color. Note the field length is for now set to varchar(7), which should be enough to include a hex color definition like "#123456". This should be fine, but could easily extended in case we missed something. There are no direct core usages of type=color, but ext:styleguide confirms this change should be ok. Resolves: #102107 Related: #101553 Releases: main Change-Id: Id989c334089b7c273691ee3367acd23a2e10284a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81366 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Nedbal <andy@pixelde.su>
-
Patrick Schriner authored
Add a aria-describedby attribute to link the password field with the requirements description. Resolves: #102100 Related: #97388 Releases: main, 12.4 Change-Id: Iec46dca547cf53764a47b18a54952aff8b33fdf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81329 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Upgrade wizard SysLogSerializationUpdate loads all to-update rows into an array to iterate and update one-by-one afterwards. This can hit PHP memory limits when many rows need to be handled. The patch fixes this by avoiding the load to array and iterating single result rows directly. Resolves: #102104 Releases: main, 12.4 Change-Id: I454f89a18bdfcf1400f05edf318e37c5ea213424 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81363 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Tables with TCA columns set to type="password" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=password. Resolves: #102106 Related: #101553 Releases: main Change-Id: Iaf64278d4eda164a535cdd2e741e13c28d7e738e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81362 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org>
-
Helmut Strasser authored
The `f:link.page` ViewHelper registers an attribute for `target`, which works in extbase context. Due to some changes, the ViewHelper has been enhanced to mitigate the need for bootstrapping extbase in non-extbase contexts. Therefore, `LinkFactory` (TypoLink) has been used to build proper links in a non-extbase frontend context with #98474. The same principal for the different context has been applied to the `f:link.action` ViewHelper with #101729. That introduced a different behaviour between extbase and non-extbase frontend context by simply overriding the target attribute, if TypoLink generates one. This change discards the build target from the `LinkFactory` to behave equaly in non-extbase frontend context compared to extbase context. Additionally, tests are added to cover these cases to the corresponding ViewHelper functional test cases. Note: If TypoScript default target configuration is needed, the corresponding `f:link.typoscript` ViewHelper needs to be used. Resolves: #101432 Related: #101729 Related: #98474 Releases: main, 12.4 Change-Id: Icea34983ea1f730f5ceada7d7d5ea0dbf9827204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Benjamin Franzke authored
Allowed content in CKEditor5 is to be configured via the General HTML Support plugin option config.htmlSupport. CKEditor4 style configs are now parsed and migrated. Note that this config.htmlSupport only applies to elements that are "known" to CKEditor5. Tags like "svg" or custom elements like "<foo-bar>" are not configurable this way as `htmlSupport.(dis)allow` can only handle elements that are defined in the CKEditor5 schema. [1] Also reintroduce the default configuration that allows any class and any attribute that starts with data- to be specified/preserved on known tags. This was removed with #96874. [1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#enabling-custom-elements Resolves: #99738 Releases: main, 12.4 Change-Id: Idaadfc09328efa4d1f21171a400dc45d29ed5904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81316 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Benjamin Franzke authored
* Use insertText command as provided by @ckeditor/ckeditor5-typing to match the behaviour of the upstream specialcharacters plugin: * Place cursor after inserted text * Replace existing selection when applying the button/shortcut * Disable button in source-editing mode (also fix ckeditor5 integration to work in case source-editing mode is disabled, to be able to test/verify that case) * Add tooltip to the toolbar button * Add a shortcut hint to the toolbar button tooltip * Show consecutive softhyphens * Show selections on softhypens and non-breaking-spaces Resolves: #101728 Releases: main, 12.4 Change-Id: I8c38a04a3c24de353edef921cc193f3fad718b4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Christian Kuhn authored
When @import or <INCLUDE_TYPOSCRIPT: lines do not resolve to any include, this probably indicates a broken import statement. To help integrators find and fix those, the Page TSconfig and TypoScript backend modules now list them as "Syntax scanner warnings". We're adding a functional test to verify the detection works. This will ensure it does not break when we refactor some details of the include tree structure later. Doing as described in #102102 and #102103 would simplify and streamline various details, but it's currently unclear if we should still do this in v12. Resolves: #102064 Related: #100218 Related: #97816 Related: #102102 Related: #102103 Releases: main, 12.4 Change-Id: I1bba0cead97ff81b38c97f18581275edee01ea63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org>
-
Markus Klein authored
The TypoScript parser matches valid operators first before dealing with values. Therefore, the TS `foo =<something` is now considered a reference and not an assignment. Resolves: #102101 Releases: main, 12.4 Change-Id: I7014b92f7a9120d0e77d264e964adef9d062070c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81355 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
editor.config.typo3link.additionalAttributes was used in TYPO3 v11 to enable certian attribute on link tags. Add a migrator that enables the same effect via the General HTML Support (GHS) CKEditor5 plugin configuration `config.htmlSupport`. Also remove the evaluation of the related but unused global config option ['EXTCONF']['rte_ckeditor']['plugins']['TYPO3Link']['additionalAttributes'] which was added in #78917 (initial CKEditor4 linkbrowser integration) but was never actually used (which was probably undiscovered due to its similar name). Resolves: #102052 Releases: main, 12.4 Change-Id: I2ca5b24890dd71dc5cba3aade22995a843e3dd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81311 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Markus Klein authored
Since v12 relative paths with INCLUDE_TYPOSCRIPT and DIR work differently. Resolves: #102065 Releases: main, 12.4 Change-Id: I365925767739e15547d0aed81f5631ab12c7d83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81298 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Josef Glatz <typo3@josefglatz.at>
-
Simon Schaufelberger authored
DataHandler->copyRecord_raw can also return null. This should be reflected in the doc header as well. Resolves: #102098 Releases: main, 12.4, 11.5 Change-Id: Ic7a12233efd32b67f0bf25d6478a03f807a5623e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81328 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-