Releases: 6.2
Change-Id: If014e492906f8efd1b32fb9f3bbdac0c8392a706
Reviewed-on: https://review.typo3.org/28784
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Instead of using TYPO3-internal functions
for creating directories and moving files,
default PHP functions are used. This creates
problems with permissions e.g. when
installing the introduction package.

Releases: 6.2
Resolves: #57298
Change-Id: Ifa5e92fd245db033dacbc3bcd15d487bd7af2101
Reviewed-on: https://review.typo3.org/28772
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

A method was misleadingly deprecated in QueryInterface.
Also an additional hint was added to the other deprecated
methods.

Resolves: #57277
Releases: 6.2
Change-Id: If80c707f1f65637682d5592116aaecb1a1e5918e
Reviewed-on: https://review.typo3.org/28754
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

As TBE_EDITOR is defined as object in jsfunc.tbe_editors.js we should
change the check here. Otherwise no eval user functions will be called.

Resolves: #57296
Releases: 6.2, 6.1
Change-Id: Ie1b701dcbf465827bc336233c2523f4df1dde9ba
Reviewed-on: https://review.typo3.org/28771
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Check if the key is available.

Resolves: #57300
Releases: 6.2
Change-Id: I99542a8c0516596b31342a7bce5daa58af4a6432
Reviewed-on: https://review.typo3.org/28777
Reviewed-by: Alexander Stehlik
Reviewed-by: Sebastian Fischer
Reviewed-by: Oliver Klee
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

The upgrade wizards searches for all filepaths in the RTE-enabled fields
as these are found in sys_refindex.ref_string. But in the RTE-enabled
fields spaces are replaced by %20 and in sys_refindex.ref_string not.

This patch replaces whitespaces with %20 in the regularExpression
used the find the occurrences of the filepath.

Resolves: #57143
Releases: 6.2
Change-Id: I6631b476defe7e3faa78914338fce70372ad1fb5
Reviewed-on: https://review.typo3.org/28600
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The toolbar of the workspace module visualizes each workspace
in a separate tab. On having many workspaces, the toolbar is
extended to multiple lines which actually reduces the available
viewport of the grid panel.

This change introduces a modified TabPanel that shrinks if the
available width is undershot. In this case an additional menu
is rendered to the right side of the panel to visualize the
remaining items in a vertical list.

Resolves: #49689
Releases: 6.2
Change-Id: I85c8b8134dfe27a4dc32c5d70a158cca41763c41
Reviewed-on: https://review.typo3.org/21920
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The current workspace module only has two levels (page and the
accordant records). Nested record sets like tt_content ->
sys_file_reference (any "text with image" content element) are
not recognized as dependent and need to be published separately.

The GridDataService is extended to determine the the accordant
nested record sets and provides additional data for parent and
child scenarios. The ExtJS view components are extended to take
care of nested record sets and to handle expand and collapse
events on these kind of record collections.

Resolves: #55349
Releases: 6.2
Change-Id: I93ca187c3997bf7f4cdadefd741be2541aef5ae4
Reviewed-on: https://review.typo3.org/28701
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Dependency element resolving of nested data structures currently
is used in CommandMap only. However the logic can be used for
other tasks as well, like e.g. showing nested structures in the
workspaces module. Callback methods are extracted to the new
ElementEntityProcessor to reduce further code duplication.

Resolves: #57231
Releases: 6.2
Change-Id: If588e2c644fb897f0ac5f7aaf4f341ce8ac5c232
Reviewed-on: https://review.typo3.org/28700
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Add a test for preparse query hash.

Resolves: #57263
Releases: 6.2
Change-Id: Ia524b65f5ef559822c62df1f53c0e78c4750f01e
Reviewed-on: https://review.typo3.org/28764
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Releases: 6.2
Resolves: #57242
Resolves: #44327
Change-Id: I0cfd55e8bbaab690cc6b22b30e18972b0e8747c0
Reviewed-on: https://review.typo3.org/28716
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Any commas in the mount point parameter are replaced with underscores
to prevent caching errors in the RootlineUtility.

Resolves: #57073
Releases: 6.2
Change-Id: If1e135d0abbc08ebc11954d17f57ea037983ba10
Reviewed-on: https://review.typo3.org/28521
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The wrong classname is used and for emitPreFolderCopySignal(),
emitPostFolderCopySignal(), emitPreFolderMoveSignal() and
emitPostFolderMoveSignal() the $newName parameter is not
passed through

Resolves: #57273
Releases: 6.2
Change-Id: Iaf82820abe29b97da93f9583435b9264671e3a38
Reviewed-on: https://review.typo3.org/28743
Reviewed-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Steffen Ritter
Reviewed-by: Ernesto Baschny
Tested-by: Xavier Perseguers
Reviewed-by: Frans Saris
Tested-by: Frans Saris

Change #57031 introduced two methods in DomainObjectInterface,
which are already present in ObjectMonitoringInterface.

Undo that change.

Resolves: #57271
Releases: 6.2
Change-Id: I95852d8221a1b54c4d6a71c508666e0fb1080223
Reviewed-on: https://review.typo3.org/28745
Reviewed-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Markus Klein
Reviewed-by: Markus Klein

Since the input type=file now supports multiple file selection
and this is suppoterd by all modern browsers.
So showing only 1 filepicker by default is enough.

For users with older browser they can use the already existing
options.folderTree.uploadFieldsInLinkBrowser tsconfig to show
multiple fields.

This patch changes the hardcoded default value to 1.

Resolves: #57170
Releases: 6.2
Change-Id: Ia2dfcc3ae81dff66ba4c389a4b99b819186f63c0
Reviewed-on: https://review.typo3.org/28699
Reviewed-by: Philipp Gampe
Reviewed-by: Sebastian Fischer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The Extbase query cache stresses the database by querying
the same cache identifier over and over again. This for example
doubles the amount of fired database queries for fetching related
objects at the moment.

Introduce a first level cache saving the cache entries during
runtime.

Resolves: #57275
Releases: 6.2
Change-Id: I964db7c9ab8b61a3d8ac6534a35dc65240398aa7
Reviewed-on: https://review.typo3.org/28744
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Follows #57263

Fixes a change of interface in the unit test for Query.
Moreover two more places miss the new interface typehint.

Resolves: #57286
Releases: 6.2
Change-Id: I528656055782e22989b8fd7cc8a652d8de829663
Reviewed-on: https://review.typo3.org/28759
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Resolves: #57263
Releases: 6.2
Change-Id: I89b5051a5fe1d6fc908428019115fcd4bc0d2b38
Reviewed-on: https://review.typo3.org/28735
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

When pages or records in general are changed using
the DataHandler, the pageCache is cleared for
each page multiple times. To fix this, the DataHandler
will collect which pages need clearing, and wait with
the actual clearing until all operations in
cmdMap or dataMap has been processed.
This way the cache is only cleared once for each page.

Resolves: #52235
Releases: 6.2
Change-Id: If1aa389991b801413eafa38d7d140f932bb321f2
Reviewed-on: https://review.typo3.org/25423
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Tested-by: Philipp Gampe
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack

Resolves: #57262
Releases: 6.2
Change-Id: I190420ef696de819ebf3f06033ba7e97c639a92c
Reviewed-on: https://review.typo3.org/28739
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Browsers center text in <th> but the header text should
be aligned to the left. This issue arose when ExtJS
normalize reset was removed. Simple explicit definition.

Resolves: #57211
Releases: 6.2
Change-Id: Ib235d9e9e2beabac01a62b10cedea08faacbd896
Reviewed-on: https://review.typo3.org/28679
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Change-Id: I581ca28ee926ad1891b33baa1c8d8f0e9f9df5a9
Reviewed-on: https://review.typo3.org/28737
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: If247d1f182ecc1de823852bda435efd7e2e420f2
Reviewed-on: https://review.typo3.org/28736
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The classes contain wrong type hints and miss a lot of
checks whether the correct object is present.

Resolves: #57031
Releases: 6.2
Change-Id: I3d03c838b05529daf0da444119dd7f8dba6d5b8a
Reviewed-on: https://review.typo3.org/28489
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

During unpacking of an extension in the installation
process it can happen that the extension data
contains folders in the file list.

These folders need to be removed from the list
in order to avoid warnings when trying to write
directories as files.

Also remove duplicates from folders before
creating them.

Besides fix some (non related) comparisons to
strict comparisons on the go.

Resolves: #57261
Releases: 6.2
Change-Id: Ib6821a0a438ebc9441b8fa2ee3fbd7869f23ec7f
Reviewed-on: https://review.typo3.org/28731
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

This is a regression fix. The regression was
introduced when fixing the dependency handling.

Resolves: #57260
Related: #57199
Releases: 6.2
Change-Id: I77bff766d0e4bd9d3ce74fa74db03d6b65223e67
Reviewed-on: https://review.typo3.org/28730
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This is a follow-up fix for the integration of preparedStatements in
Extbase. Due to a wrong comparison, an own preparedStatement object
used in $query->statement() would never be executed.

Resolves: #57254
Releases: 6.2
Change-Id: I3176339be309530b50ff89410affa386d7f6f8e8
Reviewed-on: https://review.typo3.org/28726
Reviewed-by: Felix Oertel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The setting [FE][activateContentAdapter] has a large impact on
performance. A warning in the Reports module will encourage
integrators to adapt TypoScript to increase performance.

Resolves: #57249
Releases: 6.2
Change-Id: I935b86ba701d3b0dbac3b807a1ae9312bff223fc
Reviewed-on: https://review.typo3.org/28724
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Markus Klein
Tested-by: Markus Klein

In https://review.typo3.org/28592 we apparently did not 
fix the whole problem. This followup will deal with
the edge-case of using a similar built statement, which
results in the same hash being generated from the
QueryParser.

Resolves: #57130
Related: #55167
Releases: 6.2
Change-Id: I02a478fcabb89d11054f8f0a3c800965edfd7844
Reviewed-on: https://review.typo3.org/28715
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This a follow up fix for the extbase query cache. On reusing an already
build query, it was missed to evaluate the multi valued operator and
provide it as array for resolving the parameter placeholders.

Resolves: #57104
Releases: 6.2
Change-Id: I06abbf5279ee05382a7ba314948f7d3f075d84e6
Reviewed-on: https://review.typo3.org/28695
Reviewed-by: Alexander Stehlik
Tested-by: Alexander Stehlik
Tested-by: Wouter Wolters
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Until we fully remove usage of BasicFileUtility throughout the core
(i.e. DataHandler, Import/Export module, ElementBrowser and others),
the core should not pollute the deprecation log with it.

We just individually deprecate methods which are not used anymore.
Methods which are still used in the core are marked as @deprecated
(to visualize this in the IDE) but they won't write to the
deprecation log yet.

Resolves: #57209
Releases: 6.2
Change-Id: I41d7f6c8b7c3c4df77791ce3e6f3f69140d1935d
Reviewed-on: https://review.typo3.org/28674
Reviewed-by: Xavier Perseguers
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Before version 4.7 you could build up a section index with
links to content elements with hidden headers.
Since version 4.7 elements with a hidden header type are sorted
out for the section index, overriding the extra flag "sectionIndex",
which is especially integrated for this.

This patch adds a extra flag for menu configuration sectionIndex
named "includeHiddenHeaders" to make it possible to re-enable
the behaviour of versions before 4.7.

Resolves: #52928
Related: #31767
Documentation: #53699
Releases: 6.2
Change-Id: Iee7f20cfc317c2b624dfc440811c5edc0a367a1e
Reviewed-on: https://review.typo3.org/24876
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Unit tests have been forgotten to be adapted,
so fix them now to make travis happy again.

Also remove the superfluous constructor
in InstallUtility, as both dependencies
are injected anyway.

Resolves: #57247
Related: #57199
Releases: 6.2
Change-Id: I40c39705c2db546b38d94936feac2c8757eed8da
Reviewed-on: https://review.typo3.org/28722
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In order to know what is going to be installed, the
distribution manager should display more information
about a single extension, also with a link to configure
the distribution, if possible.

Releases: 6.2
Resolves: #57212
Change-Id: Ia092ec7b2c5162b33f4fce614415de07ffa2ca47
Reviewed-on: https://review.typo3.org/28677
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add a link to http://wiki.typo3.org/Opcode_Cache in installers
system environment check messages.

Resolves: #56526
Releases: 6.2
Change-Id: If7314d52426729ce092e281697fbbd67bd6ae9d7
Reviewed-on: https://review.typo3.org/28712
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

The download queue is build recursively, but if an
extension is marked for download, it is added
to the queue before its dependencies have been
resolved, which leads to a wrong download and
installation order of extensions.

We also need to add dependency resolving when
marking an extension for installation to fix
the exact same problem when extensions already
reside in the system.

Lastly we must take care of flushed class loader
caches and trigger a rebuild to avoid fatals.
This is done by introducing a signal and registering
a method in package manager as slot that set the
packages for the class loader to trigger a rebuild
of the caches.

The parts of this patch that fix dependency handling
should be backported to older 6.x branches.

Resolves: #57199
Releases: 6.2
Change-Id: Iab343c544bfe2e3e19cbf4c05090eb4994df57b1
Reviewed-on: https://review.typo3.org/28660
Reviewed-by: Sebastian Fischer
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Tested-by: Markus Klein

See change: I517c0500cad75cae96fd739f2ff7222db80b42a5
At the end of the Typo3DbQueryParser::parseComparison() method the updated
operator for NULL values was no longer passed to the parseDynamicOperand,
generating = NULL instead of IS NULL.

Solved the issue by adding the operator parameter again.

Change-Id: I13c3cecf0bf4c95789032f31ead192b945794484
Resolves: #57130
Related: #55167
Releases: 6.2
Reviewed-on: https://review.typo3.org/28592
Reviewed-by: Markus Klein
Reviewed-by: Felix Oertel
Tested-by: Felix Oertel

Trying to access a property if the subject is
a string, causes the class loader to be triggered
as is_callable is invoked.

We can avoid that by checking if the subject
is an object or array. We can neglect that
is_scalar also returns false for resource types
as this will not really happen in practice.

Resolves: #56993
Releases: 6.2
Change-Id: I94754cd919acc857cd9a8b8e486080c0bf567112
Reviewed-on: https://review.typo3.org/28586
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The patch adds a new module for the record history view. All calls to
the show_rechis.php script are rewritten to use
BackendUtility::getModuleUrl() to ensure CSRF protection.

Resolves: #56632
Releases: 6.2
Change-Id: I2466c1b08afdd7d987ef38a29500f02641156c07
Reviewed-on: https://review.typo3.org/28205
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Fixes: #57238
Releases: 6.2, 6.1, 6.0
Change-Id: Icca7e1637387e2ad31a1368abcd59b1bd443255f
Reviewed-on: https://review.typo3.org/28705
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers