- Jan 03, 2024
-
-
Torben Hansen authored
Update copyright year to 2024 Resolves: #102741 Releases: main, 12.4, 11.5 Change-Id: I1a909b221513b5add387d9680193d8deb4285a04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82299 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Andreas Kienast authored
This commit updates `@codemirror` and its friend packages to their most recent version. Due to changes within `@lezer/javascript` and `@lezer/highlight`, our Gruntfile needs minor adjustments. Executed commands: npm install --save \ @lezer/lr@^1.3.14 \ @codemirror/autocomplete@^6.11.0 \ @codemirror/commands@^6.3.3 \ @codemirror/lang-css@^6.2.1 \ @codemirror/lang-html@^6.4.7 \ @codemirror/lang-javascript@^6.2.1 \ @codemirror/lang-sql@^6.5.5 \ @codemirror/language@^6.10.0 \ @codemirror/lint@^6.4.2 \ @codemirror/search@^6.5.5 \ @codemirror/state@^6.4.0 \ @codemirror/view@^6.23.0 npm update @lezer/javascript npm run build Resolves: #102732 Releases: main, 12.4 Change-Id: I92f81a8dfb8f64e09005f0a332b557ffdc532654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82290 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
TypoScriptFrontendController->linkVars is only used once in PageLinkBuilder. The TSFE property can be avoided quite easily by moving the calculation of "global" query parameters to this place directly. This avoids yet another dependency to TSFE. Resolves: #102717 Releases: main Change-Id: Ib6cd0dee8e3f370ebe936d5e4669d0d27dadcdec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82275 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Sascha Nowak <sascha.nowak@netlogix.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Jasmina Ließmann authored
This patch ensures that the username and - if available - the real name of the author are displayed again in the element information modal. The corresponding field label is now also displayed. Resolves: #102737 Related: #102469 Releases: main, 12.4 Change-Id: I960e274b98aec7289c84a6eaee54b7d3ccdc3cc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82293 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
This change reduces some cognitive load in some methods to use early returns instead of nested if statements. Resolves: #102726 Releases: main Change-Id: I8093d087f997e07b2d4a97d23ec5f289792b6182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82045 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The ImageViewhelper does by default add the `alternative` property as `alt` attribute to the img tag if no non-empty string is set. However, there might be valid use cases where an empty `alt` attribute should be set for such image - even if the property exists. Such case is e.g. a thumbnail of such image. The ImageViewhelper does therefore now render an empty `alt` attribute if the `alt` argument is explicitly set to an empty string. Resolves: #102739 Releases: main, 12.4 Change-Id: Id197c3d2f839fbbc37744a2ae356c8e3ae35f0c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82295 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
- Jan 02, 2024
-
-
Torben Hansen authored
This change removes several unused language labels in ext:reports. Related functionality for affected labels has been removed in TYPO3 6.2 or TYPO3 8.7 (`phpPeakMemory` check). Resolves: #102733 Releases: main Change-Id: Id8871f254860dac29ad1613f6c5dc7ff8df02a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82291 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
- Jan 01, 2024
-
-
Oliver Bartsch authored
In case a link does not set any additional attributes, no empty callout is rendered. Resolves: #102721 Releases: main, 12.4 Change-Id: I7ec4d7b64450112731363d721f4d49322448b41c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82280 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Dec 30, 2023
-
-
Andreas Kienast authored
This commit updates `chart.js` to version 4.4.1. See changelog at https://github.com/chartjs/Chart.js/releases/tag/v4.4.1. Executed commands: npm install --save chart.js@^4.4.1 npm run build Resolves: #102728 Related: #102334 Releases: main Change-Id: I326cbcd0f006bc3a299c96628ddcf7dbfdbe7a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82285 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com>
-
Benni Mack authored
Since TYPO3 v9, PageRepository dependencies are in better shape with the introduction of Context API. With TYPO3 v12, it is fully encapsulated and can now be called and instantiated when needed, instead of using TSFE->sys_page. This patch migrates the last occurrences in TYPO3 Core and only sets TSFE->sys_page as b/w compat layer (deprecation later together with other properties). Resolves: #102723 Releases: main Change-Id: I7a21ba28bfc0a22e4b980cc582c055864ebbaedd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82276 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Sascha Nowak <sascha.nowak@netlogix.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Torben Hansen authored
The `showForgotPasswordLink` setting in ext:felogin has never been used in default Fluid templates and has only been kept for backward compatibility reasons. It has however been forgotten to remove the deprecated setting in TYPO3 v12 default TypoScript. This change finally removes the deprecated and unused TypoScript setting. Resolves: #102731 Related: #98122 Releases: main Change-Id: If62d35a7cffaff6e784226c729a4d28d1f954203 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82289 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Torben Hansen authored
This change removes an unused import in `PasswordElement` Resolves: #102730 Releases: main Change-Id: I9845598850dd0b91904b90a1ac1ca2f4f19b7e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82288 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
New `core-testing-phpXY` images has been build and released. [1] This change update used image version to: * core-testing-php81:2.9 - php 8.1.27 (patchlevel) * core-testing-php82:1.8 - php 8.2.14 (patchlevel) * core-testing-php83:1.9 - php 8.3.1 (patchlevel) [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/11f78ce2ac1f38355fdb7d59e1472e62a02ba894 Resolves: #102729 Releases: main, 12.4, 11.5 Change-Id: I991061445e28a358c1aeadebf3213d87394d04ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82286 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Dec 28, 2023
-
-
Stefan Bürk authored
PHPUnit has changed the behavior of the error handler in several ways, for example introducing a PHP attribute to disable the PHPUnit error handler for tests dealing with `error_get_last()` [1], throwing an exception and stopping the script execution on `E_*_ERROR` or clearing the error result [2] - which breaks the ability to use the native `error_get_last()` method to test custom error handler implementation. Something which TYPO3 needs to do for the provided custom error handler. An additional change [3] to check and restore error handlers with levels has been reverted due to issues in the Laravel world. This change modifies the related test to use the introduced PHP attribute `#[WithoutErrorHandler]` and raises PHPUnit. Note: PHPUnit does not recognize the `@test` doc-block annotation if the `#[WithoutErrorHandler]` attribute is used. Therefore, the attribute counterparts for `@test` and `@dataProvider` has been added on top and not exclusively for now, albeit looking weird and fishy. This needs to be addressed in a more generic way in a dedicated change. Used command(s): > composer update typo3/testing-framework > composer require --dev "phpunit/phpunit":"^10.5.5" [1] https://github.com/sebastianbergmann/phpunit/pull/5430 [2] https://github.com/sebastianbergmann/phpunit/pull/5592 [3] https://github.com/sebastianbergmann/phpunit/pull/5619 Resolves: #102724 Releases: main, 12.4 Change-Id: I77f750ef2eba53b5f8caa51651f36321ae5d1224 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82282 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Dec 26, 2023
-
-
Oliver Bartsch authored
Since #102616, itemsProcFunc config is resolved in `BU::getLabelFromItemlist()`. This method therefore was adjusted to take the record in question as argument, passing it to the underlying `ItemProcessingService`, which actually just requires the uid and pid. Since the database row is not passed to BU::getProcessedValue()`, the record was fetched for each item manually via `getRecordWSOL()`. This is not sufficient and has a serious performance impact. The functionality of resolving itemsProcFunc is now still in place but `BU::getProcessedValue()` does no longer fetch and pass the record, but only the uid and pid. This will therefore still enable most use cases, but does no longer slow down the backend. Resolves: #102698 Related: #102616 Related: #100855 Releases: main, 12.4 Change-Id: Ic52564fada13b47f5364df642acbf683538b0c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82264 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Chris Müller authored
Resolves: #102718 Related: #102624 Releases: main Change-Id: I50ee2b8bbbc472f0fec330adc88acee1e78b540f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82278 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Chris Müller authored
Links to the official PHP documentation for enums have been added to ease access for developers who do not know this feature yet. Additionally, in the Enumeration deprecation changelog a link to the feature "Let Extbase handle native enums" has been added. Resolves: #102719 Related: #101163 Related: #101396 Releases: main Change-Id: I2188e1308a797fa827e646a31372e0a018a9d607 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82279 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Dec 23, 2023
-
-
Christian Kuhn authored
The patch extracts TSFE->determineId() and its sub methods from TSFE into TypoScriptFrontendInitialization middleware. The information created by these methods is modeled into the new DTO PageInformation, which is added as 'frontend.page.information' request attribute before handling other middlewares below. The non-internal old properties within TSFE are set and kept as b/w compat layer for now. This is a powerful change: It allows us to reduce dependencies to TSFE significantly, which we will start to leverage with upcoming patches. The patch is an intermediate change as such: Looking at determineId() and its related methods makes clear the code can benefit heavily from further refactoring. The method could be ultimately extracted into a service class that only returns the 'final' PageInformation object, or throws exceptions for 'early' responses. To keep the patch reviewable at this point, these refactorings will continue with additional patches. Detail notes: * TSFE->sys_page PageRepository instance is for now modeled as (@internal) PageInformation->pageRepository. This can be refactored away later: Consumers should create instances of that class on demand. * "original mount and shortcut page record" are also modeled as (@internal) PageInformation properties for now. They are internal handling since the redirects can only be created after TypoScript has been calculated later on, so the information has to be carried around for now. We *may* be able to change this later. * The two middleware properties $pageNotFound and $pageAccessFailureHistory are a tribute to the current code flow in determineId(). They should be refactored away when the code is further shuffled around. The properties currently require a hack that needs to make the middleware "shared: false" to circumvent side effects in combination with error handling sub requests. * The code flow around determineId() updates local state and state of PageInformation multiple times and is in general very hard to follow. The patch crafted this carefully and did not refactor the code flow heavily for now. Changing the early response creation strategy will make the code flow much more straightforward later. * determineId() and with it the PageInformation object is now created *before* TSFE is instantiated, shifting the instantiation to a slightly later point. * getPageAccessFailureReasons() is for now transferred to the middleware as well. It can be later dissolved when determineId() receives further refactoring. Two consumers (indirectly) by ShortcutAndMountPointRedirect middleware could be dissolved already, so the method could be removed from TSFE. * TSFE->linkVars needs to be dissolved soon: The strategy should be to create "linkVars" on demand within the link handling code and eventually encapsulate it with a runtime cache entry. * getRedirectUriForMountPoint() and getRedirectUriForShortcut() are relocated to ShortcutAndMountPointRedirect middleware. TSFE->getUriToCurrentPageForRedirect() had to be made (@internal) public to do that, but that method can be refactored away when TSFE->linkVars is dissolved. * The hacks within RedirectService are extended to deal with the new situation for now. The entire thing needs to fall at a later point completely. * Further patches should start avoiding the TSFE properties that are now set as b/w compat layer, and start using the PageInformation request attribute instead. This will reduce overall dependencies to TSFE significantly. Resolves: #102715 Releases: main Change-Id: I6470899cf65cbaaeb2177a8b20c0800f045a070c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82267 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Before styleguide has been merged to monorepo, it did not have composer require definitions to core since that gave ugly cross dependencies between monorepo and styleguide repo. With styleguide being merged into monorepo v13, we can finally safely set a core requirement just like all other core extensions do. Resolves: #102716 Releases: main Change-Id: Ic6feceab020bccb220ddeb61838b325b40755c0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82274 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Dec 22, 2023
-
-
Nikita Hovratov authored
Resolves: #102714 Releases: main Change-Id: If0ea2bb972308e361b1ec47a75a122b61006a772 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82270 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change uses the LanguageServiceFactory directly (mostly in tests) instead of Bootstrap::initializeLanguageObject() in order to explicitly define $GLOBALS['LANG'], thus showing the dependency to the global object. The internal method Bootstrap::initializeLanguageObject() can thus be removed. Resolves: #102712 Releases: main Change-Id: I78a93e222d302db796a031e585685a409aa73c41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82266 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Hader authored
PHP's base64_decode has a strict parameter to only accept characters of the corresponding base64 alphabet, see https://www.php.net/manual/en/function.base64-decode.php Resolves: #102620 Releases: main, 12.4 Change-Id: I39a038519ec1e884ba42f691c6dea76cbce772fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82139 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Bartsch authored
Properly check for valid meta data record to prevent 'Undefined array key' error on deleting a file. Meta data record might not exists, because the file might have not been indexed or simply because the record was manually deleted. Additionally, some code clean up is done. Resolves: #102700 Releases: main, 12.4 Change-Id: Ibf8a0d53b40f08b60064583d5f28762c25d75937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82262 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de>
-
- Dec 21, 2023
-
-
Markus Klein authored
Resolves: #102713 Releases: main, 12.4, 11.5 Change-Id: I18c841d9085221f4b6ff826600965b159af7971b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82269 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
florian.thiele authored
Resolves: #102056 Releases: main Change-Id: Ie19e70148b893aff2e82f6ef2ed1e5b31f39407a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81270 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Lina Wolf <112@linawolf.de>
-
Oliver Klee authored
- autoformat the files - sort the configuration options This keeps the files consistent and avoids unrelated formatting changes when other things are changed. Resolves: #102699 Releases: main, 12.4 Change-Id: Iffb8401328949d0d38f91512671f77285c470e6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82256 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com>
-
Chris Müller authored
Resolves: #102706 Releases: main, 12.4 Change-Id: Ia250046ca8e36a82012555a8ed4e638e3746c787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82265 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
- Dec 20, 2023
-
-
Christian Kuhn authored
Patch for #102279 to auto-create DB select fields reveals a bug in the styleguide data generator which tries to create (partially empty) strings for the "parent count" fields when select is configured with MM. The patch adapts the generator logic a bit to create better values in those cases. Resolves: #102704 Related: #102279 Releases: main Change-Id: I236e1c6d5c1ce8abfa1e84fc35b6aa6c2765d762 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82263 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Bartsch authored
There might be valid reasons for a module being (temporary) inaccessible for a user. Since #102665 a module redirect is done instead of throwing an exception, which a user can not resolve. However, this led to the fact that a user got redirected without knowing the reason. Therefore, a notification is now dispatched, whenever a forced module redirect takes place. Resolves: #102678 Related: #102665 Releases: main, 12.4 Change-Id: I3e3e6548c7d2ec65b1081f8bdfdab5a16ba56f31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82192 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Achim Fritz <af@achimfritz.de>
-
Georg Ringer authored
Adding the following information to itemsProcFunc helps extension authors: - effectivePid: correct page id - site: current site Resolves: #99346 Releases: main, 12.4 Change-Id: Ifc54a06c66f3dbf61a2e95f706bb54e74db4b28e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77033 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
Oliver Hader authored
TypoScript property `addQueryString.exclude` concerns the internal, URL-decoded values. However, the parameters are purged from a query array that is URL-encoded. Resolves: #102386 Releases: main, 12.4 Change-Id: Ibcdca016221035f5f2974007b1fc52c04f5d643f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81758 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
Resolves: #102383 Releases: main, 12.4, 11.5 Change-Id: Iced9d71874a51ee321857b662fa157ca2c2c0307 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82258 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Bartsch authored
Resolves: #102701 Releases: main Change-Id: I0546bdc6ebdce3a405fd6421ddc0656e6d577cf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82259 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org>
-
- Dec 19, 2023
-
-
Stefan Bürk authored
The TYPO3 core `runTests.sh` contains the `-u` option to update the images and remove dangling images. Providing an image name and a `--filter` option is not supported by podman: > Error: cannot specify an image and a filter(s) and has not been discovered yet in the TYPO3 core implementation yet. Both container runtimes `docker` and `podman` support filtering images using the `reference` filter option. Therefore, this change modifies the dangling image removal to use multiple filters To verify that filtering with two `--filter` options can be used with podman and docker, the following commands can be executed to list the set of local non-dangling images. Note: This example uses `dangling=false` instead of `dangling=true` (as in `runTests.sh`), since we expect most developers don't have dangling images yet. > podman images \ --filter "reference=ghcr.io/typo3/core-testing-*" \ --filter "dangling=false" --format "{{.ID}}" > docker images \ --filter "reference=ghcr.io/typo3/core-testing-*" \ --filter "dangling=false" --format "{{.ID}}" Resolves: #102697 Releases: main, 12.4, 11.5 Change-Id: I717d1aa229bdfb73c63aa5b2d46e1aff665544cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82255 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Garvin Hicking authored
The Indexer builds a large array of all actual files on a storage (identifiedFileUids). If many files exists, this array can get very large. This array was then passed to a QueryBuilder to fetch all records NOT IN that array. Since a NOT IN query is passed as a string to the database, it can exceed the string size allowed in a query, making the whole task fail. Since a NOT IN query cannot be chunked easily, the whole logic has been adapted in a different way. Instead of fetching a restricted list of database records, all records are fetched and iterated. Even with a million of sys_file_records of a single (!) storage this will perform alright, and be within practical usage scenarios. Each database record is then checked for a match in the large array of known records, and then execute the same logic as before. To benchmark the implications, the following test was run: Baseline: * sys_file with 50.736 entries * 16.912 marked as missing * 33.824 marked as existing * Filesystem with 8.771 actual files Tested setup via a script which: * Resets to baseline sys_file storage * Executes scheduler task "File Abstraction Layer: Update storage index (scheduler)" * Flags 41.965 files as missing, 8.771 as found. Script execution was performed 50 times, and a mean avery was calculated, once once with the patch in place, once without. Old variant (using NOT IN query): 11.787 seconds New variant (fetching all records): 12.0544 seconds On top of being within the same performance level, using the new method, no database exception will be provoked (see ticket). Resolves: #102295 Releases: main, 12.4 Change-Id: Id998d7cd062fe75aac738b896bfb307b51f5cef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81916 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Anja Leichsenring authored
Tables with TCA columns set to type="select" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=select. Resolves: #102279 Related: #101553 Releases: main Change-Id: I600d0be1b2452b93d46c6b0d8317460607988fee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81604 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Bartsch authored
Check for existence of the password field before using its value to prevent a "read properties of null" TypeError. Note: This does usually not happen for the default login provider, but might be for custom providers, not using the password field the same way as the default provider. Resolves: #102693 Releases: main Change-Id: Id1ef515c517eb3f95020b97eb7336e618fcc1d30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82253 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Benni Mack authored
This change introduces a few number of non-breaking details to be used for further (breaking) changes in the Image Processing chain. On the very low-level A new object called "ImageProcessingResult" is now used to have the previously $info array $info[0] = width of an image $info[1] = height of an image $info[2] = file extension $info[3] = full file path now consumed in an object that is used throughout the lowlevel area of GraphicalFunctions, Image Procesing and GifBuilder. The GraphicalFunctions method receives some smarter methods (currently internal): * resize() - similar to imageMagickConvert() but with type hints, and returning the new object * convert() - e.g. just convert a jpeg to png Next steps in this area: * cObject->getImageResource() should only return ImageProcessingResult (and migrate the hook to a PSR-14 event) - Breaking * GraphicalFunctions->getImageDimensions() and imageMagickConvert() should only return these objects (or null) - Breaking * ImageProcessingResult->toLegacyArray() should be removed * Have Local*Helper classes return this object or just the file name or an ImageInfo object or get rid of them completely - Breaking * Move "image types available for the browser" into a service class out of GraphicalFunctions Resolves: #102679 Releases: main Change-Id: Iefef621dff961dfdd8ff89c43b7b3b78363376a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81428 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
Input data is statically provided by EXT:core only, so there is no security issue known right now. This change is a preparation to avoid possible future security issues. Resolves: #102676 Releases: main, 12.4, 11.5 Change-Id: I49a7fdd250e8ce74fdde07ad305cbae7e4af8ec3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82190 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Nikita Hovratov authored
It is unclear why `layout` was excluded for the indexed search plugin. In contrary to `pages` and `recursive` this field has no functionality for extbase plugin. In preparation for eventual deprecation of plugins of type list, this exclusion is removed. Resolves: #102642 Releases: main Change-Id: I714714bf9d99ea7c65c2461684ed873b126bd55d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82161 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-