- Feb 16, 2022
-
-
Oliver Bartsch authored
The StandardContentPreviewRenderer runs through a list of fields, whose value should be processed and displayed in the footer. Some of those field values might be a reference to a foreign table, e.g. in the "fe_group" field. Due to changes in getProcessedValue(), it's necessary to provide the records' uid, to be able to resolve values of fields with a "foreign_table" configuration. Resolves: #96920 Releases: main, 11.5 Change-Id: I0d8739710e478a7cb264be1d5b90b70af31de964 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73563 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Kuhn authored
Class BackendTemplateView has been a temporary solution to simplify the implementation of the "TsConfig template override" feature into smaller patches. With ModuleTemplate and general view works being mostly done in the backend, BackendTemplateView should be removed again. The patch removes all usages switching nearly all views to BackendViewFactory, which removes the explicit dependency to Typo3Fluid ViewInterface since the EXT:core ViewInterface is not directly bound to Fluid anymore. Using BackendViewFactory has the additional advantage that templates which don't use ModuleTemplate because they're hook usages or some other "sub-view", can now be overridden with TsConfig, too. Using BackendViewFactory also makes the dependency to ServerRequestInterface explicit. The patch thus hands $request around at some more places where $request was only an indirect dependency before. One special @todo area is FormEngine, which is unable to have dependency injection (fo...
-
Benjamin Franzke authored
With #96906 the ES6 module files changed to lowercase-dashed naming convention, but the modules in EXT:form have been missed. Releases: main Resolves: #96931 Related: #96906 Change-Id: If1b977645c314afa451e60bde6025f8d90abf9ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73566 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Georg Ringer authored
Make the web more secure by using https as fallback scheme if not set. Resolves: #96835 Releases: main Change-Id: I7eea535046b25a55c705a1e13c841318966527ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73489 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Christian Kuhn authored
The @inheritdoc annotation is essentially useless since it adds no value to code readers especially in more and more strict environments. Static code analyzers use doc header annotations from parent classes or interfaces anyways. The patch removes all @inheritdoc annotations throughout the core and removes @inheritdoc from the 'allowed annotation' list in CI. Relsolves: #96930 Releases: main Change-Id: I33fcc837eb6b7c8c8c34a33d28aa2911070c6b6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73565 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
A few places still manually check for "LLL:" as prefix. This is now resolved, as all of this is already done in LanguageService directly. Resolves: #96926 Releases: main Change-Id: Icee5060a5d5b48177e9a5440fcab5d50e3dc9036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73561 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
Argument and return type hints are aligned to match implemented interface \ArrayAccess with proper type hints and removing the '#[\ReturnTypeWillChange]' attribute, which has been used as a workaround. Most methods and the constructor already had proper type hints with the exception of the interface methods, which is now aligned. Class properties have also been set to proper type hints along the way. Resolves: #96918 Related: #95746 Releases: main Change-Id: Iccbe482ab9b174cf6198c372dfcaf312fd1c682f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73555 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
With the introduction of the simplified ModuleTemplate API and the transition of all core backend modules towards it, the old API can and should be deprecated to faciliate the "Override templates with TsConfig" feature in extensions as well. Resolves: #96903 Related: #96730 Related: #96812 Releases: main Change-Id: I8b15e8f9d999cf61bf9856ceed67beb85921a4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73517 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benjamin Franzke authored
With the TypeScript source move in #96906 one file hasn't been moved into the correct place, causing operating systems with case insensitive file systems like MacOS to merge Input/index.d.ts and input/clearable.ts into one folder called "Input/". This causes the compilation to fail. Move the index.d.ts in to the new folder. Resolves: #96927 Related: #96906 Releases: main Change-Id: If1eb46a059c2f99eeb20613a52c30bab76b4f5df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73562 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Benjamin Franzke authored
With the recent ES6 changes, the EXT:install JavaScript modules could no longer be loaded into the main backend frame, as the importmap configuration was not tagged to be included there. Add the backend.module tag to the EXT:install importmap in order for TYPO3/CMS/Install/chosen.jquery.min.js to be loadable for the system maintainer modal in backend context. Releases: main Resolves: #96924 Related: #96323 Change-Id: I6109ce00a331b93c1bef29f0e455fa6be126e387 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73560 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
With #96570 RequireJS is no longer loaded when CKEDITOR is used, therefore the typo3link plugin needs to use direct ES6 imports (using the importShim polyfill for Firefox compatibility) instead of the legacy RequireJS shim. Releases: main Resolves: #96923 Related: #96570 Change-Id: I5bcfbca003b98f264d67e51b9738eedb6f8865ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73559 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Franzke authored
Switch from TYPO3/CMS/ExtName/ to @typo3/ext-name/ module namespace in all TypoScript modules in order to use the common "scoped package" syntax as known from npmjs. This will allow TYPO3 TypeScript declarations to be published to @TYPO3/* packages on npmjs.com at some point, allowing extension authors to require these as npm/yarn dependencies to be able to use TypeScript type declarations when developing against the TYPO3 JavaScript API. While at it, the naming convention of JavaScript modules is also switched to use lowercase-dashed form. This is to adhere to the common used naming convention in the npm-world. Also @typo3/core/ajax/ajax-request.js simply looks better than a mixed form @typo3/core/Ajax/AjaxRequest.js would be. All existing RequireJS module identifiers are mapped to the new naming syntax in the requirejs-to-es6 bridge: For example a requirejs call to TYPO3/CMS/T3editor/Element/CodeMirrorElement will transparently be transformed to the new scheme: @typo3/t3editor/element/code-mirror-element.js Manual modifications in: Build/Gruntfile.js Build/util/map-import.js Build/JSUnit/karma.conf.js Build/Sources/TypeScript/backend/Resources/Public/TypeScript/viewport/navigation-container.ts typo3/sysext/core/Resources/Public/JavaScript/requirejs-loader.js typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/package2/Configuration/JavaScriptModules.php typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/package3/Configuration/JavaScriptModules.php typo3/sysext/core/Tests/Unit/Page/ImportMapTest.php typo3/sysext/t3editor/Configuration/JavaScriptModules.php All other changes have been automated with: find Build/Sources/TypeScript/ -type f | \ grep -v index.d.ts | \ sed \ -e 's:Build/Sources/TypeScript/:typo3/sysext/:' \ -e 's:/Tests/:/Tests/JavaScript/:' \ -e 's:/TypeScript/:/JavaScript/:' \ -e 's:\.ts$:.js:' | \ xargs git rm find Build/Sources/TypeScript/ -type f | while read file do newFilename=$(echo $file | sed \ -e :loop1 -e 's:\(/Public/TypeScript\|/Tests\)\([0-9a-zA-Z/.]*\)/\([A-Z][A-Z]*\)\([0-9a-zA-Z/-]*\)\.ts:\1\2/\L\3\E\4.ts:' -e 't loop1' \ -e :loop2 -e 's:\(/Public/TypeScript\|/Tests\)\([0-9a-zA-Z/.]*[a-z]\)\([A-Z][A-Z]*\)\([0-9a-zA-Z/-]*\)\.ts:\1\2-\L\3\E\4.ts:' -e 't loop2' \ -e s:/Resources/Public/TypeScript/:/: \ -e s:/Tests/:/tests/: ) mkdir -p $(dirname "${newFilename}") [[ "$file" != "$newFilename" ]] && git mv "${file}" "${newFilename}" done cat << EOF > convert_uppercase_to_lowercase.sed :loop1 s:\(TYPO3/CMS[0-9a-zA-Z/]*\)/\([A-Z]\)\([0-9a-zA-Z/-]*\.js\):\1/\l\2\3: t loop1 :loop2 s:\(TYPO3/CMS[0-9a-zA-Z/]*[a-z]\)\([A-Z]\)\([0-9a-z/-]*\.js\):\1-\l\2\3: t loop2 s:TYPO3/CMS/\([0-9a-z/-]*\.js\):@TYPO3/\1:g :loop3 s:\(^import \|^import .* from \|import(\|declare module \)'\([0-9a-zA-Z/.]*\)/\([A-Z][A-Z]*\)\([0-9a-zA-Z/.-]*\)':\1'\2/\L\3\E\4': t loop3 :loop4 s:\(^import \|^import .* from \|import(\|declare module \)'\([0-9a-zA-Z/.]*[a-z]\)\([A-Z][A-Z]*\)\([0-9a-z/.-]*\)':\1'\2-\L\3\E\4': t loop4 :loop5 s:\(\* Module\:\{0,1\} \|\* @exports \|\* @module \)\([0-9a-zA-Z/.]*\)/\([A-Z][A-Z]*\)\([0-9a-zA-Z/.-]*\)$:\1\2/\L\3\E\4: t loop5 :loop6 s:\(\* Module\:\{0,1\} \|\* @exports \|\* @module \)\([0-9a-zA-Z/.]*[a-z]\)\([A-Z][A-Z]*\)\([0-9a-z/.-]*\)$:\1\2-\L\3\E\4: t loop6 s:\(^import '\|^import .* from '\|import('\|declare module '\|\* Module\:\{0,1\} \|\* @exports \|\* @module \)TYPO3/cms/\([0-9a-z/.-]*\):\1@typo3/\2:g s:@typo3/rte_ckeditor:@typo3/rte-ckeditor: s:TYPO3/CMS/Backend/Module/Iframe:@typo3/backend/module/iframe: s:TYPO3/CMS/Backend/PageTree/PageTreeElement:@typo3/backend/page-tree/page-tree-element: s:TYPO3/CMS/Backend/Tree/FileStorageTreeContainer:@typo3/backend/tree/file-storage-tree-container: s:TYPO3/CMS/Impexp/ContextMenuActions:@typo3/impexp/context-menu-actions: s:TYPO3/CMS/Install/chosen.jquery.min.js:@typo3/install/chosen.jquery.min.js: s:Public/JavaScript/JavaScriptItemHandler.js:Public/JavaScript/java-script-item-handler.js: s:Public/JavaScript/RequireJSConfigHandler.js:Public/JavaScript/require-jsconfig-handler.js: s:Public/JavaScript/AdminPanel.js:Public/JavaScript/admin-panel.js: EOF git ls-tree --name-only -r HEAD | \ grep -v dashboard/Documentation/ | \ grep -v Documentation/Changelog/ | \ grep -v Build/JSUnit/ | \ xargs sed -i -f convert_uppercase_to_lowercase.sed rm convert_uppercase_to_lowercase.sed sed -i \ -e 's:TYPO3/CMS/\([A-Z]\):@TYPO3/\l\1:' \ -e 's:@typo3/rteCkeditor:@typo3/rte-ckeditor:' \ typo3/sysext/*/Configuration/JavaScriptModules.php \ typo3/sysext/core/Tests/Unit/Page/Fixtures/ImportMap/*/Configuration/JavaScriptModules.php sed -i \ -e "s/: \\(@TYPO3\\/.*\\)/: '\1\'/" \ typo3/sysext/form/Configuration/Yaml/FormSetup.yaml (cd Build; grunt build) git add typo3/sysext/ Resolves: #96906 Related: #96323 Releases: main Change-Id: Ifed6ac373aa2bc0c36fe157fb3e9c220f520a9c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73522 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
Some code related to times without Site handling is cleaned up and logically arranged. Resolves: #96919 Releases: main Change-Id: Id2f61048d9bfdd4f0f397bb3afaa1fb883c1faa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73557 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The new content element wizard is using default values to define on which colPos or in which language the new element should be created. Using TSconfig it is also possible to define custom default values, most commonly the "CType". The user defined values should however never overwrite the dynamically generated values from the UI. Therefore, the dynamic values do now always overwrite the user defined values, like it's already done on preparing the data map (In case "saveAndClose" is used). Resolves: #96914 Releases: main, 11.5 Change-Id: I8f2bbf2589715c63a54bc19380f98483a12d028c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73530 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Since #96895, the ModuleData object is created for every request, targeting a backend module, and attached to the PSR-7 Request object. Previously the route targets (the controllers) made use of the nullsafe operator when accessing the module data. This however hides the dependency to the object. In case the module data is missing, the controller should fail "hard". Therefore, those nullsafe operators are removed again. Additionally, the $default value is removed from the moduleData->get() calls, since the requested properties are all registered in the module registration with a corresponding default value. Resolves: #96917 Related: #96895 Releases: main Change-Id: I3d53e435a809e925f18c7495d832beb94c7f735b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73554 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Stefan Bürk authored
This patch aligns \ArrayAccess argument and return type hints in two classes of 'ext:form' to be compatible with the implemented native php interface '\ArrayAccess'. PHP8.1 added proper return types to php internal classes, methods and interfaces, but using 'mixed' was not possible before because of PHP7.4 incompatibility. To mitigate this the PHP8.1 attribute '#[\ReturnTypeWillChange]' has been used in v11, which is now removed again. These classes are already flagged as @internal and thus changed now without further notice. Resolves: #96916 Related: #95754 Related: #95755 Releases: main Change-Id: Iad42aaed9fa8dffd88fbbb3d4f82b34b2507e481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73553 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
Setting module data does no longer use the "SET" prefix. This adjusts one place, where the migration was not done yet. Note: This has no functional impact, since the checkbox is handled via JavaScript and not in a POST request. Resolves: #96895 Releases: main Change-Id: Ie0feb1218ccb089df9164eafd7241be56c2b7421 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73531 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Feb 15, 2022
-
-
Oliver Bartsch authored
A JavaScript exception is fixed by replacing the invalid "auto" option for the "size" attribute of the custom "typo3-backend-icon" element with "small". Resolves: #96915 Related: #95353 Releases: main, 11.5 Change-Id: I765a79d4d32e93175a0c5f271b203ba39e607b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73552 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The TSFE god object handles too many things. One part is the calculation of config.linkVars which is now moved into its own separate class. Resolves: #96908 Releases: main Change-Id: I17670f7b127e22d2557173f75583729119e664c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73523 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Resolves: #96913 Releases: main, 11.5 Change-Id: Idf1b2d34d9c4373f52f5d8cbae84d83d2d5bfbd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73529 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Nikita Hovratov authored
After some refactoring, the initialisation of the perms_clause attribute ended up after BU::readPageAccess, which receives this attribute as an argument. Resolves: #96912 Releases: main Change-Id: Ia9471f32a4d05ba6db3a34012b28e1545ba3d0c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73526 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Nikita Hovratov authored
Resolves: #96911 Releases: main Change-Id: I0abf46b1e14c29a53859851fa606dacbdbcc2f70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73525 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Stefan Bürk authored
Raising doctrine/dbal to have "latest" deprecations in place. This gives us the posiblity to analyse and implement the needed adoptions to the public provided core fascade classes and analysing further which may be needed to change in preparation for upcomming "doctrine/dbal":"^4.x" and how we will handle this. used commands: > composer req doctrine/dbal:^3.3.2 -W > composer req doctrine/dbal:^3.3.2 \ -d typo3/sysext/core --no-update > composer req doctrine/dbal:^3.3.2 \ -d typo3/sysext/redirects --no-update > composer req doctrine/dbal:^3.3.2 \ -d typo3/sysext/install --no-update Resolves: #96909 Releases: main Change-Id: Ia50b7b31375aa21a9243697007e0d2526a703057 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73428 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by: Oliver Bartsch <bo...
-
Benni Mack authored
A new PSR-14 event "ModifyGenericBackendMessagesEvent" is added when collecting (warning) messages in TYPO3 Backend's About Module. The Event is added as direct replacement for the hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_befunc.php']['displayWarningMessages'] Resolves: #96899 Releases: main Change-Id: I271b8b3f91f5fc3b4d7198fc263539af4af6c8c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73479 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
When previewing the frontend for a specific usergroup (ADMCMD_simUser) or previewing a page in the future (ADMCMD_simTime) the GET parameters are now continued to be used when browsing the frontend. This solves issues when a user-restricted page or a page visible in the future has a form on it, and the GET parameters are kept. Resolves: #94974 Resolves: #96491 Releases: main, 11.5 Change-Id: I0a79749648c0235f0a959a416408540fab2fb4b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73514 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
With the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/50811/ the link markers in the label file were removed. Resolves: #96910 Related: #52286 Releases: main, 11.5 Change-Id: I59a45d2c4f43c84087c7c964ce4460f6c7eb49e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73524 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
A new "ModuleData" object is introduced, which contains the allowed module data properties for a module, overlaid by previously set values from a user. Each module now has access to this object, as it is populated during a middleware and the values are persisted. Resolves: #96895 Releases: main Change-Id: Ie9e17ada201c809ea4c1d0473c447366fbe4bbcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73415 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Since #96797, the Module object is added to the PSR-7 Request, in case a TYPO3 backend module is requested. To further support autocompletion, the Module definition is now added to the .phpstorm.meta.php file. Resolves: #96905 Related: #96797 Releases: main Change-Id: Id323f27dbe59a386cf38ba73ee75bd07abb11532 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73521 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change moves the logic for calculating the max time for caching a frontend page into a separate class. In addition, the existing hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['get_cache_timeout'] is removed in favor of a new "ModifyCacheLifetimeForPageEvent". Resolves: #96879 Releases: main Change-Id: I4b3a7f3a2aa1cb0307ed021bb5344edfeab11e91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73475 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
This removes the no longer evaluated option `uploadfolder` from ext_emconf.php files. Additionally, `clearCacheOnLoad => 0` is removed, since this is the default. Resolves: #96898 Releases: main, 11.5 Change-Id: I99379d6066e53abd67fd8e6a1f32638b597ea1c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73512 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
All static RequireJS calls (static string argument) are migrated to native ES6 modules. Excluded is CodeMirrorElement which still needs RequireJS to be available for loading CodeMirror and it's modules. CodeMirror migration to ES6 will be a separate step by upgrading from v5 to v6. Manual modifications in Form/Element/AbstractFormElement.php to keep JavaScriptModule flags for registerCustomEvaluation call-conversions. Also JavaScriptRenderer.php to is patched always include the EXT:core importmap whenever the JavaScriptItemHandler is used (required for the dependency to "JavaScriptItemProcessor.js"). All other changes have been performed with the following commands: git grep -l "loadRequireJsModule('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v ActionMenuViewHelper.php | \ xargs sed -i '/CodeMirrorElement/!'"s/->loadRequireJsModule('\\(TYPO3\/CMS\/[^']*\\)')/->loadJavaScriptModule('\\1.js')/g" git grep -l "JavaScriptModuleInstruction::forRequireJS('TYPO3/CMS" | \ grep -v /Documentation/Changelog | \ grep -v JavaScriptRendererTest.php | \ xargs sed -i '/CodeMirrorElement/!'"s/JavaScriptModuleInstruction::forRequireJS('\\(TYPO3\/CMS\/[^']*\\)'/JavaScriptModuleInstruction::create('\\1.js'/g" git grep -l "JavaScriptModuleInstruction::forRequireJS($" | \ grep -v /Documentation/Changelog | \ grep -v Form/Element/AbstractFormElement.php | \ xargs sed -i -e '/CodeMirrorElement/!s/::forRequireJS/::create/' -e "s/^\([ ]*\)'\\(TYPO3\/CMS\/[^']*\\)'/\\1'\\2.js'/g" sed -i "s/'\\(TYPO3\/CMS\/[^']*\\)'/'\\1.js'/g" typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php # Same migration as already started in #96607 git grep -l includeRequireJsModules= | \ grep -v /Documentation/Changelog/ | \ grep -v PageRendererViewHelper.php | \ xargs sed -i \ -e 's/includeRequireJsModules=/includeJavaScriptModules=/' \ -e "s/\\([0-9]: *'TYPO3\\/CMS\\/.*\\)'/\\1.js'/g" Resolves: #96570 Related: #96323 Related: #96607 Releases: main Change-Id: Idc81d6b4d58168f0bfafc3e9e4ad46fa1e5f27e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73027 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Susi Moog authored
If l10n_source points to a deleted or non-existing record the translation wizard failed in free mode with a 500 error, because determining the source languages fail and no fallback was implemented. Instead of failing, the behaviour was adjusted to handle l10n_source pointing to erroneous records similarly to an empty column and offering all available language as option for the translation - as in fact the source cannot be reliably determined. Resolves: #96838 Releases: main, 11.5 Change-Id: Iec7f4a1dba6b93c5185fec7863b1deaa175b0279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73433 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Change-Id: I31ec2d1ab4872f5ab6df354c4e808b451ac1ce71 Resolves: #96897 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73498 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Georg Ringer authored
Remove the overhead of using extbase to get all workspace records and fetch them directly. Resolves: #96896 Releases: main Change-Id: I6ff28ad661533c7804d576e17e979b55c96c0a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73497 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Feb 14, 2022
-
-
Benni Mack authored
This change is a pre-patch for introducing https://review.typo3.org/c/Packages/TYPO3.CMS/+/73339 to allow to reduce the calls to $pObj by using inheritance for all controllers related to TypoScript parsing in "Web > Info" Resolves: #96894 Releases: main Change-Id: Ifb78f415e7168b14462063c2b761503ab4d90615 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73496 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
With all casual deprecation removals being done, the ReST file can receive some final touch. Resolves: #96107 Releases: main Change-Id: I1bfdd7a569084eab3e778e9bfc544da64d19186b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73495 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
TSFE contains a lot of functionality which is rather related to other places. One of them is the protected method "determineIdIsHidden" which is now transferred to PageRepository where all other methods related to this logic is kept. Resolves: #96886 Releases: main Change-Id: I5213ae5f899fcdf9a39046021d40f2ed9005adac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73486 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Imko Schumacher authored
Tokens in an encoded URL (where '=' is '%3D') now get anonymized. Resolves: #96858 Releases: main, 11.5 Change-Id: If07d122b2a5b89cb66fef3fff0790004c5d07eb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73456 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
This change cleans up some functionality regarding TSFE when SiteHandling was introduced in TYPO3 v9: * TSFE->id is always an integer now * TSFE->contentPid and TSFE->requestedId now as well * TSFE->site is always of type Site (not SiteInterface) anymore * Some TSFE related methods now need the PSR-7 request (as defined before already) Other places such as $TSFE->type will be worked on separately. Resolves: #96880 Releases: main Change-Id: Icfcd8b50225a3dae94b72f40d79d5117df3ae4a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73477 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
With #96831 being done, a last deprecated set of functional tests can be merged into the default functional test suite. Resolves: #96888 Related: #96831 Releases: main Change-Id: Id0bbf805979e693e56721081abd7759b129bf624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73487 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-