- Apr 16, 2020
-
-
Benni Mack authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Benjamin Franzke authored
rectors `auto_import_names` causes relative class names to be transformed into `use` statements. This reduces the readability of the grouped getFactories array as used in ServiceProviders, we rather used to define all external dependencies in use statements and to include local dependencies using relative class names. Also revert the change in TYPO3\CMS\Extbase\ServiceProvider which has already been applied in #91047 using: git checkout 682873dd^ -- \ typo3/sysext/extbase/Classes/ServiceProvider.php Releases: master Resolves: #91059 Related: #91047 Change-Id: I16c4b0d264b2acc5149da375967d862c879f2958 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198 Tested-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by:Benni Mack <benni@typo3.org> Tested-by:
-
- Dec 30, 2019
-
-
Alexander Schnitzler authored
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Dec 19, 2019
-
-
Alexander Schnitzler authored
php bin/rector process The Rector\Php70\Rector\List_\ListSwapArrayOrderRector rector has been disabled as this needs proper testing and a separate patch. Releases: master Resolves: #89907 Change-Id: I56b296221622afdc72feb5a48145431efd993ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62592 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Dec 18, 2019
-
-
Alexander Schnitzler authored
php bin/rector process Releases: master Resolves: #89807 Change-Id: I667199693dc519d0353d8e10b40d86faf1cf946a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62448 Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
- Dec 10, 2019
-
-
Alexander Schnitzler authored
As the StringClassNameToClassConstantRector would convert string class names that are deliberately defined as string, this rector has been disabled. Releases: master Resolves: #89899 Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
In order to let rector process tests, the autoloading of all processed classes needs to be intact. In TYPO3 there were a bunch of classes whose namespace were a bit wrong according to PSR-4 and there were some class that didn't fit the PSR-4 standard at all. Classes that could easily be fixed have been fixed. All others have either been registered via a class map in composer.json or they have been excluded from the processing of rector. This change does not apply rector rules to tests, it only enables rector to operate on tests due to fixed autoloading. Releases: master Resolves: #89900 Change-Id: Iaa4a5bb2677a5a9af374d780423d962dcc09ade2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62583 Tested-by:
-
- Nov 29, 2019
-
-
Alexander Schnitzler authored
php bin/rector process Both sets php54 and php55 have been applied at the same time because set php54 didn't result in any changes. Releases: master Resolves: #89789 Change-Id: Idddc487b34abceb300a237bd458659a10db54469 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62439 Tested-by:
-
- Nov 27, 2019
-
-
Alexander Schnitzler authored
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:
-
