- Mar 03, 2021
-
-
Oliver Bartsch authored
This removes some searchFields from sys_file_reference, since they are not suitable for users, searching for such records in the backend. As a side effect, a superfluous condition in workspaces is removed. Resolves: #93634 Releases: master Change-Id: I5204a79146128cbca0a3b74eda7b11ed5bcd7119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68171 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Daniel Siepmann authored
The ViewHelper does not clear cache since 7.3.0 change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/34818 Still the documentation states it will clear cache. Instead users need to take care to properly clear cache. The background: FlashMessages often tend to be part of a process and already work with proper cHash and URLs. Unique URLs often lead to unique output of FlashMessages. Under some circumstances flash messages might be created before redirecting to a generic URL. Resolves: #93636 Releases: master, 10.4 Change-Id: I15479d31671a04ce12336583767277f0fc25cbca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68173 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Martin Kutschker authored
The EXT:install ServiceProvider introduced in #89892 didn't respect that LanguagePackService implements LoggerAwareInterface. That means the logger variable was null and usages of the logger resulted in exceptions. Refactor the class to require the logger instance to always be injected via constructor injection, to prevent this from happening again. Resolves: #93630 Related: #89892 Releases: master, 10.4 Change-Id: I71309863e096e5289336831ec4da294a5bcb65cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68170 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Wand <wand@itaw.de> Reviewed-by:
-
Benni Mack authored
The EM is not using the API for writing and reading the UC, and can be massively simplified. Resolves: #93622 Releases: master Change-Id: I0a3e4d935437f38f49401c52826f182492690d2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68161 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Mar 02, 2021
-
-
Oliver Bartsch authored
The workspace module features the element information modal, which displays, next to the record history, the current version records' difference to its live record. This difference is now also displayed for new and delete placeholder records. It's not reasonable forcing the user to always open the complete record to have a quick look at the values of e.g. a new record. Since new / delete placeholders basically contain all fields, defined in TCA, they are filtered using the FormDataCompiler to only show the suitable ones. Resolves: #93620 Releases: master, 10.4 Change-Id: Ib58d568664e3aecb13afa023c0e05f188662811d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68156 Tested-by:
-
Georg Ringer authored
Call the user functions with an empty array instead of null as 2nd argument. Resolves: #93513 Releases: master, 10.4 Change-Id: Ibc50b9e3ec7defc0100e5ae6447b05fca8e77cd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68168 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Mathias Brodala authored
When there is no "cv" or "s" parameter we should not perform any image processing. This is essential e.g. for accessing PDF files in private storages. These can technically be processed but should never be since then the original PDF file becomes inaccessible. Releases: master, 10.4 Resolves: #93024 Related: #90068 Change-Id: I956cc3840a14b25d57b073be81838fb33c0250f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67333 Tested-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Kuhn authored
Change-Id: Ib1e08417a716882e8c354da92d090efdb6924dc7 Resolves: #93632 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68160 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja Leichsenring authored
Due to a interdependency between tests and a recent reordering, the Input Range Test found itself on the wrong tab of the backend input form. The setup of the test now ensures the correct tab is active before starting to fill out fields. Resolves: #93629 Releases: master Change-Id: I21c6ac6a56db72bd347f3d4617162f61d21b6eff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68167 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
This change adds test images for checking if the installed IM/GM version can create webp images. Similar to the pdf/ai files tests, these changes are allowed to fail, and - if the browser does not support webp (https://caniuse.com/webp) - will not show up either. Resolves: #93627 Releases: master Change-Id: Ib676f2ad096d21266aba9ee14d235377432c63c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68166 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Oliver Bartsch authored
In case of switching to a user, having MFA enabled, with a user, having MFA disabled, the switching user is required to pass the target users' MFA, because the transformed session does not contain the `mfa` key. Since it's obviously not possible to pass another users' MFA, we need some exception for such scenario. Therefore, the evaluateMfaRequirements() method from AbstractUserAuthentication is overwritten by BackendUserAuthentication to check if the current session is a switch-user session. In this case, MFA is skipped. Otherwise the parent method is executed. Skipping MFA will be logged. Resolves: #93624 Releases: master Change-Id: I0625b23bee5aa202a20e2bb7ad46b6e606769134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68164 Tested-by:
-
Oliver Bartsch authored
Since #93455 it's possible to restrict backend routes to a limited set of HTTP methods. This route property is now also displayed in the corresponding "Backend Routes" configuration module provider. Resolves: #93623 Releases: master Change-Id: Ibc2bff74894a8d5f0be571d290706909dd98c009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68163 Tested-by:
-
- Mar 01, 2021
-
-
Anja Leichsenring authored
The acceptance test suite for the stand alone install tool can easily coexist with the other backend related tests, there is no good reason for the overhead of a separate suite. So it gets merged into the backend suite. Resolves: #93621 Releases: master, 10.4 Change-Id: I460596985cd992c4f7d59df989c7992590e479d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68158 Tested-by:
-
Stephan Großberndt authored
This patch changes the behaviour when saving the backendfilter in extensionmanager list to not allow any class unserialize as TYPO3 Core does not put any classes in the UC and no other place in Core allows to unserialize stdClass for be_users.uc. Resolves: #93617 Releases: master, 10.4 Change-Id: I4b0ba03fb1ea02e97327e11fcd76486d3bd4cda6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68155 Tested-by:
-
Jigal van Hemert authored
If the hook is used to add TypoScript, information must also be added to the rowSum array in order to generate correct cache keys. Resolves: #93597 Releases: master, 10.4 Change-Id: I9d543872206333d02b8eb6b5cdd90a53e6c6accb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68153 Reviewed-by:
-
Alexander Schnitzler authored
Several reflection methods are deprecated for a while and throw errors with PHP8. - ReflectionParameter::getClass() - ReflectionParameter::isArray() Both need to be replaced with the new api: - ReflectionParameter::getType() Releases: master, 10.4 Resolves: #92946 Change-Id: I9391cd260f0d4dba5eb03f63c1f74f01bd97e7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66936 Tested-by:
-
Stephan Großberndt authored
This patch sets the type of be_users.uc to binary in order to avoid SQL errors when updating it on PostgreSQL installations. Resolves: #93616 Releases: master, 10.4 Change-Id: Ib30d4f8be566922c573c8a5f5e1144f283273f9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68154 Tested-by:
-
Anja Leichsenring authored
The Pagetree suite for acceptance tests was set up as a separate suite in the beginning due to a necessary fixture set of pages, that all the other tests don't need. The overhead of having separate suite is higher than the additional fixture set, so the suites are merged. Resolves: #93614 Releases: master, 10.4 Change-Id: I70a3f1dd68bb07c0dc505eaadb3d240e81639add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68151 Tested-by:
-
Benjamin Franzke authored
The component is provided as replacement for the current lit-helper `icon()` which cannot provide support for icon usage inside shadow dom elements. The component renders all icons as inline SVGs. FontawesomeIconProvider is therefore adapted to provide inline rendered SVGs for font-awesome icons. Not that these inline font-awesome SVGs will also be used in areas where 'inline' icons are requested (like information toolbar) but the fallback to 'default' was used before. The component supports all properties of the Icon API via HTML attributes. Colors and custom sizes can be applied to the component via CSS color/font-size property: typo3-backend-icon[identifier=status-dialog-information] { color:#6daae0; /* An explicit font-size will be used as icon width & height */ font-size: 1.2em; } Resolves: #93473 Releases: master Change-Id: I3044c325f122eb0085ecb3f45fb9502bfb314d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 Tested-by: -
Christian Kuhn authored
composer req php:"^7.4 || ^8.0" Note this declares core master PHP 8 compatibility, even though core is not yet compatible in practice. The situation should settle until 11.2, though. Resolves: #93612 Releases: master Change-Id: Ibd428260ebd48936bb193b1df747283d3b35f410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68150 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Feb 28, 2021
-
-
Christian Kuhn authored
Package handling with a php 8 and no platform.php composer config currently fails since various dependencies don't allow php 8, yet. Drop these test stages for the time being to have a green nigthly CI build. Resolves: #93611 Releases: master Change-Id: I7667d972679a3a125b699df034b04cb8800104c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68149 Tested-by:
-
Christian Kuhn authored
Resolves: #93604 Releases: master Change-Id: I36133bd50c85f572ea0dc9ba786c7ac6e1718adb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68146 Tested-by:
-
Nikita Hovratov authored
This example configuration was accidentally added by a later commit after it was already removed. Resolves: #93600 Related: #89645, #89740 Releases: master, 10.4 Change-Id: I79bbbf3210e67e0f5425563ba58765115db3cd12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68139 Tested-by:
-
Anja Leichsenring authored
Each jobs will have one more run in case it fails in the first. This will prevent pipeline failures due to recoverable test run failures. Resolves: #93603 Releases: master, 10.4, 9.5 Change-Id: Ia054973d1f2a336727ef9d483041f1f48147c375 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68140 Tested-by:
-
- Feb 27, 2021
-
-
Christian Kuhn authored
Fix some last PHP 8.0 related issues found by unit tests and enable their execution in CI. Resolves: #93601 Releases: master Change-Id: Ie2d2aebd5858361efa85a9491808c53bcbc06288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68138 Tested-by:
-
Christian Kuhn authored
Adapt testing related docker-compose.yml to properly work with xdebug 3.0. This is packaged in the testing container images already and is the only version compatible with PHP 8. To spice up developers life, xdebug 3.0 drops important config options in a non b/w compatible way, introduces new ones, where some of them overwrite others, and does further stuff like changing the default step debugger port for no apparent reason. Since xdebug can be such a pain, runTests.sh comes with -x option, so it (hopefully) 'just works' for devs using the script in testing context. The setup of course breaks with xdebug 3.0 and is fixed with the patch. As single advantage, it is now easier to disable xdebug, so the 'prepared php.ini file without xdebug' hack in the test container images can be dropped. Change-Id: Id5810a5a6d988bfe5e814a6781d12d93baa97972 Resolves: #93599 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68137 Tested-by:
-
Christian Kuhn authored
* Test relies on xdebug, which is not available on CI, this test is never executed there. * Since the low level API header() is tested, the test additionally needs to fork a php process to do it's thing. This is ugly for a unit test. * Turning the test into a functional test won't improve the situation since the response emitting is not done with functional sub requests. * The skip logic breaks with xdebug 3.0 using xdebug.mode=off. Resolves: #93598 Releases: master, 10.4, 9.5 Change-Id: Ibab9452bdcbc83228c1445db1a92b42db54dc192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68135 Tested-by:
-
- Feb 26, 2021
-
-
Christian Kuhn authored
Resolves: #93592 Releases: master, 10.4, 9.5 Change-Id: If851b9264d7d9e3b2a18df49d2c445f034aa5a80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68133 Tested-by:
-
- Feb 25, 2021
-
-
Torben Hansen authored
Group assignment for a backend- and frontend user is currently limited to max. 20 groups per backend user and max. 50 groups per frontend user. The database field type for "usergroup" is now changed to "text" so the group limitation can be removed. Resolves: #93348 Releases: master Change-Id: I93329a8c186e13439d68cc6c36345842c4edd929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67577 Tested-by:
-
Dmitry Dulepov authored
This fix adds a check for the non-existing array member that is passed to a function that expects an array. In the debug configuration such missing check causes TypeError exception. Resolves: #93290 Releases: master Change-Id: I6d3c8cdc757349f09613a618ebe9309d96213bcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67446 Tested-by:
-
Benjamin Franzke authored
This is to avoid calling IconRegistry::setCache during early bootstrap. That hack was needed back when CacheManager was streamlined to only be usable after ext_localconf has been loaded (#86353). Since DI was not available back then, assets cache needed to injected statically. Now that DI is available, we can inject withing the factory. Resolves: #93475 Releases: master Change-Id: I97551ba7e60a6aaac832034b7df35f8c01d654c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67678 Tested-by:
-
Claus Due authored
Replaces an inefficient string parsing using strlen, for and ord, to use unpack instead. Saves one call to strlen per header, and potentially thousands of calls to ord per request. The same strategy is used in Message->filter, however, this method does not appear to be used so the unpack change is only applied in isValidHeaderValue. Releases: master, 10.4 Resolves: #92059 Change-Id: I6f485287eb6773accd8bd194ec998205479cec5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65396 Tested-by:
-
Oliver Bartsch authored
It's mandatory for HTML button elements to provide both, the starting and the ending tag, even if no phrasing content is provided. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button This is now enforced in the corresponding ViewHelper. Resolves: #93587 Releases: master, 10.4 Change-Id: Ie26716218be42ade8985dd13b222dfdebaaf2ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68109 Reviewed-by:
-
Tobias Wojtylak authored
The package @typo3/icons can be updated to version 2.2.2 which adds some new icons. Executed commands: cd Build yarn add "@typo3/icons@^2.2.2" yarn build Resolves: #93584 Releases: master Change-Id: I888594038c06f5db18c5ba5388ccdfeb29673938 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68096 Tested-by:
-
Oliver Bartsch authored
Because the request object was not set for the FluidEmail variant of the EXT:form EmailFinisher, the TYPO3 logo as well as the website URL in the footer were not displayed when using the SystemEmail layout from Core. This is now fixed by setting the request, if available. Resolves: #93588 Releases: master, 10.4 Change-Id: Ie6450b1a7a5728f1384e8010f02868bc26479c32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68103 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Stephan Großberndt authored
This patch ensures columns of tables which have been removed from ext_tables.sql definitions are recognized on PostgreSQL so they are renamed by adding a "zzz_deleted_" prefix. It also enables the formerly excluded according test for SQLite which works without additional changes. Resolves: #93491 Releases: master, 10.4 Change-Id: I8b6b487fde7ccc5f023e86cfa331d60c9606a774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68056 Tested-by:
-
- Feb 24, 2021
-
-
Christian Kuhn authored
The acceptance and functional test splitter scripts from typo3/testing-framework are tailored for core specific needs and of rather little use for non-core. For the sake of a more clean typo3/testing-framework, the patch merges the scripts into core mono-repo. Change-Id: Iefb576bb52c238ccca7b618fa6f9ea0d5718d0f9 Resolves: #93586 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68098 Tested-by:
-
Richard Haeser authored
If you have a good reason to disable the default rendering of hreflang tags, you can now use a TypoScript setting. To disable the hreflang generation, you can add the following line to your TypoScript setup. .. code-block:: typoscript config.disableHrefLang = 1 Resolves: #93188 Releases: master Change-Id: I7678b395e4c2bfd6a62a87c928b3f8a44af381ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67930 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
This brings a recent chrome version. Some tests need minor adaptions to deal with changed exceptions and behaviour. Change-Id: I1644a90ee09c98721ad8246988709461248c66a4 Resolves: #93575 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67964 Tested-by:
-
Oliver Bartsch authored
The sudo mode, introduced in #92836, is required whenever the install tool is accessed in the backend. Especially in development context accessing the install tool is a frequent task, e.g. for clearing all caches, to test global configuration or to run the database analyzer. Therefore, the sudo mode is now not longer required while the installations application context is set to "Development". Resolves: #93160 Releases: master, 10.4, 9.5 Change-Id: If61fa08847181491c01417d301a6bc1f480bae1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68094 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
