- Oct 09, 2023
-
-
Chris Müller authored
The GUI was changed with TYPO3 v12, so the screenshot is adjusted as well. Resolves: #102118 Releases: main, 12.4 Change-Id: I44a4ea5be814ed4d57b6b788254c2b4efe073bcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81376 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Oct 08, 2023
-
-
Chris Müller authored
The todo is obviously outdated, it is therefore removed. Additionally, remove some superfluous spaces in the code example and correct the indentation in the JS section to avoid "quote style" as drive-by. Resolves: #102119 Releases: main, 12.4 Change-Id: I357d878d456bdd7f5666d6982fd42337b4d2f6fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81378 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Andreas Nedbal authored
This setting is only used to determine if GIFBUILDER can be used or not. We can get rid of this configuration if we simply check for the existence of the GDLib classes that have been added in PHP 8.0, mainly the `GdImage` class. Resolves: #102113 Releases: main Change-Id: Ibe8fd29fe159074da5d3c4591bb2a332da79a1ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81373 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Oct 07, 2023
-
-
Christian Kuhn authored
phpunit 10.4.0 brings minor changed type annotations which phpstan isn't happy with. We bump both deps now. > composer req --dev phpstan/phpstan:^1.10.38 > composer req --dev phpunit/phpunit:^10.4.0 -w > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102110 Releases: main, 12.4 Change-Id: I86f6f47162d8e65bb6bf801c037a4e06e35288d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81370 Tested-by:
-
Benjamin Franzke authored
Unbundle CKEditor5 in order to be able to load plugins like "font" only if actually configured, allowing TYPO3 core to ship *all* available ckeditor5 modules without having to weigh in the downsides for large modules that we do not want to ship for "every" installation. All @ckeditor scoped npm packages provided by CKEditor5 are bundled into an own small per-package bundle that is loaded (and linked to each other) via our importmap infrastructure. This allows specific modules to be loaded ondemand and has the additional advantage that plugin authors can use modules via packages exports as suggested by upstream documentation. This should lower the the barrier for writing custom plugins. The existing bundle @typo3/ckeditor5-bundle is still in place and acts as wrapper for the split bundles. It is deprecated and will be removed in TYPO3 v13.0. Also worth noting is that terser is now used to shrink the module size. Resolves: #102099 Releases: main, 12.4 Change-Id: I873167a7cb5c04cb7ef34e943830879f3f78eaaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81323 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Oct 06, 2023
-
-
Christian Kuhn authored
Minor patch to streamline types a bit. Resolves: #102109 Releases: main Change-Id: I367bbe5092f225d45c30613e3cb46535ddf0b7f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81368 Tested-by:
-
Christian Kuhn authored
There are two rather obsure TCA 'types' settings not many people are aware of, and even less understand: $GLOBALS['TCA']['someTable']['types']['bitmask_excludelist_bits'] $GLOBALS['TCA']['someTable']['types']['bitmask_value_field'] They are meant to be used to determine table record types based on a bit field. That's probably because they can usually be superseded having a string identifier for type fields. Looking through core and searching TER extension code, both fields have never been used, ever. The patch removes these options from TCA and documents a workaround in the ReST file for those very rare cases a custom extension actually uses this feature. Resolves: #102108 Releases: main Change-Id: I8ff52c4a6aaaf9e65488cb34a8ab05dd34bb0a4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81367 Tested-by:
-
Christian Kuhn authored
Tables with TCA columns set to type="color" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=color. Note the field length is for now set to varchar(7), which should be enough to include a hex color definition like "#123456". This should be fine, but could easily extended in case we missed something. There are no direct core usages of type=color, but ext:styleguide confirms this change should be ok. Resolves: #102107 Related: #101553 Releases: main Change-Id: Id989c334089b7c273691ee3367acd23a2e10284a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81366 Reviewed-by:
-
Patrick Schriner authored
Add a aria-describedby attribute to link the password field with the requirements description. Resolves: #102100 Related: #97388 Releases: main, 12.4 Change-Id: Iec46dca547cf53764a47b18a54952aff8b33fdf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81329 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Christian Kuhn authored
Upgrade wizard SysLogSerializationUpdate loads all to-update rows into an array to iterate and update one-by-one afterwards. This can hit PHP memory limits when many rows need to be handled. The patch fixes this by avoiding the load to array and iterating single result rows directly. Resolves: #102104 Releases: main, 12.4 Change-Id: I454f89a18bdfcf1400f05edf318e37c5ea213424 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81363 Tested-by:
-
Christian Kuhn authored
Tables with TCA columns set to type="password" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=password. Resolves: #102106 Related: #101553 Releases: main Change-Id: Iaf64278d4eda164a535cdd2e741e13c28d7e738e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81362 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Helmut Strasser authored
The `f:link.page` ViewHelper registers an attribute for `target`, which works in extbase context. Due to some changes, the ViewHelper has been enhanced to mitigate the need for bootstrapping extbase in non-extbase contexts. Therefore, `LinkFactory` (TypoLink) has been used to build proper links in a non-extbase frontend context with #98474. The same principal for the different context has been applied to the `f:link.action` ViewHelper with #101729. That introduced a different behaviour between extbase and non-extbase frontend context by simply overriding the target attribute, if TypoLink generates one. This change discards the build target from the `LinkFactory` to behave equaly in non-extbase frontend context compared to extbase context. Additionally, tests are added to cover these cases to the corresponding ViewHelper functional test cases. Note: If TypoScript default target configuration is needed, the corresponding `f:link.typoscript` ViewHelper needs to be used. Resolves: #101432 Related: #101729 Related: #98474 Releases: main, 12.4 Change-Id: Icea34983ea1f730f5ceada7d7d5ea0dbf9827204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81312 Tested-by: -
Benjamin Franzke authored
Allowed content in CKEditor5 is to be configured via the General HTML Support plugin option config.htmlSupport. CKEditor4 style configs are now parsed and migrated. Note that this config.htmlSupport only applies to elements that are "known" to CKEditor5. Tags like "svg" or custom elements like "<foo-bar>" are not configurable this way as `htmlSupport.(dis)allow` can only handle elements that are defined in the CKEditor5 schema. [1] Also reintroduce the default configuration that allows any class and any attribute that starts with data- to be specified/preserved on known tags. This was removed with #96874. [1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#enabling-custom-elements Resolves: #99738 Releases: main, 12.4 Change-Id: Idaadfc09328efa4d1f21171a400dc45d29ed5904 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81316 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benjamin Franzke authored
* Use insertText command as provided by @ckeditor/ckeditor5-typing to match the behaviour of the upstream specialcharacters plugin: * Place cursor after inserted text * Replace existing selection when applying the button/shortcut * Disable button in source-editing mode (also fix ckeditor5 integration to work in case source-editing mode is disabled, to be able to test/verify that case) * Add tooltip to the toolbar button * Add a shortcut hint to the toolbar button tooltip * Show consecutive softhyphens * Show selections on softhypens and non-breaking-spaces Resolves: #101728 Releases: main, 12.4 Change-Id: I8c38a04a3c24de353edef921cc193f3fad718b4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81296 Reviewed-by: -
Christian Kuhn authored
When @import or <INCLUDE_TYPOSCRIPT: lines do not resolve to any include, this probably indicates a broken import statement. To help integrators find and fix those, the Page TSconfig and TypoScript backend modules now list them as "Syntax scanner warnings". We're adding a functional test to verify the detection works. This will ensure it does not break when we refactor some details of the include tree structure later. Doing as described in #102102 and #102103 would simplify and streamline various details, but it's currently unclear if we should still do this in v12. Resolves: #102064 Related: #100218 Related: #97816 Related: #102102 Related: #102103 Releases: main, 12.4 Change-Id: I1bba0cead97ff81b38c97f18581275edee01ea63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81352 Tested-by:
-
Markus Klein authored
The TypoScript parser matches valid operators first before dealing with values. Therefore, the TS `foo =<something` is now considered a reference and not an assignment. Resolves: #102101 Releases: main, 12.4 Change-Id: I7014b92f7a9120d0e77d264e964adef9d062070c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81355 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
editor.config.typo3link.additionalAttributes was used in TYPO3 v11 to enable certian attribute on link tags. Add a migrator that enables the same effect via the General HTML Support (GHS) CKEditor5 plugin configuration `config.htmlSupport`. Also remove the evaluation of the related but unused global config option ['EXTCONF']['rte_ckeditor']['plugins']['TYPO3Link']['additionalAttributes'] which was added in #78917 (initial CKEditor4 linkbrowser integration) but was never actually used (which was probably undiscovered due to its similar name). Resolves: #102052 Releases: main, 12.4 Change-Id: I2ca5b24890dd71dc5cba3aade22995a843e3dd33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81311 Tested-by:
-
Markus Klein authored
Since v12 relative paths with INCLUDE_TYPOSCRIPT and DIR work differently. Resolves: #102065 Releases: main, 12.4 Change-Id: I365925767739e15547d0aed81f5631ab12c7d83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81298 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
-
Simon Schaufelberger authored
DataHandler->copyRecord_raw can also return null. This should be reflected in the doc header as well. Resolves: #102098 Releases: main, 12.4, 11.5 Change-Id: Ic7a12233efd32b67f0bf25d6478a03f807a5623e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81328 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
- Oct 05, 2023
-
-
Benjamin Kott authored
The typo3-navigationIframe is not in use anymore, it is a leftover that was not removed in #96125. Resolves: #102097 Releases: main, 12.4 Change-Id: Ibc1f6be84f755c4e6b5869176edb682cc3f30f35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81327 Tested-by:
-
Stefan Bürk authored
Since PHP 8.3.0RC3 [1] the `\IntlDateFormatter` throws a `\IntlException` exception with the message: datefmt_create: invalid locale: U_ILLEGAL_ARGUMENT_ERROR if an invalid locale is passed to the constructor. The value `C` is considered as a non-valid locale, albeit it may be set. This change introduces a fallback to `en-US` for the two methods of the `\TYPO3\CMS\Core\Localization\DateFormatter` wrapping class, if `C` is passed as locale. `en-US` has been chosen as fallback because the TYPO3 locale class `\TYPO3\CMS\Core\Localization\Locale` uses the same as fallback if `C` is provided and additional tests are added to cover the same behaviour. Note: Other illegal locales are not handled and will allow the exception to bubble up with PHP8.3+. [1] https://github.com/php/php-src/commit/a80db7b52aa134bdc8b9841 Resolves: #102095 Releases: main, 12.4 Change-Id: I26d1ab74bd9dd659363320e191874f8526845158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81325 Reviewed-by: -
Nikita Hovratov authored
This event can be used to dynamically generate TCA and add it as additional base TCA. This is especially useful for "TCA generator" extensions, which add TCA based on another resource, while still enabling users to override TCA via TCA overrides as usual. Resolves: #102067 Releases: main Change-Id: I6d96e18b94f2a53693037b46e3b23d3b7f657154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81297 Tested-by:
-
Stefan Froemken authored
While migrating CKEditor5 property buttons.link.properties.class.allowedClasses the CKEditor5Migrator will now respect multiple classes. Resolves: #100841 Releases: main, 12.4 Change-Id: I245e8b0c8b2d14ee7917471963f29a9d65480245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78994 Tested-by:
-
Chris Müller authored
Resolves: #102088 Related: #101970 Releases: main Change-Id: I56c8975956fdc9dcc08a0cd61e283e46530f8033 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81321 Tested-by:
-
Torben Hansen authored
The redirects module does currently not allow to filter redirects based on the `protected` state. This making it hard to effectively administrate protected redirects on websites with a huge amount of redirects. This change introduces a new filter option in the redirect administration module which makes it possible to filter redirects based on the `protected` state. Protected redirects are now also visually highlighted by a lock-icon in the list of redirects. Additionally, unit- and functional-tests have been extended to cover redirect filtering based on the `creation_type` and `protected` state. Resolves: #102072 Releases: main Signed-off-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Josef Glatz authored
This patch improves the record history view of an element by showing the realName on top of the username if available. Resolves: #102091 Releases: main, 12.4 Change-Id: I14387e6113ea632615cddd537136660d310819a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81322 Tested-by:
-
- Oct 04, 2023
-
-
Anja Leichsenring authored
Tables with TCA columns set to type="text" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=text. Resolves: #101986 Related: #101553 Releases: main Change-Id: Id5d5ba863e83fcfdb2d716cb09e55b3fc996800b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81127 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benni Mack authored
The internal "stripProfile" check, and the checks for "processor_enabled" are now encapsulated into GraphicalFunctions. Resolves: #102048 Releases: main Change-Id: Ied1bd2e21410c77b45f0a6f83122ce9f5020a7e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81123 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de>
-
Christian Kuhn authored
We are auto-creating more and more table columns from TCA automatically with our works on #101553. ext_tables.sql can now end up defining no column of a table at all anymore. The schema parser currently stumbles when a table definition is completely left out in ext_tables.sql. The patch allows omitting a table definition in ext_tables.sql entirely. Resolves: #102085 Related: #101553 Releases: main Change-Id: I4d63250e3baa15e094f011ed21c813bc6cb12fb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81181 Tested-by:
-
Garvin Hicking authored
The scheduler detail view offers a "delete" button to delete a task from that view. This button now properly triggers a POST request, which is required by the controller to actually handle the delete action. Resolves: #102078 Releases: main, 12.4 Change-Id: I8553994f0e0a8b0967e3d93c2c5ceba84b96cc22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81310 Tested-by:
-
- Oct 03, 2023
-
-
Simon Schaufelberger authored
In order to test local composer packages, they need to be placed under the "packages" directory in "Build/composer". To autoload these packages automatically, the necessary setup is adjusted. Resolves: #102054 Releases: main, 12.4 Change-Id: I6c40a06142efaf13493a149efc636da9837c3598 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81268 Tested-by:
-
- Oct 02, 2023
-
-
Benjamin Franzke authored
Download CSS via fetch() and apply CSS scoping and URL rebasing on the client in order to avoid the need for a server side SASS wrapper that: * can not relocate relative paths * can not easily check if the resource is web accessible * had to use regex-replacements instead of straight forward replacements on a properly parsed syntax tree Commands executed: composer remove scssphp/scssphp composer remove scssphp/scssphp -d typo3/sysext/core --no-update cd Build npm install --save css-tree npm install --save-dev @types/css-tree npm run build Resolves: #101918 Resolves: #100768 Resolves: #101380 Releases: main, 12.4 Change-Id: I34dfd76c07584a482f9012de1c693f0e7f9a2cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81295 Tested-by:
-
Benjamin Franzke authored
Do not operate on the view model, but always read link attributes from the data model. Do this to avoid conflicts with the (pre)view representation of the contents which may not represent the plain data 1:1. Examples: * CKEditor5 renderes phone links in the editor preview as `href="#"`. That means `href` must not be parsed from the link (#101303). * Link classes may be alterated with stateful style classes and had therefore be filtered server side previously (#101959). This is workaround could now be removed. To make it clear that the result of getSelectedLinkElement() must not be used as data source, the (more) correct return type `ViewAttributeElement` is defined now (upstream does so too). Note that CKEditor5 uses commands somewhat like data-models, where the data is to be collected in the refresh() method. This is why we process all link-related registered attribute in there, (based on the CKEditor5 schema). Releases: main, 12.4 Resolves: #101303 Related: #101959 Change-Id: I04ee9a07c7444cd197f70d658e856d6824254020 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81266 Tested-by:
-
Oliver Bartsch authored
Resolves: #102063 Releases: main, 12.4, 11.5 Change-Id: I0ee1a4ec00ee972e9a2c8c3db442883125dacacd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81301 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Simon Schaufelberger authored
Resolves: #102073 Releases: main, 12.4 Change-Id: I18e0d9758f7d18c3d44086286b8bed8f722dd57d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81304 Reviewed-by:
-
- Sep 30, 2023
-
-
Torben Hansen authored
There are currently 3 conditions in `PageLinkBuilder` which use loose type comparison. All 3 conditions can safely be replaced by strict type comparison. Resolves: #102071 Releases: main Signed-off-by:
-
- Sep 28, 2023
-
-
Andreas Fernandez authored
This patch updates the `alwan` color picker library to the recent version 1.4, allowing us to implement localization at a later point. Executed commands: npm install --save alwan@^1.4.0 npm run build Resolves: #102061 Releases: main Change-Id: I9d30b575ad936a10c63ead7bec5e1e5c504981e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81293 Tested-by: -
Georg Ringer authored
Make the controller a bit more slim by moving database related code to the repository. Resolves: #101958 Releases: main Change-Id: I6a6f52236dcb6190d20e77f4356424e846702476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81091 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #102060 Releases: main, 12.4 Change-Id: I22acca2ecdff371a88c3cf060ac5c6707735bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81292 Tested-by:
-
Benjamin Franzke authored
Adapt to the user expection for a style selector to only show applicable styles. The list becomes overwhelming in case a lot of specific styles (like table formatting) are shown for unrelated elements. Resolves: #99673 Related: #101627 Releases: main, 12.4 Change-Id: I482935e91c863b601676b078fab0e9ba3acd62fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81269 Tested-by:
-
