- Feb 24, 2014
-
-
Felix Kopp authored
Brings CSS class for lists that semantically need to be UL or OL tags but do not have a visible list-style-item: <ul class="list-unstyled"> <li>…</li> </ul> <ol class="list-unstyled"> <li>…</li> </ol> Resolves: #55834 Releases: 6.2 Change-Id: Ic51fbe1f0995b4504d5b10a4c83775a977a19e33 Reviewed-on: https://review.typo3.org/27801 Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Feb 23, 2014
-
-
Markus Klein authored
This reverts commit 3adf7835 This patch breaks section menus as it introduces invalid caching. The original patch has not yet been backported. Resolves: #56209 Resolves: #54953 Releases: 6.2 Change-Id: Ia3fc8718ed3907913a5538eee102260425f2cf16 Reviewed-on: https://review.typo3.org/27788 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Wouter Wolters authored
Resolves: #55316 Releases: 6.2 Change-Id: I945f0c033f3d69c1951ea9ee59b0a00c5f866175 Reviewed-on: https://review.typo3.org/27046 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Stefan Neufeind authored
This reverts commit de27a20a Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc Reviewed-on: https://review.typo3.org/27792 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Andreas Wolf authored
When having e.g. the link for ``typo3/`` pointing to ``typo3_src/typo3/``, the install tool complains because the trailing slash is not expected. This slash is however perfectly ok, as there is no difference between typo3_src/typo3 and typo3_src/typo3/ – both point to the same "file" (i.e. node in the filesystem structure). This patch strips trailing slashes from the actual link target before doing the check, so no change to existing configuration is necessary. Change-Id: Ibcb2118a2bb8fcf004470f1a949824576ad4d1ec Resolves: #55551 Releases: 6.2 Reviewed-on: https://review.typo3.org/27229 Reviewed-by: Benjamin Mack Reviewed-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
It is faster to compare a string with === '' to find out if it's empty than to run strlen() on it. The replacement rules are applied as follows: * if (strlen($str)) => if ((string)$str !== '') * if (!is_string($str) || strlen($str) === 0) => if (!is_string($str) || $str === '') * If it can be seen easily that $str is a string, the typecast is omitted. Resolves: #54091 Releases: 6.2 Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457 Reviewed-on: https://review.typo3.org/27091 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Julian Kleinhans authored
Adds a new SignalSlot possibility after the preInit method call. Resolves: #56195 Releases: 6.2 Change-Id: Ia68734999a0e5fbe6c945d9e28d8571cd6192e75 Reviewed-on: https://review.typo3.org/27777 Reviewed-by: Tomas Norre Mikkelsen Tested-by: Tomas Norre Mikkelsen Reviewed-by: Erik Frister Tested-by: Erik Frister Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Feb 22, 2014
-
-
Helmut Hummel authored
Our functional test suit does not fail currently when tested code emits a PHP warning. This is due to the fact that the factory configuration uses the production exception handler which silently discards warnings. This change adds additional configuration that is merged with the factory configuration. In this configuration the TYPO3 exception handling is disabled and the core and classes cache is disabled. Additionally a new property is added to the base class to easily add some configuration values that might be needed for the test case. Resolves: #56187 Related: #56086 Releases: 6.2 Change-Id: I5c7c2c0d495bae06a56d2285b8d521eaa4ab37d2 Reviewed-on: https://review.typo3.org/27773 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Feb 21, 2014
-
-
Helmut Hummel authored
The functional test utility assumes that the current working directory is the document root, which must not necessarily be true. Use the absolute path to check for existence of extension directories instead. Resolves: #56204 Releases: 6.2 Change-Id: I9e5fa06f0e069c04586de7c23edc80e070ef4aa9 Reviewed-on: https://review.typo3.org/27786 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
Some PHP warnings occur in functional tests due to missing initialization of arrays or unused function parameters. Resolves: #56203 Related: #56187 Releases: 6.0 Change-Id: I1cd75de253382759315a8f72cff6e497b31bcc07 Reviewed-on: https://review.typo3.org/27785 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
* Cache hsc values of calls to sL() * Code cleanup * Use !empty() instead of count() for objects known to be an array Change-Id: Ie015f9755b98c41df185865325ea15ce42179e23 Resolves: #56109 Releases: 6.2 Reviewed-on: https://review.typo3.org/27745 Reviewed-by: Steffen Ritter Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stanislas Rolland authored
Solution: Configure a hook in frontend to add a meta tag just after the head tag whenever rtehtmlarea is in use on the page and the user agent is IE 11+. The meta tag instructs IE to emulate IE 10. Resolves: #56192 Releases: 6.2 Change-Id: Icc81f14c107360a47a34403032e5fe7890f1d784 Reviewed-on: https://review.typo3.org/27776 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Helmut Hummel authored
The functional test teardown does not remove the class loader but removes the instance directories. Because of this the TYPO3 class loader is still triggered (by PHPUnit classes) and tries to write things to a cache directory that does not exist any more. Resolves: #56086 Releases: 6.2 Change-Id: Ib6acb588fb8b84c64d04882228822f6398838b6b Reviewed-on: https://review.typo3.org/27775 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
Make it possible to determine the original root path of the installation by setting an environment variable just like in unit test bootstrap. Releases: 6.2 Resolves: #56182 Change-Id: I42af5d4db20a23eb5d1ce90fc87b6df818a11e88 Reviewed-on: https://review.typo3.org/27771 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Oliver Hader authored
The workspaces API has the command "clearWSID" that reverts elements that have been modified/created/deleted in a workspace. The regular behavior is to keep the elements but mark it as deleted and unset the value in "t3ver_wsid". Resolves: #56179 Releases: 6.2 Change-Id: I55bc72add6f41449dd99f5b6b2816cd1cda3e092 Reviewed-on: https://review.typo3.org/27769 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
The parent localization pointer (in this very case l18n_parent, instead of l10n_parent) is missing in the DataSet scenarios and assertions. Resolves: #56161 Releases: 6.2 Change-Id: Ieac6dd15d84f15488e0ee4690186efe2fb8dead6 Reviewed-on: https://review.typo3.org/27768 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
Integrate comma separated value functional tests for Inline Relational Record Editing for both live and workspace context. Resolves: #56143 Releases: 6.2 Change-Id: I8750cabd2e4df41e229ada888a43a104339cc55c Reviewed-on: https://review.typo3.org/27752 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Alexander Stehlik authored
If the mime type of a file has changed, the type property of a file will be updated, too. Resolves: #54305 Releases: 6.2 Change-Id: I013e2adbbb3d3cd3973ab50c8e88806b9477fe90 Reviewed-on: https://review.typo3.org/26288 Reviewed-by: Markus Klein Reviewed-by: Marcin Sągol Reviewed-by: Steffen Ritter Tested-by: Markus Klein Tested-by: Steffen Ritter
-
- Feb 20, 2014
-
-
Fabien Udriot authored
Fix a few typo in the variable names. Change-Id: I334e31a1e8e37ce7a79a3b905758843d51463c26 Releases: 6.2 Resolves: #56165 Reviewed-on: https://review.typo3.org/27762 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Oliver Hader authored
In a workspace, an existing content record is moved to an existing page. Another existing record is moved after the previously moved record on the target page. The Functional Tests show, that the content records are faulty after the processing and the first content record disappeared. A similar behaviour has been discovered for pages which finally lead to the regression causing this bug in issue #33104. Back then a hook has been introduced for moving page records and post-processing the database values. However, this hook has been called for all move operations for any table and was wrong in terms of the expected specific problem to be solved. The hook gets reverted, since it's sufficient to resolve move placeholders if a record shall be created after an existing one. Resolves: #55573 Releases: 6.2 Change-Id: Ie5cbc95daf4d46f4204cf18e80e17ff4fa37f496 Reviewed-on: https://review.typo3.org/27733 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Felix Oertel authored
While Typo3DbBackend claims to be Extbase's connection to the TYPO3 API, in reality it writes a lot of SQL state- ments itself. This replaces self-written statements with the according DatabaseConnection API call. Releases: 6.2 Resolves: #55571 Change-Id: Ia4f6ef0aadda16b6c5e89c7b36c8f91b185aac25 Reviewed-on: https://review.typo3.org/27254 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Mathias Brodala Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
In DatabaseConnection::listQuery strpos() is used with wrong parameter order. Resolves: #56135 Releases: 6.2, 6.1, 6.0 Change-Id: Iaa18d46442a2aac21a836216cb61ae376bbb2090 Reviewed-on: https://review.typo3.org/27749 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Oliver Hader authored
This change affects EXT:irre_tutorial and functional tests only: * rename tx_irretutorial_hotels to tx_irretutorial_1nff_hotels * use constants for table and field names in functional tests Resolves: #56132 Releases: 6.2 Change-Id: Iee2240c489c5523fbea208145ba667f349fde592 Reviewed-on: https://review.typo3.org/27744 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Feb 19, 2014
-
-
Oliver Hader authored
Localized sys_category records cannot be rendered in frontend, since only records with a positive pid value are overlaid - however, sys_category is stored on the root-level. Resolves: #56059 Releases: 6.2, 6.1 Change-Id: I211dad5086adf30723ef4f44757fe6a3121ac29e Reviewed-on: https://review.typo3.org/27673 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
The MM_oppositeUsage property allows to apply match fields of the opposite relation to MM records. This feature shall be enabled for sys_category records as well. Resolves: #56122 Related: #56061 Releases: 6.2 Change-Id: I33c9f3c471d66c4154be5c2fb5180254401096f0 Reviewed-on: https://review.typo3.org/27731 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
On copying a sys_category record, a new MM reference is created, however without setting the "fieldname". This value is basically defined from the opposite entity with MM_match_fields, but cannot be accessed. This change introduces the MM_oppositeUsage property for MM definitions in the TCA. Example: 'config' => array( 'allowed' => '*', 'MM' => 'tx_myextension_first_second_mm', 'MM_oppositeUsage' => array( 'tt_content' => array('somefield'), 'tx_myextension_domain_model' => array('some_property'), ), ), Resolves: #56061 Documentation: #56123 Releases: 6.2 Change-Id: I26fd54688cf44d6a026ccdb3ca9276583b32acd3 Reviewed-on: https://review.typo3.org/27677 Reviewed-by: Wouter Wolters Reviewed-by: Ernesto Baschny Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Michiel Roos authored
This often used method can be about 5% more performant by rewriting it. Change-Id: Iee80a35ebd98c3521a75977bc7ab45d170858e24 Resolves: #55198 Releases: 6.2 Reviewed-on: https://review.typo3.org/27086 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Francois Suter authored
When a table is marked as being categorizable, the categories field is added with an "exclude" flag hard-coded to 0. Thus it is not possible to hide this field for editors. This patch changes the default value to 1 and makes overridable. Resolves: #53454 Documentation: #55718 Releases: 6.2 Change-Id: Iff2431b4294b8d3b9cf3dff291186e1a6a2ebafb Reviewed-on: https://review.typo3.org/27373 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Francois Suter Tested-by: Francois Suter
-
Oliver Hader authored
After having performed changes to data structures using the DataHandler, the correct impact for the frontend needs to be asserted. This patch checks the correct behavior for DataHandler action tests for regular, MM and IRRE disposal. Resolves: #56104 Releases: 6.2 Change-Id: I99f11f6b039c31e08614caf8ee9bca9d47700b93 Reviewed-on: https://review.typo3.org/27711 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
To ensure that actions in the backend have an accordant and correct impact in the frontend, a frontend request needs to be triggered from the functional test execution. The response of that simulated frontend request shall be delivered as JSON, exceptions need to be caught and forwarded to the test suite as well. Besides that, it is required to have a possibility to set up TypoScript configuration, modify TCA and TYPO3_CONF_VARS for further hook processing. Resolves: #55882 Releases: 6.2 Change-Id: I54d475e8f1ce01fd7cb8c64b68c2318b1e9f7bbe Reviewed-on: https://review.typo3.org/27413 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Stefan Neufeind authored
Follow-up for PHP 5.3 compatiblity. Resolves: #56121 Releases: 6.2 Change-Id: I948eb3063c2e6b014b8d69c2011789c7dbe58748 Reviewed-on: https://review.typo3.org/27719 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Stefan Neufeind authored
As the other tests in GeneralUtilityTest also getFilesInDirCanOrderByMtime() should use vfs. Otherwise we might run into random problems if some mtimes are equal. Change-Id: Ic5ad10bd5beedb26c00d48602ebd5455525e4826 Resolves: #56121 Releases: 6.2 Reviewed-on: https://review.typo3.org/27717 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Oliver Hader authored
Discarding workspace changes works with the version command "clearWSID" which might come down to a "delete" action if the versioned records have a delete or new placeholder (which is the case for copied or localized elements). However, the functional tests need to use the "clearWSID" instead of the "delete" command. Resolves: #56111 Releases: 6.2 Change-Id: Id10413048a68abdb5ef05bb6e20e6cb6460f9742 Reviewed-on: https://review.typo3.org/27712 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Michiel Roos authored
Refactor getFilesInDir to use scandir(). Change-Id: Iafca3e7b7610ef0b11441ef118c85c8e6cc481b8 Resolves: #54095 Releases: 6.2 Reviewed-on: https://review.typo3.org/25768 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Felix Althaus authored
FileContentParser used to issue a warning trying to index image files with corrupted EXIF data. Suppress these warnings to fail silently. Resolves: #55286 Releases: 6.2, 6.1 Change-Id: I863601f5579ab74a0743ab684cf1d898b633edba Reviewed-on: https://review.typo3.org/27160 Reviewed-by: Wouter Wolters Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Stanislas Rolland authored
Solution: Add ExtJs css files required by the RTE Resolves: #56027 Releases: 6.2 Change-Id: I56c81a0119a34097aa8c4a3dd15655cb5a6ca635 Reviewed-on: https://review.typo3.org/27647 Reviewed-by: Wouter Wolters Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Stanislas Rolland authored
Problem: When the RTE inserts the link, the href looks like http://somedomain/?file:1234. If a rel attribute is present, the link is not transformed into a typolink on the way to the database. However, the href attribute is not transformed, as it should, into a normal file url. It should because the a-tag will be rendered as is in the frontend. Solution: When a link is not be transformed into a typolink, transform the href into a normal file url. Resolves: #54944 Release: 6.2 Change-Id: I92c45363ffd62de0f4e89941944f55320d4fc708 Reviewed-on: https://review.typo3.org/27142 Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Steffen Ritter Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Resolves: #56067 Releases: 6.2, 6.1, 6.0 Change-Id: I6d1e19026afde81bec46cec3dff9060fa6042c43 Reviewed-on: https://review.typo3.org/27679 Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 18, 2014
-
-
Caspar Stuebs authored
Get the labels for the doktypes from TCA Resolves: #52955 Releases: 6.2, 6.1 Change-Id: I6d70c11f1711bf191a4ce14a91796819224649da Reviewed-on: https://review.typo3.org/24934 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Nico de Haen authored
The DataMapper should check if an object is already in the identityMap before calling fetchRelated, since otherwise the object will be retrieved from the database again. Resolves: #53514 Releases: 6.1,6.2 Change-Id: I24e262322f1f0ba3c346fa01c50fa9063866aef7 Reviewed-on: https://review.typo3.org/25252 Reviewed-by: Nico de Haen Reviewed-by: Fabien Udriot Tested-by: Wouter Wolters Reviewed-by: Steffen Müller Tested-by: Steffen Müller
-