Change-Id: If2ba9153384609a7f87d8ab3e74c293ae0c77b3a
Reviewed-on: http://review.typo3.org/16648
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

Change-Id: Ibc293fdca09d424718f858e4b7585082ebf1e461
Reviewed-on: http://review.typo3.org/16647
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team

The jsfunc.placeholder.js file was introduced to have a fallback
for Internet Explorer on the HTML5 placeholder feature. However,
this handling is currently active in all browsers and results in
broken NULL values for textarea, since textarea don't have a
human readable representation like input fields.

Fixes: #43183
Releases: 6.0
Thus, only activate the handling in Internet Explorer.

Change-Id: Ie27c8e8544fa99cad14f3a74fa960524cc7e834a
Reviewed-on: http://review.typo3.org/16644
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Currently there's no possibility to handle NULL values in
TypoScript. This is related to the feature "Add possibility
to store NULL values (#41773)".

Thus, two new elements are integrated:
* (stdWrap).ifNull -> string/stdWrap
* (stdWrap).if.isNull -> stdWrap

Change-Id: I77a29341c66edaf3bef14de33f65c702fbbb9fbd
Resolves: #43133
Releases: 6.0
Reviewed-on: http://review.typo3.org/16637
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Deactivated textarea elements, fields that have a NULL value
stored in the database, are not visualized correctly when
loading the backend editing form. The status is currently set
using JavaScript and triggered by TBE_EDITOR.fieldSet().
However, textareas don't have a human readable clone and thus
fieldSet() is not called and thus no status is set.

This issue is fixed by directly rendering the status in the
FormEngine.

Change-Id: I2dded816853f452b25f6edf6e7d7f6dca1387739
Fixes: #43175
Releases: 6.0
Reviewed-on: http://review.typo3.org/16636
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Change-Id: Ib1b9f2f4bc274bcb1f180507a8ca0257323fd4bc
Releases: 6.0
Reviewed-on: http://review.typo3.org/16642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

This patch allows the configuration of the thumbnail image in IRRE
record headers. It is possible to configure e.g. height and width
using the TCA configuration in "headerThumbnail".

Resolves: #42837
Releases: 6.0

Change-Id: I284e9d04676fb3d4031eac6d2f8548761e167e69
Reviewed-on: http://review.typo3.org/16377
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Fixes: #42932
Related: #42806
Releases: 6.0

Change-Id: I05c179c917ed43cb70c2966984080670192713d4
Reviewed-on: http://review.typo3.org/16641
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Fixes: #42930
Releases: 6.0

Change-Id: I71780306d8edcd0da769ba7c56d4d4e3e386b77c
Reviewed-on: http://review.typo3.org/16640
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The fields title, description and alternative are available
in file references and files. If those in file references
are not defined, those of files shall be used.

Besides that, some fields are not configured yet to be shown
as placeholder element in the backend.

The flaws are fixed by adding accordant TCA configuration and
adding the fallback behaviour for the FileReference object.

Change-Id: I28fa94faeb88958ce6c6cb942ba9a88bd555acdf
Fixes: #43173
Releases: 6.0
Reviewed-on: http://review.typo3.org/16635
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

File processing is a central part of TYPO3's file usage, as e.g. all
images in content elements have to be resized when they don't fit the
requirements. However, the current implementation of file processing
with FAL has several drawbacks and shortcomings, not to mention quite a
few bugs.

This patch brings a completely reworked infrastructure behind the
File Processing Service, while keeping the external API unchanged.

The processing to be done is described in tasks, which are part of a
ProcessedFile's properties. The processing itself is now moved to
processors, which could execute the tasks using different utilities,
e.g. ImageMagick or some cloud image processing service. Currently,
there is only a local image processor implementation, which relies on
ImageMagick/GraphicsMagick (i.e. uses the same configuration as the old
processing).

The processed file class now also supports safe handling of unchanged
files, i.e. files that should have been processed, but didn't need
processing.

Fixes: #43059
Fixes: #39904
Fixes: #40033
Fixes: #40669
Releases: 6.0

Change-Id: I186a46f9923dacd98be655d72be2bd89b43866c2
Reviewed-on: http://review.typo3.org/14310
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

EXT:fluid is a required extension since TYPO3 6.0. The
isLoaded('fluid') call in FLUIDTEMPLATE content object
can be removed.

Change-Id: I514163bffc19fa264501dc2d88e1fe59f0e9a062
Fixes: #43172
Releases: 6.0
Reviewed-on: http://review.typo3.org/16633
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Some tests fail on Windows systems. Mostly this is because of a missing
file and folder permission handling. Those tests have to be skipped.
Furthermore there is some path fixing needed in basic class.

Change-Id: Ib89e84539af2742dbb3a6e2f53ae5a0c121a0626
Fixes: #43126
Release: 6.0
Reviewed-on: http://review.typo3.org/16596
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Passed $data in start method could be a non-array, e.g. in fluid
CObjectViewHelper or in extensions. Migrate $data only if it's a
not empty array and the table is set.

Makes the fieldArray fallback to TSFE->page in getData working again.

Change-Id: I469e8fa6131579a2de399516c65f4822275b187b
Fixes: #43068
Fixes: #43055
Releases: 6.0
Reviewed-on: http://review.typo3.org/16546
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In TYPO3 4.7 (and below) the default field of a configuration was a text
field. With a wrong configuration type in ext_conf_template.txt now the
field isn't rendered any more. There should be a fallback to a normal
input field like it used to.

Fixes: #43042
Releases: 6.0

Change-Id: Ic49c9b19a7f8f1795889f17ed5c1efa364dfd9b9
Reviewed-on: http://review.typo3.org/16503
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The meta data (like description, title, ...) in File References
cannot be used to disable the inherited data from the parent
File object. Currently values can be blank which results in
using data from the parent. To really override by using blanks,
the new NULL feature for TCA fields needs to be used.

Change-Id: I61e5f5e6a0d848e95e2e0402913778ef9f63a093
Fixes: #43132
Releases: 6.0
Reviewed-on: http://review.typo3.org/16602
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In some queries backticks are used to generate the WHERE clause. Those
backticks lead to an error when using dbal. Therefore they have to be
removed.

Change-Id: If6aa29f73fda93cfc122af51201730cc6475a8c1
Fixes: #43168
Release: 6.0
Reviewed-on: http://review.typo3.org/16629
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

For the table sys_category_record_mm after the first KEY command there is
a missing comma which leads to dbal crash.

Change-Id: Ib5d88df46c166a9e7fffd5106e5158679cd947d8
Fixes: #43167
Release: 6.0
Reviewed-on: http://review.typo3.org/16628
Reviewed-by: Anja Leichsenring
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Activating a field that supports NULL values and just using a
blank string ("") does not work. The problem is a strcmp() call
that returns a false-positive on comparing NULL to blank strings

Change-Id: I59417f5f5cd814db15e2b6b725f1778d098014f6
Fixes: #43139
Releases: 6.0
Reviewed-on: http://review.typo3.org/16599
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The BaseTestCase already has a possibility to create full blown
accessible object proxies. However if one does not want to have
the class stack cluttered with temporary existing classes, there
shall be a possibility to directly invoke protected/private
methods of a fixture object.

The new method callInaccessibleMethod method is taken and
rewritten from ModuleControllerTest.

Example to use it in unit tests:
$this->fixture = new \TYPO3\CMS\Core\SomeClassName();
$result = $this->callInaccessibleMethod(
  $this->fixture,
  'privateMethod',
  $first, $second, $third, ...
);

Change-Id: I2c90c136c350129b28809d8b8b88286149894a10
Resolves: #43145
Releases: 6.0
Reviewed-on: http://review.typo3.org/16598
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Some tests are failing in
TYPO3\CMS\Core\Tests\Functional\Category\Collection\CategoryCollectionTest
due to false CREATE TABLE statement.

Change-Id: I8fe03b4d02c8f85fcddf8be06010eb8b2f079102
Fixes: #43122
Release: 6.0
Reviewed-on: http://review.typo3.org/16594
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I3f333615f87c7682d251987df1e58403720d331b
Reviewed-on: http://review.typo3.org/16592
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The 'old' class files before namespace switch are commented
to be removed with TYPO3 7.0, but they should be scheduled
for removal with 6.2.

Change-Id: I2db757db54410c5764ab21aef90918a7771f2c92
Resolves: #43120
Releases: 6.0
Reviewed-on: http://review.typo3.org/16590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

EXT:cms/ext_tables.sql and t3lib/stddb/tables.sql define
an identical table schema of table cache_imagesizes.
Since cache_imagesizes is used in core classes, the
duplication in EXT:cms is removed with the patch.

Change-Id: I67a861afe34f3e388f898fc3f0bad5b5c574d626
Resolves: #43119
Releases: 6.0
Reviewed-on: http://review.typo3.org/16583
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The deprecated classes have been removed in Fluid.
Remove them from the IDE file.

Related: #43069
Releases: 6.0

Change-Id: I2d51053009fe0455e3d085645de37ac037363d41
Reviewed-on: http://review.typo3.org/16553
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The class extbase/Reflection/Service is renamed to
extbase/Reflection/ReflectionService, so the LegacyClassesForIde
must be adjusted accordingly.

Resolves: #42810
Relates: #42808,#42809
Releases: 6.0

Change-Id: Iecd47910ed6708fcde06b4ab25c73d8cbea9f44f
Reviewed-on: http://review.typo3.org/16343
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Change-Id: If47b70fb9183b9a36f88a8908ec455de7d1e7fa4
Reviewed-on: http://review.typo3.org/16582
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The Bootstrap still contains a require statement
for the language service, which can now perfectly be
loaded by the autoloader.

Resolves: #43115
Releases: 6.0

Change-Id: I04eacb1e459f4e7f1e14a46597cdbee7a1ce7a74
Reviewed-on: http://review.typo3.org/16579
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Do not save rewritten code in compatibility class loader
if no replacements have been found but require the
original class instead.
Additionally do not touch classes that do not start
with 'tx_' or other known TYPO3 specific prefixes.

Resolves: #42497
Releases: 6.0

Change-Id: Ic3cdafbfec3814ef61046500c1ac4f916bade133
Reviewed-on: http://review.typo3.org/16018
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

In some functions the old class tslib_gifbuilder is still called and
should be replaces with the namespaced class.

Change-Id: I313ce18f667e0f7cc636422d9a784433851d59d8
Fixes: #43111
Releases: 6.0
Reviewed-on: http://review.typo3.org/16577
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

extList was kept next to the new extListArray in LocalConfiguration.
Both hold the current list of loaded extensions. This leads to
confusion which variable is the one that takes precedence.
The patch removes extList from the upgrade wizard in the install tool
and only writes extListArray. This way, only one key is kept in
LocalConfiguration.php. For compatibility reasons, the array entry
'extList' is added to $GLOBALS['TYPO3_CONF_VARS'] at runtime during
bootstrap.

Change-Id: I6102b2b4da9761c86189ae3f73ad3a423715e037
Resolves: #43094
Releases: 6.0
Reviewed-on: http://review.typo3.org/16566
Reviewed-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Wouter Wolters

The length of the CType file is often too small to contain the name of
the extension that creates a new content element type. It should be
increased from 30 to 255.

Resolves: #43062
Releases: 6.0

Change-Id: I5ac23f7bdaa40ea9764d08ee330883da5be5a1ef
Reviewed-on: http://review.typo3.org/16560
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Add the missing TYPO3 prefix to the full qualified
class name.

Releases: 6.0

Change-Id: I6a6417dc63a7ef87947b8186aefff12bdeb929f2
Reviewed-on: http://review.typo3.org/16545
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The extension "frontend" is still using the old table name
sys_language_overlay

This patch fixes this issue by renaming it to pages_language_overlay

Change-Id: Ida5444d113ba089652adba7d0cbd01729ce9ab48
Resolves: #43001
Releases: 6.0
Reviewed-on: http://review.typo3.org/16454
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

In fact current implementation does not replace the LIKE
operator with an SQL equal statement for numeric fields
but whenever a query that can be interpreted as integer
is encountered, regardless of the underlying column type.

Example: If you have pages "102 W", "102 E", you used
to be able to search for "102" and get them, but now
the query is casted to an integer and the page title
is search for an equality on "102" resulting in
an empty result list.

The underlying column type should be used
instead (code to cache this information is already
available within DBAL and Helmut started months
ago to backport it to Core itself: #28654).

Thanks to Clio Online for sponsoring this fix!

Resolves: #33700
Releases: 6.0, 4.7, 4.6

Change-Id: I8c4cceac5320b9135ccf9e99892cc57dcfffadc5
Reviewed-on: http://review.typo3.org/13990
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov

With namespaces the @package and @subpackage annotations
do not have a real benefit anymore and can be removed.

Change-Id: Id8f4718db0c1c51ae5143a3353dd5efb42dadf70
Resolves: #43019
Releases: 6.0
Reviewed-on: http://review.typo3.org/16474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Function TYPO3\CMS\Backend\Template\DocumentTemplate->isCMlayers()
is not needed and can be removed.

Change-Id: I7cef6a7711055c8cd6ce7ca0b3bf94b22e50a62f
Resolves: #41272
Releases: 6.0
Reviewed-on: http://review.typo3.org/14955
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If GeneralUtility::validEmail() is called with array or object
as parameter, warnings or errors are thrown of type "strlen()
expects parameter 1 to be string" or similar.
The patch sanitizes the method by returning early with FALSE if
input parameter is not a string.

Change-Id: I56c8ec91c730e47d341de7f09c14c7ee0492a616
Fixes: #42792
Releases: 6.0
Reviewed-on: http://review.typo3.org/16462
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Refactoring #19938 a loose end was forgotten to be removed in one test.

Change-Id: I36d1f9368eb829afebd5c3be2282811b010ed5ff
Related: #19938
Releases: 6.0
Reviewed-on: http://review.typo3.org/16453
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Refactor and fix handling of preserveGETvars in felogin.
 * Add support for multi dimensional arrays
 * urlencode() values
 * Preserve only parameters defined in 'preserveGETvars'

The patch adds a new ArrayUtility method to handle
recursive array intersections. See the unit tests for details.

Change-Id: I90e2f8eb79586369a9c15c7ef19f7658b1d65ed3
Fixes: #19938
Fixes: #23324
Fixes: #23649
Fixes: #36894
Fixes: #38589
Releases: 6.0, 4.7
Reviewed-on: http://review.typo3.org/7638
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn