- Jan 20, 2021
-
-
Richard Haeser authored
When a canonical link is set in the page properties, this page or translation should not get a hreflang link in frontend as this might send conflicting signals to search engines. Resolves: #89878 Releases: master, 10.4 Change-Id: I4a2fb81b474bf155ba0beca5dfa3948f36edf840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67328 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
In the bootstrap v5 migration the data attribute key which is used in JavaScript to perform actions depending on the toggle state, has changed. Now the correct data attribute key is used again. Resolves: #93320 Releases: master Change-Id: Icd80dc210dfa55176db1b7f1be30ad015783f6be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67468 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Jan 19, 2021
-
-
Benni Mack authored
This change uses Twitter Bootstrap 5 usages across TYPO3 Backend, and fixes the toggle / icon toggle switch. Now the bootstrap-5 based toggle (form-switch) is used, and can be modified easily with a custom SVG later-on, but is kept as is for now, in order to make sure it is used consistently everywhere. Resolves: #93310 Releases: master Change-Id: If52d06932e1ee087d9c7d76cfb7d0f0c0e92276a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67461 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Kevin Appelt authored
Resolves: #93298 Releases: master Change-Id: Ic93d7e837fc3a19e78211bbe3b7562ac3cd51213 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67454 Tested-by:
-
Andreas Fernandez authored
The Permissions backend module and its JavaScript module now ditch jQuery in favor of native browser API and TYPO3 API. The JavaScript has been refactored a little bit; initially checking the permission checkboxes or writing back the calculcated permission value is now decoupled and executed in the Permission module only. To support for..of with NodeList collections, TypeScript now loads the internal "dom.iterable" library. Additionally, the interim solution to add `editform` to Document has been removed which made another change in LinkPopup necessary. Furthermore, a bug has been fixed, where the value of the first visible select element was used when saving any other select element with a completely different value. Resolves: #93301 Releases: master Change-Id: Iffede862a0eb36e805a5f127d7b19f32c899ce31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67457 Tested-by:
-
Benni Mack authored
The listing of extensions in the Extension Manager module now properly shows the inactive extensions again. Previous CSS changes didn't apply the inactive extensions again. In addition, if an extension does not have an Extension Icon in the Extension Manager list, it created an <img> tag with a path to the extension folder typo3conf/ext/my_ext/ resulting in an error in the browsers. This is now replaced with an empty icon. Resolves: #93311 Releases: master Change-Id: I723a0d603b36ad799c0c02869829742f19a69b37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67462 Tested-by:
-
Oliver Bartsch authored
To prevent broken records which reference a renamed folder, the AfterFolderRenamedEvent is now used to synchronize the corresponding relations as soon as such action took place. Furthermore does the AfterFolderRenamedEvent now contain the source folder, which is necessary to find those relations. A flash message informs the user about the synchronization when the action was performed in the backend, e.g. in the file module. Resolves: #78036 Resolves: #83054 Releases: master Change-Id: I9cc8bfbb5c8506c22dc4377fd3041b1113864182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67441 Tested-by:
-
Uwe Trotzek authored
When a user is editing a complex data structure with IRRE and if he just changes one entry of a structure then all the items will be shown as changed in the workspace module. Most users will wonder why an element is shown as changed even if the user didn't touch this particular entry. This change will hide the "show differences" button in the module for entries where no data was changed except for internal properties. Those items will also have a different color in the list. Now the user can easily identify the records where something was really changed and open the diff to see what has changed. Resolves: #91157 Releases: master Change-Id: Ib5ca5bb50360091813855bd8aef0b9e627e1e826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64295 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 18, 2021
-
-
Johannes Rebhan authored
This adds the ability to wrap the content of an automatically generated typolink link text, e.g. when linking to internal pages, with markup using the typolink options `wrap` and `ATagBeforeWrap`. Resolves: #92338 Releases: master Change-Id: I1ecac8fe52384acef249177850662ebc90497b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65758 Tested-by:
-
Guido Schmechel authored
User and group names in the access module are no longer shortened after 20 characters. It is now possible to see the full 50 characters. In addition, a title attribute has been added. Resolves: #93089 Releases: master Change-Id: If37d24235ff445297548a2830e5745cb889d5a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67363 Tested-by:
-
Benni Mack authored
The opendocs toolbar item does not have a badge background anymore, this changes re-adds the background and also unifies the badge from the system information toolbar to use the rounded-pill class. Resolves: #93303 Releases: master Change-Id: Ie2ecc99fd5ad4ad8845923af018c051665ac6118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67459 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Jan 17, 2021
-
-
Jochen Roth authored
Will set equal height for checked checkbox and the empty button. The first button will now get a border-radius to streamline the buttons according to the action buttons Resolves: #93292 Releases: master Change-Id: I6479c968f77df41ed00d23d68c5ec23363ac64a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67449 Tested-by:
-
Thomas Löffler authored
When there is no specific preview renderer defined for a given subtype, the type-specific renderer can only be used if it's not an array. Otherwise, the default preview renderer defined in TCA crtl should be used. Releases: master, 10.4 Resolves: #92758 Change-Id: Ia88d262f52ddac174cbe6750c591898c84872a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413 Tested-by:
-
- Jan 16, 2021
-
-
Elias Häußler authored
Using drag and drop, one can create new pages within the page tree. New pages can be created before, after or within existing pages. Currently, one could not provide a page title if the page was created within a page without subpages due to issues with unintended focus change after drag and drop. It is now ensured that a page title can be edited directly after dragging a page into the page tree. Some cases are also covered by acceptance tests now. Resolves: #92380 Releases: master, 10.4 Change-Id: I95391631f11552fc59e9252e904052d8288c5d91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67316 Tested-by:
-
Markus Klein authored
If some link handlers are hidden with "blindLinkOptions" then we still want to preserve the well-known order of the other tabs. This is solved by defining more dependencies on the link handlers, so that the ordering service still has a clue about the order. Releases: master, 10.4 Resolves: #86312 Change-Id: I60c3c7b1cbcb57b7774663732d7bd3aca9ef15c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67455 Tested-by:
-
- Jan 13, 2021
-
-
Benni Mack authored
The page module does not throw a fatal error anymore if a content type "text" has a bodytext of value "null" instead of "text". Resolves: #93283 Releases: master Change-Id: I23b5c508d1886dc2277e5d4a2010f8a57fd8bb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67443 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #93278 Releases: master Change-Id: Ie4b0e533fda887b92fdbd5c4e870435c12b091ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67439 Tested-by:
-
Oliver Bartsch authored
The RenameFile JavaScript handles renaming of files and folders. If renaming a folder, some input fields are not available in the form and must therefore be checked for existence, before accessing their value. Furthermore does the file delete modal now display the modal content again. The corresponding data attribute was renamed in the bootstrap v5 migration. Resolves: #93277 Releases: master Change-Id: I4ba6bc625a152d7e97ba6c44612a17b782799d31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67438 Tested-by:
-
- Jan 12, 2021
-
-
Benjamin Franzke authored
As of #92628, 'loginLogoAlt' is evaluated when a custom backend loginLogo has been set, but it is not taken into account if has not been set at all. Use null coalesce operator to avoid notices and to avoid throwing TypeErrors because trim() cannot handle null values. Resolves: #93275 Related: #92628 Releases: master Change-Id: I1cd2875f9b92b9d1a86e3817e1623acb45922b85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67437 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Martin Kutschker authored
Due to CSS changes in Boostrap 5 the navigation buttons on the login screen were invisible. This patch makes them visible again. Resolves: #93258 Releases: master Change-Id: Ifdd9dcb88504428303ac7680106c721038181505 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67402 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
The reference index can be seen as a 'cache' for consuming application parts other than the DataHandler, which does not rely on it's state but keeps it updated. From this point of view, workspace delete placeholders (t3ver_state=2 records) should not have reference index entries: The delete placeholder is just a marker that a specific live record is slated for deletion upon publish. It does not carry relation information on it's own. The patch changes reference index code to not consider relations for workspace delete placeholder records. Change-Id: I0a1fd490c4133e7ce92a53ebd4413cc7b43b1d58 Resolves: #93274 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67396 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Scenario: A live page has a page localization. In workspaces, the page localization is deleted, creating a delete placeholder. After that, the page is moved to a different parent page in workspaces. The delete placeholder of the localization is then turned into a move placeholder. This is wrong since the delete information is lost. The patch suppresses the change of delete placeholders to move placeholders when moving records. This issue is much harder to solve in v10 since v10 has to deal with two move overlay records and v11 with one. The patch is thus slated for v11 only. Change-Id: I233b944b030bba0de6c22d4ec1b6cb862184ddb6 Resolves: #93268 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67400 Tested-by:
-
Richard Haeser authored
By adding the workspace restriction to the RecordsXmlSitemapDataProvider, only records in the live workspace are shown in the XML sitemap. Resolves: #93010 Releases: master, 10.4 Change-Id: Ib46c3ebc925405de81afefda83100ccddb761fad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67392 Tested-by:
-
Oliver Bartsch authored
Some protected properties with single usage are replaced with local variables to reduce complexity. Resolves: #93269 Releases: master Change-Id: I9f34e5a2746988e11f97d923837f49b0435fc6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67401 Tested-by:
-
- Jan 11, 2021
-
-
Sebastian Iffland authored
A new TSconfig option `iconOverlay` is introduced, which allows to define an icon overlay for each element within the newContentElementWizard. Releases: master Resolves: #92942 Change-Id: Ib6aa02424e5a1d6411ef8fc9830364c8b2c19a31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66909 Tested-by:
-
Christian Kuhn authored
The DataHandler delete related methods still handle too many things. This is yet another divide & conquer patch: Move the 'undelete' functionality to dedicated methods, drop handling from 'delete' methods and refactor 'undelete'. The result is a quite straight forward 'undelete' implementation, plus reduced complexity in 'delete'. Change-Id: I6ea2326fa2ad6de03c8cd3bd37184fff116fda06 Resolves: #93253 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67368 Tested-by:
-
Andreas Fernandez authored
If a Flexform section gets deleted, the container must be hidden in DOM and not deleted, as the underlying DataHandler code relies on getting the field submitted. This patch is less intrusive as possible to allow a backport to stable releases. Flexforms needs a major refactoring and should act similar to IRRE, but this can go into the master branch only. Resolves: #93061 Releases: master, 10.4 Change-Id: I69dfdd6f2029547d600939f23e21b03abd45042d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67369 Tested-by:
-
Oliver Bartsch authored
The correct height of the input group is restored by removing unnecessary wrappers around the buttons. See: https://getbootstrap.com/docs/5.0/forms/input-group/#button-addons Resolves: #93262 Releases: master Change-Id: I3e8276f66efbb593480371d3ee26d0ec08ba35d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67399 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Simon Schaufelberger authored
When an error occurs in a DataHandler AJAX call, the error message should only be shown once. Resolves: #93207 Releases: master, 10.4 Change-Id: I8f341d08bfe051af5a485f21628907c74a812490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331 Tested-by:
-
- Jan 10, 2021
-
-
Martin Kutschker authored
The translation key login.error.capslock is duplicated. The second instance is now named login.error.capslockStatus as in the referring Fluid template. When there are no loginProviders to be chosen from then the nav region would only be comprised of an empty <ul>. Do not render the tags for this condition. Resolves: #93255 Resolves: #93256 Releases: master Change-Id: I4527eb8863a92366787827b50b82b441512df744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67370 Tested-by:
-
- Jan 09, 2021
-
-
Andreas Fernandez authored
This patch removes some actions that don't make any sense with pid 0: - toggle visibility in menu via context menu - "View webpage" action in Record List Resolves: #93252 Releases: master, 10.4 Change-Id: I444270a49642240e9a38d3664b05923da16f36e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67367 Tested-by:
-
Georg Ringer authored
The login logo for the default logo is set to "TYPO3 logo". For custom logos an alt-attribute for the image tag can be configured. In v12 it will be required to configure the alt-text to ensure accessibility. Resolves: #92628 Releases: master Change-Id: Ib35b8fbdbff08e7c9a1e778fc62d8135214d1af0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66222 Tested-by:
-
- Jan 08, 2021
-
-
Oliver Bartsch authored
TYPO3 should blind sensitive configurations options, such as credentials or keys, by default, since the configuration module can usually be accessed by all admins. Integrators always have the possibility to adjust these settings using the modifyBlindedConfigurationOptions hook. Resolves: #93250 Releases: master, 10.4 Change-Id: I8eaefa7b166de54190cee2b4eac5e2dfc1513cc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67366 Tested-by:
-
Oliver Bartsch authored
Since bootstrap v5 the collapse JavaScript plugin is using `collapse.show` instead of `collapse.in` as the expanded state class. Since TYPO3 added custom styles based on the `.in` class, several modules did not longer work. This is now fixed by using the correct class. Additionally the workspace record collapse state identifier icon now reflects the current state again. Resolves: #93243 Releases: master Change-Id: I471402250520c9c3366d1885b664a8f5fd79e338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67362 Tested-by:
-
Oliver Bartsch authored
Since #93048 using relative paths in backend does not longer work in most cases. Therefore the MediaRenderers should always use absoulte paths when in backend context. Resolves: #93226 Releases: master Change-Id: Iad08c8a4b8e255c67b6bb6fe168ecc4915620d35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67357 Tested-by:
-
Christian Kuhn authored
Since #93121 workspace records have no soft-delete behavior anymore. This is now respected when live records are deleted: Workspace overlays of these records are now properly discarded. Change-Id: I9c0ea6871ec28c944e16eda26e360629429c8dd0 Resolves: #93248 Related: #93121 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67364 Tested-by:
-
Georg Ringer authored
Fix rendering issues in `Deprecation-92386-DeprecatedExtbasePropertyInjection`. Resolves: #93241 Related: #92386 Releases: master Change-Id: I2a11061d3c86c2a3cd96cdfafbe9ae3313b4995c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67360 Tested-by:
Martin Bless <martin.bless@mbless.de> Tested-by:
-
- Jan 07, 2021
-
-
Oliver Bartsch authored
The "route" GET parameter is deprecated since #93048. Therefore the route path has now to be fetched from the request object instead. This patch replaces all places in core where the route is still fetched via GET. It's currently often necessary to access $GLOBALS['TYPO3_REQUEST'] therefore, since the request object is not always present at those places. This will be tackeled in upcoming patches. Resolves: #93158 Releases: master Change-Id: I6e163919b19484171b6ebf8087fdc650cf977c9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67355 Tested-by:
-
Benjamin Franzke authored
When a controller finds some pre-requisites of the called action are not fulfilled, it can create an 'early' response and throw it as ImmediateResponseException. This exception bypasses the middleware stack, and is caught in the Application to emit the response. This is a big win in contrast to die/exit calls. Some middlewares however expect to be always called when the response bubbles up. Good examples are 'locking' middlewares: They set up a lock when called, dispatch to inner middlewares, and tear town the lock when a response is retrieved. The tear down code of those middlewares is bypassed when a controller throws an ImmediateResponseException. The patch introduces a second exception: PropagateResponseException. This one is caught by a new very inner middleware positioned at the end of the middleware stack, just before the request is dispatched to some controller. It then sends the response up the outer middlewares. This allows middlewares like a 'locking' middleware to do it's job without being bypassed, and at the same time allows a controller to bypass any further local processing by throwing such a response exception. ImmediateResponseException exists as before and can still be used to directly bypass the middleware stack and is kept as safety net in case a PropagateResponseException is thrown within a middleware. PropagateResponseException therefore extends ImmediateResponseException. It's however discouraged to throw ImmediateResponseException from within controllers - they require knowledge on what middlewares do in their 'tear down' part and there shouldn't be a reason to bypass them. Middleware/BackendUserAuthenticator is adapted to properly handle ImmediateResponseException that would have been thrown BackendUserAuthentication::backendCheckLogin(). BackendUserAuthentication is therefore refactored to allow to call the backend login initialization without (duplicate) login check. This allows to propagate redirect/maintenance responses. Releases: master Resolves: #93007 Change-Id: I291d9d532e7fa289b803e5eef38b23402e57e8ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67042 Tested-by:
-
Christian Kuhn authored
Fix a couple of issues with state change emails in workspaces: * We still can't deep link to the backend. The generated comparisonLink to the side-by-side preview module is a workspace backend functionality. The generated links don't work and show the login form. The fix is to generate "preview links" instead which call a frontend. We may be able to improve this later, when core v11 allows deep linking. * When changing the stage of a page delete placeholder - when a page is for deletion in live - preview link generation to these pages does not make sense, trying to generate such a link throws an exception "no connection to page tree", the ajax request fails and no mails are send. Fix is to catch the exception and leave out the link in the emails. * Preview links did not carry the language id when sending notifications for state changes of non default language records. This is added to properly link to non-default language previews. * A missing closing p-tag in the HTML mail. * As a better default, preview links are now always added to the mails if possible. In rare cases where this is not wanted, the mail templates should be adapted. Change-Id: I84f0e4e5131d52ecbc5e7424137ae7e2ebdb2031 Resolves: #91515 Resolves: #81708 Related: #90411 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67342 Tested-by:
-
