Fix functional tests.

Resolves: #57379
Change-Id: Iafbf4e2b7e68dd27b488f20141f34680f57bc9c4
Reviewed-on: https://review.typo3.org/30955
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #59738
Releases: 6.3
Change-Id: Idb08c3f7311ae97590495c77d180429baabefcda
Reviewed-on: https://review.typo3.org/30960
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer

Impexp files are blown up from the files that are included as base64.
This patch adds the possibility to have the files separated from the
 t3d/xml export file. They are saved to a folder beside the export file.

Resolves: #57379
Releases: 6.3, 6.2
Change-Id: Ib8bdc4336c64d2eae0e993132a5fce84eb01f766
Reviewed-on: https://review.typo3.org/30453
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The documentation for conditions of type "language" states: "The values
must be a straight match with the value of getenv('HTTP_ACCEPT_LANGUAGE')
from PHP." (or you can use wildcards). Exact matches are actually
not working - and the unit test showing the problem was skipped.

Patch adds the feature as documented and adjusts the unit test.

Change-Id: I5691fff41c889476d8149d6f92c26731ad7bb1fd
Resolves: #59707
Releases: 6.3
Reviewed-on: https://review.typo3.org/30920
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

FAL includes some tests that are skipped ever since
FAL was merged. Most of them don't even have a
comment as to why and need to be completely rewritten
as the functionality changed.

We should remove these tests for now.

Change-Id: Ib75b4ea104a968019e06937974eaa1846cfe3a8a
Releases: 6.3
Resolves: #59728
Reviewed-on: https://review.typo3.org/30940
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This patch prevents nested flexforms from throwing
an exception on saving or opening the record.

Resolves: #59368
Releases: 6.2

Change-Id: Iadeeecc3aef92b8bcc4f7fe4e22882d924f10a50
Reviewed-on: https://review.typo3.org/30590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

Raise recommended max nesting level to 400 as 
the current value of 250 does not suffice.

Resolves: #59391
Releases: 6.3, 6.2
Change-Id: Ibccb61991809e24baddb21bd46f190cd0b8d907d
Reviewed-on: https://review.typo3.org/30608
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The tests for the ExtensionCompatibilityTester are currently skipped.
This patch removes the broken tests and leaves the working ones.

Releases: 6.3
Resolves: #59700

Change-Id: I10a49d0dddf2807bd50944837e31f0105374c8c9
Reviewed-on: https://review.typo3.org/30915
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If a redirect for login error is setup, the warning cookie
message is displayed instead of redirecting.

Resolves: #59493
Releases: 6.3, 6.2
Change-Id: I2f63b6630863ece0704198f247980c4d6c08f65a
Reviewed-on: https://review.typo3.org/30723
Reviewed-by: Oliver Hader
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Adds more entropy to the uniqid() call. So each call inside
foreach loop will generate unique value.
As uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.

On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.

Resolves: #59529
Relates: #58602
Releases: 6.3, 6,2
Change-Id: I7476f85961e906905acaca7fd816e37375c9817c
Reviewed-on: https://review.typo3.org/30696
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Increases the width of string input fields to 300 pixels.

Resolves: #59679
Releases: 6.2, 6.3
Change-Id: Ia415a6cdf81e4f6192a7e3fb93d8f01d8a749c6a
Reviewed-on: https://review.typo3.org/30904
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Changed serialize behaviour in PHP triggers funny phpunit issues in
some tests. Switching to phpunit master for now and skipping some
tests makes travis-ci green again and gives us time for detail fixes.

Change-Id: I1c694c0c5dba98b31b9ef7c826fa6614ffa512df
Resolves: #59685
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30889
Reviewed-by: Christian Mueller
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

A field name parameter is not being passed from within
DataHandler when copying a record which has a FlexForm
DF associated with it. This causes dynamic FlexForm DS
definitions to not be able to depend on the field name,
in turn causing the problem that an incorrect DS may be
returned from the DS utility which makes TYPO3 process
the data value incorrectly (for example, not detecting
file fields and processing the values accordingly).

To solve this the $field parameter is passed.

Resolves: #59423
Releases: 6.3, 6.2, 6.1
Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7
Reviewed-on: https://review.typo3.org/30633
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This patch adds cleanup to prevent warnings when accessing the
import/export module.

Resolves: #58534
Releases: 6.3, 6.2
Change-Id: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b
Reviewed-on: https://review.typo3.org/29881
Reviewed-by: Susanne Moog
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein

If you are building an extension, that outputs
data depending on a selected domain, it is easier
to compare the uid of sys_domain records
than the domainName itself.

Resolves: #57297
Releases: 6.3
Change-Id: Ic1efd3efe043f28ef7737f407d9a200b168d9685
Reviewed-on: https://review.typo3.org/28794
Reviewed-by: Markus Schubath
Tested-by: Markus Schubath
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Andrea Schmuttermair
Reviewed-by: Markus Klein
Tested-by: Markus Klein

EM "Get Extension" does not show the awesome extension culture
that lives in the TER. Change sorting basically with the primary goal
to order extensions by update.

Resolves: #59583
Releases: 6.3, 6.2
Change-Id: Ie8aebc13c41427e0603fa5313b794996d01fbc44
Reviewed-on: https://review.typo3.org/30735
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Robert van Kammen
Tested-by: Robert van Kammen
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Extension install and uninstall is an admin task. Calling the belonging
CommandController on cli should ensure, that the user has admin
rights.

This adds API to the CommandController to avoid code duplication
in every controller to achieve this.

Distribution packages could be installed via cli without errors now.

Resolves: #59556
Releases: 6.3, 6.2
Change-Id: Icd1b6bf4379322c8bec07531a15d2171b103e076
Reviewed-on: https://review.typo3.org/30715
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny

Links in RTE might be stored as <LINK or <link.
Currently the upgrade wizards lacks support for <LINK.
Add this to the regular expression.

Resolves: #51800
Releases: 6.3, 6.2
Change-Id: Ic22983db1144fb1317d6102907c792871e1eeaed
Reviewed-on: https://review.typo3.org/30820
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

This patch fixes a wrong check that prevents the clickmenu
from showing for folders in the filelist.

Resolves: #59568
Releases: 6.3, 6.2
Change-Id: Ic1e8bb28f64717631c4b57bc44221bd1132b876e
Reviewed-on: https://review.typo3.org/30759
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Remove the lines as they have not been valid, nobody will miss them.

Resolves: #57716
Releases: 6.3, 6.2
Change-Id: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36
Reviewed-on: https://review.typo3.org/30329
Reviewed-by: Markus Klein
Tested-by: Markus Klein

This patch fixed the alignment of the clear input icon in the
date input fields and the trigger icon outside the datepicker input
fields.

Resolves: #59615
Releases: 6.3, 6.2
Change-Id: I0943ea0a8c4157d46fc07ca055ac8c1ab67c9a5b
Reviewed-on: https://review.typo3.org/30758
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Releases: 6.3
Change-Id: Ie6aef74f866ac9b93e752a777ce6313126d8a32f
Reviewed-on: https://review.typo3.org/30786
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Resolves: #59624
Releases: 6.2
Change-Id: I84ff3685a94625cbc94af1967ac65b61cf9f5e43
Reviewed-on: https://review.typo3.org/30777
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If moving an element to a different page, the page tree only
visualizes the change in the source page, but does not visualize
the target page.

The reason is that the move-pointer is used (t3ver_state=4)
instead of the move-placeholder (t3ver_state=3) in that case.

Resolves: #59114
Releases: 6.2
Change-Id: Iefa01e4c85e9fb753873d03e7638ac592c09a657
Reviewed-on: https://review.typo3.org/30473
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The workspace module defines several states:
edited, moved, created, hidden, unhidden, deleted

The states "hidden" and "unhidden" are currently applied
after the action states. This change only uses the hidden
states if a record has been modified.

Resolves: #59118
Releases: 6.2
Change-Id: I95981306d61df38939a47579cb320dd93d51ce5b
Reviewed-on: https://review.typo3.org/30467
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

If e.g. a content element gets moved to a different page, the
workspace preview link opens the source page (which does not
contain the element anymore, because it was moved).

Since the elements are shown on the correct page in the
workspace backend module, using the target page in the preview
link for the frontend is just obvious.

Resolves: #59143
Releases: 6.2
Change-Id: Ib84e65766e825cc26a66cbda9ffa8132c3a3ec18
Reviewed-on: https://review.typo3.org/30474
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

This reverts commit 76741dff
(https://review.typo3.org/29626)

This change is not needed any more as the fix done
for #58713 also fixes the issues targeted with this fix.

This should be reverted not only because it is not needed
any more but especially because it "abuses" the property
->newSessionID which should only be set when really
a new ID has been generated and not to force the cookie
to be set again.

Releases: 6.2
Resolves: #59614
Reverts: #57751
Related: #58713
Change-Id: I5324769b0795bcc1b1f1e385c73fd085d7b3f571
Reviewed-on: https://review.typo3.org/30753
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Field labels are not shown if opening the history of an
element in the workspace module.

Resolves: #59546
Releases: 6.2
Change-Id: I3f522957dad8e36046b508dde658496f1cec6008
Reviewed-on: https://review.typo3.org/30713
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Issue #31951 introduced a breaking change in changing the order
of constructor arguments in the form PostProcessor. This could
have been avoided since new TypoScriptFactory object is and was
a singleton.

Resolves: #59549
Releases: 6.2
Change-Id: I1134d4440437e9fe03129241e63c0f0004712176
Reviewed-on: https://review.typo3.org/30714
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

With this patch it is possible to configure custom layouts
for the form, confirmation, and each type of post processor.
The backward compatibility is given, because this does not override
or break already existing configurations but provides some more
options to configure specific steps of the form process independent
of each other.
Therefore it prevents from breaking the layout of the confirmation view
and the HTML mail.

Resolves: #31951
Releases: 6.2
Change-Id: I3c015b53cd6d6efbd070d16bdc2111c7d60671aa
Reviewed-on: https://review.typo3.org/28526
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov

In the scope of enabling Extbase frontend rendering during
functional test runs, the response object contains multiple
data values for TypoScript ("default") and the called Extbase
actions. Processing them all at once just has practical reasons
to avoid additional frontend requests for each aspect.
To decouple the actual testing structure from assertions
and constraints, a new Contraint namespace has been introduced.

The irre_tutorial extension has been enriched with an accordant
frontend rendering for Extbase context to return structured JSON
data like in the current frontend tests.

This change contains Extbase TypoScript which will be activated
in a separate bugfixing change.

Resolves: #59521
Releases: 6.2
Change-Id: I42c0bf8957d9c4c1e4389049695512851b436d14
Reviewed-on: https://review.typo3.org/30687
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

The functional frontend tests are extended with basic FAL
use-cases in the live workspaces, as well as for modifying,
publishing single records and publishing all records in a
particular workspaces scenario.

The frontend is tested by using the TypoScript FILES cObject.

Resolves: #59276
Releases: 6.2
Change-Id: I3a1e59f70015b1168e4f29458c8d6ff77c0b3dcf
Reviewed-on: https://review.typo3.org/30516
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

During workspace move operations sometimes a warning like
this can be found:

  102: These fields are not properly updated in database:
  (t3ver_label) Probably value mismatch with fieldtype.

The reason is, that the t3ver_label field in almost every
record is limited to 30 characters in the SQL definition.
Besides that the error code "102" of the mentioned warning
is invalid and should just be "1" to be recognized by the
accordant functional tests as well.

Resolves: #59110
Releases: 6.2
Change-Id: Ia97a32dbefd1d27e33f186c19c5a6a495dcc194a
Reviewed-on: https://review.typo3.org/30466
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Marcin Sągol
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Having a parent-child structure spanning three levels, only the
first and second level elements are moved to a different page.
All child elements below the second level are not changed.

The reason is, that the move-placeholder is only created for
the first level of children.

Resolves: #59111
Releases: 6.2
Change-Id: Ia044a1241b8b1e4885cabbbc44b777f847b4c9e5
Reviewed-on: https://review.typo3.org/30463
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Clicking the "all workspaces" tab in the workspace backend
module as regular editor does not have any action and actually
misses the accordant action parameter "fullIndex".

Resolves: #59016
Releases: 6.2
Change-Id: I29d47cb82f1bbe1ea51f2a144f24964ab7328f7f
Reviewed-on: https://review.typo3.org/30267
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Testing the frontend behavior in functional tests creates
currently an own PHP sub-request to execute TypoScript in
frontent context.
Several hooks collect called cObjects and try to find the
correct nesting levels. Albeit this is working for the
current tests, it is way too complex for extending the
tests for further scenarios like for FAL and Extbase.

The hook magic is resolved and explicit render functions,
called via TypoScript, collect the data an output aggregated
JSON data in the end. Besides that the PHP sub-request
execution now re-uses the PHPUnit utilities to determine
and run the accordant executables.

Resolves: #59487
Releases: 6.2
Change-Id: Ic9eeadee5471a3e0e40d2dffb69b38dec16a0aa1
Reviewed-on: https://review.typo3.org/30515
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Preview links should not be shown in the backend, if pages are
deleted in a workspace. Currently both page tree context menu
and workspaces module offer a preview for deleted pages which
results in a "broken rootline" error once being clicked.

Resolves: #59142
Releases: 6.2
Change-Id: Id398ace2deb7dc6f000c7960d23f940b694d6229
Reviewed-on: https://review.typo3.org/30471
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

The DragUploader implementation prevents most of its JavaScript
API to be interacted with from outside the module. Especially
there is no public event allowing interaction based on ajax
responses such as "uploadComplete" or "uploadError".

This patch adds a couple of events being triggered on the $trigger
property of the DragUploader module. That's meant to be the "add"
button in DragUploader context, so it's a mandatory DOM node.

The introduced events are:
* uploadStart
* uploadError
* updateProgress
* uploadComplete

Change-Id: I983d5528247f88d319c2385e3fb032cbd701fa33
Resolves: #57454
Releases: 6.2
Reviewed-on: https://review.typo3.org/28976
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Frans Saris
Reviewed-by: Frans Saris
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Set RteHtmlParser in dontHSC_rte modus to fix garbled output.

Resolves: #25188
Releases: 6.2, 6.1
Change-Id: Ib01c3f6dcf1729b1979003c207aa622cc5c9b5c3
Reviewed-on: https://review.typo3.org/30642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Classes implementing the hook cObjTypeAndClass are instantiated each
time a contentObjectRender is created, even if they are not needed.

This patch introduces lazy loading.

Change-Id: Ifdae8c35fccc8d5070e8b7b30b5e275d9b26561d
Resolves: #59449
Releases: 6.2
Reviewed-on: https://review.typo3.org/30644
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Reviewed-by: Fabien Udriot
Reviewed-by: Christian Zenker
Tested-by: Christian Zenker
Tested-by: Steffen Ritter