- Feb 03, 2024
-
-
Stefan Bürk authored
The `Symfony\Component\Translation\Dumper\XliffFileDumper` is extended to add processing workflowes needed to update the xliff files based on the ISO Database with `Build/Scripts/updateIsoDatabase.php`. Symfony 7 added method types and return types, and therefore the extended method `dump()` needs a compatible return type. The corresponding `:void` return type is added now. Resolves: #103026 Releases: main, 12.4 Change-Id: Id39dbbab9cccffc0b0900267bdc411187623f6fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82772 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Jochen Roth authored
Currently, having a inlineLanguageLabelFiles defined without passing any additional config leads to an undefined key warning. This has been fixed by adding a fallback to an empty array. Resolves: #103020 Releases: main Change-Id: I4234a8efe5d33ee53afebbfe8d4fc36859b032ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82762 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Feb 02, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.12.0 \ @codemirror/lang-html@^6.4.8 \ @codemirror/language@^6.10.1 \ @codemirror/lint@^6.5.0 \ @codemirror/view@^6.23.1 \ @lezer/common@^1.2.1 \ @lezer/lr@^1.4.0 npm run build Resolves: #103023 Releases: main, 12.4 Change-Id: I4b21ebc335f3bc3483a957e0c6c48d62e0e4f622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82765 Reviewed-by:Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Albrecht Köhnlein authored
The methods `logicalAnd()` and `logicalOr()` allow any number of constraints as parameters. The outdated PHPdoc comment still said "two". Resolves: #103007 Releases: main, 12.4 Change-Id: I582eb3f1c17fb3149a49a15649469794ce386149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82753 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Stefan Bürk authored
The `Build/Scripts/runTests.sh` supports `podman` and `docker` as container cli binary since quite a while now, albeit docker has been kept as default if not specified using `-b`. This change removes the hard default and will now use `podman` as default. In case `podman` is not available `docker` is used. As a side-effect, the binary for CI is no longer enforced the hard way. PostgreSQL 16 is added as database version. Resolves: #103018 Releases: main, 12.4, 11.5 Change-Id: Iedcd7cbcd2380adb6781bd8b4f075da86e25c03b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82761 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 01, 2024
-
-
Oliver Bartsch authored
There is no valid reason to force a minimum amount of 5 records to be displayed in the list view. Therefore, the range is reset to 0 - 10000, as it was before #92103. Resolves: #103011 Related: #92103 Releases: main, 12.4 Change-Id: Icd22e6a77dc554774dcde6a6a3dc3c2a799d2d7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82759 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Weiske <typo3-2022@cweiske.de> Tested-by:
-
Albrecht Köhnlein authored
In case modules do not provide a "shortDescription" the module card is now rendered without title in the "About" module Resolves: #103005 Releases: main, 12.4 Change-Id: Ic383df283eb7c3e3e175862f808ea731531ccfff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82752 Tested-by:
-
- Jan 31, 2024
-
-
Peter Kraume authored
Resolves: #102999 Related: #98545 Releases: main Change-Id: I0d8b4f6d05cf77dee49265912029b8257e7b92e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82727 Reviewed-by:
-
Stefan Bürk authored
The first argument after processing defined options has been stored into the variable `TEST_FILE`. This value was passed to PHPUnit based commands as last argument, defining the test case to execute (or a subset). Removing this workaround and directly passing remaining options to the command makes special arguments like `-e` obsolete and unblocks more generic command passing. This change removes this variable and passes all remaining arguments after option processing directly to the PHPUnit command and paves the way for future command improvements. Note: This makes the `-e` option basically obsolete, but is kept for now to minimize muscle memory issues. Using it will display a `deprecation` notice at the end of the script - so it gets recognized. Resolves: #102769 Releases: main, 12.4, 11.5 Change-Id: I9a85206330a7e1b58d81dc5a2c97a13831af29a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82360 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
This reverts commit dba95382. Reason for revert: * The close button has tabIndex -1 so no aria-label is needed. Note: aria-label would have been useful in combination with #102372, but that patch was reverted as well, because with think a clearing button is not needed for keyboard users that use keyboard shortcuts anyway. * The patch introduced new inline JavaScript which we want to avoid, also writing into TYPO3.lang directly via inline JavaScript is not ideal. Releases: main Resolves: #102998 Reverts: #102524 Related: #102372 Change-Id: I0f2fed9b56484697ddb97fee1a905c83fbc49107 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82736 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
-
Willi Wehmeier authored
Add a title and aria-label to the clear input button added on all input fields with the class t3js-clearable. Resolves: #102524 Releases: main, 12.4 Change-Id: I10b2829b259779ac72abb939ddcfd4ea2e899bc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81972 Reviewed-by:
Christian Rath-Ulrich <christian@rath-ulrich.de> Tested-by:
-
Oliver Bartsch authored
To prevent PHP from encoding the numeric keys of the available languages as string, which would lead to JavaScript errors, `array_values` is now applied to the filtered list of languages. This resets the keys and therefore ensures a continuous numeric sequence starting from 0. Reference: https://www.php.net/manual/en/function.json-encode.php#refsect1-function.json-encode-notes Resolves: #102911 Releases: main, 12.4 Change-Id: Ieca55dd815d1389f44823b252df8da75196d0fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82720 Reviewed-by:
-
Oliver Bartsch authored
The element browser string (bparams), forwarding different information between states is using the pipe ("|") character as separator. With #101231, this string got extended by also respecting a "disallowed" file extension list, next to the "allowed" list. Since this information is stored as one part, an additional separator ";" was introduced. However, this character now leads to problems, depending on the used environment (see linked references). To circumvent this, the separator is changed to the "~" character for now, as this is not a reserved character, according to RFC3986. In the long run, this string should anyways be replaced by a more robust solution. * https://github.com/traefik/traefik/issues/9164 * https://github.com/symfony/symfony/pull/51709 * https://datatracker.ietf.org/doc/html/rfc3986#section-2.2 Resolves: #102992 Related: #101231 Releases: main, 12.4 Change-Id: I05e3548305d7ff50bd6db94fd2236aba95e80edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82716 Tested-by:Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Sascha Nowak authored
When fetching a lot of records from database the memory is nearly doubled in the fetchAll function. It seems php keeps references or creates an array copy that could not be garbage collected. Enforcing a manuell gc_collect_cycles does not help either. Resolves: #102986 Releases: main, 12.4, 11.5 Change-Id: I2da5f1e0126aa1dc867c8fb3074be4a11491f8f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82700 Tested-by:
-
Chris Müller authored
The index file in its current state does not has any value to the user. Mostly numbers are displayed as reference. Resolves: #102996 Releases: main, 12.4 Change-Id: I6a4c52e5c295bb27f5fd85045f2c3f9451bea1e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82722 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Jan 30, 2024
-
-
Benjamin Franzke authored
Releases: main Resolves: #102994 Related: #102959 Change-Id: I9fbb13d333cf9a773d5cfa3742d693595f694aec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82717 Tested-by:
-
Oliver Bartsch authored
There might be no comma in front of an extension scanner tag. This should not lead to an error as it's unrelated for this check and will already be catched by the "validateLastLine" check. Resolves: #102987 Releases: main, 12.4, 11.5 Change-Id: Icda7cbb1b01ced39ee80311e15bccdfd9318b953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82701 Tested-by:
-
linawolf authored
Merge right after the 13.0 release. Resolves: #102988 Releases: main Change-Id: Icbd2ffae07b15901ec8a0e3678805995bd4305c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82702 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Chris Müller <typo3@krue.ml>
-
Benni Mack authored
Change-Id: I6ac434754d0963e4d1d4cdf7f7536cc9d717c0ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82714 Reviewed-by:
-
Benni Mack authored
Change-Id: I4da133935b36f216ba4a621cda058b2c0da588ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82713 Tested-by:
-
Nikita Hovratov authored
A new event listener for the ModifyContentElementWizardItem Event is added to check for `list_type` items. If no list types are defined, the related wizard item `plugins_list` is removed from the wizard as it has no functionality alone. Resolves: #102989 Related: #102985 Releases: main Change-Id: I178c4cb779dadab29dba833beb6ff23a7ab90d49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82703 Reviewed-by:
-
Oliver Bartsch authored
This patch prevents empty categories in the wizard and prevents an undefined array key warning. Resolves: #102990 Releases: main, 12.4 Change-Id: Iec69d1d3e3df66d9a054dfe382afe3d282fec332 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Jan 29, 2024
-
-
Benni Mack authored
This change moves indexed search to the proper CType level in order to avoid using 'list' for plugins as well, similar to felogin. An upgrade wizard is in place, migrating existing records as well as corresponding backend user group permissions. Resolves: #102985 Releases: main Change-Id: I7061f26a1c4efaf9dcc57e0dfc91c64d360953f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82665 Tested-by:
-
Chris Müller authored
Resolves: #102905 Releases: main Change-Id: I0cfd33a4c938bdc9c5fc4bb08f541736e97ecf42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82604 Tested-by:
-
Andreas Kienast authored
This commit replaces the `reasons` property in Indexed Search's `Indexer` class with a more descriptive `IndexStatus` enum. Resolves: #102955 Releases: main Change-Id: I56bbdce8f525f539142b0891e4e10e51f8d78e6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82670 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Nikita Hovratov authored
There are two identical labels for the FormEngine general tab. This is the default tab, if no first tab is defined explicitly. Use the more specific version in Form/locallang_tabs.xlf and drop the other label bundled randomly into locallang_core.xlf. Resolves: #102983 Releases: main Change-Id: Id55f20b4a93349815a48c3feb7c445acb3588f1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82697 Reviewed-by:
-
Benni Mack authored
With #100759, f:translate has been changed to use the extbase LocalizationUtility in all scopes. This triggers the ConfigurationManager, which fetches TypoScript setup from the Request attribute. But TS setup is never set in fully cached page content scenarios and there is usually no Fluid view triggered in this scope. The admin panel however renders in "fully cached" as well, which then fails when trying to fetch TS setup. We *do* want extbase to fail in this scenario, since TS is important for extbase configuration and it needs to rely on TS setup being set in Frontend. The patch thus works around the issue in admin panel directly. The situation should resolve later again, when work on LocalizationUtility finished. Resolves: #102638 Related: #100759 Releases: main, 12.4 Change-Id: I5cf8af6593f37299e71b8555b79bf05c0e5e9c09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82396 Reviewed-by:
-
Simon Praetorius authored
Fluid 2.10.0 introduced a regression concerning the handling of local and global variables, which was fixed with 2.10.1. Executed command: composer req typo3fluid/fluid:^2.10.1 Resolves: #102984 Releases: main Change-Id: Ica56338d520b3a10d12bb94e2fb8e4d41ee5cef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82698 Reviewed-by:
-
Christian Kuhn authored
typo3/testing-framework no longer loads EXT:install in functional tests by default. The patch adapts a couple of tests to cope with this. Note core will continue to refactor in this area after 13.0: It for instance needs to be sorted out if the upgrade wizard infrastructure should be moved to EXT:core. For this reason, no full communication happened in this area, yet. > composer u typo3/testing-framework Resolves: #102982 Releses: main Change-Id: Id786a2f16d336b6e9d80519e7f944d560f61d8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82695 Tested-by:
-
Oliver Bartsch authored
In case no replacement has been done, e.g. due to an already modified version, don't update the server configuration file, since this might lead to an endless loop. Resolves: #102977 Releases: main Change-Id: If5cc0d33450c5b14b9f2e9ab1aec958ec02420ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82693 Reviewed-by:
-
Oliver Klee authored
Resolves: #102954 Releases: main Change-Id: I5d96243c83544195b21d3a45cd504d9755eb6951 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82669 Tested-by:
-
Oliver Klee authored
Resolves: #102966 Releases: main Change-Id: I6b7dce63373e805a7fdbc0792e834a424236c864 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82684 Tested-by:
-
Stefan Bürk authored
For `ext:indexed_search` not only a cumbersome md5 to int conversion has been used. The original md5 length has been reduced by simply cutting off values from the end, combined with a `hexdec` conversion, leading to a highly increased conflict probability (duplicate keys) for several places. To mitigate this, the raw md5 hash should be used instead of the reduced integer representation. This change modifies the database and the user land code to use the full `md5()` hash without castrating them any longer. The following table fields are therefore changed from `int` to `varchar`: * index_phash: phash, phash_grouping, contentHash * index_fulltext: phash * index_rel: phash, wid * index_words: wid * index_section: phash, phash_t3 * index_grlist: phash, phash_x, hash_gr_list * index_debug: phash Note: The required table truncation is handled within the database analyzer schema changes and not as an upgrade wizard. Recently added native php types are now changed to string to cope with this change again. Also removed the now unused internal `IndexedSearchUtility::md5inthash()` method. Using `QueryBuilder::quoteArrayBasedValueListToStringList()` instead of named placeholders for `IN()` conditions to reduce the risk for exceeded placeholder limit. QuerySize limitation may still occur, but can be increased by the responsible server administrator. Resolves: #102975 Resolves: #84541 Resolves: #90977 Resolves: #79802 Resolves: #87138 Releases: main Change-Id: I8e1dcffccb351dc03b58f0d5bc5d4c8419bc307a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74688 Tested-by:
-
Garvin Hicking authored
Example for TCA and flex form XML usage scenarios added to the RST changelog. Resolves: #102981 Related: #102970 Releases: main Change-Id: Ic6d84e767f880924a6bf4dc239cb8154a578e674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82696 Reviewed-by:
-
Christian Kuhn authored
The PaginationInterface contains the basic set of methods a pagination provides. The interface has been introduced with #89603, later, #93340 added getAllPageNumbers() to SimplePagination, and issue #94625 picked that up in SlidingWindowPagination. The patch adds the method to the interface to be generally available. Resolves: #102980 Related: #89603 Related: #93340 Related: #94625 Releases: main Change-Id: I895ba9f1c70be1c354f75b4a6dc564410fde375a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82694 Tested-by:
-
Stefan Bürk authored
It's a generic goal to provide database scheme defaults for TCA defined tables with the on-going #101553 quest. For `ext:redirects` the `target_statuscode` field has not been removed due to the database default value. Meanwhile it is ensured with #102938 that not only the DataHandler but also the auto-create using QueryBuilder respects TCA and database defaults - albeit overriden with a manual default and based on the SiteConfiguration. Therefore, this entry is now removed along with the todo comment from the `ext_tables.sql`. Core uses proper API's which ensures keeping the same default - whereas extension not using proper api could be trapped with the removed database default. Note: Removing the `source_*` fields and `hitcount` is not possible right now due to the simple fact that `type=input` not having default schema creation yet. Resolves: #102944 Related: #102938 Related: #101553 Releases: main Change-Id: I841baf50cf6eb8ed170af9496e283641e4be917f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82661 Tested-by:
-
Benni Mack authored
The TimeTracker exists for a very long time and did not receive much love over the years. It comes with fishy internal structures and needs a bigger overhaul. While various parts throughout the core and extensions actively use the "write" API - push(), pull() and setTSlogMessage() - the "init" API is only used by middlewares and the "read" and "print" API only by EXT:adminpanel. The patch moves the "print" related methods to the admin panel extension as is, and declares everything except the "write" methods `@internal`. This allows future refactoring of the now internal data structures and API. Resolves: #102976 Releases: main Change-Id: Ida37154a71dd4b04cb5bcea79208824f4e6f4293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82677 Reviewed-by:
-
Oliver Klee authored
Also fix the PHPDoc annotations and generics along the way to avoid introducing (valid) PHPStan warnings. Resolves: #102956 Releases: main Change-Id: I8444978d984993ff5a3fb6b29e487ed3b67f4e9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82671 Reviewed-by:
-
Oliver Klee authored
Resolves: #102878 Releases: main Change-Id: I2f197b9417c0acc6a05f6e72543429382ff580c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82524 Tested-by:
-
Stefan Bürk authored
This change gathers the default values for a redirect from the definied TCA and uses the database schema as fallback and use it for the auto-created redirects as default before applying the SiteConfiguration setting, manual defaults and dispatching the redirect event `ModifyAutoCreateRedirectRecordBeforePersistingEvent`. Reduces the need to implement a event listener when the `sys_redirect` table is extended with not nullable columns to ensure proper default value handling unknown to the redirects slugservice. Further superflous properties are removed in the SlugService and remaining properties get native types donated. Resolves: #102938 Releases: main Change-Id: I8cb406e3f571b9fdfe6f13bd356ea8d2e1668b2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82656 Tested-by:
-
