- May 03, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/element/table-wizard-element` is tightly coupled to FormEngine's `TextTableElement`, therefore said module is moved to the FormEngine namespace. Additionally, the element gets renamed to `typo3-formengine-table-wizard`. Resolves: #103725 Releases: main, 12.4 Change-Id: I1c020a4ec6045007ab4c1f42289fe0a9c842f794 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84117 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Oliver Hader authored
Commands: composer req 'enshrined/svg-sanitize:^0.18.0' composer req 'enshrined/svg-sanitize:^0.18.0' \ -d typo3/sysext/core --no-update Resolves: #103722 Releases: main, 12.4, 11.5 Change-Id: I9a20a46b27b3abbfd18f7ca6027e4def9ce5b59b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84137 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Torben Hansen authored
With this change, the following changes have been applied to the toolbar of the CKEditor "full" configuration preset: * Remove superfluous `clipboard` toolbar item, since CKEditor 5 does not provide a UI for the clipboard plugin. * Rename wrong `find` toolbar item to `findAndReplace`. * Added `TableProperties` and `TableCellProperties` toolbar items. * Move the `findAndReplace` toolbar item before the `link` toolbar item, because we also have this order in the `default` preset. * Move the `selectAll` toolbar item to a dedicated group Resolves: #103745 Releases: main, 12.4 Change-Id: I021b8c2f990c8e302bf169c3e368bf04928dd200 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84139 Tested-by:
-
Georg Ringer authored
Allow the valid return type false which is returned by the function exec on failure. Resolves: #103778 Releases: main, 12.4 Change-Id: I8f0391efb6f890ebc0095ddb8a1f93ee9c36e18c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84116 Tested-by:
-
Andreas Nedbal authored
Newer rollup major versions feature optimizations in build output. The rollup source files are now natively parsed as ESM modules by NodeJS. Earlier rollup versions implicitly transpiled ESM to CJS and allowed a mixture of ESM and CJS imports (both `import` statements and `require()` calls) in one module. With the switch to ESM-only modules we now make use of `createRequire` utility method when node-require resolution is needed for CJS path lookups. Since our main project (Build/) is still in CJS mode by default (for grunt), we apply a sub-project module type overwrite for the Build/rollup/ folder via Build/rollup/package.json to ensure rollup configuration runs in native ESM mode. See https://nodejs.org/docs/latest-v18.x/api/packages.html > Node.js will treat the following as ES modules when passed to node as > the initial input, or when referenced by import statements or import() > expressions: > […] > * Files with a .js extension when the nearest parent package.json file > contains a top-level "type" field with a value of "module". Executed commands: npm install --save-dev \ rollup@^4.17.2 \ @rollup/plugin-commonjs@^25.0.7 \ @rollup/plugin-node-resolve@^15.2.3 \ @rollup/plugin-replace@^5.0.5 npm run build -- exec:rollup Resolves: #103775 Releases: main, 12.4 Change-Id: I6793bd9233b2907ce5ed06d68c7008b349237360 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84136 Tested-by:
-
Benjamin Franzke authored
The node version used for building TYPO3 assets is raised to 22.0. See https://nodejs.org/en/blog/announcements/v22-release-announce for further details. Resolves: #103780 Releases: main, 12.4 Change-Id: Ibc5b8c88ca5baedb7ae500adb5ef26a33617df4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84115 Tested-by:
-
- May 02, 2024
-
-
Stephan Bauer authored
An error was previously shown and is now removed if no backend type is selected. Releases: main, 12.4, 11.5 Resolves: #103766 Change-Id: Ia83552de40abffb880244e8b0eb0f4c28f0e6637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84112 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Frank Naegler authored
This patch addresses two key accessibility issues in the recycler module: it adds a caption element to the table for better context and provides labels for dropdown icons used in multi-selection, ensuring screen reader compatibility. Resolves: #103764 Releases: main, 12.4 Change-Id: Ia8b839cbc438396c8438969087d225c37a479bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84107 Tested-by:
-
Willi Wehmeier authored
The clear-input button now has a proper title and additionally an aria-label to guide visually impaired users. The button isn't read out by screenreaders when navigating the site linearly (due to tabindex="-1") but when hold-pressing the button with the mouse pointer, a screenreader will search for a human readable label. We therefore add an aria-label attribute. The title attribute is added for sighted users but will be ignored by screenreaders since it's value equals the value of the aria-label attribute. Resolves: #103417 Releases: main, 12.4 Change-Id: I4cbbe5200476a7d84ef1d675911ddd51f5899e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84106 Tested-by:
-
- May 01, 2024
-
-
Oliver Hader authored
The new factory method `HashValue::hash('test')` creates the hash from the raw payload `'test'`. This is a simpler shortcut for using `HashValue::create(hash('sha256', 'test', true))`. Resolves: #103772 Releases: main, 12.4 Change-Id: Id201e166eeabc856b8d8dc498cc73cde8d5eb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84114 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 30, 2024
-
-
Frank Naegler authored
This patch adjusts the flash message and notifications elements by removing the h4 tag to prevent incorrect header flow throughout the content structure, allowing for better flexibility based on different use cases. Resolves: #103762 Releases: main, 12.4 Change-Id: Ide330150145d5c4965410fbf61973ef682bb96b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84093 Tested-by:
-
Frank Naegler authored
This patch adjusts the infobox/callout element by removing the h4 tag to prevent incorrect ordering in the content structure, allowing for better flexibility based on different use cases. Resolves: #103761 Releases: main, 12.4 Change-Id: I2556ea0df0e55ffcdf752c9c0574b843ffea44ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84094 Tested-by:
-
Frank Naegler authored
This patch enhances the accessibility of the link validator module by ensuring proper relationships between table headers and content cells. Resolves: #103763 Releases: main, 12.4 Change-Id: Icef43369761f88705b491f3661252cc9a4b7ac0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84092 Reviewed-by:
-
- Apr 29, 2024
-
-
Jasmina Ließmann authored
The title of the linked page was missing a hover style, which is now ensured with this patch. An appropriate link title is also added. Resolves: #103715 Releases: main, 12.4 Change-Id: I4ec60ef43fd7ced6cdc5ede88445931a37e12c3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84058 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Apr 28, 2024
-
-
Torben Hansen authored
When an editor uses the suggest wizard, undefined array key warnings can occur, when certain array keys have not been defined. This change adds fallbacks for undefined array keys using the null coalescing operator. Additionally, the function `currentBackendUserMayAccessTable` is now covered with unit tests. Resolves: #103721 Releases: main, 12.4 Change-Id: I2b1a8af0883f7d34dde38f6f838df080f34ea87c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84057 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Andreas Kienast authored
With the update of Bootstrap to v5.3, the implementation of progress bars has changed for accessibility reasons [1]. This commit updates all usages of progress bars to the new markup. [1] https://getbootstrap.com/docs/5.3/migration/#progress-bars Resolves: #103718 Releases: main, 12.4 Change-Id: I208e3561b4943e382caa09e23e75d350bd702a6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84075 Tested-by:
-
- Apr 27, 2024
-
-
Jasmina Ließmann authored
With #103737 a new locallang key for the configuration heading was introduced, but it contains a typo. The patch now fixes this. Resolves: #103743 Related: #103737 Releases: main, 12.4 Change-Id: I5bcf5d2b792e1312daf813ec5d3347068d5ecbf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84056 Tested-by:
-
Jasmina Ließmann authored
In the "Localization overview" view, an incorrect title was displayed when hovering over a page icon. This was caused by both an incorrect and duplicate title attribute. This patch fixes this behavior. Resolves: #103739 Related: #102472 Releases: main, 12.4 Change-Id: Ibb2ce64d0313c24c6d1e3f1e6b5fc6f55b172622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84055 Tested-by:
-
Jasmina Ließmann authored
If there are no records or the filter/search does not return a result, an information is now displayed in the "Log" backend module. Resolves: #103738 Releases: main, 12.4 Change-Id: I388e1e4db0885a143d3a626cd35199728b5c395b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84054 Tested-by:
-
Jasmina Ließmann authored
Resolves: #103736 Releases: main, 12.4 Change-Id: Ia93d67fc49fd9b7a123494928a4360515fc76cb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84053 Reviewed-by:
-
Jasmina Ließmann authored
Resolves: #103737 Releases: main, 12.4 Change-Id: I83278a84037a4fe46b85a8570b7ff345eabeb0a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84052 Tested-by:
-
- Apr 26, 2024
-
-
Benjamin Kott authored
Both extensions core and linkvalidator do not ship css files. PostCSS cannot find any files to process here. Resolves: #103731 Releases: main, 12.4 Change-Id: Ibdfcecb4dd813b04e89bab5d2fcfe3a55b0bf4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84035 Tested-by:
-
- Apr 25, 2024
-
-
Willi Wehmeier authored
The modal form to rename a file needs a proper label for the filename input field. Resolves: #103724 Releases: main, 12.4 Change-Id: I29018d288ced1de6001d38b841ef37a1231f7394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83982 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 24, 2024
-
-
David Hedden authored
Provide the current language fallback chain to new instance of LanguageAspect. So it can be used in PageRepository to let extbase records use the fallback chain. Resolves: #91781 Releases: main, 12.4 Change-Id: I291c73c05772533919a7bf6beaa767d156bc9d74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83981 Tested-by:
-
Andreas Kienast authored
The grunt module `grunt-newer` was introduced with #90200 to help improving build times on consecutive single builds by running tasks on changed files only. This is nowadays not required anymore in JS build context, as it's possible in TypeScript to compile changed files only, which is already incorporated for quite a while. Therefore, the usage of `newer` is now removed in this context. However, to avoid running `terser` multiple times on the same, previously compiled files, the directory `Build/JavaScript` now gets removed before each TypeScript compilation. The postcss calculation is fast enough to not require grunt-newer at all, therefore grunt-newer is dropped here as well. Executed commands: npm remove grunt-newer Resolves: #103712 Releases: main, 12.4 Change-Id: I1c6b88945a45cb9a394a2beaa2ec8198865880b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83980 Tested-by: -
Stefan Bürk authored
Wizards not marked as done, but not having updates, display a notice `No changes applied, marking wizard as done.` when using the CLI command `bin/typo3 upgrade:run <wizard-identifier>` and return an error exit code. This also happen when not specifying a single wizard, but running all available ones. The GUI based upgrade execution behaves different, as it does not return an exit code and does not display information about `no changes applied`, like its CLI counterpart. This change: * Adds new concrete exception classes for the `upgrade:run` command. * Modifies `UpgradeWizardCommand::getUpgradeWizard()` to throw now one of the new concrete exception or return a wizard instance to run. * Skips available upgrade wizards not eligible to be executed. Resolves: #103447 Releases: main, 12.4 Change-Id: Ib6eab07919bb2f6e11bac774ecfd333572c2205f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83979 Tested-by:
-
Stefan Bürk authored
TYPO3 provides the ability to configure different error handlers for specific (or all) error codes, as well as the error handler type to use (core handler or custom). The `\TYPO3\CMS\Core\Error\PageErrorHandler\PageContentErrorHandler` allows to specify a target using the link handler. The default config allows to define `LinkService::TYPE_PAGE` and `LinkService::TYPE_URL`. After implementing and stabilizing the TYPO3 sub-request feature, this particular error handler has been refactored to use an internal sub-request to resolve the error page content: An external URL not matching the same instance or having a page unavailable within the TYPO3 instance will not return any content. This change modifies the `PageContentErrorHandler` to send a Guzzle request for an external URL instead of using internal sub-requests, even if it would access the originating instance again. A limitation is that the requested URL **must** return a HTTP status-code 200. A custom request header is attached to this request. It is then checked to avoid recurring errors or loops in the page-resolving workflow. Resolves: #103399 Related: #98396 Related: #94402 Releases: main, 12.4 Change-Id: If09158abd2aa9246bcb7a4fa41a0ad6e4a0f942c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83978 Tested-by:
-
- Apr 23, 2024
-
-
Oliver Bartsch authored
To be consistent with the other listings in the backend is the root page title of a site in the site configuration module now linked, allowing to edit the corresponding site configuration. Additionally does the link as well as the edit button now use a dedicated label instead of a generic one. Resolves: #103695 Releases: main, 12.4 Change-Id: Ice46e82587cdc36daa6275f6eec2c46909e8a071 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83976 Tested-by:
-
Oliver Bartsch authored
Since the button to create a new site configuration is already descriptive the non-translated title attribute is removed. Resolves: #103696 Releases: main, 12.4 Change-Id: I28c8945f9b2b8fba29461dbd8033c52eacc1f035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83975 Reviewed-by:
-
Jasmina Ließmann authored
If no record was found in "Workspaces" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of with specific Bootstrap styling classes. Resolves: #103714 Releases: main, 12.4 Change-Id: I78637defba53cebdfc659b2414c59b4f4dbb7bbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83977 Reviewed-by:
-
Daniel Siepmann authored
The existing solution using `array_diff` did not work, as it only respects values, not a combination with keys. Given an existing record with some empty values would prevent unsetting another value with an empty. The same would apply for setting another value to an existing value. That's why we change to `array_diff_assoc`, which handles proper diff of value in combination with key. Resolves: #103708 Releases: main, 12.4 Change-Id: I36adbc8279e5160c33e8feffcd8741c30c667adc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84012 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Nedbal authored
In the current frontend tooling, we invoke Rollup twice: * via grunt-rollup to build library modules * via the command line to build everything related to CKEditor This commit gets rid of the first way and moves the library compilation to a JS-backed configuration as well, so we can get rid of a grunt package and also unify the tooling a bit. We also make use of @rollup/plugin-terser instead of the deprecated rollup-plugin-terser module that was used in ckeditor build before. To match the new behaviour, the "exec:ckeditor" task also was renamed to "exec:rollup". Executed commands: npm remove grunt-rollup npm remove rollup-plugin-terser npm install @rollup/plugin-terser --save-dev npm run build Resolves: #103686 Releases: main, 12.4 Change-Id: I8057dcceae2d039c637c6db68cf51b3ef1f12406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84005 Tested-by: -
Ayke Halder authored
There is a checkbox in page module to show hidden content elements. If this checkbox is not selected the hidden content elements must be hidden. Additionally hidden elements must not be accessible/focusable by keyboard. Resolves: #103626 Releases: main, 12.4 Change-Id: Id8f4b98938ae27e3bd3d3e7903c3f50588d554b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83974 Tested-by:
-
Oliver Hader authored
Given a static route argument mapper is used - for instance one that allows values in the range of 1 to 100 - then generating an URL from a route with an out of scope `&value=5000` was still generating an URL. However, HTTP request to that URL would result in an 404 error. This change skips routes using out of scope values during the URL generation process to avoid pointing to invalid resources. Resolves: #103400 Releases: main, 12.4, 11.5 Change-Id: I11e12f29e294ec86bec948d3a922d4a56b231771 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84002 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save chart.js@^4.4.2 npm run build Resolves: #103652 Releases: main, 12.4 Change-Id: Iddbfb5be5f998c7b9d693dac94fee88a1f242edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83996 Tested-by: -
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.7.0 \ @typescript-eslint/parser@^7.7.0 \ @typescript-eslint/typescript-estree@^7.7.0 \ eslint-plugin-wc@^2.1.0 \ sass@^1.75.0 \ sharp@^0.33.3 \ terser@^5.30.3 \ typescript@^5.4.5 npm run build Resolves: #103653 Releases: main, 12.4 Change-Id: I96bb9e96d12182adc33b5fafb52d53a4fecf6806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83997 Reviewed-by: -
Andreas Kienast authored
The "No results found" alert is rendered in a flex-row container, which caused a rendering bug where the alert box was stretched to a height of 100%, but its width is limited to its content. Use flex children modifiers to ensure correct positioning. Resolves: #103662 Releases: main, 12.4 Change-Id: I5b17950ca381fda841cd3a901d9f5e1a70e5562d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83972 Tested-by:
-
Oliver Bartsch authored
To allow the use of "empty" attributes, such as `download` in the CKeditor, the RTEHtmlParser does now keep such attributes while processing. Resolves: #103698 Releases: main, 12.4 Change-Id: I331066c0abaa604ba68c19f0013b5a077fe8f5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83973 Tested-by:
-
Nikita Hovratov authored
It is possible that TCA items array is not set in DataHandler if 1. items is defined through types/*/columnsOverrides 2. DataHandler is triggered with context of another record type (e.g. by a translation request) This patch ensures we are always dealing with an array for items. Also, when passing it as parameter to `ItemProcessingService->getProcessingItems`. Resolves: #103472 Releases: main, 12.4 Change-Id: I364841982b7c2913e339bf5a504d811b3e050049 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83899 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Apr 22, 2024
-
-
Sybille Peters authored
The TSconfig configuration option mod.linkvalidator.searchFields is documented in the documentation. Previously, it was only possible to check within fields, if at least one softref was configured. This was changed to include fields with the type "link" (see LinkAnalyzer class). This change updates the documentation to reflect that. Resolves: #103477 Related: #83835 Releases: main, 12.4 Change-Id: I83ceafca206b2b1821e622bc36867eb13a9a5984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83955 Tested-by:
-
