- Nov 29, 2019
-
-
Susanne Moog authored
Punctuation at the end of a link will no longer be automatically included in the link. It is valid as part of a link, but has been removed from links if it is the last char. Resolves: #89786 Releases: master, 9.5 Change-Id: I6dc239ddbee71eb2ef6dc26cd11ae444421a2a9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62478 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benjamin Franzke authored
Symfony 4.4 deprecated support for non-object services: https://github.com/symfony/dependency-injection/commit/6f11b359ab9 The usage of `array` as service is therefore no longer officially supported in Symfony 5.0. It still works, but in order to make sure that a possibly introduced type declaration in a 5.x release doesnt causes a type error, we migrate the middleware service from array to ArrayObject. Change-Id: Ie544014b4aa0217b84b0c9d2cc69efde352bef27 Releases: master Resolves: #89766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62429 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Benni Mack authored
Some "methods" used in ViewHelpers to mock a class (RenderingContext) which only uses a fixture to avoid constructor calls can be achieved by using phpunit's getMockBuilder() logic itself, making this class in the testing framework useless. TYPO3 Core should not depend on this, but rather use native phpunit logic. Some other things are moved to the specific classes where they are needed, so setUp() will be much faster for other ViewHelper test classes. Resolves: #89793 Releases: master Change-Id: Ia2b2d9e3d4a7bd9a6eabd254259ff24ff3565e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62451 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Mathias Brodala authored
This ensures that the target of translated "shortcut" pages is properly available. Normally this value is lost due to language overlay thus the original page record needs to be retrieved to restore the original shortcut target. Now it is possible to e.g. mark shortcut menu items as active on translated pages. Resolves: #67047 Related: #36822 Releases: master, 9.5 Change-Id: I2cabc252ba1936763d6cbe1fe0a093aa74f5a4e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/39630 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benjamin Franzke authored
Upgrade wizars may contain legacy code that requires services using makeInstance. As makeInstance needs to use the PSR-11 container for services that require dependency injection, we need to provide the global container intance during upgrade wizard execution. Also ensure that only *one* (singleton) PackageManager instance is used: ProviderConfigurationLoader used to create a second PackageManager instance. It passed a constructor argument which caused GU::makeInstance to bypass the symfony (PSR-11) container and to create a new instance (on its own). This new instance was then cached as singleton instance and all subsequent makeInstance calls returned this instance instead of the global instance. Therefore we now ensure that new singleton instances will not be cached if the singleton is known by the PSR-11 container. This inconsistency caused the Typo3DbExtractionUpdate to fail because some codepaths used one PackageManager instance (through DI) and some codepaths another instance (through makeInstance). Change-Id: I947310d1c2e46f7ded6399ad48d94efa9854f347 Releases: master Resolves: #89504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62425 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
This change allows to change to "Copy Mode" in the clipboard without having items on the clipboard. However, switching to a different clipboard will have this selection vanish again (before and after the change). Changing this behavior is considered out of scope for this patch. Resolves: #89726 Releases: master, 9.5 Change-Id: I83483c631915b390dfb0c9584c29f0f86a44d051 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62369 Tested-by:
-
- Nov 28, 2019
-
-
Susanne Moog authored
We can use vfs stream directly nowadays. Resolves: #89798 Releases: master Change-Id: Ie41eccb21dff70c6587bfd1380488697c4f6aca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62473 Tested-by:
-
Anja Leichsenring authored
There will be more tests with other PHP versions and DBMS versions in the future, a little cleanup round will ease the integration. Resolves: #89783 Releases: master, 9.5, 8.7 Change-Id: I84eb9a813087d8f94cf2800b30efd7dd0174171d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62435 Tested-by:
-
This adds an example on how to save uploaded files in ext:news' `sys_file_reference` columns. Releases: master, 9.5 Resolves: #89775 Change-Id: Id775a59ee7f39446f5b0046a486861566cfa28ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62431 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Andreas Fernandez authored
Resolves: #89791 Releases: master Change-Id: I9716c810035886dd3c1a5579b6b2e33ac38f585e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62445 Tested-by:
-
Jan Stockfisch authored
A new Extbase-based plugin is added to TYPO3's Extension "felogin" which can be used as a toggle with custom templates based on Fluid, instead of marker-based templates. A new feature toggle is added to the Settings module for Site Administrators to switch to the newly added felogin extbase plugin, or continuing using the pibase plugin, e.g. for upgrading purposes. Resolves: #84262 Releases: master Change-Id: I9d281912373a078e0403f52b27483dd3e04785f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61900 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Remaining parameters need to be deflated (prepared and normalized to strings and fitting into Symfony route length and literal constraints) during route generation. However, when resolving a route remaining query parameters have to be kept as is - explained in more detail in the following examples based on using enhancer with namespace set to 'app': * https://example.org/page/route-value/app__value=inject + previously assigned `app[value]=inject` -> dirty -> rejected + not inflated anymore, kept as `app_value` * https://example.org/page/route-value/app__other=inject + previously assigned `app[other]=inject` -> okay, wrong namespace + not inflated anymore, kept as `app__other` * https://example.org/page/route-value/[32+ characters]=inject + arbitrary characters lead to OutOfRangeException -> no valid hash + previously `md5('app__@any__value')` assigned `app[@any][value]` -> dirty -> rejected + not inflated anymore, kept as `md5('app__@any__value')` Basically the mentioned OutOfRangeException revealed that misbehavior, hacking `VariableProcessor::resolveHash` would not have solve issues with (incorrectly) merged query parameters - but would have hidden it. Resolves: #87688 Releases: master, 9.5 Change-Id: I3daf02d3b4ed540b9eb098a8b116f485cc79fa72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62385 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Frank Nägler <frank.naegler@typo3.org>
-
- Nov 27, 2019
-
-
Benjamin Franzke authored
The recently released symfony 4.4 introduced a deprecation for non-object services and so 5.0 dropped support. That means we run into exception with symfony 5.0 when we add synthetic non-object services. Symfony 5.0 contains a type declaration that allows for objects only: Argument 2 passed to Symfony\Component\DependencyInjection\Container::set() must be an object or null, bool given, called in […]/typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php on line 99 at Symfony\Component\DependencyInjection\Container->set( '_early.env.is_unix', true ) We provided four boolean services in v10.0 but never used or documented these in core, therefore we drop them now: - env.is_unix - env.is_windows - env.is_cli - env.is_compoer_mode These variales can actually be substitued by using dynamic environment parameters (those are supported thanks to our EnvVarProcessor): - "%env(TYPO3:isUnix)%" - "%env(TYPO3:isWindows)%" - "%env(TYPO3:isCli)%" - "%env(TYPO3:isComposerMode)%" One more, internally used, boolean service is now migrated into the internal boot.state service: - cache.disabled Releases: master Resolves: #89764 Change-Id: If40ef73fdce61a81732b9670876aec7c457648d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62427 Reviewed-by:Richard Haeser <richard@maxserv.com> Tested-by:
-
Alexander Schnitzler authored
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
To have a variable import chain per environment (dev, stage etc) for example, YAML files now may contain environment variables. Resolves: #89398 Releases: master Change-Id: I274c8e78f1a072ba490f4844d545b3015f658409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61955 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Nov 26, 2019
-
-
Markus Klein authored
Remove the double html encoding of the current link in the PageLinkHandler. The HTML is encoded centrally in the BrowseLinksController. All other link handlers already send the plain content correctly. Resolves: #89773 Releases: master, 9.5 Change-Id: I83ac730f150009c1ef6fc286fa26b4a829b2b412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62432 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Alexander Schnitzler authored
composer require --dev friendsofphp/php-cs-fixer:"^2.16.1" Raising the version brings support for running the fixer with PHP 7.4. Releases: master, 9.5, 8.7 Resolves: #89776 Change-Id: Ib065b38c606f17c8e58a684e819cc555e493a91f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62433 Tested-by:
-
Benni Mack authored
Using Indexed Search plugin, one can customize the language selector, however, you needed a TypoScript condition, as Site Handling support was not possible yet. The default behaviour should be to only search in the selected language, which can be achieved by looking into the current language. The default option is now set to "current". Existing implementations still using conditions continue to keep working. Resolves: #80840 Releases: master, 9.5 Change-Id: I7772e40d11593331cddf8fc90c8630f0a4db1758 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62382 Tested-by:
Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
- Nov 25, 2019
-
-
Alexander Schnitzler authored
- Adjust namespaces of classes according to PSR-4 - Add a classmap for test fixtures Releases: master Resolves: #89706 Change-Id: Iefd73f8039eb3db4de419ecaab13a18f6abb23e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62341 Tested-by:
-
Georg Ringer authored
The following changes are applied: - Set a title tag - Add aria labels to the various input fields Resolves: #89597 Releases: master Change-Id: I0a48e9d885b35ea81e47a29989c69f9c8d4b99f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62232 Tested-by:
-
Anja Leichsenring authored
Resolves: #89767 Releases: master, 9.5 Change-Id: I8524a55804e9a5dcda3d6a319053156e557a374e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62428 Tested-by:
-
Benni Mack authored
The existing slot in EXT:frontend for overlaying sys-file-metadata is migrated to a PSR-14 event listener. Although this is not a new feature, this is a perfect example of a migration from SignalSlot to PSR-14 event listener. Resolves: #89748 Releases: master Change-Id: I98fb14b0b9c56ea9d8938e29be88ddcf8dd43eb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62388 Reviewed-by:
-
Benni Mack authored
The BackendUtility::getCopyRightNotice() is ugly, and can only be used in Backend context (not install tool). A new PHP class "Typo3Copyright" in EXT:core encapsulates this information so it can be used in other places as well. The old method is marked as deprecated. Resolves: #89756 Releases: master Change-Id: I5d793138324b315f4ad4873687f85b84120e271a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62420 Tested-by:
-
Benni Mack authored
Various patches introduced a feature to not send the referer nor the opener information to external links. However, just because others CMS do it this way, one should carefully consider WHAT THESE THINGS DO. So, adding "noreferrer" implicitly includes "noopener". What this means is that we can save a lot of bytes, save the environment by producing less bytes and sending them over the wire. References: - https://www.w3.org/TR/2011/WD-html5-20110113/links.html#link-type-noreferrer - https://web.dev/external-anchors-use-rel-noopener/ - https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer Relates: #78488 Relates: #89044 Resolves: #89757 Releases: master Change-Id: Ia366169cd30da23f988bae04175fdaa18be418b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62421 Tested-by:
-
1. "Override for one table" is not implemented in core; 2. Preset "normal" is confusing / non-existing in core. Use "myCustomPreset" to demonstrate usage of custom presets. 3. Use the same syntax (with square brackets) like in: https://docs.typo3.org/m/typo3/reference-tsconfig/master/en-us/PageTsconfig/Rte.html Releases: master, 9.5 Resolves: #89696 Change-Id: I45c51d6afd4a1f46fc377715c24952f781858d54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62334 Tested-by:
-
- Nov 24, 2019
-
-
Ralf Zimmermann authored
Use a nullable typehint for the method setBackendUserAspect() within TYPO3\CMS\Frontend\Middleware\TypoScriptFrontendInitialization to avoid PHP fatal errors if the backend user does not have backend access rights for a frontend page. Resolves: #89763 Releases: master Change-Id: I076c34be2fa7b35d4bcdefb13a6b3f385e96b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62424 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Ralf Zimmermann authored
Write default values which are written through "Inspector-PropertyGridEditor" inspector editors (form editor) as integer numbers if the values can be interpreted as integer numbers. Resolves: #88240 Releases: master, 9.5 Change-Id: If46b571782c64fc96905ab539f63de318c1515d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60616 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Ralf Zimmermann authored
Let the FormPersistenceManager respect user mount points and auto created file mounts while retrieving and creating folders which are configured within "TYPO3.CMS.Form.persistenceManager.allowedFileMounts". Resolves: #88895 Releases: master, 9.5 Change-Id: Ic422c692e268165de986e43239d9f293a71e0b25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62415 Tested-by:
-
- Nov 23, 2019
-
-
Mathias Brodala authored
Resolves: #84713 Releases: master Change-Id: Ic7b3dba44b8dc57d2aa4950c887c63b2b290517f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62416 Reviewed-by:
-
Mathias Brodala authored
This adds fieldset labels as separators on the summary page and mails. Resolves: #82706 Releases: master Change-Id: I09ab461cf7efa49a7658b950b30a7a5f3b73282d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62389 Tested-by:
-
Alexander Schnitzler authored
- Switch the order of constructor arguments $currentPageNumber and $itemsPerPage of both the ArrayPaginator and QueryResultPaginator classes as the $currentPageNumber needs to be set on every object construction whereas the $itemsPerPage argument only needs to be changed for paginators that use a differen amount of items per page other than the default of 10. - Change visibility of properties of both the ArrayPaginator and the QueryResultPaginator from protected to private as both classes are marked final. Releases: master Resolves: #89754 Change-Id: If900c1b786aef7f155bbe0b06cdd167f59e8c9ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62418 Tested-by:
-
Benni Mack authored
There are various places where TSFE is instantiated, and holding the proper information about a site and the current language. Using the properties from there avoid using $GLOBALS[TYPO3_REQUEST] in "safe" places. Resolves: #89745 Releases: master Change-Id: Id2bb16ce376172bdf563fed0c7ddd0bf84415506 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62379 Tested-by:
-
Sybille Peters authored
The changelog about removing classes from `ext:fluid` is changed to refer to the classes in typo3fluid. This should ease migration. Resolves: #89753 Releases: master, 9.5 Change-Id: Ibf2ce1194427d5b13dca6b7702d3c582813c5b97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62414 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Benni Mack authored
The SystemInformationToolbarItem now has one unified PSR-14 Event instead of the previous signals used by SignalSlotDispatcher. New Event class is called: - TYPO3\CMS\Backend\Backend\Event\SystemInformationToolbarCollectorEvent and provides access to the actual SystemInformationToolbarItem allowing to add messages or new systemInformation blocks by using the API methods there. The existing signals are deprecated, and all existing code is migrated to the PSR-14 event. Resolves: #89750 Related: #89733 Releases: master Change-Id: I249c49f8d24b6e2dc73c2db7b4f7c15c9ccfa3fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62390 Tested-by:
-
Benni Mack authored
Currently, the Static Route Resolver returns HTTP status code 200 on invalid routes, but a 404 is the correct response. Resolves: #89752 Releases: master, 9.5 Change-Id: Ic7f0cda76777e942ce20fa0577d0c4b0675a69a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62413 Reviewed-by:
-
Alexander Schnitzler authored
This patch introduces native support for pagination of lists such as arrays or QueryResults of Extbase. The main part of this feature is a new PaginatorInterface that defines a basic set of methods a paginator needs to implement. To enable a quick creation of new paginators, an AbstractPaginator class has been created which holds the main pagination logic while the concrete paginator only needs to take care of the concrete data type handling. The PaginatorInterface and the AbstractPaginator allow the creation of futher paginators like one that supports the doctrine/dbal query builder. It's basically possible to create paginators for all sets of items that are countable and which can be transformed into an iterable sub set of given items. The PaginationInterface will also be the foundation for a new type agnostic pagination ViewHelper. Releases: master Resolves: #89603 Change-Id: I46c712d8112ae7dca6caaf0c9476402f6ea5054a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62239 Tested-by:
-
Mathias Brodala authored
Resolves: #88899 Releases: master Change-Id: I775b73eed5b257a65e48f6cc824e0ce855a67f6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62361 Tested-by:
-
Benni Mack authored
This patch mainly: - Does use statements in all EM code - Removes unused fields "sponsorlink", "sponsorlogo" and "sponsorname" of mirrors XML - Removes unused methods in internal classes It is time to clean up... First one is to get an overview of what is still needed. Resolves: #89751 Releases: master Change-Id: Ie30f05f413afc259fdef6064c363fff47483b331 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62391 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Björn Jacob authored
Resolves: #84458 Releases: master, 9.5 Change-Id: I0f54f01f2f1adee798c0df7358f61f865039d4e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60613 Tested-by:
-
Mathias Brodala authored
Resolves: #84203 Releases: master Change-Id: If33c0587881009c378f28112f60a947f0c957cc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62412 Tested-by:
-
