- Oct 09, 2021
-
-
Nikita Hovratov authored
The coalesce operator has a relatively low precedence over other operators. If used as part of other expressions, it is almost always necessary to wrap it in parenthesis. Otherwise unexpected behaviour or undefined array key errors (in PHP 8.0) may occur. Resolves: #95482 Releases: master, 10.4 Change-Id: I4ddecdbeab03c215477f77742674ded01bc29257 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71449 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Oct 08, 2021
-
-
Benni Mack authored
When showing required dependencies (= extensions) in Extension Manager, e.g. for distributions - downloading the Introduction Package, the remote (e.g. "ter") needs to be set for displaying purposes. Resolves: #95544 Releases: master Change-Id: I4cc2ca1af7d8acaaac3dfb4d8fe7ca3461749610 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71510 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Robert Kärner authored
Access to $GLOBALS['BE_USER'] must be protected by the neccessary fallbacks, as no backend user might be logged in when an exception is thrown in the frontend. Resolves: #95538 Releases: master Change-Id: I03e21c9ef8f1770ed3d2fa72bd6cd99d7e6fc3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71505 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
physikbuddha <r.kaerner@oranto.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
The confirmation password, required for accessing the install tool through the backend, now uses the autocomplete attribute to prevent password managers from initiating a "change password" workflow. Resolves: #92969 Releases: master, 10.4 Change-Id: I27bc81e7ebaa9684b4e15c7208841ca5e3a4338d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71501 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Marcel Schüßler authored
When using the "saveAndClose" option for a newContentElementWizard item, the target link forwards directly to the record_commit route instead of FormEngine. Previously the parameters for this link were added to an array, which was then never reset after used for the link creation. This therefore resulted in multiple elements were created as soon as the "saveAndClose" option was set multiple times. This is now fixed by not using a single use variable anymore, but directly building the data array in the link, like it's already done for the FormEngine links. Releases: master Resolves: #95526 Related: #95277 Change-Id: I897acd376ce44c6f26c27dc7ddd927302e5be8bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71488 Tested-by:
-
Jochen Roth authored
The paths for source set images is currently prefixed with a slash which causes duplicated slashes at the beginng of the path so images are not displayed anymore. This has been fixed by removing the url prefix for source sets. Resolves: #95493 Releases: master Change-Id: Ieba7c4b380a9c8c14d73b83909b891dd634a041d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71508 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #95258 Change-Id: Idddbd4c449e2dc891c91f466614f04a8770d5815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64429 Tested-by:
-
Oliver Bartsch authored
This fixes some undefined array key warnings, that appear on frontend requests. Resolves: #95542 Releases: master Change-Id: I40e6fb10b618f0487ecd763afea2b67ee2eabb7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71509 Tested-by:
-
Alexander Stehlik authored
Prevent access to undefined array keys in content renderer and menu objects. Resolves: #95489 Releases: master Change-Id: I1ec4b046478e7e83176e1178153d57a2890b269e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71454 Tested-by:
-
Robert Kärner authored
Several undefined array key warnings prevented the TCA suggestion wizard from showing results. These have been fixed. Resolves: #95537 Releases: master Change-Id: I6a9019b977c62529f6263d9f37eed30bbb88ba4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71503 Tested-by:
-
Oliver Bartsch authored
Some item providers (context menu) access clipboard information. Since the clipboard was previously not properly initialized, this led to exceptions, since no longer existing elements could falsely be retrieved. This is now fixed by cleaning up the clipboard before making it available for the context menu item providers. Resolves: #92805 Releases: master, 10.4 Change-Id: I31d4c8fa4fa89815cbc660dbc8a4af5d111e1462 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71502 Tested-by:
-
Oliver Bartsch authored
In #86291 the scheduler task list was refactored. A part of this refactoring was aligning the list with the one, known from the recordlist module. Therefore also the "toggle table" functionality from EXT:recordlist was added. However, since the updated state was never retrieved on building the table, the collapse state was saved but never used. While integrating the multi record selection in #94918, the corresponding "t3js-toggle-recordlist" class was removed to prevent cross dependencies. Since then, the collapse state was not just not retrieved, but no longer saved at all. This is now fixed by properly implementing this functionality in the corresponding scheduler JavaScript module, while the saved state is now properly taken into account on building the table. Resolves: #88351 Related: #86291 Related: #94918 Releases: master Change-Id: Ie8cb870bfba8170adec98410b6de2e53bbcf7938 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71506 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
EXT:redirect is using the TargetPageIdViewHelper to get the page ID from a "t3://page?uid=" link. If this link is however somehow malformed, e.g. "t3://page=uid=", this previously lead to an exception being thrown, making the redirects module unusable for an editor. Since an editor usually does not have access to pid=0, it needed an administrator to make the module accessible again. This is now fixed by catching this exception in the view helper. Resolves: #95488 Releases: master, 10.4 Change-Id: I27625f22a8b6f6a197402742c781d5fe8adae7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71500 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Nikita Hovratov authored
The values of tx_testdatahandler_group for the second content element in the default language now match with ImportDefault.csv. This fixes unexpected behaviour in those tests. Resolves: #94569 Releases: master Change-Id: I134259ace54e9c85df5f218acce154e53ac47688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69902 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Nikita Hovratov authored
This unifies the approach of calculating the size attribute value when having autoSizeMax set. Resolves: #94476 Releases: master Change-Id: I4477b5376c78f1288d586522887ea4027dd0e96e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69712 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Bartsch authored
The page module displays a flash message for page translations with inconsistent ("mixed mode") content elements. The last sentence of the flash message reads: "We highlighted the problematic records for you". This however was no longer the case in the fluid based page module. Therefore, this patch restores highlighting of such records. Resolves: #91177 Releases: master Change-Id: Ic0ada77428a426254f9cbba256e23f938733f9aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71484 Tested-by:Rachel Foucard <rfoucard@w-seils.com> Tested-by:
-
Oliver Bartsch authored
This fixes the ExtendedTemplateService->ext_getSetup() method, which now properly handles array key accesses. A new early return now also checks for an empty key and returns the whole setup in this case. This is a special case, needed for e.g. the object browser, to still show the full setup when object lists exist. Resolves: #94971 Releases: master Change-Id: I7b6615022ba59dc99929b05744c1cb33805098aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71461 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Christian Kuhn authored
TypoScript options config.spamProtectEmailAddresses_atSubst and config.spamProtectEmailAddresses_lastDotSubst may not be set. Use null coalescing operator to sanitize access. Link/EmailViewHelperTest stumbles here and also needs a proper initialization of $GLOBALS['BE_USER']. Resolves: #95532 Releases: master Change-Id: I8169229c1a31c1243cf2c4fc4321d015f532dc12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71494 Tested-by:
-
Oliver Bartsch authored
EXT:felogin uses checkbox items in their FlexForm configuration. Since the item key does not start with 0 but with 1, it's no longer possible to save the items. This previously only worked because of another bug in the checkbox element, which however had been fixed in #95371. This is now fixed by correctly using 0 as the first item key for the checkbox items. Background: The item key is used for the "is checked" calculation wich uses arithmetic operators and requires the first item key to be 0. Resolves: #95510 Related: #95371 Releases: master Change-Id: Icb71d5b8d8beeba9f6b11bb03f72d45fbbdedb3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71499 Tested-by:
-
- Oct 07, 2021
-
-
Jochen Roth authored
Currently the fe_user field email has a eval value of "trim". So it does not verify the given email. This has been fixed by setting eval to "email" and trim the email before validation. On top of that the validation flash message now shows the correct value that was entered. Resolves: #95459 Releases: master Change-Id: I274ae040da9fe8d03a56e5ba9b4f17a828da57f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71483 Tested-by:
-
Christian Kuhn authored
The extbase UriBuilder can be used in backend context, ActionMenuItemViewHelper does that for instance. The code accesses $GLOBALS['TSFE'] at one point, which may not be set. The ActionMenuItemViewHelperTest triggers this, but it should be a general asset of UriBuilder to work without TSFE, so this is not considered an incomplete test setup, but fixed in UriBuilder directly. Resolves: #95529 Releases: master Change-Id: I59bcdf00b11fa0f1af13207021da8d7ef3e4c0f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71491 Tested-by:
-
Jochen Roth authored
A link to a folder created in RTE leads to undefined array key warning in frontend. This has been fixed by using null coalescing operator instead of ternary operator. Resolves: #95519 Releases: master Change-Id: I2f5315db87281825fc53a63fdf6edabc5a8a7b01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71496 Tested-by:
-
Georg Ringer authored
The links at the error page can be improved: - link to the official donation page - show typo3.org without protocol Resolves: #95480 Releases: master Change-Id: I6a4b3358c8dfc5dc0776a53e9aedb3b72e167166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71447 Tested-by:
-
Christian Kuhn authored
* Arguments with default values are registered with their default values in fluid by default. Tests that circumvent argument initialization by setting them directly must set them. The patch adds this for the "exception" tests in ImageViewHelperTest. * The main tests of ImageViewHelperTest run in backend scope. The FAL logic triggers StoragePermissionsAspect in this scope, which needs a $GLOBALS['BE_USER'], but that is not set up by the tests. The patch initializes a backend user. Change-Id: I91280cf869bf4609c20387132d076267e54b9b7a Resolves: #95531 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71493 Tested-by:
-
Georg Ringer authored
Fix a regression introduced in #91834 to be able to use stdWrap for text. Resolves: #95497 Related: #91834 Releases: master Change-Id: I6bbfce97870e3b33b8e363bdafa648d1b88ea23f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71497 Tested-by:
-
Christian Kuhn authored
The FileViewHelperTest runs in backend scope, a valid backend user needs to be initialized to satisfy StoragePermissionsAspect. Change-Id: Icd5cd1f1916e0244c61429f62b94dbd183f9b401 Releases: master Resolves: #95533 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71495 Tested-by:
-
Christian Kuhn authored
Argument 'priority' is accessed in ScriptViewHelper without fallback. This is fine, since fluid sets arguments to default values in normal operation. The test case however circumvents this argument initialization, so a value has to be set in the test. Resolves: #95527 Releases: master Change-Id: If23fcd0c3632f662038815a8bd760f228abbeb92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71489 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Fluid Viewhelper class name resolution is case sensitive. The patch fixes a cases where f:format.htmlentitiesdecode is used instead of f:format.htmlentitiesDecode (upper case D). Resolves: #95530 Releases: master Change-Id: I6742dc05f6cfba9b8908f5dbf12c21b16e17d26e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71492 Tested-by:
-
Benni Mack authored
Give the actual method the name "generateMessagesForCurrentPage" as no flash messages are generated. Resolves: #93428 Releases: master Change-Id: I1c0c9e721a012fab2942133637fcd8513571d03c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71487 Reviewed-by:
-
Christian Kuhn authored
Avoids a deprecation level log error since of this functional test related extbase test controller action. Resolves: #95524 Releases: master Change-Id: Ic789f78bd96033d454da4eb94ec4da06758f7982 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71486 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Christian Kuhn authored
Some functional tests using SiteBasedTestTrait create a broken site config, example: base: 'https://website.local/' errorHandling: - - errorFluidTemplate: typo3/[...]/FluidError.html errorFluidTemplatesRootPath: '' errorFluidLayoutsRootPath: '' errorFluidPartialsRootPath: '' errorHandler: Fluid errorCode: 404 It should be: base: 'https://website.local/' errorHandling: - errorFluidTemplate: typo3/[...]/FluidError.html errorFluidTemplatesRootPath: '' errorFluidLayoutsRootPath: '' errorFluidPartialsRootPath: '' errorHandler: Fluid errorCode: 404 This is due to a superfluous array when creating the site config. The patch adapts usages. Change-Id: I953abb0cd5d3414e8ea259e73b47cc6b391b299a Resolves: #95523 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71485 Tested-by:
-
Christian Kuhn authored
Viewhelpers need to be registered in Services.yaml. Add this for a functional test related fixture extension. Resolves: #95521 Releases: master Change-Id: I27f56c89958d4338c2d7f8bdd3c0c8defceb7da8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71482 Tested-by:
-
Georg Ringer authored
If a slug is changed, the redirect cache must be rebuilt to make the redirect actually work. Resolves: #94808 Releases: master, 10.4 Change-Id: Ieb3615db1829aa45eb14d6a7baaeed183a70b248 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70461 Tested-by:
Tim Schreiner <schreiner.tim@gmail.com> Tested-by:
-
Marcin Sągol authored
This refactores the "Make Query" block in the DB check module to use proper bootstrap styles. This makes the whole block more readable and also aligns with other backend components. Resolves: #94896 Releases: master Change-Id: Ic858ecc5cb494f6b653ba9e0651ca8ea302b4c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70605 Tested-by:
-
Nikita Hovratov authored
Resolves: #95075 Releases: master Change-Id: I6c2c9981aac3ccf892767c4205032e8aa2a465e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70863 Reviewed-by:
-
Christian Kuhn authored
Functional test ext:felogin ContentVisibleFieldsTest::loginFormContainsExpectedFields indirectly calls $GLOBALS['TYPO3_REQUEST'] of Clipboard::initializeClipboard(). Clipboard class does multiple things: It is a 'repository' to find out which items are in the clipboard, and it helps with rendering. The 'repository' part does not need $request. Functional tests call initializeClipboard() without handing over a request object and without preparing a request as $GLOBALS['TYPO3_REQUEST']. While they could actively init a request, they shouldn't need to do so. The patch adds a fallback so clipboard class does not emit a warning if neither $request is given nor $GLOBALS['TYPO3_REQUEST'] is set. An according @todo is added to further streamline the code. Change-Id: Ifde4e8fa053203acf8570cf969b073a7da176c42 Resolves: #95509 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71477 Tested-by:
-
Oliver Bartsch authored
This fixes a couple of array key related PHP warnings, triggered in the TypoScript object browser while searching. This also fixes an error, leading to an empty search result under some circumstances. A new acceptance test is taking care, the search will always work in the future. Resolves: #95491 Resolves: #95494 Releases: master Change-Id: Ifbd0aae5abf87ba455ea9d2acbf870cc830f652b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71464 Tested-by:
-
Stefan Bürk authored
Log messages generally use double-quotes. This patch fixes the few stragglers that do not. This also fixes an issue in PHP 8.1, where the defaults for htmlspecialchars() have changed resulting in some test failures. Standardizing the quotes makes the tests pass in all cases. Resolves: #95507 Releases: master Change-Id: I7ee189b8df997700f62f8379916624c27f02742a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71476 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Torben Hansen authored
With #92238 the objectManager usage has been removed in Extbase validationResolver. In the same patch it is also mentioned, that validators must not have services injected. The possibility to inject services in validators has been removed with #94451. This change adds a breaking.rst document about the topic and how to migrate existing code in extensions. Resolves: #95026 Related: #92238 Releases: master Change-Id: I139c21e9ddeeac1ef66af34090b1a5c0bbc097a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70811 Tested-by:
-
Stefan Bürk authored
Brings fix for changed sqlite driver behaviour for php8.1, which would fix a schemamigrator issue for php8.1. composer req doctrine/dbal:^2.13.4 composer req doctrine/dbal:^2.13.4 -d typo3/sysext/core --no-update composer req doctrine/dbal:^2.13.4 -d typo3/sysext/install --no-update composer req doctrine/dbal:^2.13.4 -d typo3/sysext/redirects --no-update Related test Build/Scripts/runTests.sh -s functional -p 8.1 -d sqlite -x \ -e '--filter="SchemaMigratorTest::changeExistingIndex"' Resolves: #95511 Releases: master Change-Id: I37a3d9c51c7158b685277b05d6320c5cca56e756 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71469 Tested-by:
-
