- Mar 21, 2014
-
-
Nicole Cordes authored
On empty pages no page content is rendered at all. This patch brings the clipboard back, if it contains elements so you can check those on the empty pages. Besides the drawFooterHook is shown again on empty pages. this isn't set in the core itself and extension authors should be able to choose if the content should be visible on empty pages. Resolves: #57062 Releases: 6.2 Change-Id: Ie7bd6fda730e801b285d7876a1eff39c3ba1eff0 Reviewed-on: https://review.typo3.org/28603 Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Frans Saris Tested-by: Frans Saris
-
Jigal van Hemert authored
The stdWrap property escapeJsValue actually encodes the content and should thus be called encodeForJavaScriptValue. Also the value must be enclosed in quotes to prevent it from being used outside the target context of string values in JavaScript. Releases: 6.2 Resolves: #57107 Documentation: #57108 Change-Id: Id5f850d36a87d71ca80eb58e3359ddacdd5b655e Reviewed-on: https://review.typo3.org/28571 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Ernesto Baschny authored
This reverts commit 07714455 This new interface is not being used throughout the Core, as this was just the first step of three to complete this functionality. So we revert and postpone this change for the next release. Change-Id: I5dd0e074a0026ff49b1d096ff4fd8926370aba3f Reviewed-on: https://review.typo3.org/28598 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Helmut Hummel authored
The check if we have class information can be simplified to !empty() Resolves: #57117 Related: #56933 Releases: 6.2 Change-Id: I8532b26142cc39da2b9bcca9880df715da57d59e Reviewed-on: https://review.typo3.org/28596 Reviewed-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Francois Suter authored
With the changes introduced by the new cache grouping system, the "Clear all cache" menu item in the clear cache menu has become ambiguous. Labels and tooltips can be improved. Resolves: #57128 Releases: 6.2 Change-Id: I2c723e3581605f7040f8a1cc1598053155ee80a4 Reviewed-on: https://review.typo3.org/28588 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Ludwig Rafelsberger Reviewed-by: Stephan Großberndt Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
- Mar 20, 2014
-
-
Markus Klein authored
Resolves: #57117 Related: #56933 Releases: 6.2 Change-Id: Ie305b808b0a9b9e10b5adca4af9e2562cf5123f6 Reviewed-on: https://review.typo3.org/28577 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Wouter Wolters authored
Resolves: #57124 Related: #55116 Releases: 6.2 Change-Id: I26ce6a340c06f6dfccf255b9b6c9424d9bd70efb Reviewed-on: https://review.typo3.org/28583 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Helmut Hummel Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
Install tool shows errors for file and folder permissions on Windows system. As those are writable by default the errors should be turned into information. Resolves: #57118 Releases: 6.2 Change-Id: Idc9f1126916e161bcde1e48c91ada2f9846a9ef9 Reviewed-on: https://review.typo3.org/28579 Reviewed-by: Wouter Wolters Reviewed-by: Xavier Perseguers Reviewed-by: Stefan Neufeind Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Marc Bastian Heinrichs authored
This patch add functional tests for exporting and importing FlexForm fields of types "group" internal_type "file" and "file_reference" and a field with a soft reference link to a file. Resolves: #56612 Releases: 6.2 Change-Id: Ic66257dab15ec7a2fde522be9f74170eec346877 Reviewed-on: https://review.typo3.org/28466 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Marc Bastian Heinrichs authored
According to the fixes for the normal TCA fields of type "group" internal_type "file_reference" in #49538 and #56353, this needs also to be fixed for the FlexForm fields: handle the internal_type file_reference as an db reference to sys_file. Resolves: #56991 Releases: 6.2, 6.1, 6.0 Change-Id: Ie66c86c1bf3f0386d23259d0aee6706564beace3 Reviewed-on: https://review.typo3.org/28465 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Xavier Perseguers authored
Resolves: #57119 Releases: 6.2 Change-Id: I9be8b51fd695e2470e22fe084eeec507fd78f6f2 Reviewed-on: https://review.typo3.org/28578 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Resolves: #53812 Releases: 6.2 Change-Id: I41ac63010ff245ccbd7b1c09f6ee9f42b64e79cd Reviewed-on: https://review.typo3.org/25547 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Ernesto Baschny authored
The recommended setup (660/770) should generate a green "ok" and not a Notice. It now also includes a comment if group read/writeable about the potential risk and if configured a hint to BE/createGroup. Also display errors in case the configured mask does not include user read/writeable flags. Resolves: #57025 Releases: 6.2 Change-Id: If42d505e0b1bac10cfca1d7b76faec058989ccb2 Reviewed-on: https://review.typo3.org/28492 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Markus Klein authored
The tests have not been adjusted when http://forge.typo3.org/issues/52668 was merged. Resolves: #57055 Releases: 6.2 Change-Id: I259c7b5462d372f3244ee4c2e89a96cef0780478 Reviewed-on: https://review.typo3.org/28513 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Alexander Stehlik authored
The icon_warning2.gif is used instead of the deleted icon_warning.gif. Resolves: #57116 Releases: 6.2 Change-Id: I3a902a0bfb362c29e8ff6b384b844bf1f7f63cf8 Reviewed-on: https://review.typo3.org/28575 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Xavier Perseguers authored
Fixes: #57075 Releases: 6.2 Change-Id: Ided1204857dabf4fb15045056cc8a14010a53ae9 Reviewed-on: https://review.typo3.org/28558 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Thomas Maroschik authored
The class loader caches if it doesn't find a class name for subsequent calls. But currently it only checks for NULL results from the cache and not the empty strings returned from the cache and thus tries to resolve the non existing class name over and over again. The fix converts the empty string to a NULL and changes the semantics of NULL to FALSE in the class loader. Fixes: #56933 Releases: 6.2 Change-Id: I4cd1a18b4a4496c287a937d6d9882ae21d3ee9a3 Reviewed-on: https://review.typo3.org/28419 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
This patch fixes the import of fields type "group" "internal_type" "file_reference" and adds functional tests for exporting and importing records with fields of type "group" "internal_type" "file" and "file_reference", the types for file handling before introducing the File Abstraction Layer. Resolves: #56516 Resolves: #56071 Releases: 6.2 Change-Id: I4298f27ee77a89230188aa0df1b187429d555188 Reviewed-on: https://review.typo3.org/28021 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Marc Bastian Heinrichs authored
The field "link" of the table "sys_file_reference" handles links. To make the SoftReferenceIndex, which is used by impexp and linkvalidator, work right, the “softref” key "typolink" should be registered. Resolves: #57010 Releases: 6.2, 6.1, 6.0 Change-Id: I95cb8dbfa0c6d84926cd57d1fe4e4dad93e9c21a Reviewed-on: https://review.typo3.org/28484 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Frans Saris Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Francois Suter authored
New TSconfig option clearCache.system does not work as expected because class \TYPO3\CMS\Backend\Toolbar\ClearCacheToolbarItem wrongly checks access to that option. Thus if only clearCache.system is set the clear cache menu does not show up at all. Resolves: #57064 Releases: 6.2 Change-Id: I51c9605c830a9099f21d254ae86d8d6cc430b02a Reviewed-on: https://review.typo3.org/28518 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Kay Strobach Tested-by: Kay Strobach Reviewed-by: Francois Suter Tested-by: Francois Suter
-
Alexander Stehlik authored
Instead of using unnamend parameters (?) in parseComparison() in the Extbase Typo3DbQueryParser the matching parameter identifier will be used for building the comparison SQL. Additionally the non existing "$parameters" method parameter is removed from a lot of method calls. Resolves: #57053 Related: #55167 Releases: 6.2 Change-Id: I1123275af57e8803ecd792d65f91627cef54f501 Reviewed-on: https://review.typo3.org/28511 Reviewed-by: Felix Oertel Tested-by: Felix Oertel Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Mar 19, 2014
-
-
Stanislas Rolland authored
Problem: Magic images inserted in RTE content may be missing, for instance after flushing the _processed_ directory. Solution: Regenerate any missing magic image when rendering the content element. Revolves: #56147 Releases: 6.2 Change-Id: Ifa156791bcd1c446c7ae61888465bb680abdf36d Reviewed-on: https://review.typo3.org/27884 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Wouter Wolters Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Benjamin Rau authored
Fixing several typos and slips of the pen in the PageBrowsing ViewHelper. Without fixing all of them the page browsing ViewHelper is not functional properly, that´s why i want to submit them at once and also supply the fix for it. That are these errors: * Undefined but used class property prefixId * Overwriting instead of appending content to already defined variable * Not using UpperCamelCase for extensionName in Localization Utilty * Accidentally using wrong variables * Defining variable in for-loop which could be defined outside also * Using undefined variable freeIndexUid Resolves: #55340 Releases: 6.2, 6.1 Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800 Reviewed-on: https://review.typo3.org/27058 Reviewed-by: Dmitry Dulepov Reviewed-by: Wouter Wolters Reviewed-by: Cedric Ziel Reviewed-by: Tymoteusz Motylewski Tested-by: Tymoteusz Motylewski Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Christoph Dörfel authored
Fixes cases where the shortcut page is cached by some devices leading to exceptions or wrong behaviour. Resolves: #56423 Releases: 6.2 Change-Id: I71252b13320417ecffa9c28db6af9476d667d58f Reviewed-on: https://review.typo3.org/27933 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
This patch fixes the import and export of RTE contents including images and links to files as well as softreference links to files (file:{uid}) and adds functional tests for this use cases. Resolves: #56089 Resolves: #56285 Related: #56286 Releases: 6.2 Change-Id: I29312b304d265581bf9f35bdc2692a19d2df5a93 Reviewed-on: https://review.typo3.org/28105 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Marc Bastian Heinrichs authored
The Extbase implementation registrations don't have to be initialized in BE mode only. Resolves: #55593 Releases: 6.2 Change-Id: I78a643fba62d48734fc727d7bf78bf774e6c3ddd Reviewed-on: https://review.typo3.org/28519 Reviewed-by: Wouter Wolters Reviewed-by: Ernesto Baschny Reviewed-by: Markus Kasten Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Frans Saris authored
The code responsible for rendering the thumbs belonging to a record doesn't catch the exceptions when a file couldn't be found. This change adds a try catch around the functions that tries to retrieve the file and displays a flash message when the file is missing. Resolves: #56077 Releases: 6.2 Change-Id: Icc6550db43c8738c74fd7ea8faac6e99a54bc0f3 Reviewed-on: https://review.typo3.org/28284 Reviewed-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Tymoteusz Motylewski authored
Catch exceptions raised when the potential target folder or the default user upload folder does not exist. The change https://review.typo3.org/27323 from ticket http://forge.typo3.org/issues/48512 should be applied in few places more. Resolves: #56751 Related: #48512 Releases: 6.2 Change-Id: I7446697d64a580203f8f772d4bba690542dd7cb2 Reviewed-on: https://review.typo3.org/28247 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Frans Saris Tested-by: Frans Saris
-
Alexander Stehlik authored
If a field is configured to allow NULL values ("eval" is set to "null") and the default value in the TCA is explicitly set to NULL the value will not be converted to a string. Additionally the mode setting "useOrOverridePlaceholder" will not have any influence any more on the default value when creating new records. Resolves: #54412 Releases: 6.2 Documentation: #56584 Change-Id: Ica43a1af33e6f86dd042b66781acc0e9cd904cf9 Reviewed-on: https://review.typo3.org/26408 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Reviewed-by: Oliver Hader Reviewed-by: Ernesto Baschny Reviewed-by: Stefan Neufeind Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Markus Klein authored
AbstractCoreUpdate redefines the $view member to be a JsonView, but does not re-implement the parent methods that rely on $view being an AbstractView. Fix this by re-implementing the initializeHandle() method. This method can be merged with the former initializeCoreUpdate(), which wasn't called at all in most actions. Resolves: #56865 Releases: 6.2 Change-Id: I85260a0e57e915ac941569cfbdde1f96cdaec5e6 Reviewed-on: https://review.typo3.org/28393 Reviewed-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 18, 2014
-
-
Marc Bastian Heinrichs authored
Resolves: #57045 Releases: 6.2 Change-Id: I439305e5143b3c51a03befc642caf66286264679 Reviewed-on: https://review.typo3.org/28496 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Oliver Hader authored
Add the copyPage() functional test for live and workspace. Resolves: #57030 Releases: 6.2 Change-Id: Id9ddea21a50c449c3f2674d704c10fefb2da12ff Reviewed-on: https://review.typo3.org/28488 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
As a follow-up to issue #57046 (which fixed a bug in sys_file_metadata pointing to sys_file_reference as translation parent), these corrections need to be updated in the functional test assertions as well. Resolves: #57054 Releases: 6.2 Change-Id: I1a3d395fb4fcb1271d2684af38e5fc32a10463fc Reviewed-on: https://review.typo3.org/28512 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Alexander Opitz authored
Follow-up to 2268f64c If typo3temp does not exist, the Locker should throw an exception. The ClassLoader needs to catch this exception and acts upon depending on whether we are in the Installer or not. When in the Installer, locking has to be skipped completely due to missing typo3temp directory. Resolves: #57008 Releases: 6.2 Change-Id: Ic595dc97826cd94d6f173b7c681194ed754ed3e0 Reviewed-on: https://review.typo3.org/28482 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Marc Bastian Heinrichs authored
Instead of sys_file_metadata sys_file_reference was configured. Resolves: #57046 Releases: 6.2 Change-Id: I1194012cbacb0415993672338d6ac6ee0a515dc1 Reviewed-on: https://review.typo3.org/28501 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Benjamin Mack authored
As TYPO3 is loading all ext_localconf.php on each call, the existing code can be cleaned up by removing old information, putting BE-only functionality in TYPO3_MODE == 'BE' and install-tool only in Install only mode. Also, some hardcoded require_once statements are removed. Benefits are that FE does not need to load everything all the time. I haven't noticed any side-effects so far, but please test extensively. Resolves: #55593 Releases: 6.2 Change-Id: Ibc37e84cb2af05ddb6b227290330aad31037a018 Reviewed-on: https://review.typo3.org/27286 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Fabien Udriot Tested-by: Fabien Udriot Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Andreas Fernandez authored
The method analyzeFields() of DBAL's DatabaseConnection caches the table structure. The cache always uses the real table name, ignoring any mapping, which results in a RuntimeException: "Could not update BLOB >>>> no WHERE clause found!" The method now checks for a possible mapping and sets the alias as table name. Resolves: #56349 Releases: 6.2 Change-Id: I9599cebc8604103c3749bc142cd44b813f018a72 Reviewed-on: https://review.typo3.org/27874 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Bernhard Kraft authored
Instead of iterating over the array and calling "intval" for each element the "array_map" php function gets used. Change-Id: I5ae699f9bc158eb0caebf1fc9ea8ebaa3cdd73ca Resolves: #56738 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/28234 Reviewed-by: Dmitry Dulepov Tested-by: Dmitry Dulepov Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Alexander Stehlik authored
In the image rendering TypoScript configuration of css_styled_content the uid is removed from the references configuration of the FILES content object. This makes sure that the language overlay mechanism from the FILES content object is used. Resolves: #56712 Releases: 6.2 Change-Id: Iaea43ca006826facfba40a846da67704dd3154ea Reviewed-on: https://review.typo3.org/28210 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
As TYPO3 is now using mysqli, prepared queries are natively supported and should be used. DBAL, however, does not yet actually use native prepared queries but falls back to standard queries by replacing placeholders and executing the underlying SQL query. Change-Id: If50da6e6d27af89e01c0439bcb9d39a85615a75d Resolves: #27372 Releases: 6.2 Reviewed-on: https://review.typo3.org/28231 Reviewed-by: Andreas Fernandez Tested-by: Andreas Fernandez Tested-by: Wouter Wolters Reviewed-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-