- Apr 19, 2024
-
-
Stefan Bürk authored
Doctrine DBAL 4.x has been introduced with #102875 and required adoption of breaking changes - which had been done. This included changes of children structures in classes, for example `\Doctrine\DBAL\Schema\Table` no longer returns associative array for `getColumns()` and `getIndexes()`. TYPO3 builds a virtual database schema reading extension `ext_tables.sql` files combined with TCA based default schema definitions to provide the Database Analyzer flow. The collection process build up partly table structures, and having tables multiple time which needs to be merged at some point to get the final virtual structure. With change #103015 this merge process has been moved to an earlier point, overseeing that columns and indexes are no longer associative arrays and using `array_merge()` is no longer suitable for them. In cases, where an extensions change or overrides the table definition of a table this merge process will throw a Doctrine DBAL `ColumnAlreadyExists` exception, because columns and indexes of multiple table parts are not correctly merged anymore. This change introduces two helper method as sidekicks for method `SchemaMigrator::mergeTableDefinitions()`, to merge table columns and indexes correctly and guard it with the added test. Note: Foreign keys constraints are still associative, and the TYPO3 does not support unique constraints at all within `ext_tables.sql` files. Resolves: #103666 Related: #103015 Related: #102875 Releases: main Change-Id: I9b5bca0f4faab198c3aba1c70d249ac08d07d2db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83934 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de>
-
Christian Kuhn authored
There is a relatively obscure and not well known TCA config property for type='select': 'allowNonIdValues'. It can be used in scenarios with 'foreign_table' relations, where select stores the uids of selected records as CSV list: It allows additional items next to "true" relations, for instance items from a static 'items' list. To keep "true" relations and "additional static values" apart, those static values must be some string that can not be interpreted as an integer uid. This only works when select stores selections as CSV list: When using an MM table, relation uids are forced to be integers. This is documented, too. RelationHandler still handles 'allowNonIdValues' in its MM related readMM() method, which is obsolete code since that can not work. The patch clean this up and simplifies readMM() a bit along the way. Resolves: #103676 Releases: main Change-Id: I5f760f4c111ce5ae7a1cc3c9412b8900e4ac82d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83929 Tested-by:
-
Christian Kuhn authored
Extend the functional RootlineUtilityTest with more scenarios for resolving category MM, and a "casual" inline relation. Resolves: #103680 Releases: main Change-Id: Ic6e5f9cd604582853431be9415c0fb68b4a41b3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83933 Tested-by:
-
Nikita Hovratov authored
Also adjust variable name along the way. Resolves: #103679 Related: #103667 Releases: main Change-Id: I345dabbd388eaac9e5a56af6b70e249c4bac0feb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83932 Tested-by:
-
Christian Kuhn authored
There is no point to trim() value arrays that have been created with GU::trimExplode() just the line before. Clean up the loop a bit along the way. Resolves: #103674 Releases: main Change-Id: Ia5580b292b1a44a0291468b35bc1e5ca5b2f9823 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83928 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Rath-Ulrich authored
Add record titles to the record icon alt text. To make the alt text for record icons helpful, the title and type of the record is now added to the existing id=x. To implement this also for the pagetree, the method BackendUtility::titleAttribForPages() has got a new parameter to return the value unescaped. The JsonResponse in the TreeController already escapes the data and additionally the TemplateResult from lit also does escaping. Additionally BackendUtility::getRecordIconAltText() received a new parameter to make it possible to not escape string values. This is necessary to prevent values to get double encoded when used in the fluid context. Resolves: #102472 Releases: main, 12.4 Change-Id: I2476baccc4caf1ffaf27bbb3d5681cd53aea6052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81883 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Nikita Hovratov authored
New Content Element Wizards are retrieved from both normal Content Types (CType) and Plugin sub-types (list_type). For the latter the bool parameter `$isPluginSubType` has to be set to `true`. Tests are added to ensure correct functionality. Resolves: #103667 Related: #102834 Releases: main Change-Id: Ib1b63b77f5c66edbde7622d4f8324fcfb82cdf53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83923 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Oliver Bartsch authored
Using `options.folderTree.altElementBrowserMountPoints` it's possible to add additional mount points to the file / folder tree. Adding such entries does now properly work by adding the missing `identifier` key, which is required to add those entries to a storage in `StoragePermissionAspect`. Additionally, null coalescing operators are added at two places to prevent undefined array key errors. Resolves: #103609 Releases: main, 12.4 Change-Id: I275f51b5bb2d2a1583393a9e782366092d4f558a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83841 Tested-by:
-
- Apr 18, 2024
-
-
Christian Weiske authored
Feature #89650 added support for newlines in TCA field descriptions, but palette descriptions were forgotten. This patch makes newlines in palette descriptions visible in the same way. Resolves: #103659 Related: #89650 Releases: main, 12.4 Change-Id: Ib505f476eb0f3efd0bf75bee7550b9e203ccda2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83915 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Jasmina Ließmann authored
Resolves: #103664 Releases: main Change-Id: I310eee5d304821d5f1b5ba210645f5ed2b4a85d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83921 Reviewed-by:
-
Christian Kuhn authored
Calculation of reference index for workspace relations has a nasty bug in getListOfActiveWorkspaces(): It always returns only the first workspace id when there are multiple. This isn't good in v12 since it creates broken or missing index entries with MM. It is worse in v13, since refactorings of the class use the method for some additional operations. The patch fixes the broken helper method. Resolves: #103655 Related: #96067 Related: #103661 Releases: main, 12.4 Change-Id: I989b22f9c25b22f52030c3dbce742074d2e09f97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83875 Tested-by:
-
Jasmina Ließmann authored
In the "Indexing" backend module, words can have various informations, such as frequency and flags. The flags are now displayed as badges and their labels have been updated. Resolves: #103660 Releases: main Change-Id: I73b30e5201619dc2f1cd0831a23d017c5ca7065a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83916 Tested-by:
-
Christian Kuhn authored
Resolving relations in RelationHandler for MM in workspaces is a two fold process: readMM() first finds all relation "candidates". A second step then filters live MM relations from the candidate list that have a workspace overlay. In general, it *should* be possible to combine this rather expensive operation into a single query. This however requires a bigger rewrite of the class, which absoletly needs to happen at some point, especially for performance considerations. There is however a significant bug the patch aims to solve now: The result set of MM relations tends to return relations not only of the workspace-uid that has been requested, but relations of other workspaces as well, due to an insufficient query with improper filter logic in the second part of the process. This patch is important for a bug fix within ReferenceIndex, which - when fixed - triggers the currently broken RelationHandler relation calculation. Resolves: #103661 Related: #103655 Releases: main, 12.4 Change-Id: If42c138321f0043bf9d8c363f0e20e61d649e1e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83917 Reviewed-by:
-
Jasmina Ließmann authored
The "Indexing" indexed_search backend module allows picking single indexed words and adding them as keywords a pages 'keywords' field. This mixes up two different topics: Search and seo. Good seo administration should be a separate topic that involves much more than just adding some arbitrary keyword to a page. Additionally, meta keywords lost quite a bit of relevance over the years, and it seems odd the indexed_search BE module takes care of this detail. It additionally comes with zero additional explanation for editors, is hidden in detail views of the module, and removes the index of a page when used, which leads to unexpected routing within the module. The patch removes this functionality. This also fixes an issue when trying to save keywords for an index that is not a page, but something else like an image. Resolves: #103657 Resolves: #103618 Releases: main Change-Id: Ifd0e1de9c5d02082e2abb363dcd435ecb6778337 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83878 Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev flag-icons@^7.2.1 npm run build Resolves: #103656 Releases: main, 12.4 Change-Id: Ibebf001a8867104d616777adf47b7c0edaccbf9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83876 Tested-by: -
Nikita Hovratov authored
In case of CLI context, normalized params are not available and as they are nullable, a guard condition is required before accessing methods. Note: The access via request object was added in #100047 along with a deprecation of using the ip() function in TSConfig. However, there is a special case, where plain TypoScript is loaded even in CLI context. For example this can happen when EXT:form listens to FlexForm data structure parsing event. Then it needs information from TypoScript on how to manipulate FlexForm based on YAML definitions. Resolves: #103644 Related: #100047 Releases: main, 12.4 Change-Id: Id2d166fd11794db9b7a8102677e5b9305fe18c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83842 Reviewed-by:
-
- Apr 17, 2024
-
-
Rafal Jania authored
Resolves: #103596 Related: #97548 Releases: main, 12.4 Change-Id: I2384d223202af1575a93497f81e6a69599ebbc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83740 Tested-by:
-
Christian Kuhn authored
When a TCA table has no 'ctrl' 'tstamp' field defined, the workspace module crashes with an undefined array access for records of this table. Sanitize this. Resolves: #103650 Releases: main, 12.4 Change-Id: I3f8c6a1788ec2f9e8f03eddaf9c2ed4df5d737e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83848 Tested-by:
-
Nikita Hovratov authored
The $event parameter is now added and a superfluous parenthesis is removed in the condition. Also, the $tableName variable is used now. Resolves: #103645 Related: #98375 Releases: main, 12.4 Change-Id: I8f827ac7f6941ab03a6f5c67e9fb3525d1a79868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83843 Tested-by:
-
Jasmina Ließmann authored
With #92993 the table 'index_stat_search' was removed. The related field 'index_stat_search_id' in table 'index_stat_word' is left as an orphaned remnant. This patch now removes the field. Resolves: #103649 Related: #92993 Releases: main Change-Id: Idc04a6675c6b75fefd13149cd68a93a2cca3123d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83847 Reviewed-by:
-
Christian Kuhn authored
TCA type=select has no config field 'foreign_field'. A check in RootlineUtility can be simplified a bit. Resolves: #103647 Releases: main Change-Id: Ia34a79f1797a9dfb8d9fbadb76d12fd1b2b175b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83845 Tested-by:
-
Jasmina Ließmann authored
The element information modal displays both field information for the current record and its references. The more fields there are in a table and the more content the specific record contains, the more the reference sections disappear from view. The three sections are now displayed as accordions to enable the user to decide for themselves which sections are relevant to them. In addition, the display of non-existent records in the reference sections has been adjusted and information about the paths/storage locations has been removed, as these can already be viewed in the record's editing mask. Resolves: #102469 Releases: main Change-Id: Ia4ba85921d7be2ab30477e8248d4fb8734f6eaaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81873 Tested-by:
-
Jasmina Ließmann authored
Several minor adjustments have been made to the submodules of the “Indexing” backend module to improve the UX and accessibility. This includes, among other things, the following: * move action links to a dedicated control/button-group column * use badges for label 'Not indexed' * set unique h1 in all submodules * use correct heading levels (h2/h3) * show infobox when either no page has been selected or no results exists and unify locallang labels * add label to back-button in statisticDetailsAction * move back-button to docheader in wordDetailAction Resolves: #103593 Releases: main Change-Id: I078ba09de3c0a9e3ae000231c63b29bc203af8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83733 Tested-by:
-
- Apr 16, 2024
-
-
Stefan Bürk authored
Default value support for TEXT, JSON and BLOB fields has been added with #103578 by implementing the use of default value expression for MySQL. That required to add custom normalization on data schema reads to be comparable. MySQL requires to use a single-quote to quote a single quote in a value string, and due to the expression way this needs to be properly decoded now in two steps: * Revert escape sequences in the retrieved default value * Unquote the unescaped retrieved default value JSON field defaults shows a similar issue for double quotes in the json value and can be fixed in the same way. Added test revealed, that Doctrine DBAL has an issue with double single-quotes for PostgreSQL too. To fix this the issue has been reported [1] and a pull-request provided [2]. This change ensure correct unescaping and unquoting of the retrieved column default value for TEXT, JSON and BLOB column types for MySQL connections, enriched with further tests. The extended PostreSQLSchemaManager now clones method `_getPortableTableColumnDefinition()` to incorporate the bugfix directly until a fixed Doctrine DBAL version has been released. [1] https://github.com/doctrine/dbal/issues/6357 [2] https://github.com/doctrine/dbal/pull/6358 Resolves: #103610 Related: #103578 Releases: main Change-Id: Icb39cdb8c87ae7907f84e5c38adcde4ef545ed1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83745 Tested-by:
-
Benjamin Kott authored
Resolves: #103638 Releases: main, 12.4 Change-Id: Ib5880f2ea62c8d9b54b7db6f6488fc6d5a479827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83836 Tested-by:
-
Willi Wehmeier authored
Add proper focus styles to the nav links in the Link Browser modal window. Resolves: #103631 Releases: main, 12.4 Change-Id: I0abb597124e335c3955c73438ac3cd2f0dad93bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83786 Tested-by:
-
Christian Rath-Ulrich authored
To trigger a search, usually an icon-only button is placed next to the search input field. To improve the accessibility of these icon-only buttons, a visually hidden label is added. Resolves: #102410 Releases: main, 12.4 Change-Id: Ifd7faee3d4c727dd2e86ad7304e19f970b61699e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81800 Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Lina Wolf authored
Remove excess bracket Releases: main, 12.4 Resolves: #103635 Change-Id: Ie9ea1f03457177eeb6be7abb788c05bd2bf64e8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83832 Tested-by:
-
Torben Hansen authored
The new core `HashService` and the deprecated extbase `HashService` have the function `validateAndStripHmac` to validate and strip a given HMAC appended string. The function will throw an exception, if the given string is either too short or the appended HMAC in the string is not valid. In context of a TYPO3 extension, those exceptions are usually thrown, when a given HMAC appended string has been tampered. Logging those exceptions to sys_log or logfiles make no sense, since a TYPO3 site owner have no reasonable possibility to prevent a tampered HMAC appended string being passed to the `validateAndStripHmac` function. This change prevents logging of four exceptions caused by potential manipulated HMAC appended strings. Additionally, a note has been added to extbase `HashService`, that exception codes from that class must be removed in v14 in `AbstractExceptionHandler::IGNORED_HMAC_EXCEPTION_CODES`. Resolves: #103592 Releases: main, 12.4 Change-Id: I2870db815f3348cac2465b1caca711f4736f16db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83774 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Chris Müller authored
As "Hotkeys" is the default export inside hotkeys.js, it must be outside the curly braces. Resolves: #103623 Related: #101507 Releases: main Change-Id: I43cfea685503caa54bc1f7e786e16a01c5e06c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83780 Tested-by:
-
Oliver Bartsch authored
While introducing the new module registration API, the previously used page TSconfig options to hide modules has been replaced by an extended user TSconfig option. This change (page TSconfig -> user TSconfig) is now clarified in the corresponding changelog. Resolves: #103627 Releases: main, 12.4 Change-Id: Ic701cf0674c8ff1ed18273ad2629b2217947f7c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83812 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
- Apr 15, 2024
-
-
Oliver Bartsch authored
The search word is now properly kept on switching between advanced and normal search mode in EXT:indexed_search. Resolves: #103633 Releases: main, 12.4 Change-Id: Ic694e40da3a7bdeee3d76be2402fd4bf8e150e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83787 Tested-by:
-
Kevin Appelt authored
Resolves: #103628 Releases: main Change-Id: I5728324bc922682fcccea2ee90a5cb9eb3f77923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83782 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Andreas Kienast authored
The "Upgrade Wiards" view automatically checks whether mandatory database changes are pending. In that case, a list of tables, fields and indices are rendered. Before the removal of jQuery, a line break was rendered between the list items. However, the migration was not complete, as the line breaks are now rendered as `<br>`. The commit fixes this by creating real `<br>` elements. Resolves: #103613 Releases: main Change-Id: I6896ceeaed30606f55ac4376002552f92224c878 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83784 Tested-by:
-
Benjamin Franzke authored
An invalid site-set fluid condition was added in #103439 that cause the site-set related label to also be printed for `sys_template` record where a button was to be shown instead. Releases: main Resolves: #103629 Related: #103439 Change-Id: I44b970a5fcc9bd84abe12301b98b6967da92e7dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83783 Tested-by:
-
- Apr 13, 2024
-
-
Philipp Kitzberger authored
It's now possible to filter the page tree not only by strings and single uids but by comma-separated lists of uids. Resolves: #103220 Releases: main Change-Id: I6cae67676d438dd3ce3992aee8fe160173ad142c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83153 Reviewed-by:
-
Jasmina Ließmann authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files. An attribute was used twice, this is hereby corrected. Resolves: #103620 Related: #103615 Releases: main, 12.4 Change-Id: I4d813f29db0d64f486c1d5593bc8c2b955a8eafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83777 Tested-by:
-
- Apr 12, 2024
-
-
Andreas Kienast authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files, but one had a typo. It's fixed now. Resolves: #103616 Related: #103615 Releases: main, 12.4 Change-Id: I2e2ab733e5b7186193cd4f8482b4ff6c0a6e0b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83773 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83772 Reviewed-by:
-
Christian Kuhn authored
New version phpdocumentor/reflection-docblock:5.4.0 changed the signature of DocBlockFactory::createInstance(), which now points out a misuse in extbase. The patch changes the instantiation and avoids calling registerTagHandler() since this can and should be hand over to createInstance() directly. Resolves: #103614 Releases: main, 12.4 Change-Id: I344ef7df23dedd950c2775fe2fab93f7bb808786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83750 Tested-by:
-
