Follow-up for PHP 5.3 compatiblity.

Resolves: #56121
Releases: 6.2
Change-Id: I948eb3063c2e6b014b8d69c2011789c7dbe58748
Reviewed-on: https://review.typo3.org/27719
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

As the other tests in GeneralUtilityTest also
getFilesInDirCanOrderByMtime() should use vfs.
Otherwise we might run into random problems if some
mtimes are equal.

Change-Id: Ic5ad10bd5beedb26c00d48602ebd5455525e4826
Resolves: #56121
Releases: 6.2
Reviewed-on: https://review.typo3.org/27717
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

Discarding workspace changes works with the version command
"clearWSID" which might come down to a "delete" action if the
versioned records have a delete or new placeholder (which is
the case for copied or localized elements).
However, the functional tests need to use the "clearWSID"
instead of the "delete" command.

Resolves: #56111
Releases: 6.2
Change-Id: Id10413048a68abdb5ef05bb6e20e6cb6460f9742
Reviewed-on: https://review.typo3.org/27712
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Refactor getFilesInDir to use scandir().

Change-Id: Iafca3e7b7610ef0b11441ef118c85c8e6cc481b8
Resolves: #54095
Releases: 6.2
Reviewed-on: https://review.typo3.org/25768
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

FileContentParser used to issue a warning trying to index image
files with corrupted EXIF data. Suppress these warnings to fail
silently.

Resolves: #55286
Releases: 6.2, 6.1
Change-Id: I863601f5579ab74a0743ab684cf1d898b633edba
Reviewed-on: https://review.typo3.org/27160
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Solution: Add ExtJs css files required by the RTE

Resolves: #56027
Releases: 6.2
Change-Id: I56c81a0119a34097aa8c4a3dd15655cb5a6ca635
Reviewed-on: https://review.typo3.org/27647
Reviewed-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Problem: When the RTE inserts the link, the href looks like
http://somedomain/?file:1234. If a rel attribute is present, the link
is not transformed into a typolink on the way to the database.
However, the href attribute is not transformed, as it should, into a
normal file url. It should because the a-tag will be rendered as is in
the frontend.

Solution: When a link is not be transformed into a typolink,
transform the href into a normal file url.

Resolves: #54944
Release: 6.2
Change-Id: I92c45363ffd62de0f4e89941944f55320d4fc708
Reviewed-on: https://review.typo3.org/27142
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #56067
Releases: 6.2, 6.1, 6.0
Change-Id: I6d1e19026afde81bec46cec3dff9060fa6042c43
Reviewed-on: https://review.typo3.org/27679
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Get the labels for the doktypes from TCA

Resolves: #52955
Releases: 6.2, 6.1
Change-Id: I6d70c11f1711bf191a4ce14a91796819224649da
Reviewed-on: https://review.typo3.org/24934
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

The DataMapper should check if an object is already in the identityMap
before calling fetchRelated, since otherwise the object will be retrieved
from the database again.

Resolves: #53514
Releases: 6.1,6.2
Change-Id: I24e262322f1f0ba3c346fa01c50fa9063866aef7
Reviewed-on: https://review.typo3.org/25252
Reviewed-by: Nico de Haen
Reviewed-by: Fabien Udriot
Tested-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller

This patch improves the regular expression in
ExtensionManagementUtility::executePositionedStringInsertion().

It is made sure that the field name ends with a comma or a line
ending to prevent duplicate insertions of the string when field
names start with the same substring.

Resolves: #55932
Releases: 6.2
Change-Id: I375c40760a38b7f939086bb851911bd7f52509ca
Reviewed-on: https://review.typo3.org/27583
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein

If the Indexer updates metadata during runtimer (after a file object)
has been created, the file object itself is not updated.

This leads to possible errors with image rendering, if files are to be
shown which have not been indexed before.

Releases: 6.2
Resolves: #53772
Change-Id: I70be5ebefe1e00e903694a576847fa8fba167461
Reviewed-on: https://review.typo3.org/27690
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

* create and copy
* create and localize
* modify and discard
* create and copy and discard
* create and localize and discard

Resolves: #56072
Releases: 6.2
Change-Id: Iead056883f7bbb2072a0bd082b05094d7d46101d
Reviewed-on: https://review.typo3.org/27693
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Resolves: #56070
Releases: 6.2
Change-Id: Iaae9944796311d7e453b5374827acf7030e6bdbf
Reviewed-on: https://review.typo3.org/27681
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Brings a discreet :focus style for fields and buttons in ice
blue to complement our favorite TYPO3 orange.

Is introduced for all input fields, input submit & input reset,
buttons and textareas - generally and without exceptions.

Select and multi select fields do not get this focus definition.

Resolves: #55901
Releases: 6.2
Change-Id: I49d958199e29560a766f4687aa76541d07702901
Reviewed-on: https://review.typo3.org/27562
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(TypoScriptFrontendController::checkTranslatedShortcut()).
In menu rendering it's the other way round, the translated
overlay (if any) is used directly - the fallback to use the
"shortcut" value of the original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Change-Id: I26a9eb4813c6b99327043b0a764ec7ff80b6a905
Fixes: #36822
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12765
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

encodeURIComponent is added to escape all special characters in
parameters for AJAX call.

Resolves: #54304
Releases: 6.2, 6.1, 6.0
Change-Id: I3559104e1a26241b519f40a10000637852a4f114
Reviewed-on: https://review.typo3.org/26283
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27640
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #56057
Releases: 6.2, 6.1
Change-Id: I9c1ec60e7518867d27e99681d3d18957a27c4983
Reviewed-on: https://review.typo3.org/27670
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Currently it is not possible to edit files as an editor because no file
uid is submitted. This happens because meta data properties are not
loaded. This patch makes sure they get loaded before returning them.

Resolves: #56035
Releases: 6.2
Change-Id: I610aa50d785ea22cd1f0bc6265369cccf5bdd719
Reviewed-on: https://review.typo3.org/27652
Reviewed-by: Michiel Roos
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

When you try to create one of multiple folders in filemodule
and leave one of the new name input fields empty this results
in a non catched exeption.

This change filters out the empty input fields and gives a
error message when no name is given.

Resolves: #56034
Releases: 6.2
Change-Id: I1d341d1b7951dc8e8fe64190168f8b71c6f75676
Reviewed-on: https://review.typo3.org/27651
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The cleanup done in #55810 breaks the styling of the
inline upload progress queue.

This patch is a followup that removes the use of css class
file_list_normal in for DragUploader. And adds the missing
table css class so the progress queue looks correct again.

Resolves: #56020
Releases: 6.2
Change-Id: I2889041a0d3be82be9b5df462b816a8d5a130d7d
Reviewed-on: https://review.typo3.org/27643
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The thumbnail rendering in filelist clibboard isn't
updated to use FAL. And adding folders to clipboard
with thumbnails enabled results in a fatal error.

This changes makes sure the thumbnail is only rendered
for files and updates the thumbnail part so it uses FAL.

Resolves: #56037
Releases: 6.2, 6.1
Change-Id: I2a0eccd633f5313fed9ab94b5081c13e08892900
Reviewed-on: https://review.typo3.org/27653
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

The classes belonging to the FileCollection types are hardwired
in ResourceFactory::createCollectionObject(), therefore you can
not use your own types.

This change introduces a Registry API that makes it possible to
register your own FileCollection type + class and has a generic
way to add the new type to TCA[sys_file_collection].

How to use:
- Register type in ext_localconf.php
  $register->registerFileCollectionClass(full_class_name, your_type);
- Add type to TCA in Configuration/TCA/sys_file_collection.php
  $register->addTypeToTCA(your_type, label, needed_fields);
  return $GLOBALS['TCA']['sys_file_collection'];

Resolves: #53910
Documentation: #56032
Releases: 6.2
Change-Id: Id6cb1c7a59f741b28fee7bdfef32890f34a072a5
Reviewed-on: https://review.typo3.org/27257
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters

Resolves: #56011
Releases: 6.2
Change-Id: Ia5773bb02c82828896573c8410988d04aa69de68
Reviewed-on: https://review.typo3.org/27666
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Simplifies the method. Avoids using array as intermediate. Work directly
with the string value instead.

Resolves: #53677
Releases: 6.2
Change-Id: I1abcd606a2699e959be1816c88cb147dbf557141
Reviewed-on: https://review.typo3.org/25723
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein

The ContentObjectRenderer creates instances for each content
object to be rendered, e.g. TEXT, COA, CONTENT, etc. However,
these instances are re-used and therefore we introduced work
arounds since serialization of FLUIDTEMPLATE failed back then.
If dealing with nested record sets using RECORDS or CONTENT,
reusing objects might be tricky since the parent pointer to the
ContentObjectRenderer might be wrong and strange things happen.

This patch removes the pseudo singleton approach since the
objects are not state-less and might lead to unexpected
results in rare cases.

Resolves: #55941
Releases: 6.2
Change-Id: I043a31403c05b87e1591f0e0237effa21bf93c98
Reviewed-on: https://review.typo3.org/27586
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The language initialization process is currently split in two main
methods (TypoScriptFrontendController->initLLvars and ->settingLanguage).

Only settingLanguage contains hooks and sets the "sys_language_uid"
property (and "sys_language_content") which determine the displayed
records in Frontend. On the opposite, initLLvars is not hookable and sets
the "lang" property, which may be used by charset conversion methods.

In order to determine display language within hooks, the only way
currently is to call initLLvars a second time after determining language,
but this method populates the "languageDependencies" property without
initializing it. So it is filled two times, which leads to incorrect
labels, especially if the displayed language is English and the
default language is not English (as "languageDependencies" is already
filled with "default language").

The three parts of the patch are:
 * The initLLvars method now pre-initializes the "languageDependencies"
   property.
 * The initLLvars is now called from "settingLanguage" method, right
   after the "settingLanguage_preProcess" hook to avoid a second call it.
 * The convPOSTCharset call is now moved after the language
   initialization, as the language determination done by initLLvars
   can have some impact on charset handling (multi-charset locallang.php
   legacy).

Change-Id: I6924345931342d5114b13e5d6fab417387559b9a
Resolves: #49499
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23529
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Fix a undefined variable and a wrong variable assignment in the
ShortcurtToolbarItem.

Resolves: #55998
Releases: 6.2, 6.1, 6.0
Change-Id: I0f0ebcc846a9aa56edd05e384d62aad8f0a5b05b
Reviewed-on: https://review.typo3.org/27641
Reviewed-by: Markus Klein
Reviewed-by: Stefano Kowalke
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Since #55545 the frameset layout behaves strange in
Chrome and Chromium when you add a new image to
a content element. This is caused by some css set
on the hidden input[file] element.

This patch changes the css to prevent this behaviour.

Resolves: #56018
Releases: 6.2
Change-Id: I8a9b6b7d402ec712cb9b1761b059d2eeebd0ad3e
Reviewed-on: https://review.typo3.org/27655
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Adds an additional check after processing of the ext_emconf.php, throwing
an exception if EmConfUtility::includeEmConf returns FALSE.

Change-Id: Ib1404e2911b8372c5d8ff99aaf2e6313eaf7e157
Fixes: #53210
Releases: 6.2
Reviewed-on: https://review.typo3.org/26741
Reviewed-by: Markus Klein
Tested-by: Markus Klein

We have 3 implementations of the \localPageTree
class in the global namespace:
- db_new.php
- move_el.php
- class.browse_links.php

This patch renames classes from db_new and move_el files.
It should not break non core scripts, as both db_new.php
and move_el.php are entry points, so classes defined
there should only be used in the entry point scope.

The class 'localPageTree' from the class.browse_links.php
will keep its name, so it can be added to autoload now.

Resolves: #55876
Releases: 6.2
Change-Id: I2e084349b93af212aec85b368e7e3468a76c7a82
Reviewed-on: https://review.typo3.org/27572
Reviewed-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

To execute more than one different CommandController at
the same time, every execute call has to use its own request
and response object. Otherwise the request would be already
dispatched for the further tasks.

Fixes: #55362
Releases: 6.2, 6.1 , 6.0
Change-Id: I62ba9cbd2c47a59c7243a1017716b28526bcf6ea
Reviewed-on: https://review.typo3.org/27073
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein

StorageRepository fails to load storages if new one is created.
This is regression to #55186.

Resolves: #55992
Releases: 6.2
Change-Id: I72dc36bb01141695249cf104237f10dfdcfc2b16
Reviewed-on: https://review.typo3.org/27634
Reviewed-by: Steffen Ritter
Reviewed-by: Frans Saris
Tested-by: Steffen Ritter

* load modified typo3conf/extTables.php
* add label for copied records
* add label for localized records
* streamline test assertion of IRRE reference test

Resolves: #56029
Releases: 6.2
Change-Id: I4b60200c568aa17e8d51cae95567fe045bff62c7
Reviewed-on: https://review.typo3.org/27648
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

getClassSchema() is being called within a foreach loop while the
$className never changes for that call.

Change-Id: I699a1a0ab34d784b7463244f218f4e8a0c0b7a0c
Resolves: #55991
Releases: 6.2
Reviewed-on: https://review.typo3.org/27633
Reviewed-by: Marcin Sągol
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

The package manager throws an exception "core" package
already being registered. This is caused by the signal
which instantiates the PackageManager while in
install tool the actual class is FailsafePackageManager

Solution is to not register the slot in install tool
as the failsafe package manager already takes care
of scanning for available packages.

Releases: 6.2
Resolves: #55969
Change-Id: I34b33e4ed947b532c24265e16dcc52a7aac4487e
Reviewed-on: https://review.typo3.org/27616
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Add two new functions to check if 'systemLocale'
setting is correct and if configured 'systemLocale'
supports UTF-8 when 'UTF8filesystem' is set.

Resolves: #55721
Releases: 6.2
Change-Id: Id9edfc896a87d5025a5170690a6b7d6eb25950e6
Reviewed-on: https://review.typo3.org/27510
Reviewed-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert

This patch fixes the condition that checks if an image is selectable
in the "plain" image mode in the RTE.

This fixes a regression that was introduced with #55765.

Resolves: #55939
Releases: 6.2
Change-Id: I92ed00406dcfdba6decb78e2d027f2aa6424ba1b
Reviewed-on: https://review.typo3.org/27585
Reviewed-by: Markus Klein
Tested-by: Markus Klein

To prevent multiple retries when loading information about non existing
classes (e.g. caused by class_exists() calls) the cache is filled with
an empty string when a non existing class is detected.

With this information the class loader can return early and does not
need to run all expensive checks for determining the class file.

Releases: 6.2
Resolves: #53962
Change-Id: I3c7e750bcce8846aaee79ac2d04527be2e31fc16
Reviewed-on: https://review.typo3.org/25679
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel