- Sep 30, 2018
-
-
Wouter Wolters authored
Resolves: #86477 Releases: master Change-Id: I9595a1f1a4d90566d732dcf3c3f8b883a08a6bbe Reviewed-on: https://review.typo3.org/58500 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Tymoteusz Motylewski authored
Make Extbase fetch records in the same way as in TypoScript rendering, making QuerySettings options mean the same as corresponding settings from TypoScript. This change allows e.g. to filter and sort by translated values of the aggregate root. To make upgrades easier a feature switch is introduced which enables the new behavior. It can be disabled with TypoScript if somebody relies on the old behavior. The feature switch is enabled by default in v9 and will be gone in v10 so in version 10 the fixed way will be the only way to fetch records in Extbase. Releases: master Resolves: #82363 Resolves: #84011 Change-Id: I58d0a24c1f73debc6b9251efea9c28c9cf09d6d0 Reviewed-on: https://review.typo3.org/53974 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com>
-
Georg Ringer authored
Remove nested class "form-group" in backend user module form Resolves: #86450 Releases: master Change-Id: I15a46b772d55ee8c0ea6fe9de00ef5a3cf53f27e Reviewed-on: https://review.typo3.org/58468 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
The TypoScript Parser has been around since PHP 4 and hasn't been touched much since 12ys. In order to speed up TypoScript processing in the future, it is important to first streamline all usages and mark internal functionality as "protected" instead of "public". Some other parts for sys_template rendering has been marked as internal as well. Resolves: #86461 Releases: master Change-Id: I4ab0852bc0fb386aa9016b8845f7f8f15a7c3166 Reviewed-on: https://review.typo3.org/58477 Reviewed-by:
-
Benni Mack authored
The extracted extension should use the new DB API. Resolves: #86373 Releases: master Change-Id: Ibcb58f3c795cc888285b61bc7f3e2251f15cd328 Reviewed-on: https://review.typo3.org/58495 Reviewed-by:
-
Benjamin Franzke authored
Neither the backend user authentication should try to perform database queries, nor the extbase services. As a side effect this allows to run the cli tool when LocalConfiguration.php or PackageStates.php are missing, which allows to run commands like `dumpautoload` in that case. Note: *Only* in that case, not if a database connection is configured, but not available – for that usecase failsafe booting will be needed, as proposed in https://review.typo3.org/c/58298/ and/or https://review.typo3.org/c/58300/ As a drive-by we also add a null coalescing operator to IconRegistry::registerModuleIcons() which is currently required because ext_tables.php files are loaded in incorrect order if PackageStates.php is missing (reported in another bug: #86408). Although this workaround will not be strictly required when that bug is fixed, that functions should still properly handle that case. Change-Id: I7d339e21160d25b5aee5dd0e2f25491a22ec83e9 Releases: master Resolves: #86416 Related: #86408 Reviewed-on: https://review.typo3.org/58427 Tested-by:
-
Benni Mack authored
Resolves: #86473 Releases: master Change-Id: I19f499533636b6a187adde51f2a4ca96149cc45f Reviewed-on: https://review.typo3.org/58493 Reviewed-by:
-
Benni Mack authored
The descriptions and listings of site language in FormEngine hasn't been worked on since its introduction. This is now streamlined in terms of wording and grouping, to help people find things in a better way. Resolves: #86470 Releases: master Change-Id: I3692b8466c779b32d8a52d58469e5b87874643fa Reviewed-on: https://review.typo3.org/58489 Tested-by:
-
Claus Due authored
PageRepository is now used independantly from TSFE most of the time, and a new instance is created each time a content element gets rendered. This means that the current cache strategy using class properties gets flushed repeatedly and multiple identical SQL requests to be sent to the DB. By replacing the class property caching with runtime cache which survives across instances, the problem is solved. On some sites this represents a reduction of several hundred SQL requests. Change-Id: Ib606ada46c3c262fd9004a12166b79d80bbc5edb Resolves: #80138 Releases: master Reviewed-on: https://review.typo3.org/51953 Tested-by:
-
Sascha Egerer authored
The mountpoint variable must be respected in the key used for the menu runtime cache. Without that part in the key all links generated to a mount-point sub-page will link to the first mount target page in the menu. Resolves: #80970 Resolves: #62248 Releases: master, 8.7, 7.6 Change-Id: I8ccfebabd515d6da9f78388de51d24603e9fe532 Reviewed-on: https://review.typo3.org/57532 Tested-by:
-
Christian Kuhn authored
Resolves: #86469 Related: #86441 Releases: master Change-Id: Iff35a1be7c436ff3aceab7b9eb82af773278b363 Reviewed-on: https://review.typo3.org/58488 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86468 Related: #86440 Releases: master Change-Id: I1e0cf65d487b8ea95edb7acdad50c671da3277a5 Reviewed-on: https://review.typo3.org/58487 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86467 Related: #86439 Releases: master Change-Id: If14e53972535458ec493454d8e42c48eb67dc35c Reviewed-on: https://review.typo3.org/58486 Reviewed-by:
-
Christian Kuhn authored
To untie authentication services from user authentication a bit better, the fetchUserRecord() method of AbstractAuthenticationService now implements fetchUserRecord() on its own instead of calling the method with the same name of $pObj. AbstractUserAuthentication->fetchUserRecord() is then unused and can be deprecated. Resolves: #86466 Releases: master Change-Id: Ia144ea2dfb8a7c7462ed12875ee35caab9763ba2 Reviewed-on: https://review.typo3.org/58485 Reviewed-by:
-
Jigal van Hemert authored
Flag icons that come with core, the flags that are registered in the icon registry, the lists in sys_language and site_language are now in sync again. Releases: master Resolves: #86460 Change-Id: I1e274b3e274b305486b6e37d600a915177ef484c Reviewed-on: https://review.typo3.org/58476 Tested-by:
-
Josef Glatz authored
Leftover .htaccess files were savedly removed, as the root .htaccess (for Apache webserver) / .web.config (for IIS webserver) already takes care of access rules. Resolves: #86463 Releases: master Change-Id: I1186a5cdd068c2052d3d6ab2a4210d931d8684cd Reviewed-on: https://review.typo3.org/58482 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Benni Mack authored
When an extension author writes a display condition in TCA and by incident uses a wrong format for the displayCondition (see ticket) the strtoupper fails due to the lack of an associative array because it's a numeric-key array. An additional check fixes the issue. Resolves: #79692 Releases: master, 8.7 Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7 Reviewed-on: https://review.typo3.org/58480 Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #85305 Releases: master Change-Id: I01c62adede04f5f74c506c15e28d471ad3185593 Reviewed-on: https://review.typo3.org/57261 Tested-by:
-
Benni Mack authored
A new TCA option for TCA type "slug" is added, called "prependSlash", which adds a "/" in front of the field. For pages (pages.slug), this is mandatory and cannot be configured, as the slug field has to be filled and set to "/" as a base for the root page. For other database fields, this is optional (and disabled by default), and can be enabled via "prependSlash" in TCA config. This option is mostly useful for recursive records, like categories, but for most "flat" structures like "news" or "events", this is not suitable. For pages, it is hard-coded and cannot be (un-)set. Resolves: #86457 Releases: master Change-Id: I997908ed74af7ca21873b0793674e9185cc581ce Reviewed-on: https://review.typo3.org/58474 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Oliver Hader authored
* adds test cases for resolving and generating enhanced links * fixes locale issues when dealing with persisted mappers * removes PersistedAliasMapper.valueFieldName and uses TCA 'uid' field per default, which is required for proper language based resolving as well * introduces language based resolving to PersistedAliasMapper and PersistedPatternMapper Resolves: #86444 Releases: master Change-Id: Ib9c9ea8efc25a8a5adb727f8402a2b6b1e6a1602 Reviewed-on: https://review.typo3.org/58461 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Susanne Moog authored
To allow others to use the new upgrade wizard API the interfaces are no longer marked as @internal. Resolves: #86448 Releases: master Change-Id: I2e146e6d27c5aaed922a004054b3df2bbea88cb8 Reviewed-on: https://review.typo3.org/58466 Tested-by:
-
Benni Mack authored
When hooks modify _GET or _POST parameters, it is important that these changes reflect the PSR-7 request for now, as long as TYPO3 access the _GET/_POST parameters via GeneralUtility::_GP(). In order to move away from global access, we still want to avoid places where it is unclear to use $_GET/$_POST vs. $GLOBALS['TYPO3_REQUEST'] until all parts are completely "global-scope free" for GET/POST parameters. The change adds the initial GET/POST parameters to the request object in the very first middleware of the frontend. If these have been modified when the RequestHandler builds up the content, they are added on top of the PSR-7 request object. Additionally, if the PSR-7 request object has been modified, these changes are put back in the global scope to reliably use _GPmerged within Extbase and Additionally, if _GET/_POST have been modified, a warning will be shown in the TimeTracker to find out that there have been modifications. Until then, it is safe to continue to access _GET/_POST within Hooks and Frontend, however it is highly discouraged to *modify* _GET/_POST directly as this functionality will be breaking in TYPO3 v10.0. Bottom line: This safety net can now trigger deprecation warnings if _GET/_POST have been modified during PSR-15 middleware hooks. Bottom line 2: If these have been modified, they are put inside the current request object. Bottom line 3: If the request object has been modified, global state will be modified ONCE in one place to ensure that we work with the same object during the request phase. Bottom line 4: We cannot get away from the current state of running a TYPO3 Frontend Request from another source, and we try to maintain compatibilty for legacy scripts for now. However, this will be breaking in TYPO3 v10.0. Resolves: #86458 Releases: master Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4 Reviewed-on: https://review.typo3.org/58443 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
RteHtmlParser has never received a good clean up, that's because it was there since PHP 4 ages. In order to rename, reorder code, all internal methods and properties are now declared as protected. Resolves: #86440 Releases: master Change-Id: I204efa8156abcf9ae07a607fa03fa04fbb269885 Reviewed-on: https://review.typo3.org/58457 Reviewed-by:
-
- Sep 29, 2018
-
-
Josef Glatz authored
This patch re-adds a missing functionality to CKEditor. Due to the move from htmlArea to CKEditor, the well-known wordcount information was gone. The wordcount information is added to all existing CKEditor presets per default. In addition, it is now possible to customize the displayed information below the editor. - It's possible to switch paragraph-, word- and/or character count. - You can define if spaces are counted as charactars. - You can define if HTML tags are taken into account. - You can define if linebreaks are taken into account. Beside that, the used plugin enables also setting up maximum values for word- and/or character count. This can be easily used for custom RTE presets. The fact that the global configuration is located in the Base.yaml makes it possible to overwrite settings partially or completely in any inherited RTE preset. With that it is easy possible to realize word/character limits. Following commands were used to add the external package as a dependency and copy the plugin files/folders to the final location: `yarn add --dev ckeditor-wordcount-plugin && yarn build` Resolves: #86395 Releases: master Change-Id: I2c76d7bfebc9a5a57c1f105788af206bdffb00f2 Reviewed-on: https://review.typo3.org/58405 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Benni Mack authored
Normalized Params only needs serverParams and $TYPO3_CONF_VARS[SYS] to work with, so the object is modified in order to simplify further work on the object. Resolves: #86454 Releases: master Change-Id: I30f2c6195468b275e61570c1de67b39f281bb494 Reviewed-on: https://review.typo3.org/58471 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Nikita Hovratov authored
The tooltip has to be removed at that point, because as soon as any data is deleted the row disappears and it's not possible to trigger the mouseout event manually. Resolves: #81856 Releases: master, 8.7 Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698 Reviewed-on: https://review.typo3.org/58463 Reviewed-by:
-
Georg Ringer authored
Sort the extension settings by the extension key. Resolves: #86452 Releases: master Change-Id: I6fb0110820d4a8406f01b617b3279640be9aa743 Reviewed-on: https://review.typo3.org/58470 Reviewed-by:
-
Benni Mack authored
Instead of explicitly call loadJQuery() this should be handled by requireJS or - even better - use vanilla JavaScript instead. Resolves: #86438 Releases: master Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1 Reviewed-on: https://review.typo3.org/58455 Reviewed-by:
-
Benni Mack authored
The following methods will trigger a deprecation warning if they are called from the outside: - TemplateService->prependStaticExtra() - TemplateService->versionOL() - TemplateService->processIncludes() - TemplateService->mergeConstantsFromPageTSconfig() - TemplateService->flattenSetup() - TemplateService->substituteConstants() Several other methods have been marked as internal. Resolves: #86439 Releases: master Change-Id: Ifabbda8048449e6919d054da4111f01065a5eeab Reviewed-on: https://review.typo3.org/58456 Reviewed-by:
-
Benni Mack authored
Install Tool still uses TYPO3's own RequestHandler interface which exists since TYPO3 v7, but is superseded with PSR-15's RequestHandler concept. Install Tool now uses PSR-15 and the old interface in order to still use the priority concept. In a further step, both RequestHandlers should be migrated to Middleware+RequestHandler concept. Resolves: #86451 Releases: master Change-Id: I55cf31a2b803951491ba072969a4cff68ef2c2ac Reviewed-on: https://review.typo3.org/58469 Reviewed-by:
-
Benni Mack authored
The phpDoc comment "@internal" is used in most places during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9 and denotes that this specific method, class or property is not part of the Public API, and does not even need any notice if it is removed. However, we still have/had various places in TYPO3 core where "@access private" was used. This is now migrated to "@internal". "@access public" is not needed and is removed. Resolves: #86446 Releases: master Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700 Reviewed-on: https://review.typo3.org/58462 Reviewed-by:
-
Susanne Moog authored
As the core uses American English, 'analyze' should be spelled with a `z`. This looked especially strange in the install tool, where both spellings were mixed on one card. Resolves: #86447 Releases: master Change-Id: I484f75a05d3cf988baaebf91df30cd936f454eac Reviewed-on: https://review.typo3.org/58454 Reviewed-by:
-
Benni Mack authored
The property "checkWorkspaceCurrent_cache" is now protected. Second method argument of "modAccess()" is deprecated. "isPSet()" is not in use anymore, and will be removed in TYPO3 v10.0. Some other methods, which are workspace-related, are marked as internal in order to properly move them into EXT:workspaces in the next version. Resolves: #86441 Releases: master Change-Id: Ie776e71cdc7485937b2a38e7cfc93c13aba925ab Reviewed-on: https://review.typo3.org/58458 Tested-by:
-
Benni Mack authored
Use @internal where access private was marked, also add some meaning to currently public methods that should only be used by TYPO3 Core. Resolves: #86442 Releases: master Change-Id: If90f1a6dc6cad1edb0db2179cb87f5e6eb18f2ec Reviewed-on: https://review.typo3.org/58459 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benni Mack authored
Page-based routing can now be configured within a site configuration to add so-called "route enhancers" which allow to add more placeholders to a route for a page. There are three Enhancers that TYPO3 now ships with: - SimpleEnhancer - PluginEnhancer - ExtbasePluginEnhancer It is also possible to add custom enhancers by third- party extensions. Each placeholder within an enhancer can receive a so-called "Aspect", usually used for mapping speaking values instead of IDs, or month-names in an archive link, and "modifiers" to modify a placeholder. The simple enhancer transfers a link parameter, previously maybe used to add a `&product=123`, which will now result into `/product/123` for a page. PluginEnhancer adds a namespace, common for simple plugins or Pi-Based plugins, and the ExtbasePluginEnhancer adds logic for multiple route variants to be added, depending on the controller/action combinations. Aspects are processors / modifiers / mappers to transfer a placeholder value back & forth to make each placeholder value more "speaking". TYPO3 Core ships with the following aspects: * LocaleModifier (for localized path segments) * StaticValueMapper (for path segments with a static list) * StaticRangeMapper (for pagination) * PersistedAliasMapper (for slug fields) * PersistedPatternMapper (for database records without slug fields) Routing now returns a so-called "PageArguments" object which is then used for evaluating site-based URL handling and the cHash calculation. It is highly discouraged to access _GET or _POST variables within any kind of code now, instead the PSR-7 request object should be used as much as possible. Releases: master Resolves: #86365 Change-Id: I77e001a5790f1ab3bce75695ef0e1615411e2bd9 Reviewed-on: https://review.typo3.org/58384 Tested-by:
-
Christian Kuhn authored
With the new routing, TYPO3 relies on a default redirect to index.php for FE requests. The patch checks during installation if apache or IIS are used and creates the default .htaccess / web.config files. Change-Id: I9406a7e4d91050d3f5bf96dd63e4bf63e8f71250 Resolves: #86173 Releases: master Reviewed-on: https://review.typo3.org/58451 Tested-by:
-
Anja authored
Change-Id: I6fccf8db0ab996139692a07be8d08ceb8feee86f Releases: master Resolves: #86434 Reviewed-on: https://review.typo3.org/58448 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
lsascha authored
Releases: master, 8.7 Resolves: #86396 Change-Id: I198fe52a8024dcf392582a78c3fce0f134ed6b7a Reviewed-on: https://review.typo3.org/58406 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Christian Kuhn authored
This adds a dummy wizard to remind admins during upgrade to check the live system for argon2i support if the local instance uses it, or to select a different hash algorithm. Having this wizard gives this information to admins early in the upgrade phase, so they have time to check the live system or to select a different mechanism before too many passwords have been upgraded. Resolves: #86402 Releases: master Change-Id: I2b1f75ecf079dc2e29d2675dda558c79b67f77e0 Reviewed-on: https://review.typo3.org/58411 Tested-by:
-
Helmut Hummel authored
During generation of processed files a wrong processed folder is evaluated when the processed folder resides on a different storage. We now ensure to ask the correct storage for the processed folder. Also ensure that correct storage is used for checking file existence when original file and processed files are on different storages. Fixes: #86399 Releases: master, 8.7 Change-Id: I254b9a0bf86a156ae135510a4439e87737ec1a29 Reviewed-on: https://review.typo3.org/58410 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
