- Jan 29, 2014
-
-
Thomas Maroschik authored
In the installer fatals can happen during updates of very outdated extensions. Many updates can lead to a redirect to the extension check where the user gets displayed a message that a fatal has been detected. But the detected fatal error itself is not displayed. This patch passes the error as url parameter to the extension check and displays it there. Fixes: #54943 Releases: 6.2 Change-Id: I111df5d5411015b21c4b2b5e9be3b83b311c8bc5 Reviewed-on: https://review.typo3.org/26781 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Thomas Maroschik Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Functional test bootstrap creates a full new instance within typo3temp together with an own database. Goal is a controlled environment without dependencies to the parent instance. The patch introduces separation of PackageStates.php. The file is now compiled based on a static list of active core extensions and optional additional extensions for specific functional tests. Change-Id: I39e37a16b5cef5b6b1dab2ce3c4e8efc42cecbe7 Resolves: #55409 Releases: 6.2 Reviewed-on: https://review.typo3.org/27108 Reviewed-by: Thomas Maroschik Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Tim Lochmueller authored
Remove two count calls in the often called stdWrap function to increase the performance. Furthermore remove the is_callable calls, because the hook interface take care that the methods exist and are callable. Resolves: #55372 Releases: 6.2 Change-Id: Ifc8f831a7b101c5c56f717c23024fae7b71b71a9 Reviewed-on: https://review.typo3.org/27078 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Xavier Perseguers Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Helmut Hummel authored
If lockSSL is set to 1 and the backend is not accessed via SSL currently a 404 header is sent with no message body. The same happens when the client IP address does not mach the configured list of allowed addresses. Give a more useful hint for users in these cases by throwing an Exception. Resolves: #51378 Releases: 6.2 Change-Id: Ic76d8415c482e78bdea7e57e1cb5dab21a49969f Reviewed-on: https://review.typo3.org/26718 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Tested-by: Georg Ringer Reviewed-by: Oliver Klee Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Marcin Sągol Reviewed-by: Felix Kopp Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
The introduction of a TypeConverter for Enumaration types in #52762 added is_subclass() calls to getPlainValue() in the DatabaseBackends. These methods are meant to convert objects to simply types but are regularly called with simple types, in particular strings. Since is_subclass() also works with strings, The class loader is triggered when these methods are called with a table name like "tx_ext_domain_model_foo". This triggers an issue #55418 in the class loader especially on case insensitive filesystems. Instead of is_subclass we now use instanceof to make sure we only check for conversion if the value is an object. Additionally this change fixes a wrong case statement which also was introduced in #52762 Resolves: #54275 Change-Id: If1b2a28a2623e49dfb47720641935c6f24447c19 Reviewed-on: https://review.typo3.org/27079 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
The JavaScriptEncoder class is used a lot in the TYPO3 backend. It does expensive character conversions, character by character. It would improve performance a lot if we use PHP native json_encode to do the encoding for us. Change-Id: I3cb3bd6d887d49565fda496f9b13852cbeb9dfa1 Resolves: #54560 Releases: 6.2 Reviewed-on: https://review.typo3.org/26545 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Jan 28, 2014
-
-
Felix Kopp authored
Unifies buttons over the backend: + <button> + <input type="submit"> + <input type="reset"> + <a class="t3-button"> Extensions do not need to bring own styling for buttons. Also adds padding and margin to input, buttons. Change-Id: Ie1ab255354a222acfbac9b3260297ff345b6feed Resolves: #55319 Releases: 6.2 Reviewed-on: https://review.typo3.org/27048 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marcin Sągol Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Tim Lochmueller authored
There is a "copy-and-paste" mistake in the domain redirect mechanism. The function HttpUtility::redirect should call with a valid HTTP status code (the const value) and not with the name of the constant. Resolves: #55350 Releases: 6.2, 6.1, 6.0, 4.5 Change-Id: I97f55ac8df1688011198666da1fd322a5c3bd323 Reviewed-on: https://review.typo3.org/27066 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Felix Kopp authored
Removes the find file function from EXT: lowlevel. Find file was only available for admins. Change-Id: I79cedeeef8e8cea9266c893a2c9bd2ab462be482 Resolves: #55134 Releases: 6.2 Reviewed-on: https://review.typo3.org/26928 Reviewed-by: Oliver Klee Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Benjamin Mack authored
With the optimization of the TS parser (see #54856), it is not possible to write TypoScript like this anymore: config { baseUrl = www.mywebsite.com tx_realurl_enable = 1 } The problem is that the TS parser is not allowing tabs after the TS object name (baseUrl). The fix strips away tabs after the TS object name. Resolves: #55357 Releases: 6.2 Change-Id: I880267c2b512e50d6b9e47f469157ea5fd814180 Reviewed-on: https://review.typo3.org/27069 Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Stefan Neufeind authored
Besides fixes this release features "fewer forced layouts" and "lower startup overhead". Change-Id: I988141ccd356425626f68089f9e65c1b04174c23 Releases: 6.2 Resolves: #55367 Reviewed-on: https://review.typo3.org/27076 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
- Jan 27, 2014
-
-
Felix Kopp authored
Configuration arrays should be accessed via $GLOBALS. Modify labels to include the $GLOBALS keyword. Change-Id: Iea3255e8ebcbf5bd23400fe4d597ea5eca421025 Resolves: #55324 Releases: 6.2 Reviewed-on: https://review.typo3.org/27055 Reviewed-by: Marcin Sągol Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Tim Lochmueller authored
Remove the strlen calls in the DatabaseConnection to avoid many string length calculations for the small checks in the query build process. Replace it with a string cast and not identical operator. Resolves: #55370 Releases: 6.2 Change-Id: I0c175671ed51ab3034ffae7c0b812a90218e9f58 Reviewed-on: https://review.typo3.org/27077 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Philipp Gampe authored
Resolves: #55366 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: Ia90d7c85f81828bd23275b7fa4017ee74a758ad6 Reviewed-on: https://review.typo3.org/27074 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
Benjamin Mack authored
As there is the possibility to use grouped caching in order to be more flexible, Extbase should not use hard-coded cache names for clearing the frontend cache (cache_pagesection and cache_pages) but use the group, so other caches could be triggered as well. Releases: 6.2 Resolves: #55044 Change-Id: I8077f889fce7561170bffc7f97c1884c698d673c Reviewed-on: https://review.typo3.org/26866 Reviewed-by: Felix Oertel Tested-by: Felix Oertel
-
- Jan 25, 2014
-
-
Xavier Perseguers authored
The conversion from a class name such as tx_extensionname_domain_model_somename to its corresponding PHP file does not take Extbase naming conventions for the file name. This yields an wrongly-cased file name which will be validated anyway on case insensitive file systems. This wrong conversion may lead to a PHP fatal error Cannot redeclare class VendorName\Extension\Domain\Model\Somename Fixes: #55256 Releases: 6.2 Change-Id: Ibe512945ac01f53844f790bea9f0d0cf58518c54 Reviewed-on: https://review.typo3.org/26999 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Marcin Sągol Reviewed-by: Stefan Neufeind Tested-by: Marcin Sągol Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Jan 24, 2014
-
-
Felix Kopp authored
Use <table class="t3-table"> in backend module. Removes duplicate SASS/CSS definitions in module in order to make use of central core styles. Change-Id: I174d63ab9014ec35842a7bd55863ed0113a669fe Resolves: #55127 Releases: 6.2 Reviewed-on: https://review.typo3.org/26923 Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
The options [BE][unzip_path] and [BE][diff_path] expect different values. Adjust the descriptions accordingly. Resolves: #53964 Releases: 6.2, 6.1, 6.0 Change-Id: Id433091f2be77f5c13304619e080a2d1adfb7b0c Reviewed-on: https://review.typo3.org/25680 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Jan 23, 2014
-
-
Tolleiv Nietsch authored
In case a select field with renderMode "checkbox" is used together with the suggest wizard, clicking the suggestions will not check the related item in the list and therefore the wizard isn't useful anyhow in that combination. Fixes: #21924 Releases: 6.2, 6.1, 6.0 Change-Id: I5823197e9f6bb3f3d4ffc4032677478bd18d87f3 Reviewed-on: https://review.typo3.org/18689 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Steffen Ritter authored
Since the split of sys_file to sys_file_metadata the data is stored in different arrays. The hasProperty method of AbstractFile is not overriden in File to consider that change. Resolves: #54012 Releases: 6.2 Change-Id: Iab2b55e56795033c77c1e3f2969d927ba71a4ceb Reviewed-on: https://review.typo3.org/26688 Reviewed-by: Alexander Stehlik Tested-by: Alexander Stehlik Reviewed-by: Frans Saris Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Eric Chavaillaz authored
Since removing the t3lib folder in TYPO3 6.2, there is no more reason to keep reference to this folder in the example .htaccess file. Resolves: #55265 Releases: 6.2 Change-Id: Ic7f2cff96186551b2aa08c9e785f42c4f8612fce Reviewed-on: https://review.typo3.org/27017 Reviewed-by: Henrik Ziegenhain Reviewed-by: Oliver Klee Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Tomita Militaru authored
Enables the security flag ignoreRootLevelRestriction in order for the sys_category table to be listed in allowed excludefields. Resolves: #53201 Releases: 6.2, 6.1 Change-Id: If2d1ef7fb7d1af943f2ccc13f643014c20b49974 Reviewed-on: https://review.typo3.org/25268 Reviewed-by: Francois Suter Tested-by: Francois Suter Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
Francois Suter authored
The "items" selector in a system categories misses a "size" property. It is thus considered by the forms JS to be a single select field and all items are removed at once rather than the selected one. Resolves: #53665 Releases: 6.2, 6.1 Change-Id: Ice539a42b60a14fd604a9b43ecb4dd48b85d3ae3 Reviewed-on: https://review.typo3.org/27016 Reviewed-by: Francois Suter Tested-by: Francois Suter
-
Tymoteusz Motylewski authored
Category collection test now extends FunctionalTestCase class and is green again. Resolves: #54914 Releases: 6.2 Change-Id: Idc49bcf59b6e2e4ebae5c4f7a232f0b543b6821d Reviewed-on: https://review.typo3.org/26756 Reviewed-by: Oliver Klee Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Fabien Udriot Reviewed-by: Francois Suter Tested-by: Francois Suter
-
- Jan 22, 2014
-
-
Felix Kopp authored
Font-sizes are defined in t3skin at various places multiple times. In order to reduce complexity font-size & line-height should be defined centrally and inherited by containers and elements. Removes few definitions to unify font-sizes and line-heights. Also fixed ExtJS CSS theme. Change-Id: I6493aca9c2dd0fe36c19a65b1e6076b6a181419a Resolves: #52497 Related: #52501 Related: #49592 Releases: 6.2 Reviewed-on: https://review.typo3.org/24299 Reviewed-by: Marcin Sągol Tested-by: Marcin Sągol Reviewed-by: Stefan Neufeind Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
- Jan 21, 2014
-
-
Peter Niederlag authored
* Test typeof TBE_EDITOR == "undefined" in jsfunc.evalfield * Thanks to Stefan Neufeind/Markus Klein for adding the Unittest Resolves: #55093 Releases: 6.2, 6.1, 6.0 Change-Id: I2cc8a5ca3dd6251f89618d3615c1457938ff135e Reviewed-on: https://review.typo3.org/26895 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Henrik Ziegenhain Tested-by: Henrik Ziegenhain Reviewed-by: Wouter Wolters Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Peter Niederlag authored
ExtendedTemplateService ======================= * fix/improve ExtentedTemplateService->lineNumberToScript * don't prepend additional LF in ExtentedTemplateService->ext_outputTS * remove obscure empty line removals in ext_outputTS and ext_formatTS TemplateAnalyzerModuleFunctionController ======================================== * use local $hierarchyInfo to fetch template titles Resolves: #54897 Releases: 6.2 Change-Id: Ia01a89af49d72ed47bef6430042e260af0de3907 Reviewed-on: https://review.typo3.org/26747 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
To make GifBuilder and GraphicalFunctions work in backend context, it is needed to set the absolute path prefix for processed images to document root. It works in FE context, because the current working directory of PHP is document root, but fails in BE context, as the CWD can be anything, depending on the location of the executing script. Set absPrefix to PATH_site in FAL crop scale mask helper so that the FAL file processing can be used in BE context. Resolves: #51804 Releases: 6.0, 6.1, 6.2 Change-Id: I824333dc6f6cff4286d9eefb20c045e5bb207658 Reviewed-on: https://review.typo3.org/23652 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
This change is reverted in favor of a cleaner approach: https://review.typo3.org/23652 This reverts commit 2e463036 Change-Id: I0a297b9ae85e0b02ad3753d752abe4f31f260c12 Reviewed-on: https://review.typo3.org/26975 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Markus Klein authored
Make sure RootlineUtility::enrichWithRelationFields() does take the TCA setting foreign_sorting into account when fetching foreign data for the rootline cache. Resolves: #54884 Releases: 6.2, 6.1 Change-Id: I6f8323bd5a99f9009820332c220a5637e0930712 Reviewed-on: https://review.typo3.org/26727 Reviewed-by: Robert Wildling Tested-by: Robert Wildling Reviewed-by: Steffen Ritter Reviewed-by: Georg Ringer Tested-by: Georg Ringer Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Mathias Brodala authored
Remove duplicate translation entry in locallang_core.xlf Change-Id: Ie550b4a8b9736e397a8ce46d00feb957652d92c0 Resolves: #55153 Releases: 6.2 Reviewed-on: https://review.typo3.org/26966 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Stefano Kowalke authored
When running UnitTests for UpdateExtensionListTask and the extension Scheduler is not loaded will raise an Fatal error because it tries to mock TYPO3\CMS\Extensionmanager\Task\UpdateExtensionListTask which extends from TYPO3\CMS\Scheduler\Task\AbstractTask. It is necessary to skip the whole test case because every single test creates a new instance of \TYPO3\CMS\Extensionmanager\Task\UpdateExtensionListTask(). Releases: 6.2 Resolves: #55192 Change-Id: I81e69c57d58078cf00e4f8e47a1e8d5c7d984177 Reviewed-on: https://review.typo3.org/26954 Reviewed-by: Wouter Wolters Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Georg Ringer authored
As t3lib doesn't exist anymore, get rid of this naming schema. Change-Id: I525db9a511813e1e517c1363e29894b34b80ad48 Resolves: #55149 Releases: 6.2 Reviewed-on: https://review.typo3.org/26934 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Reviewed-by: Marcin S?gol Tested-by: Marcin S?gol Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Benjamin Mack authored
As discussed in the Core newsgroup, the Tidy functionality should be removed from the TYPO3 CMS Core. The checks and options are removed, and a NEWS note is added. An already released replacement was added to the TER. As the importance is very low, and the drop-in replacement in the TER fits nicely, IMHO there is no need for an upgrade wizard, as nothing breaks if the functionality is missing. Every upgrader should read the NEWS anyway in order to know what to do to have the functionality back. Releases: 6.2 Resolves: #55190 Change-Id: I3101b7e09f36cbaa63b6b5d8930f61242e4e2cc6 Reviewed-on: https://review.typo3.org/26952 Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Jan 20, 2014
-
-
Philipp Gampe authored
Avoid calling BackendUtility::getPagesTSconfig() with default or useless parameters. Resolves: #53502 Releases: 6.2 Change-Id: I842c33022a00f5633b1ef5a250d143b6a253dde1 Reviewed-on: https://review.typo3.org/25249 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Georg Ringer authored
There might be situation where very long 'words' (line text without spaces) are rendered in System environment check and that leads to some visual issues. As a solution apply a CSS rule to break the text. Change-Id: Ic096a6a81052f42787cea93a88e05665b50dce5e Resolves: #55120 Releases: 6.2 Reviewed-on: https://review.typo3.org/26937 Reviewed-by: Marcin S?gol Tested-by: Marcin S?gol Reviewed-by: Benjamin Rau Tested-by: Benjamin Rau Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
This exception is required by PackageManager Resolves: #55132 Releases: 6.2 Change-Id: I80d966d581da78802dffd15c6bf27f50633a2f35 Reviewed-on: https://review.typo3.org/26925 Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe
-
Stefan Froemken authored
ImageMagick command was executed from directory typo3/, but output file is relative and starts with typo3temp. This patch adds absolute path to output file when in BE mode. Resolves: #54886 Releases: 6.2 Change-Id: I6216a9bb74b9619c090c1ef70322cb6788a73c92 Reviewed-on: https://review.typo3.org/26729 Reviewed-by: Oliver Klee Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Reviewed-by: Marcin S?gol Tested-by: Marcin S?gol Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Markus Klein authored
The TCA pages misses 'trim' as eval setting for column subtitle. The title field and the subtitle field of pages_language_overlay already have a trim setting applied. Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Resolves: #55113 Change-Id: Icfa441c0010214e3718ed6923ffd7443ce032f81 Reviewed-on: https://review.typo3.org/26933 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Marcin S?gol Reviewed-by: Oliver Klee Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
- Jan 19, 2014
-
-
Felix Kopp authored
Use <table class="t3-table"> in backend module compare view. Change-Id: Icd8fb361a61c6bbfd933fc4b1b011838f18868e8 Resolves: #55139 Releases: 6.2 Reviewed-on: https://review.typo3.org/26929 Reviewed-by: Marcin S?gol Tested-by: Marcin S?gol Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-