- Sep 13, 2018
-
-
Benni Mack authored
The config.defaultGetVars is executed and $_GET is modified, but not the middleware where this method is called. In order to also modify the middleware's request object, the option config.defaultGetVars is also evaluted again in the PSR-15 middleware. Resolves: #86241 Related: #86046 Releases: master Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74 Reviewed-on: https://review.typo3.org/58266 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Daniel Sattler <sattler@b13.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Susanne Moog authored
The recycler doktype should be allowed in rootline in BE. Resolves: #86209 Releases: master Change-Id: I173c2deca5cd395d566a6fd9d6499538ef20d2e6 Reviewed-on: https://review.typo3.org/58243 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Sep 12, 2018
-
-
Anja Leichsenring authored
If an exception identifies itself with a code, display it next to the Exception title. Change-Id: Ib24b7ce4e0bef426dd4e0f4b7f25c4f5338e02c6 Resolves: #86238 Releases: master Reviewed-on: https://review.typo3.org/58260 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Susanne Moog authored
Resolves: #86237 Releases: master Change-Id: Id139dcabb6367b03fb5584a6c7d4a673595eb88e Reviewed-on: https://review.typo3.org/58258 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #86235 Releases: master Change-Id: I1e75309abd8bc1aa38d861dae4a48a958b9750dd Reviewed-on: https://review.typo3.org/58256 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
Double backticks are now replace with single ones, fixed some typos like missing colon. Resolves: #86233 Releases: master Change-Id: I5889a285a5b9a7d65b8bcf7931801298d539e9df Reviewed-on: https://review.typo3.org/58254 Tested-by:
-
Christian Kuhn authored
With latest refactorings, the good old backend module classes BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule (t3lib_extobjbase) are finally unused. These spaghetti classes have been a hindrance to refactor modules that used them for a long time already due to their hard to follow code flow, bad method namings, global variable usages and having everything declared public. It's time to get rid of them to unlock refactoring of controllers and allow dropping of various global variables in v10. Resolves: #86225 Releases: master Change-Id: I3b5bb35b693c7991052f4e0855c2aae4e39f02a1 Reviewed-on: https://review.typo3.org/58249 Tested-by:
-
Alexander Schnitzler authored
The @internal annotation – which is a regular phpDocumentor annotation that is used to denote that associated structural elements are elements internal to the application or library, has been misused by extbase to tell if a command is internal and thus should not be exposed through help texts, user documentation etc. – is deprecated without any replacement. TYPO3 does no longer support the use of the @internal annotation to influence the behaviour of the code. Releases: master Resolves: #85980 Change-Id: I7f3b998b56e270b30e5193d494d35329f5608603 Reviewed-on: https://review.typo3.org/58039 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Georg Ringer authored
Catch exceptions for non existing directories which are imported using the @import syntax for TypoScript and return those as warning in the template module. Resolves: #86230 Releases: master Change-Id: Ie4a6376407eeeaa7a717cb01ede5cabefa8a443f Reviewed-on: https://review.typo3.org/58251 Tested-by:
-
Georg Ringer authored
Resolves: #86226 Releases: master Change-Id: Idcffc65e6e040ab4f09e352f268aa4919c2abc59 Reviewed-on: https://review.typo3.org/58250 Tested-by:
-
Georg Ringer authored
During the refactoring of #85543 a line too much has been removed. Readd the initialisation of $tsfe. Resolves: #86223 Releases: master Change-Id: Icd7bf93fe1d04e845b4a8cc497f171c7429d0d55 Reviewed-on: https://review.typo3.org/58252 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Sep 11, 2018
-
-
Lienhart Woitok authored
If installing a new TYPO3 instance on mysql, utf8mb4 is now used as default charset for the database connection and as default collation. Upgraders may change LocalConfiguration to use utf8mb4, too. They however need to take care of changing their collations and setting according table detaults on their own. A reports status check verifies there is no mixed collation. Resolves: #80398 Resolves: #82080 Resolves: #82551 Releases: master Change-Id: I6bf464a22c6ed74631bf5aacff9c2cfe670077da Reviewed-on: https://review.typo3.org/56440 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Lienhart Woitok <lienhart.woitok@netlogix.de> Tested-by:
Georg Großberger <garfieldius67@gmail.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Benni Mack authored
The cObject FILE has a strange behaviour, and rather became low-level since Fluid's rise in rendering Frontend. FILE shows an image if the file is jpg,jpeg,gif,png (but not SVG), and if has a different file ending, it will check if the file is less than 1MB, it will get its contents and output that. If the file is 1 byte bigger, nothing is done. This _magic_ is sketchy, and obsolete, as Fluid offers more flexibility nowadays. Thus, cObject FILE will be removed from TYPO3 Core in v10.0, however due to the flexibility of custom cObject, an extension author could just re-implement the functionality in a custom extension within minutes. Resolves: #85970 Releases: master Change-Id: I792ec89486e29051da478c5ec0855d2f9cf913a1 Reviewed-on: https://review.typo3.org/58028 Reviewed-by:
-
- Sep 10, 2018
-
-
Oliver Hader authored
The expected behavior is that the copied record is not synchronized when modifying the language parent record (since it is not in connected mode). Resolves: #86215 Releases: master, 8.7 Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc Reviewed-on: https://review.typo3.org/58246 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Christian Kuhn authored
Last patch in the protect controller patch series. This time the Web->Info module controller no longer extends BaseScriptClass and the single sub controller classed don't extend AbstractFunctionModule anymore. The patch sets as much as possible to protected to allow further refactoring of these classes in v10. Resolves: #86210 Releases: master Change-Id: I5c474e6cc0bc093c58b2e939e408b47020547a6b Reviewed-on: https://review.typo3.org/58241 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Christian Kuhn authored
The patch disentangles the tstemplate extension controller classes. The main controller class no longer extends BaseScriptClass and the sub controllers no longer extend AbstractFunctionModule. The classes set as many properties and methods to protected to allow further refactoring of this module in v10. Resolves: #86207 Releases: master Change-Id: If9ad462a423be5f0e370e0894ebb848b822ee66b Reviewed-on: https://review.typo3.org/58240 Tested-by:
-
Christian Kuhn authored
TaskModuleController no longer extends BaseScriptClass. Properties and methods are copied over to the controller and most of them are set to protected. An instance of the controller class is given to single class that fetch and set the one or the other information, so not everything can be made protected. The patch should still allow us to have more refactoring freedom in v10 in this area. Resolves: #86204 Related: #86182 Releases: master Change-Id: I171b22ddbcee67205234b6ca23acf9c95da6ac1b Reviewed-on: https://review.typo3.org/58239 Tested-by:
-
Markus Klein authored
The usage of a 401 header must be accompanied by a valid www-authenticate header, which does not support form-based logins. Resolves: #85411 Releases: master, 8.7 Change-Id: I71062c58a7d846214f1fec41e78cce4ae72955f3 Reviewed-on: https://review.typo3.org/57399 Tested-by:
-
Nicole Cordes authored
This patch fixes an error if no argument was given for a trace step. Resolves: #86211 Releases: master Change-Id: Iee26940df2c463fc0badde245f9da92e73f6740e Reviewed-on: https://review.typo3.org/58242 Reviewed-by:
-
- Sep 09, 2018
-
-
Christian Kuhn authored
To gain freedom in v10 refactoring this controller, the class no longer extends BaseScriptClass, copies over properties and methods from the base class and sets them to protected. Resolves: #85031 Releases: master Change-Id: I3c71ede5f2e00e93b5dc5cd0c9c540540d7e5058 Reviewed-on: https://review.typo3.org/58228 Reviewed-by:
-
Christian Kuhn authored
Protect properties and methods of RecordListController. The two hooks 'drawHeaderHook' and 'drawFooterHook' now receive an instance of the PSR-7 request, handing over the parent object is deprecated and will be removed in v10. The sys_notes hooks are adapted accordingly and used as a migration example in the .rst file. Resolves: #86198 Releases: master Change-Id: Idee82d2e675eefaee1ead7435bc17cfc3a48356b Reviewed-on: https://review.typo3.org/58231 Tested-by:
-
Christian Kuhn authored
Some public -> protected changes for AbstractLinkBrowserController and BrowseLinksController Resolves: #86193 Releases: master Change-Id: I349dd5961ac2d90ede36a17c4d4ca550171e315e Reviewed-on: https://review.typo3.org/58223 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Resolves: #86197 Releases: master Change-Id: I3ad96b95e6e631adfe67ec83db60b8b9d5ec2045 Reviewed-on: https://review.typo3.org/58226 Tested-by:
-
Christian Kuhn authored
Resolves: #86192 Releases: master Change-Id: Id7076427c911af750748e47902e87c1c48b2d2d7 Reviewed-on: https://review.typo3.org/58222 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
- Sep 08, 2018
-
-
Christian Kuhn authored
Core eid and backend dispatching uses only the $request object as argument, but not the prepared $response object anymore. This was a misconception in the first place. The patch deprecates the second argument and logs deprecations by reflecting the target action at runtime. This can be supressed with a new feature toggle. Resolves: #84196 Releases: master Change-Id: I003aba6010957cd82e6910fb718ef531116296be Reviewed-on: https://review.typo3.org/58190 Reviewed-by:
-
Christian Kuhn authored
As far as I could find out, the 'browser' route target class ElementBrowserFramesetController is unused for a while already. I think it is unused since element browser and modal works in v7 and v8, the FormEngine JS browserUrl route target is always wizard_element_browser and searching for other things like the bparams argument reveals no usages, either. The patch deprecates the route and the controller. Resolves: #86178 Releases: master Change-Id: Ifed2e9210ef04f95944ddc2371e1ad616c73715f Reviewed-on: https://review.typo3.org/58208 Tested-by:
-
Christian Kuhn authored
Resolves: #86177 Releases: master Change-Id: Idc357c62b4040165d3a5d04f291b84c69313402e Reviewed-on: https://review.typo3.org/58207 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
rolandgolla <rolandgolla@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- Sep 07, 2018
-
-
Roland Golla authored
Add isset check before use is_array. This will prevent a notice if the array key does not exist. Resolves: #86187 Releases: master Change-Id: I6f74f2200981802ffe2d9ca527ed7230c0d75b27 Reviewed-on: https://review.typo3.org/58215 Reviewed-by:
-
Benjamin Franzke authored
When there is no site configuration, no TCEMAN.preview configuration and no sys_domain record available, the host URL needs to be derived from TYPO3_SITE_URL. This recently broke (and was fixed). Due to wrong logic the protocol was added twice, resulting in URLs like: http://http://hostname.tld/ It initially broke due to the site handling features, probably with https://review.typo3.org/57949 A condition became dead, due to $domain being always set, when it was null before that change (if a sys_domain record could not be found). The bug was fixed by adding an additional condition (without removing the dead "else" condition) in https://review.typo3.org/c/58177/ This patch tries to clean this up by removing the new condition (introduced in #58177) and rather restructure the code. To circumvent those bugs and to avoid confusion what $domain actually refers to (now always including the protocol) the code is refactored to not re-assign $domain over and over again. Change-Id: I155db1b91357bb6345da1ef469d32b0125344b16 Releases: master Resolves: #86140 Reviewed-on: https://review.typo3.org/58182 Tested-by:
-
Christian Kuhn authored
Using a custom renderType instead of a userFunc for type=user TCA elements is much more flexible and suits better into the overall FormEngine node construct. The patch deprecates userFunc and outlines details on how existing ones can be migrated over to custom renderTypes without much hassle. Resolves: #86163 Related: #86109 Releases: master Change-Id: I2bad5f79dab5643efe7f8dc959e788b9426bfdd6 Reviewed-on: https://review.typo3.org/58198 Tested-by:
-
Christian Kuhn authored
Resolves: #86182 Releases: master Change-Id: I80b8b519ad530d5d98e284e0666cd6c2eb3f5603 Reviewed-on: https://review.typo3.org/58212 Reviewed-by:
-
Christian Kuhn authored
There are only two methods in the report controller, calling them via call_user_function() does not make much sense. The patch simplifies the dispatcher logic and sets the two actions to protected. Note this does not affect the extendability of the reports module itself. Resolves: #86184 Related: #84231 Releases: master Change-Id: Ia329b7de7251825028a5587899be3f6c694873e5 Reviewed-on: https://review.typo3.org/58214 Reviewed-by:
-
Anja authored
In order to create workspace stage records, the parenttable field must not be a tinytext, else the not null restriction fails on SQlite. Change-Id: I38cb8fca0eb293100ab7d73433cc284307eb1d0d Resolves: #85405 Releases: master Reviewed-on: https://review.typo3.org/58210 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Andreas Fernandez authored
If root pages are configured in workspaces, such pages must not get rendered in the sites module. The BackendWorkspaceRestriction is added to prevent fetching such pages in the LIVE workspace. Resolves: #86174 Releases: master Change-Id: I35a614d41125516a65cd1d2bce917c04f6af57ac Reviewed-on: https://review.typo3.org/58202 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Georg Ringer authored
The site module displays now also sites with no valid related page anymore. This can happen if the page is being removed. Resolves: #86150 Releases: master Change-Id: If75a33e6c2d189abd42746b52d0b828b7a7b38cb Reviewed-on: https://review.typo3.org/58192 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Timo Hund <timo.hund@yahoo.com> Tested-by:
-
Andreas Fernandez authored
When the slug is calculated by using the according button, the `event` is now triggered to let the user know that the field value has changes and to invoke the "You have unsaved changes" modal when closing the form. Resolves: #86190 Related: #86077 Releases: master Change-Id: I6eb4e11252562f53e637e3a1abdd7b02a8f73a5a Reviewed-on: https://review.typo3.org/58218 Reviewed-by:
-
Oliver Hader authored
Resolves: #86191 Releases: master Change-Id: Ie65dac040f720c313835603bd2446a15e6670c14 Reviewed-on: https://review.typo3.org/58220 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
If a relation field (select / group) does not exist in db for whatever reason, System -> DB check -> Database relations crashes. Resolves: #86167 Releases: master, 8.7 Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982 Reviewed-on: https://review.typo3.org/58201 Tested-by:
-
Christian Kuhn authored
Resolves: #86180 Releases: master Change-Id: I6277be526cb11d1c6120f13e763d47405aac84d0 Reviewed-on: https://review.typo3.org/58211 Tested-by:
-
Christian Kuhn authored
Resolves: #86179 Releases: master Change-Id: Ie61ab04889e36b5290a0d8f4fc1fb68dd95a87ac Reviewed-on: https://review.typo3.org/58209 Tested-by:
-
