- Mar 01, 2018
-
-
Josef Glatz authored
Add missing TCA configuration for descriptionColumn in sys_file_collection records. The database column already exists in ext_tables.sql. Change-Id: I696e982145604114181240bef321683569187bcd Resolves: #84093 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55953 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Feb 28, 2018
-
-
Georg Ringer authored
Avoid using a prepared statement to return the final query part. Resolves: #84022 Releases: master, 8.7 Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a Reviewed-on: https://review.typo3.org/55914 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Sven Juergens <typo3@blue-side.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Josef Glatz authored
The space between the time amount and time unit must be added directly in the code, as it's not possible to add a leading space character in a localized string on our translation server. - use GeneralUtility::trimExplode() for localized label parameter - add space directly in the code instead of the LLL string Already translated strings must not be adopted. Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d Resolves: #84088 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55948 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
Patch for issue #83971 is only an Important change, not a breaking change and belongs to the 8.7.x documentation folder to stay in sync with v8 Change-Id: I1314eda5dbf90af5e61b940ad1431b82bd28b0de Resolves: #84086 Related: #83971 Releases: master Reviewed-on: https://review.typo3.org/55945 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benjamin Franzke authored
As documented in Bootstrap code, GeneralUtility should be used instead of Bootstrap to retrieve the ApplicationContext. Therefore ClassLoadingInformation is adapted to read the ApplicationContext from GeneralUtility. Bootstrap now pushes the ApplicationContext early to GeneralUtility to be available for ClassLoadingInformation during bootstrap. Change-Id: I119ac944dd49c7d063b0f1e05f23e48f664ce2bc Releases: master Resolves: #84083 Reviewed-on: https://review.typo3.org/55940 Tested-by:
-
Frank Naegler authored
Google Chrome deprecated the browser notification API for unencrypted origins. For this reason we now use an additional check to prevent deprecation warnings in the console and disable this feature for instances without SSL/TLS. Resolves: #83971 Releases: master, 8.7 Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb Reviewed-on: https://review.typo3.org/55916 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Benjamin Franzke authored
Do not use global state from Bootstrap::getInstance(), rather pass the requestId from LogManager through the Logger to the LogRecord. We do not have a core object container yet, therefore Bootstrap now creates a LogManager, injects the requestId and stores that instance as singleton in the GeneralUtility singleton storage. Change-Id: Ia9af3c3a0e029a3748045fcf73e92f874f4a37ba Releases: master Resolves: #84082 Reviewed-on: https://review.typo3.org/55938 Tested-by:
-
Benjamin Franzke authored
As all request type specific initialization has been refactored to the Application classes, request type specific code in Bootstrap is unused [1] and can be removed. [1] redirectToInstallTool() is actually still in use, but moved into the frontend and backend Application classes with this change. (Also make their parent class abstract as drive-by change.) Change-Id: Ieded3603c2936d83d3d4701abef6c3884b558e31 Releases: master Resolves: #83869 Reviewed-on: https://review.typo3.org/55692 Tested-by:
-
Helmut Hummel authored
Renumbering array keys, even if all keys are integer is a destructive operation. Doing so at least breaks our logging configuration, which uses LogLevel constants as array keys and these constants are defined as integer. Therefore this pure visual optimization is removed when writing LocalConfiguration.php At a later point we might consider deprecating this method, which at least has a wrong method name (mentions "numeric", while it meanwhile uses "int" checks). As this method performs a destructive operation, its usefulness is limited. Resolves: #82304 Releases: master, 8.7, 7.6 Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d Reviewed-on: https://review.typo3.org/55936 Tested-by:
-
Markus Klein authored
For Apache HTTP versions 2.3+ there is a better way to avoid conflicts in priority of sections. Since the `if` condition has been introduced it is ranked the highest priority, hence it is most suitable for rules to protect sensitive data. Resolves: #81849 Releases: master, 8.7 Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9 Reviewed-on: https://review.typo3.org/55937 Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
-
Georg Ringer authored
Simplify the sys_note handling by removing extbase from it Resolves: #84055 Releases: master Change-Id: Ib41d5e88c7ec9d79ee23dc913c3dc1ee0184c372 Reviewed-on: https://review.typo3.org/55804 Reviewed-by:
-
Tobias Kretschmann authored
Log a warning message if the configured TYPO3 backend login - logo or - background image can't get resolved. Change-Id: I782a9b08650d9b2f9cfb3cefb9c4ba18577d5a7d Resolves: #84050 Releases: master Reviewed-on: https://review.typo3.org/55911 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Georg Ringer authored
Provide a ViewHelper to render the markup to show an icon for files and folders. Resolves: #83942 Releases: master Change-Id: I44a99f3e06dc35b98b3e29f509432a8575c29807 Reviewed-on: https://review.typo3.org/55759 Reviewed-by:
-
Frans Saris authored
Releases: master, 8.7 Resolves: #84069 Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824 Reviewed-on: https://review.typo3.org/55927 Reviewed-by:
-
Benedikt Huß authored
Evaluate number of total items and trigger subsequent requests to process the remaining items, so that all changes are actually processed. Resolves: #84037 Releases: master, 8.7 Change-Id: I92f388b50328320973abcc290de52083f05655dd Reviewed-on: https://review.typo3.org/55933 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Benni Mack authored
The unused BE_USER method setWorkspacePreview() updates a DB field called "workspace_preview_id" which just does not exist at all. It would lead to an SQL error if called. However, since this method is never called, nor evaluated since TYPO3 6.2, all functionality should be removed. Previewing a workspace is handled via `be_users.workspace_id` anyway. Resolves: #84021 Releases: master Change-Id: I706e893aef1faaccf6e43f0e66ac28bff79190d8 Reviewed-on: https://review.typo3.org/55871 Reviewed-by:
-
Andreas Fernandez authored
Change-Id: Iafb5d62329d70704aac0dc73f8a6254e2745ffea Resolves: #82611 Releases: master Reviewed-on: https://review.typo3.org/55894 Tested-by:
-
Frank Naegler authored
Needs a typo3/testing-framework raise, too. Commands: yarn upgrade jquery composer update typo3/testing-framework Updates: - jquery@3.3.1 Resolves: #84063 Releases: master Change-Id: Iec4e821ebeb42c46da7d379ea081f3c0f25cc112 Reviewed-on: https://review.typo3.org/55921 Reviewed-by:
-
Claus Due authored
This patch adds a try/catch around the call in TSFE to get page and rootline with domain and makes getPageShortcut function set $this->pageNotFound code, then throw error. Change-Id: Id6aae04d7b4c2a8b267b0d949c056471c3a6b01b Releases: master Resolves: #78831 Reviewed-on: https://review.typo3.org/50805 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
-
Andreas Fernandez authored
Commands: yarn upgrade grunt-contrib-uglify --latest Upgrades: uglify-js 2.7.5 > 3.3.12 Change-Id: I082a92d87ef1616488c0d8ddcf3801617a37eb50 Resolves: #84075 Releases: master Reviewed-on: https://review.typo3.org/55932 Tested-by:
-
Ralf Zimmermann authored
Avoid PHP warnings within ext:form DatePickerViewHelper if the property properties.additionalAttributes.placeholder is not defined within the form definition. Releases: master, 8.7 Resolves: #84065 Change-Id: I49e0bb3a9548f0be402e1a4794c60c1b42744fac Reviewed-on: https://review.typo3.org/55922 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Frank Naegler authored
Commands: yarn upgrade chosen-js Updates: - chosen-js@1.8.3 Resolves: #84061 Releases: master Change-Id: Ic22da5e322ac5ad969f72cedfe7593e3976dff4d Reviewed-on: https://review.typo3.org/55920 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
The TSFE method "determineId" is hard to read, mostly due to the fact that it first evaluates preview settings from admin panel or logged-in backend users, and then calls "fetch_the_id()" possibly multiple times. In order to increase readability, the preview settings evaluation is moved into a custom protected method within TSFE. Resolves: #84056 Releases: master Change-Id: I9611801b77ab10f0e9407f2c558cbec1867cc560 Reviewed-on: https://review.typo3.org/55913 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Feb 27, 2018
-
-
Frank Naegler authored
Commands: yarn upgrade grunt yarn upgrade grunt-sass yarn upgrade jasmine-core Updates: - grunt@1.0.2 - grunt-sass@2.1.0 - jasmine-core@2.99.1 Resolves: #84059 Releases: master Change-Id: I833e2883c49a20cb5d748cb9d96b9e0cfb3f0d79 Reviewed-on: https://review.typo3.org/55918 Tested-by:
-
Frank Naegler authored
Commands: yarn upgrade @types/bootstrap yarn upgrade @types/jasmine yarn upgrade @types/jqueryui Updates: - @types/bootstrap@3.3.38 - @types/jasmine@2.8.6 - @types/jqueryui@1.12.2 Resolves: #84058 Releases: master Change-Id: I0cca00b6acc1cf8b4d9ed5ce1c09b73dc5bcfc07 Reviewed-on: https://review.typo3.org/55917 Tested-by:
-
Frank Naegler authored
Command: yarn upgrade codemirror Updates: - codemirror@5.35.0 Resolves: #84060 Releases: master Change-Id: I5e62d8ba0a7e2e51143a4d0438b7220ef72f80d1 Reviewed-on: https://review.typo3.org/55919 Tested-by:
-
Susanne Moog authored
The admin panel consisted of one big god class that contained the complete rendering. The hook to extend the admin panel only allowed to add content but not to add new modules (with expandable headers). The code has been refactored as a first step for a more flexible admin panel: - All modules are now rendered by a class per module - Modules have an interface - Modules can be registered in ext_localconf (and overwritten) using the dependency ordering service for priority - All new classes are strictly typed Related: #84044 Resolves: #84045 Releases: master Change-Id: I124bb503907dcfcbd4425d6f7178b87562d2fda4 Reviewed-on: https://review.typo3.org/55890 Reviewed-by:
-
Markus Klein authored
Add a new test to make sure that identical input arrays also deliver an empty result as difference. Resolves: #84067 Releases: master, 8.7, 7.6 Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e Reviewed-on: https://review.typo3.org/55923 Reviewed-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Andreas Fernandez authored
Change-Id: I3fb32010cbbf319ddc35a9c0e13a771625e9c5be Resolves: #82598 Releases: master Reviewed-on: https://review.typo3.org/55910 Tested-by:
-
Benni Mack authored
Use shortening parameters on places that haven't been touched in a while since PHP 7.0 was a requirement. Fix PHPdoc comments on various places. Use booleans instead of integers on variables clearly defined and evaluated as booleans. Resolves: #84057 Releases: master Change-Id: If0ef1a58622a98f4ae5769f953c4c62121abdc89 Reviewed-on: https://review.typo3.org/55915 Tested-by:
-
- Feb 26, 2018
-
-
Andreas Fernandez authored
Change-Id: I070facc7961d59b2151178810f3b77e6928607e0 Resolves: #82601 Releases: master Reviewed-on: https://review.typo3.org/55902 Tested-by:
-
Andreas Fernandez authored
The SplitButtons module is migrated to TypeScript. Additionally, some parameters of the Icons module are declared as optional. Change-Id: I61f883e8e496e018a45f63c303de66274d071d94 Resolves: #82602 Releases: master Reviewed-on: https://review.typo3.org/55906 Tested-by:
-
Andreas Fernandez authored
The arguments `overlayIdentifier`, `state` and `markupIdentifier` are not required most times. This patch declares these arguments as optional. Change-Id: Id6d372be1d814763f2bf432254ac34b6b0d39f54 Resolves: #84048 Releases: master Reviewed-on: https://review.typo3.org/55909 Tested-by:
-
Andreas Fernandez authored
Change-Id: I7783157819cebea7c4ee55a0b0612483daf9cbf3 Resolves: #82582 Releases: master Reviewed-on: https://review.typo3.org/55907 Tested-by:
-
Andreas Fernandez authored
Change-Id: Ic71a3dde434402ad828e2098eefae80f4039475b Resolves: #82596 Releases: master Reviewed-on: https://review.typo3.org/55847 Tested-by:
-
Paweł Rogowicz authored
Additionally add a console warning when doktype doesn't have an icon Releases: master, 8.7 Resolves: #84018 Change-Id: If220a53e1dacf4d5b4fabdfcfc25331e83fe6811 Reviewed-on: https://review.typo3.org/55904 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Benjamin Franzke authored
There is Bootstrap::getInstance()->getEarlyInstance() and GeneralUtility::makeInstance() to retrieve (global) early instances. Sometimes the former, sometimes the latter is used (e.g. to retrieve the PackageManager). Classes should not know whether something is an early instance or not. Implementation details like that should be abstracted into a singleton container. That (currently) is GeneralUtility::makeInstance(). As there is no obvious reason why different methods are used, we now use GenerallyUtility::makeInstance() to retrieve singletons. Add all early singleton instances to the GeneralUtility singleton array and stop using Bootstrap::getEarlyInstance in classes outside Bootstrap. One exception to this is the composer ClassLoader. That (obviously) does not implement the TYPO3 SingletonInterface. We now push that instance to ClassLoadingInformation during the bootstrap. (similar to how the PackageManager is pushed to the ExtensionManagementUtility). Releases: master Resolves: #83966 Change-Id: Icf3bef5f51a6142d9d1dcdc9b3700a86d7bb7f78 Reviewed-on: https://review.typo3.org/55802 Tested-by:
-
Andreas Fernandez authored
Change-Id: Iab7de8a076a8d0d9249504dd487278e57a6b9ba4 Resolves: #82606 Releases: master Reviewed-on: https://review.typo3.org/55891 Tested-by:
-
Benni Mack authored
Frontend-related hooks are migrated into a PSR-15 compatible middleware to initialize workspace behaviour and previewing functionality. Resolves: #84040 Releases: master Change-Id: I8a86665aad95a84d4d65700949d861b96d006c13 Reviewed-on: https://review.typo3.org/55899 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Benni Mack authored
The third parameter in PageRepository->getDomainStartPage is not used anymore. Saving an extra call to GeneralUtility to not hand this parameter over to the method in TSFE should be helpful. However, in the future, this method will probably be changed, the third parameter is not deprecated for now. Resolves: #84043 Releases: master Change-Id: I397dd86d703f4fa5778794209e90ffaa82baf872 Reviewed-on: https://review.typo3.org/55901 Tested-by:
-
