- Apr 01, 2024
-
-
Albrecht Köhnlein authored
When opening the "tile view" in the backend, third party FAL adapters may not correctly return 'mtime' and 'ctime' as integers. This already is fixed in the main branch but can occur in TYPO3 12 LTS as well, therefore relevant changes are picked from #101469. Resolves: #103495 Related: #101469 Releases: 12.4 Change-Id: Ibdcf878da63ff0c79dd1dba8ac28f6f7f68e7a0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83616 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Mar 25, 2024
-
-
Oliver Bartsch authored
At various places, it's possible to edit the metadata of a file in the default language. However, users might not have access to the default language. To prevent moving to FormEngine and facing access permission errors, those places now use proper language access checks and do not display corresponding action if the user does not have access. Resolves: #103432 Releases: main, 12.4 Change-Id: I22c3755a17888cfc623ce05b25fd655b323cc553 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83583 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Lina Wolf authored
A backport to 11.5 is not possible due to too many issues in the Docs that cannot be backported automatically. Change-Id: I32e957ec8b41059e8eb8ddfd17f80f08c3ea454d Resolves: #103479 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83543 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Mar 23, 2024
-
-
Benjamin Franzke authored
The page tree in TYPO3 v11 and v12 has a default timeout of 300ms for click events to be processed (in order to wait for double-click detection). This caused race conditions in tests since code that waited for #nprogress to hide after clicking on the pagetree did not have anything to wait for (yet), because the progress loaded was only triggered 300ms later, when the click was detected to not be a double click event and the content frame was started to be updated. Also remove wait timeout that were implicitly added for the same issue, but were spread throughout the test cases. Resolves: #103473 Releases: 12.4, 11.5 Change-Id: Ie9c9aff8c8a36581555a9ad352fb98b3d446ba42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83576 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Mar 22, 2024
-
-
Christian Ludwig authored
Fixes the Doctrine error: Incorrect integer value: '' for column 'editlock' at row 1 Releases: main, 12.4, 11.5 Resolves: #103461 Resolves: #103462 Change-Id: I0e3f0344157f66c07681bd29a47f4f51e32e4225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83541 Reviewed-by:
-
Stefan Bürk authored
`SiteBasedTestTrait` created a instance of the `SiteConfiguration` using the PHP `new` keyword for writing functional test instance site configurations. It is possible, that the `SiteConfiguration` is retrieved from the `Dependency Injection container` by code executed before the test releated site configuration is written, which does not reset the instance based `SiteConfiguration->$firstLevelCache` property and later retrieving site configurations using the `SiteFinder`, for example in rootline and other operations, cannot find the test instance configurations. This change now uses the `SiteConfiguration` from the test instance `Dependency Injection container` which ensures that the internal first level cache is properly reset on `write()` actions. Resolves: #103470 Releases: main, 12.4 Change-Id: I70368e56abd10e55f06d3813371c4538ad704136 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83540 Tested-by:
-
Stefan Bürk authored
New core-testing-* images have been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-php81 => 2.12 * core-testing-php82 => 1.12 * core-testing-php83 => 1.13 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/ebdaefdb54a4fe970abf0cb1d32567bbd6339de5 [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/21f88537fab0a6c5be866c602f206acdb289a20a Resolves: #103469 Releases: main, 12.4, 11.5 Change-Id: I35ffd10e7979d4fd59aab5a7fa5d52330e71e0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83537 Reviewed-by:
-
Oliver Bartsch authored
When removeByType is used to remove restrictions from the container, it is now ensured that also cross classes are properly respected. Resolves: #103456 Releases: main, 12.4 Change-Id: I4841fe1cba7388358771cf01ee220afa4482349a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83539 Tested-by:
-
Oliver Bartsch authored
Unset non matching key arrays and additionally secure the array access with a corresponding check. Resolves: #102241 Releases: main, 12.4 Change-Id: If034faf04f52f6e8882dd0b610fa5dfdf9ec2298 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83570 Reviewed-by:
-
Lina Wolf authored
Resolves: #103424 Releases: main, 12.4 Change-Id: I3c2da18a3d09e78fe9b72113e1a7332942bde715 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83536 Tested-by:
-
- Mar 21, 2024
-
-
Andreas Kienast authored
This commit checks whether `eval` and `is_in` are not empty before they are used as "input params" for the JavaScript part of the FormEngine. Also, a plausibility check is added to ensure `eval=is_in` and a non-falsy `is_in` configuration are given. Resolves: #103184 Releases: main, 12.4 Change-Id: I23da4483f1b35b0720ce59d07847fe01ead9a461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83561 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Mar 20, 2024
-
-
Jasmina Ließmann authored
Resolves: #103429 Releases: main, 12.4 Change-Id: Id8ab8e745a316f8af0abcfe495b7174f0afe1b96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83535 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Andreas Kienast authored
This commit adds `_ga` to the `excludedParameters` configuration used for the cHash calculation. Resolves: #103435 Releases: main, 12.4, 11.5 Change-Id: I5c79c9264d1d8f09f45db947d714d27b3da4fb00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83533 Tested-by:
-
- Mar 19, 2024
-
-
Benjamin Franzke authored
* Always clean-up containers when Control-C is pressed * Enforce removing networks even if some containers have not been fully stopped (does not work with older docker versions, therefore only enabled for podman) * Bail out if `waitFor` failed instead of resuming with subsequent commands * Avoid waiting unnecessarily for VNC-web port 7900 in headless mode * Do not derive `--pull=never` from the `$CI` environment variable, as `$CI` is set both in gitlab [1] and github [2] actions. runTests.sh might be used in github actions, therefore this flag is moved into our gitlab-ci specific configuration. * Fix typos [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html [2] https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables Resolves: #103420 Releases: main, 12.4, 11.5 Change-Id: Ie8fcdc5ebc5ba651242bb54faffdfd8de0dc6026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83518 Tested-by:
-
Stefan Bürk authored
Doctrine DBAL 3.x has been introduced into TYPO3 v12 with #96287 and raised over the time, adding the one or other deprecation and dual code branches and some compat layers. The `\Doctrine\DBAL\Schema\Comparator::compareSchemas()` for example is still static and instantiaces itself, and therefore not properly handing over the platform. The missing platform does not execute the new way of using `AbstractPlatform::columnsEqual()`, but renders the platform specific handlings useless - specially added for MySQL based platforms, for example the datbase type `TEXT` length check and comparision. This change passes the platform down to the inner `Comparator` instance to ensure that the platform specific handling can work. To avoid the new way using the `AbstractPlatform::columnsEqual()` which introduces incompatible checks for now, that method is overriden and the `diffColumn()` check used. That allows the proper TEXT sub-type handling with MySQL and MariaDB while supressing noise for now. Note: This is also done currently in TYPO3 v13. Resolves: #103348 Related: #96287 (Doctrine DBAL 3.2) Releases: 12.4 Change-Id: If130c73ff122d09a50158bc3ac53f28f9a4eb749 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83457 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christophe Monard <contact@cmonard.fr> Reviewed-by:
Developer Archriss <typo3@archriss.com> Tested-by:
-
Benni Mack authored
Change-Id: I03729854c268a32ba072d891d4701d42ba5d365d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83517 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Change-Id: I981c2fe620a96ce344730b184ce60e7aa17a6aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83516 Reviewed-by:
-
Benjamin Franzke authored
This commit updates ckeditor5 to v41.2.1. It fixed a recent regression where importing documents from Word with suggestions caused CKEditor 5 to crash. See changelog at https://github.com/ckeditor/ckeditor5/releases/tag/v41.2.1. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.2.1 \ @ckeditor/ckeditor5-autoformat@^41.2.1 \ @ckeditor/ckeditor5-basic-styles@^41.2.1 \ @ckeditor/ckeditor5-block-quote@^41.2.1 \ @ckeditor/ckeditor5-clipboard@^41.2.1 \ @ckeditor/ckeditor5-code-block@^41.2.1 \ @ckeditor/ckeditor5-core@^41.2.1 \ @ckeditor/ckeditor5-editor-classic@^41.2.1 \ @ckeditor/ckeditor5-engine@^41.2.1 \ @ckeditor/ckeditor5-essentials@^41.2.1 \ @ckeditor/ckeditor5-find-and-replace@^41.2.1 \ @ckeditor/ckeditor5-font@^41.2.1 \ @ckeditor/ckeditor5-heading@^41.2.1 \ @ckeditor/ckeditor5-horizontal-line@^41.2.1 \ @ckeditor/ckeditor5-html-support@^41.2.1 \ @ckeditor/ckeditor5-indent@^41.2.1 \ @ckeditor/ckeditor5-link@^41.2.1 \ @ckeditor/ckeditor5-list@^41.2.1 \ @ckeditor/ckeditor5-paragraph@^41.2.1 \ @ckeditor/ckeditor5-paste-from-office@^41.2.1 \ @ckeditor/ckeditor5-remove-format@^41.2.1 \ @ckeditor/ckeditor5-show-blocks@^41.2.1 \ @ckeditor/ckeditor5-source-editing@^41.2.1 \ @ckeditor/ckeditor5-special-characters@^41.2.1 \ @ckeditor/ckeditor5-style@^41.2.1 \ @ckeditor/ckeditor5-table@^41.2.1 \ @ckeditor/ckeditor5-theme-lark@^41.2.1 \ @ckeditor/ckeditor5-ui@^41.2.1 \ @ckeditor/ckeditor5-undo@^41.2.1 \ @ckeditor/ckeditor5-utils@^41.2.1 \ @ckeditor/ckeditor5-word-count@^41.2.1 npm install --save-dev \ @ckeditor/ckeditor5-dev-utils@^39.6.3 npm run build Resolves: #103421 Releases: main, 12.4 Change-Id: I19bc3c823bffa99a6055514edcfb8d03c37e4098 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83513 Tested-by:
-
Benjamin Franzke authored
All applicable acceptance tests are now also executed in composer mode. Tests that check classic-mode specific functions are excluded and are therefore now tagged as classic-mode test. The composer mode instance is generated with our CLI setup tools, allowing to mimic the realworld case where a instance is creating via our setup tools instead of from fixtures (which we still use for classic mode tests, but try to reducde/avoid for composer mode tests). The existing existing classic-mode test acceptance test execution will keep running as-is. The v12 backport additionally imports pieces from #102440 as t3editor extension is enabled in this composer-mode, while v12 classic mode is tested (for historic reasons) without t3editor extension enabled. Commands executed: > composer require --dev "typo3/cms-styleguide":"^12.0.5" Resolves: #103297 Releases: main, 12.4, 11.5 Change-Id: I64973f110931b51ed2ef7ef8f8cc3411834fcf37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83263 Reviewed-by:
-
- Mar 18, 2024
-
-
Willi Wehmeier authored
The used ll keys used in the javascript code for the inline pagetitle edit feature in the page and recordlist module aren't set correctly in the corresponding templates. This patch solves that mismatch. Resolves: #103419 Releases: main, 12.4 Change-Id: I5dfb242bb596bef73a3d9474e8cd31ded723fea0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83477 Tested-by:
-
- Mar 17, 2024
-
-
Oliver Klee authored
In #88366, the caches have been renamed, e.g., from `cache_core` to `core`. Some occurrences of the old names in comments were missed at that time. This commit streamlines those occurrences to also use the new names. Resolves: #103409 Related: #88366 Releases: main, 12.4, 11.5 Change-Id: I69039160b3d3cc5da00d4f3d3e57fce755d22a63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83475 Tested-by:
-
- Mar 16, 2024
-
-
Oliver Bartsch authored
Resolves: #103391 Releases: main, 12.4 Change-Id: I48d55c7b66669f9836886f257aefba2171b6910e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83474 Tested-by:
-
- Mar 15, 2024
-
-
Oliver Bartsch authored
Resolves: #103385 Releases: main, 12.4, 11.5 Change-Id: Ifd93dfa4049d0d3550d052fa960ae79cc5a27c34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83430 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Willi Wehmeier authored
This change makes the toggle button accessible via keyboard and sets the focus manually, so that the pagetree can be toggled via pressing space or enter on the keyboard. Resolves: #102426 Releases: main, 12.4 Change-Id: I6916cf1f19de288e961ecb0dab85c76241097d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83473 Tested-by:
-
Willi Wehmeier authored
This patch adds a label to the action-menu used by most of the core extensions. Resolves: #102548 Releases: main, 12.4 Change-Id: I57db0e4d35b439e8841d7f4281bc09b593bb9dc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83492 Tested-by:
-
Oliver Hader authored
Several tests for URI route generation are stricter and assert that either the whole URI matches, or that at least the `?cHash=` suffix is applied for the corresponding test permutations. Besides that, individual URI assertions are streamlined to use AbstractEnhancerLinkGeneratorTestCase::assertGeneratedUriEquals. Resolves: #103396 Releases: main, 12.4, 11.5 Change-Id: I65ae10fa2984021da653bac33579feb6d10a6464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83464 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Mar 14, 2024
-
-
Willi Wehmeier authored
The thumbnail images in the inline file relations have the properties alt and title set to "id=x" which is only helpful when used to show the record uid in the tooltip. For screenreader users the info in the alt attribute isn't helpful at all. That's why the alt text should be empty so the thumbnail doesn't get read out by screenreaders at all. Resolves: #103397 Releases: main, 12.4 Change-Id: I233a54705c9c81e31b8852a8454165593fa8e061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83431 Tested-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/prefer-string-starts-ends-with` [1] into account, enforcing the usage of `startsWith()` and `endWith()` over index checking in strings. [1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with Resolves: #103374 Releases: main, 12.4 Change-Id: I88640f71cbe960db2a2e2b162410ff5a79e7c55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83448 Tested-by:
-
- Mar 13, 2024
-
-
Ayke Halder authored
In the backend CEs are elevated by a surrounding box-shadow. This box-shadow was clipped off on top, left and right side. Resolves: #103381 Releases: main, 12.4 Change-Id: I3052ff7ced18e509aefb2f05c6b1bde8725572b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83429 Tested-by:
-
Kevin Appelt authored
Resolves: #103392 Related: #103117 Releases: main, 12.4 Change-Id: I97f9c68b6ad1c6b3ded4c70a82dbfe20eb5a9f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83428 Tested-by:
-
Oliver Bartsch authored
This prevents the element browser from closing as soon as one file or folder was added. This restores previous behaviour, allowing the user to add multiple references without having to open the browser again and again. Resolves: #103369 Releases: main, 12.4 Change-Id: Id57ebe3ed115c0929beb06fd7dd136fe0f08e415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83458 Tested-by:
-
Willi Wehmeier authored
The "+" labelled button in the File selector modal was just labelled with the filename as the title which doesn't give any meaning to screenreader users. To show the purpose of the button to screenreader users the title has been changed to additionally describe the action. Also an aria-label with the same value has been added. This is not ideal, because some screenreaders will read out the title twice, but on the other hand other screenreaders ignore the title or the aria-label attribute. Resolves: #103292 Releases: main, 12.4 Change-Id: Ia53fd77623e3cbd3a63a48f1bd4edc457f453c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83459 Tested-by:
-
Benjamin Franzke authored
With #103197, a loading indicator was added to the context menus, which rendered a stub context-menu. The position of the context-menu needs to be recalculated once the data has been loaded (the context-menu becomes taller) in order to avoid rendering outside the visible window area. Releases: main, 12.4 Resolves: #103382 Related: #103197 Related: #103294 Change-Id: I75e3659c619d4b98c773faa4dab9bbf184471065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83454 Tested-by:
-
Michael Hitzler authored
Resolves: #102139 Releases: main, 12.4 Change-Id: I9eb3b759de4af5c322aedc96df169aa7c603add6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83427 Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/restrict-plus-operands` [1] into account, prohibiting merging of type-incompatible operands. [1] https://typescript-eslint.io/rules/restrict-plus-operands Resolves: #103378 Releases: main, 12.4 Change-Id: I267272e4f384cbcabc245cd85ea493886134b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83447 Tested-by:
-
- Mar 12, 2024
-
-
Andreas Kienast authored
The `@typescript-eslint` packages are updated for TypeScript 5.4 support. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.2.0 \ @typescript-eslint/parser@^7.2.0 \ @typescript-eslint/typescript-estree@^7.2.0 npm run build Resolves: #103370 Related: #103354 Releases: main, 12.4 Change-Id: I2c173437e1119dccb148e9eaa426cfdcdc94f682 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83426 Tested-by: -
Christoph Lehmann authored
Since #98377 it is not possible to use `f:link.page` ViewHelper in the ConfirmationFinisher template. This adds the server request to the standalone view to make it work again. Also removed wrong comment and direct usage of global request object. Resolves: #103368 Releases: main, 12.4 Change-Id: I3822cda0bb5fde9feb992696775051ec676592c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83446 Tested-by:
-
Andreas Kienast authored
With #103197, a loading indicator was added to the context menus. However, due to the nature how the context menu component registers itself, we run into conflicting event handling. We have to silent any subsequent handlers on the same event, therefore the event propagation is immediately stopped. This aligns the event propagation behavior with the modernized tree in TYPO3 v13. Resolves: #103379 Related: #103197 Releases: 12.4 Change-Id: I87ae7ac815d3271788a164258ab2208fe5e57e6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83441 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/no-array-delete` [1] into account, prohibiting element removal from an array via `delete`. The problem with `delete` is that the element to be removed is in fact replaced with an `empty` slot, effectible keeping the array's size. Using `splice()` [2] is the preferred way to remove elements from an array. [1] https://typescript-eslint.io/rules/no-array-delete/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice Resolves: #103375 Releases: main, 12.4 Change-Id: Ic742a43d44cbd8c5cc323f629cc82ad606a9858f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83443 Tested-by:
-
Oliver Hader authored
The new methods AbstractUserAuthentication::getUserName() and AbstractUserAuthentication::getUserId() can be used to resolve the corresponding values (instead of using the $user->user array). In addition, the pure system-maintainer checks have been moved into to central BackendUserAuthentication::isSystemMaintainer(). The term "pure" refers to ignoring the development context and not applying any fallbacks in case the setting is empty. Resolves: #103323 Releases: main, 12.4 Change-Id: Ia7db222dac32acc2ef13a34ded4545ba1aedefc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83440 Tested-by:
-
