- Feb 14, 2014
-
-
Alexander Stehlik authored
To prevent multiple retries when loading information about non existing classes (e.g. caused by class_exists() calls) the cache is filled with an empty string when a non existing class is detected. With this information the class loader can return early and does not need to run all expensive checks for determining the class file. Releases: 6.2 Resolves: #53962 Change-Id: I3c7e750bcce8846aaee79ac2d04527be2e31fc16 Reviewed-on: https://review.typo3.org/25679 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
* Skip cache->has() calls * Remove class alias registration on object instantiation Resolves: #55037 Releases: 6.2 Change-Id: Ia9f8523a9d710b2703c3ee2caf2f1fa9ae6e76e9 Reviewed-on: https://review.typo3.org/26836 Reviewed-by: Markus Klein Reviewed-by: Thomas Maroschik Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
The return should test for: - isset($this->runtimeActivatedPackages[$packageKey]); before it tests for: - parent::isPackageActive($packageKey) Change-Id: Ia18fb601a83e717c9bbf498eaa38c4cae04ceac6 Resolves: #55749 Releases: 6.2 Reviewed-on: https://review.typo3.org/27391 Reviewed-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Michiel Roos authored
The following methods are amongst the most frequently called ones: * getFileAbsFileName() * validPathStr() * isAllowedAbsPath() * verifyFilenameAgainstDenyPattern() They can be optimized to return early, save some variable assignments and save some preg_match calls. Change-Id: Id30b2f9b5a053d4267d9c24339f414821ba661ea Resolves: #54525 Releases: 6.2 Reviewed-on: https://review.typo3.org/26505 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 13, 2014
-
-
Stanislas Rolland authored
Use same styling as in RTE Image wizard. Order form fields in the same order as in TYPO3 Link Wizard. However, the RTE has more configurable fields and more configuration options for common fields. Resolves: #55951 Releases: 6.2 Change-Id: Ia4cb513edb8c5fb825e8d8f54e29ed94f3bb59e3 Reviewed-on: https://review.typo3.org/27590 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
Marc Bastian Heinrichs authored
Extends the functional tests with the possibility to link folders or files inside the TYPO3 CMS test instance created within typo3temp. For example you are able to link a folder inside the fixture data of the functional tests to the fileadmin folder of the test instance. Resolves: #55111 Releases: 6.2 Change-Id: Ic41809e7642756b7c5eb1e0d717ef3cbd6d81e1d Reviewed-on: https://review.typo3.org/26904 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Christian Weiske authored
Check if a class already exists before requiring the file. Change-Id: I555d259f7fb869428d20b63d2766684bb21c1a5c Fixes: #55904 Releases: 6.2 Reviewed-on: https://review.typo3.org/27570 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Markus Klein authored
The validator task of the linkvalidator scheduler task sets the validated email addresses now instead of the raw user input. Resolves: #55922 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: Id1a93de455decd7a223ef271499679628892e4c4 Reviewed-on: https://review.typo3.org/27580 Reviewed-by: Online Now! GmbH Tested-by: Online Now! GmbH Reviewed-by: Stefan Neufeind Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Stanislas Rolland authored
Solution: Fix form markup inside table tag. Remove old color class on labels. Add rtehtmlarea skin file in order to size and position select and checkboxes correctly in image update tab. Position correctly window title. Resolves: #55946 Releases: 6.2 Change-Id: I497c4a3005bd80b5b05edd64e7ebbca1dee3c0ce Reviewed-on: https://review.typo3.org/27589 Reviewed-by: Stanislas Rolland Tested-by: Stanislas Rolland
-
- Feb 12, 2014
-
-
Michiel Roos authored
Change-Id: I0c105134ca9de463eed7c6a3760003b8694958ce Resolves: #55923 Releases: 6.2 Reviewed-on: https://review.typo3.org/27576 Reviewed-by: Marcin Sągol Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
Change-Id: Ib1c877c1353844dfac1955c39c864a0974bd6b78 Resolves: #55706 Releases: 6.2 Reviewed-on: https://review.typo3.org/27573 Reviewed-by: Stefano Kowalke Reviewed-by: Jo Hasenau Tested-by: Jo Hasenau Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Pascal Hinz authored
The dimension settings in the source collections was overriden after calculation. Now the result will not be overriden anymore. Resolves: #53169 Releases: 6.2 Change-Id: I34b4dbab5e99b5cf3d790f92d06d11d31b9b8140 Reviewed-on: https://review.typo3.org/25077 Reviewed-by: Ingo Schmitt Tested-by: Ingo Schmitt Reviewed-by: Sebastian Fischer Tested-by: Sebastian Fischer Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 11, 2014
-
-
Helmut Hummel authored
Execute unit tests first and lint last, since the lint is las resort anyway and unlikely to fail. Also use a simple printf instead of a php call. Change-Id: I7471e4ac0b217e1a58d1324bd24fc7e2f517e17e Reviewed-on: https://review.typo3.org/27564 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Michiel Roos authored
Add a test to check for mtime sorting capability of getFilesInDir(). Change-Id: I73082bcfd1f8d46b77a228b1ea7dabc1602d9d0a Resolves: #55864 Releases: 6.2 Reviewed-on: https://review.typo3.org/27536 Reviewed-by: Oliver Klee Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Jost Baron authored
When importing the extension list from TER, each version of each extension is one database record. For each extension key the EM calculates the newest version and sets the column 'current_version' to 1 for the corresponsing extension record. The old implementation issued one database query for each extension key, resulting in about 6k queries, taking a long time to execute (several minutes on my machine). After applying this patch the same thing is done in three queries, speeding up the process. Resolves: #55820 Related: #52949 Releases: 6.2 Change-Id: I55d3699a63b13e7c07af4babbf57d0d06f367027 Reviewed-on: https://review.typo3.org/27496 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Jost Baron Tested-by: Jost Baron Reviewed-by: Oliver Klee Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Karol Lamparski authored
Resolves: #49440 Releases: 6.2, 6,1 Change-Id: Iea20a7e9c637c2f1f13c39eebe406d07edc8a2c3 Reviewed-on: https://review.typo3.org/27453 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Karol Lamparski Tested-by: Karol Lamparski Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Michiel Roos authored
Change-Id: I06bb7492146a9149917bc2fc9100fbdddd9b8d09 Resolves: #55871 Releases: 6.2 Reviewed-on: https://review.typo3.org/27539 Reviewed-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Michiel Roos authored
Replace strtolower and ternary operations with strcasecmp. Change-Id: Ia962ef879c6ba1d91081db78f74fc577fa67c467 Resolves: #55899 Releases: 6.2 Reviewed-on: https://review.typo3.org/27559 Reviewed-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Wouter Wolters authored
The FormProtectionFactory can be initialized later. Move the initialization to the point where it is needed. Resolves: #55856 Releases: 6.2 Change-Id: Id83304341ddec4cc2d4d5c8a6bd40463277a37b5 Reviewed-on: https://review.typo3.org/27533 Reviewed-by: Benjamin Mack Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Dmitry Dulepov authored
If the config.cache_ClearAtMidnight is set, the current code of TypoScriptFrontendController::get_cache_timeout() will not take content's starttime/endtime into account. Thus if the content (or other configured record) has start or end time before the midnight, it will not be taken into account and the cache timeout will be wrong. Change-Id: I732da8f07270a86c62b7ce5028b12b630bb2e027 Resolves: #53028 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/24951 Reviewed-by: Wouter Wolters Reviewed-by: Peter Foerger Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helge Funk authored
Adding composer packages to „Packages“ folder will cause a fatal error This fix prevents the extension manager from handling not legacy packages Resolves: #55754 Releases: 6.2 Change-Id: I3ac491c8566b14578f5d3a604c63dffc1310d042 Reviewed-on: https://review.typo3.org/27402 Reviewed-by: Thomas Maroschik Reviewed-by: Marcin Sągol Tested-by: Thomas Maroschik Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
When working on #55559 (refactoring class alias handling) accidentally code was introduced to avoid more than one alias for a class name. Remove this code to make multiple aliases work again. Fixes: #55897 Releases: 6.2 Change-Id: I8b4b721c57c52d117130947fe92c564d6ddcdd9b Reviewed-on: https://review.typo3.org/27558 Reviewed-by: Claus Due Tested-by: Claus Due Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Thomas Maroschik authored
During the installation of packages via the extension manager a fatal error can occur when the ext_localconf and ext_tables are loaded and use classes from their own package. This happens because the package is activated but the class loader is not aware yet of the new package. This patch adds the extension temporarily to the runtime activated packages in the class loader. Fixes: #53795 Releases: 6.2 Change-Id: I195b86284b9a288f4d7c102168ec18ed8683cb07 Reviewed-on: https://review.typo3.org/27544 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Alexander Stehlik authored
If the root folder is used as folder identifier (/) no slash is appended so that isFirstPartOfStr works correctly in the isWithin check in LocalDriver. Resolves: #55740 Releases: 6.2 Change-Id: I2af1cd3759656502ea84887828dfb222f0a07b64 Reviewed-on: https://review.typo3.org/27379 Reviewed-by: Markus Klein Reviewed-by: Markus Kasten Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
Thomas Maroschik authored
During installation of extensions the Extension Manager does not take the Category API into account. The code to do so is present in the Install Tool in the Database Compare Tool. It is cumbersome to switch to the install tool to update the database in order to use the category fields. The install tool and extension manager currently need to know which components manipulate the table definitions and this is bad coupling of components which shouldn't know each other. This fix replaces the individual calls to the components by two signals and thus a generic approach. Fixes: #53016 Releases: 6.2 Change-Id: I7f99ad7cadc323d4f8b975de97e4c665a82647a5 Reviewed-on: https://review.typo3.org/26506 Reviewed-by: Fabien Udriot Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
Different build environments have been set up mainly to be able to execute lint, unit tests and functional tests in parallel. However setting up the build environment on travis also takes quite some time, so that overall build times are quite high. This change cleans up the travis configuration, reduces the number of builds to only the configured PHP versions and executes lint, unit tests and functional test in parallel using the command line tool "parallel" By doing so, the overall build time can be reduced by at least 50% This change also removes the installation of a current git version which has been added to fix temporary Travis service errors. Releases: 6.2 Change-Id: Ic1591ed0b596df22a648a825639c1a2bbc7ffcc2 Reviewed-on: https://review.typo3.org/27540 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Frans Saris authored
Issue #55549 added a wrong check for user uid. As result the FE cookie gets deleted when you are loggedin instead when your not. This change inverses the check. Resolves: #55845 Releases: 6.2 Change-Id: I0c59afb8c89e9f7887970eaf0a4079fe98280b2c Reviewed-on: https://review.typo3.org/27525 Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Reviewed-by: Marcin Sągol Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
- Feb 10, 2014
-
-
Jan Kiesewetter authored
In order to provide the full functionality known from the switch/case PHP function, a default case possibility is introduced. Use it like: <f:switch expression="{person.gender}"> <f:case value="female">Mrs.</f:case> <f:case value="male">Mr.</f:case> <f:case default="TRUE">Mrs. or Mr.</f:case> </f:switch> Change-Id: Ib9468cdabd66fb8b484cb4d07520d5b529548dd1 Resolves: #49371 Documentation: #54283 Releases: 6.2 Reviewed-on: https://review.typo3.org/26058 Reviewed-by: Benjamin Kott Tested-by: Benjamin Kott Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Alexander Stehlik authored
If the given delimiter is not found in the given string GeneralUtility::revExplode() will return an array with a single element containing the unexploded string. Resolves: #55838 Releases: 6.2 Change-Id: I1146552a625a8057be86b2745febf808638a290c Reviewed-on: https://review.typo3.org/27524 Reviewed-by: Andreas Wolf Tested-by: Andreas Wolf Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Running the whole unit test suite on cli can eat up a significant amount of memory. Most of that can not be mitigated due to phpunit itself, but we can at least hint the PHP garbage collection by unsetting test class properties in tearDown(). The patch introduces a generic tearDown() method that reflects the test class and unsets all temporary properties of the class. In effect, tests do not need to take care of unsetting properties. The patch removes all tearDown() methods that only unset() stuff and keeps others that do additional things but adds a call to parent::tearDown(). Private properties are changed to protected, so parent::tearDown can reach them. The additional computing effort of the reflection is insignificant, the suite is nearly as fast as before. Results: php 5.3: 1056MB -> 851MB php 5.4: 870MB -> 670MB php 5.5.: 876MB -> 674MB Resolves: #55850 Related: #51436 Releases: 6.2 Change-Id: Ie665c53a3ab35e4808677e483d2099e0511c393f Reviewed-on: https://review.typo3.org/27528 Reviewed-by: Helmut Hummel Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Helmut Hummel authored
Change-Id: Icab8cd1d7f4b9a56f10ed7fc1f6e945ff50b295c Reviewed-on: https://review.typo3.org/27529 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
All $GLOBALS are backed up by phpunit, no explicit backup of $GLOBALS['TYPO3_DB'] is required. Change-Id: I2859a5922d85a23fa8281382b1d78043ec7bd934 Resolves: #55846 Related: #51436 Releases: 6.2 Reviewed-on: https://review.typo3.org/27526 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Andreas Wolf authored
In order to be able to easier debug stuff and intercept database calls, all queries are made through a central ``query()`` method in ``DatabaseConnection``. Change-Id: I53cd98dbb837232765bcc24e30851f99d3cfdca0 Resolves: #55769 Releases: 6.2 Reviewed-on: https://review.typo3.org/27420 Reviewed-by: Stefan Neufeind Reviewed-by: Pascal Dürsteler Tested-by: Pascal Dürsteler Reviewed-by: Oliver Klee Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Ernesto Baschny authored
jumpUrl_transferSession adds some more parameters to the URL, making the juHash invalid. Simply add the check for the allowed redirection before the jumpurl is internally modified. Resolves: #46463 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I53fad094caca37b476e07cae953105623e038e85 Reviewed-on: https://review.typo3.org/19270 Reviewed-by: Helmut Hummel Reviewed-by: Alexander Stehlik Tested-by: Alexander Stehlik Reviewed-by: Wouter Wolters Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Marcin Sągol Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Anja Leichsenring authored
The function menu of info module API method can create proper link targets without mentioning index.php. The patch is a preparation for switching the entry point of info module to mod.php. Change-Id: I467e99ff50513033f887049e5b4a487f0ade645b Resolves: #55797 Relates: #55672 Releases: 6.2 Reviewed-on: https://review.typo3.org/27482 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Michiel Roos authored
Calling stat() is cheaper than calling filemtime() AND filesize(). Change-Id: I8fc3cb46d934b3c49f6919f7f178e2b232fd62e1 Resolves: #55574 Releases: 6.2 Reviewed-on: https://review.typo3.org/27256 Reviewed-by: Marcin Sągol Reviewed-by: Karol Lamparski Reviewed-by: Michał Jankiewicz Reviewed-by: Stefan Neufeind Reviewed-by: Michiel Roos Tested-by: Michiel Roos Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Łukas Jurys authored
protected LocalizationUtility::setLanguageKeys() is only called from static initializeLocalization and needs to be static, too. Resolves: #47983 Releases: 6.2 Change-Id: I7d0a4f5e8fc09ee049a6a7af1be65d5d5e8bf5e4 Reviewed-on: https://review.typo3.org/27506 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn Reviewed-by: Oliver Klee Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Felix Kopp authored
Bring standard styles for UL/OL html elements. Ordered and unordered lists are styled with disc bullet and decimal. Also overrides those new standard definition for non standard "lists" like tabs or trees. Resolves: #55819 Releases: 6.2 Change-Id: I6f4317d46d503f6d5737015710d19d9c2361b14c Reviewed-on: https://review.typo3.org/27517 Reviewed-by: Marcin Sągol Reviewed-by: Georg Ringer Tested-by: Georg Ringer
-
Anja Leichsenring authored
The function menu of info module API method can create proper link targets without mentioning index.php. The patch is a preparation for switching the entry point of info module to mod.php. Resolves: #55796 Relates: #55672 Change-Id: Ida807864ea8d75a2737313c88d8f89b37bb816b6 Reviewed-on: https://review.typo3.org/27479 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Georg Ringer authored
Change-Id: I40990623e3d53e70666438acafc27275ac36b621 Resolves: #55827 Releases: 6.2 Reviewed-on: https://review.typo3.org/27523 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-