- Sep 19, 2018
-
-
Christian Kuhn authored
The micro optimization introduced a bug, fixing the bug would basically lead to the same code that is within renderStatic() already. There is then no advantage in having an inline compiled solution in comparison to a static call to the class anymore. The initial patch and its follow up are reverted. This reverts commit e6f470eb. This reverts commit 852ad1d9. Resolves: #86292 Reverts: #82454 Releases: master Change-Id: I573a4298b0b9aedf83d51416919204bf910ae4bf Reviewed-on: https://review.typo3.org/58322 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Sep 18, 2018
-
-
Josef Glatz authored
This patch adds .log files to .gitignore. Releases: master Resolves: #86302 Change-Id: If19c37208fb6d2d7004a03daca8d58821f2fae42 Reviewed-on: https://review.typo3.org/58321 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
Check if the prefix is not an empty string to avoid a warning thrown by strpos(). Resolves: #86300 Related: #85477 Releases: master Change-Id: I68a1fc83745594524c088600258c2925eccf3015 Reviewed-on: https://review.typo3.org/58320 Reviewed-by:
-
Benni Mack authored
The last methods within FrontendBackendUser (BE_USER in FE mode) are now deprecated in favor of Admin Panel and middlewares: - checkBackendAccessSettingsFromInitPhp() - extPageReadAccess() - extGetTreeList() - extGetLL() Resolves: #86288 Releases: master Change-Id: I6752589a4b7a5353ae1699f3786be743c6f1f13d Reviewed-on: https://review.typo3.org/58305 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Sascha Egerer authored
The TCA group dataprovider is currently executet very early and before the ColumnsOverride dataprovider. Because of that it is not possible to override settings of a tca field of type group. The DataProviders have been reorderd so that the GroupDataProvider is executed at a later point. Resolves: #81618 Releases: master Change-Id: Ic6f9e860b8a7abd5dd1e483dcb35c15f7b8e5ecf Reviewed-on: https://review.typo3.org/53526 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
BE admins without mountpoints set have value '0' in $this->groupData['webmounts']. If this is checked additonally to empty string, some 'where uid=0' database calls can be suppressed. Resolves: #86272 Releases: master Change-Id: I4142034c3d3fac3c9319649fd39200da7955a8db Reviewed-on: https://review.typo3.org/58290 Tested-by:
-
Xavier Perseguers authored
The breaking change documentation is adapted to explicitly mention that the signal/slot registration is kept untouched. This will prevent confusion for developers reading the list of breaking changes. Related: #50467 Related: #62983 Related: #84131 Related: #84691 Releases: master Change-Id: I43ff5a6882e84c29844495fa9f10e6a35f07b1ff Reviewed-on: https://review.typo3.org/58313 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benjamin Franzke authored
The suggested migration (xclasses) does not work for Models mapped using the PropertyMapper. It also fails if additional injections have been configured. (though that could be fixed using `GeneralUtility::makeInstance(ObjectManager::class)->get()`) Change-Id: If22b98526fce575435662e731a4f2efca9a014f3 Releases: master Resolves: #86290 Related: #86270 Reviewed-on: https://review.typo3.org/58310 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86283 Releases: master Change-Id: Id2fad147fd081e86ecb1b40e0b407b17f60c74d8 Reviewed-on: https://review.typo3.org/58301 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Stefan Froemken authored
Confirmation Modal shows buttons with translated button labels now, if you try to delete a page from page-tree. Resolves: #79879 Releases: master, 8.7 Change-Id: Iff2ed8205bdcc54b48ba301035cd0aac9c2de826 Reviewed-on: https://review.typo3.org/58186 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Thomas authored
Removing the integer casting, so that the cropVariant can also be a string identifier. Resolves: #86294 Releases: master, 8.7 Change-Id: Id4a80a7b879ddb8539e8cf4b47eeff1fc111029e Reviewed-on: https://review.typo3.org/58312 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Susanne Moog authored
Resolves: #86275 Releases: master Change-Id: I767f02c75b5f505e9b7ec78e933513d427dba2ae Reviewed-on: https://review.typo3.org/58308 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Andreas Fernandez authored
The extension scanner merges all matches into an array. This is done in a loop, which is pretty greedy as it impacts CPU and RAM. Instead, it's possible to do a single array_merge() at the end of the loop. See this document for reference: https://github.com/kalessil/phpinspectionsea/blob/master/docs/performance.md#slow-array-function-used-in-loop Resolves: #86282 Releases: master Change-Id: I09b45468dfd9f60ce6bd9e264ecfc3cbfcb54fa1 Reviewed-on: https://review.typo3.org/58302 Tested-by:
-
Benjamin Franzke authored
We do not want to pollute $GLOBALS to be able to inject PackageManager as $GLOBALS['TYPO3_currentPackageManager']. to cache-restored Package objects (during unserialize). Therefore this patch drops the PackageManager dependency from the Package class. The global injected PackageManager was used to calculate the package metadata on demand. Package metadata is a small array that doesn't harm to be created during Package object construction, (it's cached afterwards anyway). This allows us to drop the PackageManager reference, which simplifies serialize/unserialize logic (we can drop __sleep and __wakeup). We also combine the PackageManger and PackageObjects cache into one cache file instead of two. There is no advantage in having to read two files from the filesystem. The prior argument (introduced with the initial PackageManager patch in 2013) "so PHP does not have to parse the serialized string" is actually invalid: The serialized string has to be parsed anyway. PHP did not need to parse the var_export'd variant, true. BUT: The var_export'd variant is theoretically php opcache'able, while reading a file and passing the file contents to serialize() is not. That means the previous solution actually hampered native optimizations. Ideally we could drop the serialize/unserialize thing and just use var_export for Package objects, but for that to work the Package class (and all of it's properties) would need to implement the magic __set_state() method (which is used by var_export to create objects). That's currently not possible, because the composerManifest (which is read from json_decode) is a stdClass and does not provide a __set_state() method. We'd need to rewrite all that code to an array or so. Maybe something for a later patch. As a drive-by fix we now hash the TYPO3_version value into the cacheEntryIdentifier like other core caches do. Change-Id: I764dc92c64165ede24c8020c44cd2360b3faa00c Releases: master Resolves: #86261 Reviewed-on: https://review.typo3.org/58282 Tested-by:
-
- Sep 17, 2018
-
-
Sebastian Michaelsen authored
TCA select fields with renderType = 'selectTree' have the option treeConfig.appearance.nonSelectableLevels, which doesn't seem to work anymore since TYPO3 v7. The items are correctly flagged with node.selectable = false in PHP but the JavaScript doesn't check for that property. Resolves: #84708 Releases: master, 8.7 Change-Id: Iefe98e1c9fd316f05c27ad1230d63236a7069bf1 Reviewed-on: https://review.typo3.org/58263 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Benni Mack authored
When deprecating TSFE->sys_language_mode and TSFE->sys_language_uid it was forgotten (by myself) to set the visibility to protected. This way, the deprecation layer (with compat calls) is never used, and legacy code gets wrong results. Resolves: #86285 Related: #85543 Releases: master Change-Id: I2d809b577e5265054f2f54d54ecfbb8e441b6bdc Reviewed-on: https://review.typo3.org/58303 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benjamin Franzke authored
If we want to introduce a system wide container in v10, the non deterministic behaviour of object (re)configurations during runtime in extbase will be a problem. Compiled containers like symfony DI do not allow runtime reconfigurations. Also the concept of per plugin overwrites is broken anyway, and should therefore be dropped: The "objects" configured through plugin.tx_%name%.objects are are never reset, that means: Plugin A might overwrite an object and plugin B will implictly use that overriden class, despite not having configured that at all. (depending on the fact whether plugin A is rendered before or not) config.tx_extbase.object class overwrites can be replaced by XCLASSes. If config.tx_extbase.object was/is used to conditionally overwrite classes (through sys_template or conditions), these occasions should be changed to XCLASSes as well. In that case the conditional overwrite needs to be moved into the xclass itself. Change-Id: I2ef839bcbb7f941c3afa0010767560d20e15f98b Releases: master Resolves: #86270 Reviewed-on: https://review.typo3.org/58288 Reviewed-by:
-
Benni Mack authored
With PSR-15 it is not necessary to use any custom hooks during the frontend request setup process anymore, as middlewares are flexible enough to manipulate anything people want to do. On top, various middlewares are also declared internal as the usages are not really necessary to be publically exposed. - typo3/cms-core/normalized-params-attribute - typo3/cms-backend/legacy-document-template - typo3/cms-backend/output-compression - typo3/cms-backend/response-headers - typo3/cms-frontend/timetracker - typo3/cms-frontend/preprocessing - typo3/cms-frontend/eid - typo3/cms-frontend/content-length-headers - typo3/cms-frontend/tsfe - typo3/cms-frontend/output-compression - typo3/cms-frontend/prepare-tsfe-rendering - typo3/cms-frontend/shortcut-and-mountpoint-redirect Resolves: #86279 Releases: master Change-Id: I14fbd7b026acdc84fb23ca43cd395de5b7b9c4b6 Reviewed-on: https://review.typo3.org/58253 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Sep 16, 2018
-
-
Benni Mack authored
The following properties have changed their visibility to be protected from public. * pageAccessFailureHistory * workspacePreview (not in use anymore) * ADMCMD_preview_BEUSER_uid (not in use anymore) * debug (not in use anymore) * MP_defaults (not in use anymore outside of TSFE) * loginAllowedInBranch (use checkIfLoginAllowedInBranch()) The following methods have changed their signature to be protected, as their purpose is to be called from within TypoScriptFrontendController. - tempPageCacheContent() - realPageCacheContent() - setPageCacheContent() - clearPageCacheContent_pidList() - setSysLastChanged() - contentStrReplace() Resolves: #86047 Releases: master Change-Id: I98f54f4a75023b963b69c12457b73e5117469497 Reviewed-on: https://review.typo3.org/58083 Reviewed-by:
-
Christian Kuhn authored
If a system maintainer used the install tool from within the backend, the session is now destroyed on logout explicitely. Resolves: #86249 Resolves: #85404 Releases: master Change-Id: I6bf4f2a724ec85b60854e8f92c00a10e7614f140 Reviewed-on: https://review.typo3.org/58297 Reviewed-by:
-
Richard Haeser authored
Use the Uri class to check if a host is given in the url to determine if an absolute url should be generated. Resolves: #86253 Releases: master Change-Id: Ib84d391b0564f29352eda93a814f5d9b46696f37 Reviewed-on: https://review.typo3.org/58274 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Christian Kuhn authored
Suppress a where uid=0 call on sys_file table if the backend user has not avatar assigned. Resolves: #86273 Releases: master Change-Id: Id67e80dbb906ce27af3954f9c20ee49a5c7050ee Reviewed-on: https://review.typo3.org/58291 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Page uid 0 has no rootline by definition. The patch adds an early return to RootlineUtility to suppress some cache->get() calls. This happens in BE quite often. Additionally, the SiteFinder does not query RootlineUtility for page uid 0 at all to save a series of instance creations. Resolves: #86271 Releases: master Change-Id: I63c819c6dcd5e5c7a0e226ae16b0ecd6cf391e30 Reviewed-on: https://review.typo3.org/58289 Tested-by:
-
Michael Schams authored
This change updates the text in the Core Upgrade dialog and fixes a typo as well as introduces some basic styles. Resolves: #86274 Releases: master Change-Id: Ie6433a9fa3a5f8b8d1c808955872dda91d10788a Reviewed-on: https://review.typo3.org/58292 Tested-by:
-
- Sep 15, 2018
-
-
Christian Kuhn authored
Some DB drivers like pdo_mysql and our postgres flavor return values from DB always as string. Classes with enabled strict_types then tend to fail if those values that should be integers but are strings are fed to functions that accept integers only. The patch fixes two places in SchedulerModuleController where a db value is directly sent to date(), which needs an int as second argument. Resolves: #86263 Releases: master Change-Id: I00ce0425774762fef235373f643f8b69bdd072bb Reviewed-on: https://review.typo3.org/58285 Reviewed-by:
-
Markus Klein authored
Resolves: #86259 Releases: master Change-Id: I0a5c7020d879250cf38ca1975a8f63e65f1a0649 Reviewed-on: https://review.typo3.org/58281 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86200 Related: #86172 Releases: master Change-Id: I9f6412ed7a6adb8b00f62cbca7476a49bed6985d Reviewed-on: https://review.typo3.org/58278 Tested-by:
-
Frank Naegler authored
This patch introduces error handling to mitigate a missing type check in the Symfony Expression Language handler. In case a condition uses the "in" or "not in" check in combination with a non-array a PHP warning is thrown. Example: [1 in "foo"] or ["bar" in "foo,baz"] These conditions are broken, but they will break the complete installation including the backend. To mitigate the problem we do the following: 1) In FE an InvalidTypoScriptConditionException is thrown (if strictSyntax is enabled) 2) In FE catch this error silently and log it (if strictSyntax is disabled) 3) In BE catch this error silently and log it, but never break the backend. Resolves: #86257 Releases: master Change-Id: I2a54f819383775a300af6848cfc85e9f626bec21 Reviewed-on: https://review.typo3.org/58280 Tested-by:
-
Christian Kuhn authored
Maintenance > Remove temporary assets now properly lists statistics for FAL processed files and allows to clear them. Releases: master Resolves: #83034 Change-Id: Ic9238c88648d98a76a0cbd4015820d51bffde0fa Reviewed-on: https://review.typo3.org/57837 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- Sep 14, 2018
-
-
Christian Kuhn authored
Resolves: #86256 Releases: master Change-Id: I6b108342ebb7439657afec296c68de7ba45bf29e Reviewed-on: https://review.typo3.org/58279 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frank Naegler authored
This patch fix broken TSConfig condition because of missing backend user aspect. Resolves: #86229 Releases: master Change-Id: I6528b5d48a5b5711cad8710d4bfcc6222f9fef9c Reviewed-on: https://review.typo3.org/58275 Reviewed-by:
-
Christian Kuhn authored
Issue #85092 introduced a copy & paste bug in TemplateService. Resolves: #86255 Related: #85092 Releases: master Change-Id: If0d92e0886e625db8793991f264628030ccfdad4 Reviewed-on: https://review.typo3.org/58277 Reviewed-by:
-
Georg Ringer authored
Instead of only checking the sys_domains with a database query the SiteFinder and PseudoSiteFinder should be used. Resolves: #86219 Releases: master Change-Id: I99f9367258f9b19ef3a1310cb2fd61076083333c Reviewed-on: https://review.typo3.org/58257 Tested-by:
-
Susanne Moog authored
Migrates all upgrade wizards based on the `AbstractDownloadExtensionUpdate` class to the new API. Related: #86172 Resolves: #86199 Releases: master Change-Id: I79ffa702a1448bb66324074ef2debf41922d95e8 Reviewed-on: https://review.typo3.org/58233 Reviewed-by:
-
Andreas Fernandez authored
The JavaScript for the SlugElement is partially designed to be a independent instance for each slug field. However, this does not work for mass editing the slug fields, as the `initialize()` method is always called on the same instance. This patch does multiple things: - The JavaScript is converted to a TypeScript basis, which allows better handling of each instance - The "Regenerate slug" button is disabled in case the "feeder" fields are not available to avoid getting bogus values Resolves: #86221 Releases: master Change-Id: I458247beb597c77407e94ce633314ae2e2d7095a Reviewed-on: https://review.typo3.org/58273 Tested-by:
-
Richard Haeser authored
Create absolute URL's for the hreflang links by using the configuration of the current site. Resolves: #86224 Releases: master Change-Id: Id3196542875862b20145418956fcfdfcc3834241 Reviewed-on: https://review.typo3.org/58262 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Sep 13, 2018
-
-
Susanne Moog authored
Wizards marked as done are no longer displayed as executable in the install tool, the missing state check has been included. Resolves: #86246 Releases: master Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a Reviewed-on: https://review.typo3.org/58270 Tested-by:
-
Daniel Goerz authored
The check for pages.l18n_cfg is wrong now, as this is always done against pages.sys_language_uid=0 records (as "resolvePage" is called right before). So, these if-statements have to go further south. On top, the getPageOverlay call needs to be done - on top. resolvePage -> get default language of page getPageOverlay -> put the wanted translation on top A fix for pages.alias has to be in place, as DataHandler cannot handle pages.alias yet. Resolves: #86242 Releases: master Change-Id: Ief99e5f934f6e9d31973b9543cb9a6e599d2d33c Reviewed-on: https://review.typo3.org/58267 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Helmut Hummel authored
To make the registry for done wizards consistent and stay backwards compatible once all upgrade wizards are converted to use the new interface, always store the class name of the wizard instead of its identifier in the registry. Additionally we now add checks for valid identifiers to all API methods that receive one. Releases: master Resolves: #86165 Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e Reviewed-on: https://review.typo3.org/58197 Tested-by:
-
Christian Kuhn authored
With the install tool move to modals, various details on CSS level broke: The modal HTML is on top level in backend and thus not within the content-iframe, so styles defined in install.css loaded in the iframe do not kick in. Since the standalone install tool does not use iframes, there are various differences on view level between standalone and embedded-in-backend version, usually with the embedded version looking more ugly than standalone. The install.css is not very different from backend.css anyway, so we resolve various details with the patch, kick install.css entirely and rely soley on backend.css, even for the installer. Details: * <hr> shows a border again in modals in embedded, broken since modal patch * image processing view has borders and other details again in embedded verision, broken since modal patch * removed 'fixed save button location' for 'all configuration' code. This broke with the modal patch, the code does not do anything useful at the moment. A solution needs a change of the modal js to render the buttons to modal-footer instead. This is too complex for this patch and may be done with another patch. * A couple of classes to easily limit styles to installer and maintenance parts * Remove left overs from old install-tool menu approach that have not been cleanup up, yet. Resolves: #86245 Related: #84772 Releases: master Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7 Reviewed-on: https://review.typo3.org/58269 Tested-by:
-
