- Jul 11, 2023
-
-
Oliver Klee authored
There already was a data provider for the negative case of this method, but no tests using this data provider. Resolves: #101308 Releases: main, 12.4, 11.5 Change-Id: If32b5f2943240f224031e20d9849f849275358a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79973 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
Stage-change notification mails have only been delivered to the last recipient off the list of possible recipients, because Utility.convertFormToObject failed to detect checkbox elements from (other) frames. In this case the to-be-converted form elements are created on the top frame (modal contents are placed outside list frame on the top frame). Due to JavaScript being prototype based, instanceof checks do only operate per-frame. Prototypes are bound to the current window. `foo instanceof HTMLInputElement` is basically a shortcut and equivalent to `foo instanceof window.HTMLInputElement` while `window != top.window`. Instead of `instanceof` checks, we switch to a `tagName` comparision which is usable for cross-frame HTMLElement type detection. Resolves: #99784 Releases: main, 12.4, 11.5 Change-Id: If9bfd7be1e46d8c04619be3563d3bdba9d9de549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79924 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Jul 10, 2023
-
-
Benjamin Franzke authored
Map backend URLs like /typo3/install.php?install%5Bcontroller%5D=settings to /typo3/module/tools/settings for display in the browsers URL bar. Resolves: #101287 Releases: main, 12.4, 11.5 Change-Id: I5177146e28b01011f946c578804a8141fe9a371f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79925 Tested-by:
-
Nicole Cordes authored
The GlobalEventHandler changes the location of the current (target) window. The location is set to a given destination without any ability to interrupt. The existing ConsumerScope API isn't used even if the current window is the ContentContainer. This patch extends the handling of a navigation action by checking its target window and using proper ContentContainer API to set the location. Therefore registered listener can deny a location change and trigger own functions. Resolves: #95474 Resolves: #100114 Releases: main, 12.4, 11.5 Change-Id: If6a3b1cc546e1f2ff0b8e9fed3f83055f3f55e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77720 Tested-by:
-
Tomasz Woldański authored
When using GA4, Google's scripts add "_gl" param to track cross domain links. See https://support.google.com/analytics/answer/10071811?hl=en Resolves: #101302 Related: #101180 Releases: main, 12.4, 11.5 Change-Id: I6c32db355a7a1306710cff9768187f687ce4b5a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79935 Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
Philipp Kuhlmay authored
Replace link to the documentation of the "crawler" community extension. Releases: main, 12.4, 11.5 Resolves: #101300 Change-Id: Ie284fcb1850f655fb3541653326f7c6c0ed79c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79933 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Bj�rn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Jul 08, 2023
-
-
Gerrit Mohrmann authored
Resolves: #98178 Releases: main, 12.4, 11.5 Change-Id: I6ebcbb67b9cc51d7d56b1da945fdd8b05d5081dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79869 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Torben Hansen authored
With #99920 the HTTP referrer evaluation has been extended to not overwrite the evaluated HTTP referrer on failed logins. The fix however broke the HTTP referrer evaluation, when the login plugin is placed on a page which is configured as 403 error page. In this case, the page is called via sub-request and a possible available HTTP referrer from the initiating request is used as redirect url. This patch extends the HTTP referrer evaluation, so the URL of the initiating request is used as HTTP referrer variable, if the plugin is called via sub-request. This ensures, that the user is redirected to the URL which the 403 error handler intercepted. In order to do so, the `PageContentErrorHandler` is extended to pass the original request as request attribute `originalRequest` to the sub-request. Additionally, the evaluation of the referrer URL has been moved to `RedirectHandler` and all scenarios have been covered with tests. It has to be noted, that in TYPO3 11.5 the fix will only work, if the "Subrequest page errors" feature toggle is enabled. Resolves: #100715 Releases: main, 12.4, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ibcfdf5093eac72f1796d15f40ef9426d0597d7f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79704 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
- Jul 07, 2023
-
-
Stephan Großberndt authored
Backend no longer crashes with an TableNotFoundException if a table has been removed and an according item is in the list of recent documents. The patch catches the exception. Releases: main, 12.4, 11.5 Resolves: #101139 Change-Id: I489d8cf1ee2bb10800fe2966ae4fc1cb0bcd57c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79842 Tested-by:
-
- Jul 06, 2023
-
-
Oliver Hader authored
The filename of uploaded files might not be encoded as normalized unicode. For instance, this happens when using umlauts in filenames on HFS+ filesystem (macOS). For instance the client sends an `ö`, which is sent in NFD as `0x6fcc88`, but should be normalized as `0xc3b6`. https://en.wikipedia.org/wiki/Unicode_equivalence#Normalization Executed commands: composer req symfony/polyfill-intl-normalizer:^1.27 composer req symfony/polyfill-intl-normalizer:^1.27 \ -d typo3/sysext/core --no-update Resolves: #101253 Releases: main, 12.4, 11.5 Change-Id: I8605481ffdc3b5d96f529850bf09a1fd75d09cd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79838 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Sybille Peters authored
The redirects documentation contains a link to the issues on the page "Known problems", using a category filter. This used to be "Link Handling, Site Handling & Routing", but redirects now have their own category "Redirects Handling", so we use this. Resolves: #101260 Releases: main, 12.4, 11.5 Change-Id: Ife6c4bbd7b2db1476054d5ce2558f84f32ab4800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79830 Tested-by:
-
Stefan Froemken authored
In case of activated STRICT_TRANS_TABLES, better known as strict_mode, the index_words record incl. metaphone can not be stored as a string is provided, but an int is expected. As various metaphone related methods in TYPO3 return a string we change the DB type of column metaphone to varchar. We set the length to 60 as it is the same we use in analyzeHeaderinfo(). Resolves: #99547 Releases: main, 12.4, 11.5 Change-Id: Ice4223f2169595b781ed8c3a7dd5dda3f50e8a1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79818 Tested-by:
-
Susanne Moog authored
The "show dialog" option is an option below the notification settings of each workspace and therefor only impacts the notification settings. A dialog will still appear, allowing the user to add a comment. The documentation now reflects this. Releases: main, 12.4, 11.5 Resolves: #101255 Resolves: #84629 Change-Id: I16b4d80cb454f77afe9fb0e8783920b41e3991ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79784 Reviewed-by:
-
Philipp Kitzberger authored
I've just found out how to hide the fields from the table and table cell dialog without hacking the source code. Releases: 11.5 Resolves: #97285 Change-Id: I46d2f528bbac22a6e29f3d37e6ba5c4c742e026e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74159 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
jakotadesigngroup authored
Nullable time fields with value null (not set) are reset to 0 on update. This changes the value from not set to midnight. It is not so problematic for date fields as there reset value, for the time being, is null also. But this behavior is wrong anyway. Resolves: #99847 Releases: main, 12.4, 11.5 Change-Id: I080b6bb1ad00a025967d9626632ff71b8fb2193a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78168 Reviewed-by:
-
Henrik Elsner authored
Resolves: #97710 Resolves: #97639 Releases: main, 12.4, 11.5 Change-Id: I5ff95d2d8c4d31105a95da3a18467adb0f7d3852 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79779 Tested-by:
-
Benni Mack authored
This change allows user-lang code when using TYPO3's PSR-7 implementation to also use integers and floats for header values. This change popped up in PHP 8.0 environments. Resolves: #101001 Releases: main, 12.4, 11.5 Change-Id: Ia4d3309ef5c6c4f4357eed75bb0ddad40503d132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79781 Tested-by:
-
Andreas Fernandez authored
TYPO3 ships some default handling for encrypted email links and popup windows. Unfortunately, only links that were available on initial document load were handled, links that were added after couldn't get handled. To solve the issue, the events are not directly bound to such links anymore, but handled by an event delegation approach. Resolves: #101228 Releases: main, 12.4, 11.5 Change-Id: I8ec5d5736d9f9cfe8496cf69cf1128f1af4c0eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79762 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jul 05, 2023
-
-
Mario Lubenka authored
Until TYPO3 CMS 10.4 the ValidatorTask could be used without sending the validation report via email. The task could be used to re-crawl all links and update the reports in the module only. This behaviour is restored by sending emails only if an email address is set. Resolves: #97431 Releases: main, 12.4, 11.5 Change-Id: I63197605c272f56449f933abd08d0c05bd7a7661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79773 Reviewed-by:
-
Benni Mack authored
Kudos to Georg Ringer for the hint. Resolves: #98600 Releases: main, 12.4, 11.5 Change-Id: I1c200b4a8835bdccc4e9dc2cf2cee423459a13c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79747 Tested-by:
-
Oliver Bartsch authored
Resolves: #101248 Releases: main, 12.4, 11.5 Change-Id: If7954c44729897bf807bb06dd864fdfbf7f3f7eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79745 Reviewed-by:
-
Florian Schöppe authored
The indexed_search extension uses a truncated md5 hash for building a word index. The truncation greatly increases the probability for collisions. These collisions are the root cause for the problems that are described in the related issues. The best solution would be to either use full-length hashes or no hashes at all. As this is not possible without changing the database schema and rebuilding the whole word index, this patch prevents the exceptions caused by the hash collisions. This is done by removing all words with colliding hashes before the word index is updated. Note that this patch just makes it possible to index page contents that contain hash collisions (words with colliding hashes) again. The affected words are obviously not added to the word index and though won't yield results when searched for. Resolves: #101249 Related: #84541 Related: #90977 Related: #87138 Releases: main, 12.4, 11.5 Change-Id: I5bf7d562ee42f63a5eeb99381b252018439bfaab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79754 Tested-by:
-
Benni Mack authored
This change adds an additional guard clause check to avoid SQL errors when an invalid row is entered. Resolves: #98189 Releases: main, 12.4, 11.5 Change-Id: Iecb12b9c6ef97fb603c8b720d5e2be7433543637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79739 Tested-by:
-
Florian Schöppe authored
Added tests for: - indexing contents and words - a basic search - metaphone search Resolves: #97732 Releases: main, 12.4 Change-Id: Id56e09f129de4bd13092f584e97eedc9fd326b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79737 Tested-by:
-
Thomas Hohn authored
The following classes were marked as @internal in TYPO3 11 since the feature was experimental. This should have been removed with TYPO3 12. The @internal has now been removed for: \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderInterface \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderPropertyManager \TYPO3\CMS\Core\Authentication\Mfa\MfaViewType Resolves: #101237 Related: #100224 Related: #93526 Releases: main, 12.4, 11.5 Change-Id: Iad9b3337a595c2ee1b9162f4cd1463d3c45881f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79716 Tested-by:
-
Andreas Nedbal authored
Prepared nodes were not properly handled in the category element, causing the indetermination state recalculation to never trigger properly. Using the nodes from the nodes-prepared event fixes this issue. Resolves: #98689 Releases: main, 12.4, 11.5 Change-Id: I63f9618c596cdad343d4af8393120eabae3fdbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79689 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jul 04, 2023
-
-
Stefan Bürk authored
With #89091 pages with slugs containing trailing slash have been enabled to be resolved when requested with trailing slash in the request uri and have been a logical follow-up of #86055. In between an issue with language fallback chain have been found, which allowed that a valid translated page could be resolved with the default language slug even and reported as #88715 and #96010. These issues have been solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 which partly broke the original implemented behaviour for pages with trailing slash slugs requested without a trailing slash. This change now ensures pages are resolved containing a trailing slash in their "slug" like "/my-page/subpage/" if requested without the trailing slash like "https://domain.tld/my-page/subpage". Additionally, tests are added to cover this case along with other possible cases. This should detect future regressions. The docblock return annotation for `PageRouter::matchRequest()` is changed to the correct returned value, removing ignore pattern for the phpstan baseline instead of increasing the counter. Note: This change ensures that a page can be resolved in any constellation with trailing slash in record slug/not in record slug and requested with trailing slash/not requested slug. In both cases, already working and the now fixed variant are serving both potential duplicate content - if no correct cannonical url is provided. Tackling the duplicate issue should be done in a dedicated change for both cases. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100990 Related: #96010 Related: #88715 Related: #89091 Related: #86055 Releases: main, 12.4, 11.5 Change-Id: I9f26c4500e2f812e8727b4b565570fcc579bf3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79705 Reviewed-by:
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79676 Tested-by:
-
Guillaume Germain authored
Use array chunked query combined with direct value list to retrieve full data set in `DataMapProcessor` methods `fetchTranslationValues` and `fetchDependentElements`. Resolves: #99326 Releases: main, 12.4, 11.5 Change-Id: Iaf220014cd991002450779197169c5c32a3c7dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79692 Tested-by:
-
- Jul 03, 2023
-
-
Oliver Bartsch authored
Resolves: #101194 Releases: main, 12.4, 11.5 Change-Id: I431e0af6b35d85aed0a3834c16b9f75c2923bfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79635 Tested-by:
-
Benni Mack authored
This change prevents a PHP warning in ContentObjectRenderer when working with "max" and "begin". Resolves: #100857 Releases: main, 12.4, 11.5 Change-Id: I1af115deecc537efdc41125daa119630d6449044 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79549 Tested-by:
-
Benni Mack authored
Resolves: #100538 Releases: main, 12.4, 11.5 Change-Id: Ia0e37a39ed566938a9b9f947ad21949a9ab3b0bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79551 Tested-by:
-
Torben Hansen authored
This change moves the section about "Access restrictions on the felogin plugin" to the user manual, since the section is not an example, but an important notice for users of the plugin. The part about having two plugins on one page has been removed, since this will lead to other problems as noted in the "Known problems" chapter. Additionally, a short notice about the "Hide at login" problem has been added to the "Known problems" chapter. Resolves: #100632 Releases: main, 12.4, 11.5 Signed-off-by:
-
Markus Klein authored
All PHP code is adjusted to use proper spelling "referrer". Existing Fluid variables or config options are not touched. Resolves: #101216 Releases: main, 12.4, 11.5 Change-Id: I8d18b1f269c921d01bcd1b5c3b7017527d92e72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79582 Tested-by:
-
Tymoteusz Motylewski authored
Include Matomo, Google, Hubspot. Resolves: #101180 Releases: main, 12.4, 11.5 Change-Id: I15ba4d4ec84e5abfb22e5f83d02535e06e2de40f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79540 Tested-by:
-
- Jul 01, 2023
-
-
Christian Kuhn authored
A new patch level requires to regenerate baseline. > composer req --dev phpstan/phpstan:^1.10.22 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101214 Releases: main, 12.4, 11.5 Change-Id: I762846574afa26b6b4bc0ae122b07be3dde99c73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79578 Tested-by:
-
Nikita Hovratov authored
The previous logic for checking whether a value for a specific doktype already exists falsely assumed the value should be an array. This is now fixed by using the null coalescing assignment, which is available since PHP 7.4. Resolves: #101196 Related: #94498 Releases: main, 12.4, 11.5 Change-Id: Iab1dba7987d336b08bfb4f398b16666d591daada Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79537 Tested-by:
-
- Jun 29, 2023
-
-
Andreas Fernandez authored
The fix for #100750 aimed to apply `array_unique()` to the array containing page ids used as webmounts for the backend search. Unfortunately, the call was done only for the storage in the runtime cache with the side effect that still the full array with possible duplications is returned on first invocation. The affected `array_unique()` call is now extracted into a separate line right before storing the resulting array to cache, which results in returning the same, unified array. Resolves: #101200 Related: #100750 Releases: main, 12.4, 11.5 Change-Id: Idbe6f1639ec84737ab151d5ab2d18739736e2327 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79563 Tested-by:
-
Oliver Hader authored
Adds tests for site resolving by e.g. https://example.org/?id=1&L=0 Resolves: #101198 Releases: main, 12.4, 11.5 Change-Id: Ie6a3db97181662e2d3570eb8e93bebaa9c3509c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79557 Tested-by:
-
- Jun 27, 2023
-
-
Benni Mack authored
In the site configuration, the value is called "flag", whereas in TypoScript or in the SiteLanguage object, it is called "flagIdentifier" which is longer, but technically more correct. This change now also allows to use page.10 = TEXT page.10.data = siteLanguage:flag instead of page.10 = TEXT page.10.data = siteLanguage:flagIdentifier to avoid confusion for integrators. Resolves: #94347 Releases: main, 11.5 Change-Id: Ie15614bd7ec7d7461fbecc4cc791314bda2c236f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79512 Tested-by:
-
