- Sep 07, 2018
-
-
Benjamin Franzke authored
When there is no site configuration, no TCEMAN.preview configuration and no sys_domain record available, the host URL needs to be derived from TYPO3_SITE_URL. This recently broke (and was fixed). Due to wrong logic the protocol was added twice, resulting in URLs like: http://http://hostname.tld/ It initially broke due to the site handling features, probably with https://review.typo3.org/57949 A condition became dead, due to $domain being always set, when it was null before that change (if a sys_domain record could not be found). The bug was fixed by adding an additional condition (without removing the dead "else" condition) in https://review.typo3.org/c/58177/ This patch tries to clean this up by removing the new condition (introduced in #58177) and rather restructure the code. To circumvent those bugs and to avoid confusion what $domain actually refers to (now always including the protocol) the code is refactored to not re-assign $domain over and over again. Change-Id: I155db1b91357bb6345da1ef469d32b0125344b16 Releases: master Resolves: #86140 Reviewed-on: https://review.typo3.org/58182 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Using a custom renderType instead of a userFunc for type=user TCA elements is much more flexible and suits better into the overall FormEngine node construct. The patch deprecates userFunc and outlines details on how existing ones can be migrated over to custom renderTypes without much hassle. Resolves: #86163 Related: #86109 Releases: master Change-Id: I2bad5f79dab5643efe7f8dc959e788b9426bfdd6 Reviewed-on: https://review.typo3.org/58198 Tested-by:
-
Christian Kuhn authored
Resolves: #86182 Releases: master Change-Id: I80b8b519ad530d5d98e284e0666cd6c2eb3f5603 Reviewed-on: https://review.typo3.org/58212 Reviewed-by:
rolandgolla <rolandgolla@gmail.com> Reviewed-by:
-
Christian Kuhn authored
There are only two methods in the report controller, calling them via call_user_function() does not make much sense. The patch simplifies the dispatcher logic and sets the two actions to protected. Note this does not affect the extendability of the reports module itself. Resolves: #86184 Related: #84231 Releases: master Change-Id: Ia329b7de7251825028a5587899be3f6c694873e5 Reviewed-on: https://review.typo3.org/58214 Reviewed-by:
-
Anja authored
In order to create workspace stage records, the parenttable field must not be a tinytext, else the not null restriction fails on SQlite. Change-Id: I38cb8fca0eb293100ab7d73433cc284307eb1d0d Resolves: #85405 Releases: master Reviewed-on: https://review.typo3.org/58210 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Andreas Fernandez authored
If root pages are configured in workspaces, such pages must not get rendered in the sites module. The BackendWorkspaceRestriction is added to prevent fetching such pages in the LIVE workspace. Resolves: #86174 Releases: master Change-Id: I35a614d41125516a65cd1d2bce917c04f6af57ac Reviewed-on: https://review.typo3.org/58202 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
Georg Ringer authored
The site module displays now also sites with no valid related page anymore. This can happen if the page is being removed. Resolves: #86150 Releases: master Change-Id: If75a33e6c2d189abd42746b52d0b828b7a7b38cb Reviewed-on: https://review.typo3.org/58192 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Timo Hund <timo.hund@yahoo.com> Tested-by:
-
Andreas Fernandez authored
When the slug is calculated by using the according button, the `event` is now triggered to let the user know that the field value has changes and to invoke the "You have unsaved changes" modal when closing the form. Resolves: #86190 Related: #86077 Releases: master Change-Id: I6eb4e11252562f53e637e3a1abdd7b02a8f73a5a Reviewed-on: https://review.typo3.org/58218 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Hader authored
Resolves: #86191 Releases: master Change-Id: Ie65dac040f720c313835603bd2446a15e6670c14 Reviewed-on: https://review.typo3.org/58220 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
If a relation field (select / group) does not exist in db for whatever reason, System -> DB check -> Database relations crashes. Resolves: #86167 Releases: master, 8.7 Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982 Reviewed-on: https://review.typo3.org/58201 Tested-by:
-
Christian Kuhn authored
Resolves: #86180 Releases: master Change-Id: I6277be526cb11d1c6120f13e763d47405aac84d0 Reviewed-on: https://review.typo3.org/58211 Tested-by:
-
Christian Kuhn authored
Resolves: #86179 Releases: master Change-Id: Ie61ab04889e36b5290a0d8f4fc1fb68dd95a87ac Reviewed-on: https://review.typo3.org/58209 Tested-by:
-
Christian Kuhn authored
If rendering page trees in Info -> Pagetree overview that has a full Site configuration, hide the "alias" field - it is not shown in FormEngine, either. If rendering a PseudoSite (no site configuration), hide the slug field. Resolves: #86175 Releases: master Change-Id: I46ccb150184e4b76799ab8636ac280eda269c76b Reviewed-on: https://review.typo3.org/58204 Tested-by:
-
Oliver Hader authored
Resolves: #86191 Releases: master Change-Id: I45d265cd6866dff1ab8fc0a058973c24471ac357 Reviewed-on: https://review.typo3.org/58219 Tested-by:
-
Frank Naegler authored
Since the symfony expression language is available for TypoScript conditions, the old condition syntax is being deprecated. Resolves: #86068 Releases: master Change-Id: Iae1f4b6e400afbab233561af54c98bc4a4a40792 Reviewed-on: https://review.typo3.org/58109 Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Christian Kuhn authored
With the new upgrade wizard API the InstallStatusReport has to be adapted a bit to prevent a fatal calling shouldRenderWizard() on wizards that don't have this method. Resolves: #86183 Releases: master Change-Id: I0551c0a823a0a6f670c0ca079a1f2f4475ccf583 Reviewed-on: https://review.typo3.org/58213 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Helmut Hummel authored
Remove implementation details from public API methods Releases: master Resolves: #86166 Change-Id: I3605132946d4fa1e92eccfa91498290dab4762c2 Reviewed-on: https://review.typo3.org/58199 Tested-by:
-
- Sep 06, 2018
-
-
Anja authored
All values are available in the request object, no need to touch the globals. The constructor of the controller is empty after the replacement, so it can be removed. Change-Id: Ieb0d714965716638d51a982a858341938700572f Resolves: #86146 Releases: master Reviewed-on: https://review.typo3.org/58185 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Nicole Cordes authored
This patch ensures a connection can be established multiple times and is initialized correctly using the init commands on each fresh connection call. Resolves: #86154 Releases: master, 8.7 Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5 Reviewed-on: https://review.typo3.org/58189 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Sep 05, 2018
-
-
Georg Ringer authored
The query parameter of the live search should be trimmed. The same behaviour is already used in the regular search in the list module which is available in the live search by clicking on the button "show all". Resolves: #86149 Releases: master, 8.7 Change-Id: I3ec2ac03f67fa8c0daaa11aaf3e4351d05949b83 Reviewed-on: https://review.typo3.org/58188 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Richard Haeser authored
Pages with no_index, follow shouldn't show up in XML sitemap. Only pages that needs to be indexed. Resolves: #86157 Releases: master Change-Id: I609b321d8cd256ceac6599b6a0516c8b3994928b Reviewed-on: https://review.typo3.org/58191 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
- Localize labels - Use label_alt to show not only errorCode but also errorHandler Resolves: #86148 Releases: master Change-Id: I699117be14d5b2c14f6d9325f7a3f4ecabd1382c Reviewed-on: https://review.typo3.org/58187 Tested-by:
-
Anja authored
The class is called by two ajax routes and is therefore to be named, placed and handled as the controller that it is. Change-Id: I5106f5310041d3f0a993c2bf7ebe03ac51454cad Resolves: #86142 Releases: master Reviewed-on: https://review.typo3.org/58183 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Benni Mack authored
The class is not in use anymore, only feedit instantiates the class for legacy reasons. Also FrontendBackendUserAuthentication->frontendEdit which holds an instance of that, is deprecated. Resolves: #86110 Releases: master Change-Id: I3ff2ae529dd920d2abf9908f2ae94ae4c2bf9c15 Reviewed-on: https://review.typo3.org/58067 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Sep 04, 2018
-
-
Oliver Hader authored
Change-Id: I96b70e192770b6955f82a8106db386f2044e738b Reviewed-on: https://review.typo3.org/58181 Tested-by:
-
Oliver Hader authored
Change-Id: I10cf279d74af2cfc2964704ba31c6ce2b7be3493 Reviewed-on: https://review.typo3.org/58180 Reviewed-by:
-
Oliver Hader authored
Resolves: #86126 Releases: master Change-Id: I7724cb1415742861a0c6496f4e3888787e6467d4 Reviewed-on: https://review.typo3.org/58160 Tested-by:
-
Oliver Hader authored
In order to correctly work with rootlines (e.g. when resolving according sites and pseudo-sites for URL resolving and generation) possible version move placeholders have to be resolved. Resolves: #86137 Releases: master Change-Id: Ief9841f7592018292c034c03c45343363cf79248 Reviewed-on: https://review.typo3.org/58178 Reviewed-by:
-
Anja authored
The change also contains some documentation related improvements in some code files, where the need occured. Change-Id: I346fd70e20bd0765ac4cc663dc7e3fd73d02651b Resolves: #86075 Releases: master Reviewed-on: https://review.typo3.org/58166 Reviewed-by:
-
Benni Mack authored
When having a pseudo-site the view functionality is broken due to some different handling how to deal with protocols. Resolves: #86134 Releases: master Change-Id: Ia3b08ce968ecfdce631ce9c7ff9c973cfb25eef5 Reviewed-on: https://review.typo3.org/58177 Tested-by:
-
Georg Ringer authored
Show the error with a proper markup. Also hightlight type and render type as code. Resolves: #86133 Releases: master, 8.7 Change-Id: I79323aaff834c47e6ff875f8a584b2c88f42c51d Reviewed-on: https://review.typo3.org/58173 Reviewed-by:
-
Benni Mack authored
Due to refactorings lately in BackendUtility::getPagesTSconfig() with which results in a fatal error when clearing page cache while persisting an extbase object. The patch adds a test without a Backend User, and encapsulates this with a simple if() statement. However, this also shows that some other areas that are touched are not fully notice-free / strict, which are tackled as well. Resolves: #85310 Releases: master Change-Id: I0f1318d395451e704e1783e841d96583efe2a560 Reviewed-on: https://review.typo3.org/58174 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Fernandez authored
If a node in the page tree is clicked, the `nodeSelectedAfter` event is triggered for any active node that is being deactivated. The event listener is now aborted if the event is called on a unchecked node. Resolves: #85787 Releases: master Change-Id: I4fa5bbc4290b5ffd2ecb77a901dceb042dff3d27 Reviewed-on: https://review.typo3.org/57836 Tested-by:
Paweł Rogowicz <rogowicz.pawel@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Andreas Fernandez authored
The template module now respects the workspace constraint of the current backend user and the stored sys_template records. Resolves: #86131 Releases: master, 8.7 Change-Id: I0463844c4222957aede4b4ca749a3368cb399f81 Reviewed-on: https://review.typo3.org/58171 Tested-by:
-
Benjamin Kott authored
Resolves: #86132 Releases: master Change-Id: I34a09ec83491b0f08e0a094680fbd93057ad76a4 Reviewed-on: https://review.typo3.org/58172 Reviewed-by:
-
Georg Ringer authored
Fix 1px off error in page tree toolbar. Resolves: #86098 Releases: master Change-Id: Ia1476d57b935159fc32e40a9134c7c7a1e9a6ef3 Reviewed-on: https://review.typo3.org/58167 Reviewed-by:
-
- Sep 03, 2018
-
-
Jigal van Hemert authored
The arguments are now treated as parts of a UTC date/time and prevents different results depending on the system date.timezone settings. Releases: master Resolves: #86128 Change-Id: Ieb336ea43eb246ec0e0c5a7db8194c03a0801f83 Reviewed-on: https://review.typo3.org/58165 Reviewed-by:
-
Benni Mack authored
If two subpages share the same name, it is important, that the first page gets a proper name, and the second one follows the uniqueInSite pattern. Also, sorting by workspaces (live first), PID and then sorting seems to be just logical. I wonder why I did not add this before. Resolves: #86120 Releases: master Change-Id: I53f279034c2c61a31b50fc973721827f0c2685ba Reviewed-on: https://review.typo3.org/58153 Tested-by:
-
Oliver Hader authored
This change ensures that workspace version placeholders are kept in sync when slug values (TCA type 'slug') are modified in their specific workspace version. This is done implicitly without the requirement to define shadowColumnsForNewPlaceholders in TCA. Resolves: #86117 Releases: master Change-Id: I11baab1e2154b5f3a043a29c08617c0ad360226a Reviewed-on: https://review.typo3.org/58150 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Hader authored
BackendWorkspaceRestriction automatically resolves specific records already for a given workspace. In most cases this seems to be fine to omit the usual workspace overlay processing. However, especially when dealing with references and page tree assignments, it just contains wrong information. For instance all workspace versions have the `pid` column set to -1 which of course cannot be resolved as valid page then. Resolves: #85917 Releases: master, 8.7 Change-Id: Ibe20037b25770bea8f58d1a8bba785ca43ac26cb Reviewed-on: https://review.typo3.org/57982 Tested-by:
-
