- Apr 18, 2024
-
-
Christian Weiske authored
Feature #89650 added support for newlines in TCA field descriptions, but palette descriptions were forgotten. This patch makes newlines in palette descriptions visible in the same way. Resolves: #103659 Related: #89650 Releases: main, 12.4 Change-Id: Ib505f476eb0f3efd0bf75bee7550b9e203ccda2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83894 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Calculation of reference index for workspace relations has a nasty bug in getListOfActiveWorkspaces(): It always returns only the first workspace id when there are multiple. This isn't good in v12 since it creates broken or missing index entries with MM. It is worse in v13, since refactorings of the class use the method for some additional operations. The patch fixes the broken helper method. Resolves: #103655 Related: #96067 Related: #103661 Releases: main, 12.4 Change-Id: I989b22f9c25b22f52030c3dbce742074d2e09f97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83920 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Resolving relations in RelationHandler for MM in workspaces is a two fold process: readMM() first finds all relation "candidates". A second step then filters live MM relations from the candidate list that have a workspace overlay. In general, it *should* be possible to combine this rather expensive operation into a single query. This however requires a bigger rewrite of the class, which absoletly needs to happen at some point, especially for performance considerations. There is however a significant bug the patch aims to solve now: The result set of MM relations tends to return relations not only of the workspace-uid that has been requested, but relations of other workspaces as well, due to an insufficient query with improper filter logic in the second part of the process. This patch is important for a bug fix within ReferenceIndex, which - when fixed - triggers the currently broken RelationHandler relation calculation. Resolves: #103661 Related: #103655 Releases: main, 12.4 Change-Id: If42c138321f0043bf9d8c363f0e20e61d649e1e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83918 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev flag-icons@^7.2.1 npm run build Resolves: #103656 Releases: main, 12.4 Change-Id: Ibebf001a8867104d616777adf47b7c0edaccbf9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83893 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Nikita Hovratov authored
In case of CLI context, normalized params are not available and as they are nullable, a guard condition is required before accessing methods. Note: The access via request object was added in #100047 along with a deprecation of using the ip() function in TSConfig. However, there is a special case, where plain TypoScript is loaded even in CLI context. For example this can happen when EXT:form listens to FlexForm data structure parsing event. Then it needs information from TypoScript on how to manipulate FlexForm based on YAML definitions. Resolves: #103644 Related: #100047 Releases: main, 12.4 Change-Id: Id2d166fd11794db9b7a8102677e5b9305fe18c59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83892 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Apr 17, 2024
-
-
Rafal Jania authored
Resolves: #103596 Related: #97548 Releases: main, 12.4 Change-Id: I2384d223202af1575a93497f81e6a69599ebbc3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83873 Tested-by:
-
Christian Kuhn authored
When a TCA table has no 'ctrl' 'tstamp' field defined, the workspace module crashes with an undefined array access for records of this table. Sanitize this. Resolves: #103650 Releases: main, 12.4 Change-Id: I3f8c6a1788ec2f9e8f03eddaf9c2ed4df5d737e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83849 Tested-by:
-
Nikita Hovratov authored
The $event parameter is now added and a superfluous parenthesis is removed in the condition. Also, the $tableName variable is used now. Resolves: #103645 Related: #98375 Releases: main, 12.4 Change-Id: I8f827ac7f6941ab03a6f5c67e9fb3525d1a79868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83856 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Apr 16, 2024
-
-
Benjamin Kott authored
Resolves: #103638 Releases: main, 12.4 Change-Id: Ib5880f2ea62c8d9b54b7db6f6488fc6d5a479827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83855 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Willi Wehmeier authored
Add proper focus styles to the nav links in the Link Browser modal window. Resolves: #103631 Releases: main, 12.4 Change-Id: I0abb597124e335c3955c73438ac3cd2f0dad93bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83854 Tested-by:
-
Christian Rath-Ulrich authored
To trigger a search, usually an icon-only button is placed next to the search input field. To improve the accessibility of these icon-only buttons, a visually hidden label is added. Resolves: #102410 Releases: main, 12.4 Change-Id: Ifd7faee3d4c727dd2e86ad7304e19f970b61699e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83835 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Lina Wolf authored
Remove excess bracket Releases: main, 12.4 Resolves: #103635 Change-Id: Ie9ea1f03457177eeb6be7abb788c05bd2bf64e8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83853 Tested-by:
-
Torben Hansen authored
The new core `HashService` and the deprecated extbase `HashService` have the function `validateAndStripHmac` to validate and strip a given HMAC appended string. The function will throw an exception, if the given string is either too short or the appended HMAC in the string is not valid. In context of a TYPO3 extension, those exceptions are usually thrown, when a given HMAC appended string has been tampered. Logging those exceptions to sys_log or logfiles make no sense, since a TYPO3 site owner have no reasonable possibility to prevent a tampered HMAC appended string being passed to the `validateAndStripHmac` function. This change prevents logging of four exceptions caused by potential manipulated HMAC appended strings. Additionally, a note has been added to extbase `HashService`, that exception codes from that class must be removed in v14 in `AbstractExceptionHandler::IGNORED_HMAC_EXCEPTION_CODES`. Resolves: #103592 Releases: main, 12.4 Change-Id: I2870db815f3348cac2465b1caca711f4736f16db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83833 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Oliver Bartsch authored
While introducing the new module registration API, the previously used page TSconfig options to hide modules has been replaced by an extended user TSconfig option. This change (page TSconfig -> user TSconfig) is now clarified in the corresponding changelog. Resolves: #103627 Releases: main, 12.4 Change-Id: Ic701cf0674c8ff1ed18273ad2629b2217947f7c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83852 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Apr 15, 2024
-
-
Oliver Bartsch authored
The search word is now properly kept on switching between advanced and normal search mode in EXT:indexed_search. Resolves: #103633 Releases: main, 12.4 Change-Id: Ic694e40da3a7bdeee3d76be2402fd4bf8e150e3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83792 Tested-by:
-
Christian Kuhn authored
Backport of https://review.typo3.org/c/Packages/TYPO3.CMS/+/83155 to TYPO3 v12. PHPUnit 10.5.18 introduces deprecation warning due to use of non-matching parameter names with data providers, introduced by https://github.com/sebastianbergmann/phpunit/pull/5812. This patch backports changes that were made for PHPUnit v11 support, which also addresses these kind of deprecation warnings too. Resolves: #103634 Related: #103222 Releases: 12.4 Change-Id: Ia9a1f7c5d62894dc80b3d1f9b465fb488b3250fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83788 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Apr 13, 2024
-
-
Jasmina Ließmann authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files. An attribute was used twice, this is hereby corrected. Resolves: #103620 Related: #103615 Releases: main, 12.4 Change-Id: I4d813f29db0d64f486c1d5593bc8c2b955a8eafb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83761 Reviewed-by:
-
- Apr 12, 2024
-
-
Andreas Kienast authored
The patch for #103615 added `resname` attributes to EXT:dashboard locallang files, but one had a typo. It's fixed now. Resolves: #103616 Related: #103615 Releases: main, 12.4 Change-Id: I2e2ab733e5b7186193cd4f8482b4ff6c0a6e0b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83760 Tested-by:
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83758 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Georg Ringer authored
`DateTimeImmutable::setTimestamp()` requires the timestamp to be an integer. Resolves: #103588 Related: #99627 Related: #98045 Releases: main, 12.4, 11.5 Change-Id: I2dba1b3836063872fa04ea38d58b5bd499a8f7d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83756 Tested-by:
-
Christian Kuhn authored
New version phpdocumentor/reflection-docblock:5.4.0 changed the signature of DocBlockFactory::createInstance(), which now points out a misuse in extbase. The patch changes the instantiation and avoids calling registerTagHandler() since this can and should be hand over to createInstance() directly. Resolves: #103614 Releases: main, 12.4 Change-Id: I344ef7df23dedd950c2775fe2fab93f7bb808786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83751 Tested-by:
-
- Apr 11, 2024
-
-
Stefan Bürk authored
Test covering the SQL file parser has been streamlined and enriched with #103602, adding a disabled test with a todo to enable it when the SuT is fixed. Turns out the parser already handles the case well, the patch just enables the test. Resolves: #103605 Related: #103602 Releases: main, 12.4 Change-Id: I4b39dce5265c2504a9dc5f11a70dfe94702d0451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83754 Tested-by:
-
Stefan Bürk authored
* Add variable names as dataprovider set array keys to increase readability. * Add dataset for double-quote parsing in default values. * Add a disabled dataset for single-quote parsing in default values with todo to enable it with the bugfix. Resolves: #103602 Releases: main, 12.4 Change-Id: Ie85deff13598238fc437f6781b6ccf8349801846 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83753 Reviewed-by:
-
Christian Kuhn authored
RootlineUtility uses RelationHandler to resolve relations attached to pages. The tests from #103598 show that relations which are set to deleted ("delete placeholder", t3ver_state=2) are not considered and still part of the result set. The patch adds a missing call to prevent these. Resolves: #103599 Related: #103598 Releases: main, 12.4 Change-Id: Ie580e4d9b64c477d8c9d6d4092114c18f43a2a70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83739 Reviewed-by: -
Christian Kuhn authored
* Increase abstraction in imported CSV fixture to separate scenarios from each other. * Turn single tests into a single test powered by a data provider. * Add tests for pages['media'] relation resolving. * Point out a bug related to a deleted workspace relation. Resolves: #103598 Related: #103566 Releases: main, 12.4 Change-Id: I679534f1837a4dc73e1d875bf5ee26f45566889d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83736 Tested-by:
-
Andreas Kienast authored
This commit updates ckeditor to 41.3. See changelog at [1]. Executed commands: npm install --save \ @ckeditor/ckeditor5-alignment@^41.3.0 \ @ckeditor/ckeditor5-autoformat@^41.3.0 \ @ckeditor/ckeditor5-basic-styles@^41.3.0 \ @ckeditor/ckeditor5-block-quote@^41.3.0 \ @ckeditor/ckeditor5-clipboard@^41.3.0 \ @ckeditor/ckeditor5-code-block@^41.3.0 \ @ckeditor/ckeditor5-core@^41.3.0 \ @ckeditor/ckeditor5-editor-classic@^41.3.0 \ @ckeditor/ckeditor5-engine@^41.3.0 \ @ckeditor/ckeditor5-essentials@^41.3.0 \ @ckeditor/ckeditor5-find-and-replace@^41.3.0 \ @ckeditor/ckeditor5-font@^41.3.0 \ @ckeditor/ckeditor5-heading@^41.3.0 \ @ckeditor/ckeditor5-horizontal-line@^41.3.0 \ @ckeditor/ckeditor5-html-support@^41.3.0 \ @ckeditor/ckeditor5-indent@^41.3.0 \ @ckeditor/ckeditor5-link@^41.3.0 \ @ckeditor/ckeditor5-list@^41.3.0 \ @ckeditor/...
-
- Apr 10, 2024
-
-
Jasmina Ließmann authored
If no page has been selected in the "Indexing" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of as a heading. Resolves: #103590 Releases: main, 12.4 Change-Id: I6e44c5ad8502eb7ecb71581cb11084543c3e13aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83752 Tested-by:
-
Christian Kuhn authored
This is a late backport of a v13 patch to prepare changes that have to go into v12 as bug fixes. Tests: * Merge remaining unit tests into functional tests. * Switch from YAML based DB scenario creation to direct CSV import to gain more control in tests. * Test reference index integrity of import CSV. * Move some not related fixtures to a more suitable directory. Resolves: #103566 Releases: main, 12.4 Change-Id: Ife5c2e115abfcf3f399ebc49dcf5759461812293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83731 Tested-by:
-
- Apr 09, 2024
-
-
Benni Mack authored
Change-Id: I0e897680df27e5380344f4436a7db7a6085d0688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83717 Reviewed-by:
-
Benni Mack authored
Change-Id: Ibd990830d7ad9d43707be802c6a24a1388589d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83716 Tested-by:
-
- Apr 08, 2024
-
-
Stefan Bürk authored
This change adds additional tests to cover additional variants for `EXT:redirects` handling. Placing guards helps to avoid mitigating regressions for these cases. Resolves: #103564 Related: #103395 Related: #103555 Releases: main, 12.4 Change-Id: I4b6deb258610d1a3d416c16eec610aa2bfd9ef72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83665 Tested-by:
-
Stefan Bürk authored
Redirects can match even if no SiteConfiguration could be determined for the current request and a `NullSite` has been added as request attribute. In this case, the `RedirectService` already resolves a SiteConfiguration for the matched redirect. Bootstrapping a `TypoScriptFrontendController` is done using the resolved SiteConfiguration, still using the NullSite in the request for id determination and loading TypoScript. In cases where no real `sys_template` records exists, for example when `b13/bolt` is used to provide fake rows, it is important to avoid NullSite. This change uses the redirect target based resolved site in case the request does not contain a valid site object. Prepared test from #103555 is enabled now to guard this case for the future. Note: TYPO3 v13 recieved quite some refactoring in the Middleware, TSFE and TypoScript loading order a long with a factory and fixed this already. This is a simple solution for TYPO3 v12. Resolves: #103395 Related: #103555 Releases: 12.4 Change-Id: If3d3003c8af1799e19937328c00fedb7b32562c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83701 Reviewed-by:
-
Stefan Bürk authored
`\TYPO3\CMS\Backend\RecordList\DatabaseRecordList` provides the ability to modify the QueryBuilder used for the record list representation with the PSR-14 `ModifyDatabaseQueryForRecordListingEvent`, after generic query information like default orderings and similar have been added. That is covered within the `getQueryBuilder()` method, which is used in other class methods, for example in `getTables()` where it is changed to a `COUNT()` query. MariaDB for example is picky about count queries using `order by`, `group by` or aggregation methods which are not reflected or added in the counter parts leading to a not so useful error like Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP BY clause or similar variants. This error message can be missleading for the case a order by has been used along with a COUNT() query. Listener of the event do not get the information if order-by can be added or should be left out, therefore maybe adding sorting conditions for a count query. This change now resets any order statements for the count-query like other places in the TYPO3 core. Resolves: #103427 Releases: main, 12.4, 11.5 Change-Id: Ie421993a1890dd6682d02f54203d538e6ae1b76c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83532 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Georg Ringer authored
The check for content_from_pid is wrong as it is not the raw database record and therefore the relation is an array. Resolves: #103405 Releases: main, 12.4 Change-Id: I31cfc584d9d1164ef96e1c3bec5ec75cc1619bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83662 Tested-by:
-
Christian Kuhn authored
The indexed_search BE module links to word details. This link is broken in main and v12: * In main, the wordHash argument is a string, but the extbase target action expects an int. * In v12, the wordHash is an int, but is misinterpreted as pages-uid. The patch fixes this by switching from the argument name 'id' to 'wordHash' to suppress the pages-uid "convention" to kick in. In main, the target action argument is declared as string and both arguments are set non-optional. Resolves: #103547 Related: #102975 Related: #96797 Related: #103540 Releases: main, 12.4 Change-Id: Ibd4732d086f1af264ee317c7e7d4fe0f15a15aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83680 Tested-by:
-
- Apr 07, 2024
-
-
Stefan Bürk authored
Issue with the `RedirectService` has been reported wiht #103395 related to non-matching SiteConfig in cases no TypoScript template records exists, like when `b13/bolt` is used in instances. Changes #103437, #103439 and #103554 fixed the mentioned issue #103395 for TYPO3 v13, leaving the issue open for TYPO3 v12. Note: For v12 the regression test dataset needs to be disabled for now, and will be enabled with the upcoming fix. This change adds now some tests for non matching SiteConfiguration for `source_hosts`. Resolves: #103555 Related: #103395 Related: #103554 Related: #103439 Related: #103437 Releases: main, 12.4 Change-Id: I2c72de3fa5f8d8aae5e6d2ca702ea4685cd367b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83695 Tested-by:
-
Lukas Maxheim authored
This change introduces the use of the DataHandler instead of the QueryBuilder when creating backend users via CLI command `backend:user:create`. This ensures that the user is initialized with TCA default options and the creation and history of the new user is logged to the TYPO3 log. Resolves: #102062 Releases: main, 12.4 Change-Id: I78f7093108d1df3c6d37ab7545911365d3c846bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83688 Tested-by:
-
Andreas Kienast authored
When t3editor got streamlined in the past, configuration for flex was defined that conflicts with CodeMirror's internal style definition, leading to UI glitches like "cut out" content, see screenshot attached to the ticket.. This commit removes the conflicting CSS. Resolves: #101442 Releases: main, 12.4 Change-Id: Ie5b9f8d498cdaef0b3455e05e247cb5fd64b0617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83685 Tested-by:
-
Markus Klein authored
As documented by PHP, `\DateTime` or `\DateTimeImmutable` objects created with a timestamp only ('@12345678') as the first constructor argument will use UTC as TimeZone. Creating an object instance without any constructor arguments will use the `date_default_timezone_get()` timezone for the object - and setting the timestamp using `setTimestamp()` will not change the object's timezone. That means, that formatting the value will be done using the object Timezone and **NOT** the default PHP Timezone (`date_default_timezone_get()`). Consequently, this may lead to wrong interpretation of the displayed formatted value in the context of another timezone - if no timezone information (+0000/-0100) is included. This change streamlines this for a couple of places were it is expected to format date, datetime or time values for the current context timezone by ensuring objects get the current timezone set instead of `UTC`. Note: Changing the date default timezone on the fly after an object has been created will show a similar effect like using constructor values, even if the object has been created by using the `setTimestamp()` method. [1] https://3v4l.org/sGEe2 Resolves: #98045 Resolves: #99627 Releases: main, 12.4, 11.5 Change-Id: I095a0b0b376361e25396647d02727ac08f35cae0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83682 Tested-by: -
Christian Kuhn authored
The backend uses request GET/POST parameter 'id' as convention for "pages uid" at various places: Especially the BackendModuleValidator checks for this parameter early, to deny access to pages a BE user has no access to. This convention is a broken misuse: There is no such convention, and for instance the filelist module uses 'id' to transfer a selected "storage-uid:path". The BackendModuleValidator mitigates this by calling MU::canBeInterpretedAsInteger() before interpreting that parameter as a pages-uid. The extbase BackendConfigurationManager also uses 'id' to retrieve the FE TypoScript configuration for this "pages-uid", it however does not check with MU::canBeInterpretedAsInteger(), first. The patch adds a MU::canBeInterpretedAsInteger() check to extbase BackendConfigurationManager to be in-line with BackendModuleValidator, and adds `@todo` comments outlining the general misuse of the argument. Change-Id: I9b53a521bde4d3c145bfda2994d81dc4abf9c103 Resolves: #103540 Related: #96797 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83678 Reviewed-by:
-
