- Feb 19, 2018
-
-
Georg Ringer authored
Simplify generation of the error icon by removing the ViewHelper and generate the icon identifier in the model instead. As the ViewHelper is no public API it can be removed without a RST file. Resolves: #83945 Releases: master Change-Id: I7515ff69a729ccb66288437f5236a1ce8fa591c1 Reviewed-on: https://review.typo3.org/55763 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Andreas Fernandez authored
Change-Id: I123e6dae9b0b6a5bb68261bc9ae5aaf75a64822d Resolves: #83926 Related: #83892 Releases: master Reviewed-on: https://review.typo3.org/55741 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
If an edit form is reloaded after the record has been deleted, a message should be shown to the user instead of an exception. Resolves: #83903 Releases: master, 8.7 Change-Id: Ib427ee8601a70c53d63f1afea7f1eacc71fd5da1 Reviewed-on: https://review.typo3.org/55730 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
Georg Ringer authored
Several ViewHelpers inside the extension maanger are not used and can be removed. As those are not public API no RST file or deprecation is required. Resolves: #83937 Releases: master Change-Id: I0bb551e14062e805ef8b23559bcc22ae32a8e399 Reviewed-on: https://review.typo3.org/55734 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
The initialization of a Backend user for Frontend Contexts is currently bound to TSFE, however, the only parts where TSFE is actually needed is to set the flag "beUserLogin". Additionally, the initialization of the Language object is now moved into the middleware, directly after the set up of $GLOBALS['BE_USER'] to allow the admin panel to use $GLOBALS['LANG'] as well. Further steps are to deprecate "$TSFE->initializeBackendUser()" method, and to deprecate the hooks, as they can now be implemented as PSR-15 middlewares. Additional cleanups on the Authentication object will follow separately once all Middlewares and the Request object are in place. For now, this patch aims to extract the logic and keep maximum backwards- compatibility. Resolves: #83959 Releases: master Change-Id: Ia4055f2d3671e9c14e492baa4eea724d989e9521 Reviewed-on: https://review.typo3.org/55793 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Benni Mack authored
The initialization of a frontend user is currently bound to TSFE, however, the only parts where TSFE is actually needed is to set the frontenduserauthentication object to $TSFE->fe_user and to call a post-processing hook, which could be dealt with through a middleware for extensions. Further steps are to deprecate "initFEuser()" method, and to move the transferring of the user session into the FrontendUser object itself, once this is not using superglobals instead anymore. Additional cleanups on the Authentication object will follow separately once all Middlewares and the Request object are in place. For now, this patch aims to extract the logic and keep maximum backwards- compatibility. Resolves: #83936 Releases: master Change-Id: Id51b49f41336717fde4606a71ec6b2c805662b88 Reviewed-on: https://review.typo3.org/55753 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Feb 18, 2018
-
-
Andreas Fernandez authored
Change-Id: Ib06890d7697f0a819d436b679995162cba5543fe Resolves: #82605 Releases: master Reviewed-on: https://review.typo3.org/55776 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Andreas Fernandez authored
Change-Id: I5b738983f733da77100830b841419ba9d12fdf23 Resolves: #83955 Releases: master Reviewed-on: https://review.typo3.org/55780 Tested-by:
-
Christian Kuhn authored
The array handling in AbstractTreeView has not been used in the core for quite some while. To clean that class up a bit, the functionality is now deprecated. Deprecation is covered by the extension scanner, except the class property $this->data which is too common and would create way too many false positives. Change-Id: I7bafdab242bf3d568c733cec669e895b87498241 Resolves: #83904 Releases: master Reviewed-on: https://review.typo3.org/55722 Reviewed-by:
-
Gianluigi Martino authored
The "Set" button is obsolete because the filter change automatically on dropdown select. Resolves: #83895 Releases: master, 8.7 Change-Id: I0f0acf05a5c06395bb8710829d68e5add9462d94 Reviewed-on: https://review.typo3.org/55717 Tested-by:
-
Alexander Opitz authored
If the linked record wasn't found (wrong uid, removed from database) we check before trying to gather an icon for the non-existing record. Resolves: #81804 Releases: master, 8.7 Change-Id: Ie06ec8a614650d8147f143cda8d8e6a9cb3e98e9 Reviewed-on: https://review.typo3.org/55751 Reviewed-by:
-
- Feb 17, 2018
-
-
Mathias Schreiber authored
Each composer.json file in a system extension now has its dependencies checked against the root composer.json to avoid errors after the subtree split. Resolves: #83957 Releases: master, 8.7 Change-Id: Ibf37bd56fd1534b14e714dfdfaaf6374a48978c4 Reviewed-on: https://review.typo3.org/55785 Tested-by:
-
Christian Kuhn authored
Version constraints must be identical to not spoil composer single extension installations. Change-Id: Ic799ef5d5f695072618d8a500c4fca52a68f9803 Resolves: #83956 Releases: master Reviewed-on: https://review.typo3.org/55783 Tested-by:
-
Mathias Schreiber authored
We now make sure that invalid CSV no longer gets merged into TYPO3s core. Resolves: #83943 Releases: master, 8.7 Change-Id: If8b6a20b3ccf9cbcdc3ffe0e74733dfd941c09d5 Reviewed-on: https://review.typo3.org/55760 Tested-by:
-
Anja Leichsenring authored
MySql receives a test to install the introduction package, PgSql gets one for the blank page preset. With this change, both install suites check both kind of setup the instance. Change-Id: Ic21091f5bc3a0aa14a49e9e9fa65a5f9db829cdb Resolves: #83949 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55770 Tested-by:
-
Christian Kuhn authored
To manipulate the FormEngine data provider list by extensions, it can be helpful to just set a data provider as disabled and add an own one after the disabled one and before the next one. This avoids funny array munging and dependency shuffling if an extension author needs to substitute an entire data provider with an own solution. The concept has been implemented for node expansion render types in a similar way and is repeated here. Change-Id: Ia1f2de94940248b60e851c7b9968539f5ab0ef79 Resolves: #83906 Releases: master Reviewed-on: https://review.typo3.org/55724 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Similar to other places that use dependency configurations via arrays, the middleware stack configuration now allows disabling single middlewares by setting disabled=true. Change-Id: I42c741062b5f6952577e164939593f0553b1ad31 Resolves: #83907 Related: #83906 Related: #83725 Releases: master Reviewed-on: https://review.typo3.org/55725 Reviewed-by:
-
Anja Leichsenring authored
System extensions used to create their _cli_* users lowercased. The wizard queries only for uppercase varieties. Adding a LOWER command to the where-clause catches now all casings. Change-Id: I556f0181416067479ff579d2498389a564c6a5e3 Resolves: #83927 Relates: #79276 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55743 Reviewed-by:
-
Andreas Wolf authored
Change-Id: If1aeff95d06e98e9c5a3725445bc616552c1eb14 Resolves: #82585 Releases: master Reviewed-on: https://review.typo3.org/55295 Tested-by:
-
Georg Ringer authored
Instead of creating the HTML in the ViewHelper it should be done in the template. Resolves: #83918 Releases: master Change-Id: I8e9aaf51f23cd8808cc2910d6e8668f27671cf66 Reviewed-on: https://review.typo3.org/55733 Tested-by:
-
Benjamin Franzke authored
Due to the recent changes in the commit: e487cf52 [TASK] Create own response instance in controller actions ..ajax routes and eID handlers that used a *pre-generated* Response object (from the RequestHandler) now return different Content-Type headers than before. For backend ajax request applicaton/json was set by default, for eID scripts no Content-Type was set (by default). Change these controllers to use JsonResponse or a plain Response to reflect the previous state.. The changes in this commit were intended to be squashed into the mentioned commit – but this commit was too late. Therefore other (a bit) unrelated optimizations to changes that patch made are included. Change-Id: Icfdcd02d353dfaf48ad959c50be4802349eaaacd Releases: master Resolves: #83946 Related: #83939 Reviewed-on: https://review.typo3.org/55766 Tested-by: -
Anja Leichsenring authored
Change-Id: I2450313e4fb470a62f9bb4e371e0200c720bb4b5 Resolves: #83950 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55771 Tested-by:
-
Andreas Fernandez authored
Change-Id: I44878243205274bac6e328ee8f1e4db79377869c Resolves: #82584 Releases: master Reviewed-on: https://review.typo3.org/55774 Tested-by:
-
Mathias Schreiber authored
All CSV fixtures are now a proper CSV file with a proper column count. This makes editing them with a picky CSV editor possible again. Resolves: #83941 Releases: master Change-Id: Ic5f59c49fd3fa6ad98036f5392e36d450633d501 Reviewed-on: https://review.typo3.org/55765 Tested-by:
-
Christian Kuhn authored
If a test adds some mock or prophecy revelation to the GeneralUtility::makeInstance() stack using addInstance(), it is important the test subject actually consumes that instance. Otherwise, the dangling instance can have side effects on other tests run afterwards. The patch raises typo3/testing-framework from 3.0.0 to 3.1.0 which extends tearDown() with a test to verify the instance stack is empty. If not, the test fails with an accordig message. composer command used: composer update typo3/testing-framework An @internal method to GeneralUtility is added to retrieve the current instance stack, and one test is fixed which violates this rule. Change-Id: I769b82bf704834bf5d1718cbf39b9b411438e30c Resolves: #83948 Releases: master Reviewed-on: https://review.typo3.org/55769 Tested-by:
-
- Feb 16, 2018
-
-
Christian Kuhn authored
Better safeguard a BookmarkCest detail to stabilize that patch again. Change-Id: Ia873d1c8a04d0ef329c280ff5d4d7518c6b73e22 Resolves: #83947 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55767 Tested-by:
-
Christian Kuhn authored
For the memory garbage collection of UnitTestCase to kick in, it is important that unit tests which implement tearDown() call parent after their own job. Fix some missing parent calls, refactor some other tests slightly to live without tearDown() and activate two tests that come with an invalid @depends annotation. Change-Id: I51c7534ea3220ec63fd8c3efa94e8bf295590e68 Resolves: #83944 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55761 Tested-by:
-
Christian Kuhn authored
To further support the PSR-7 / PSR-15 and removal of GeneralUtility::_GP() and friends efforts, all controllers no longer use the second 'ResponseInterface $response' argument given by dispatchers: Dispatchers should not assume which type of response a controller returns, there is no point in preparing this object. Instead, controllers now always create one of HtmlResponse, JsonResponse or RedirectResponse on their own and return these objects. Changes overview: * Always use "new" to instantiate a response, PSR-15 middlewares allow fiddling with the object if needed, xclassing these classes is never needed, we instead can rely on proper API usage. * All controller actions drop the second $response argument and add ResponseInterface return type hint. * Some controllers action also drop first $request argument, but only if the action does not need access to ServerParams at all. Those controllers that access _GP or _POST or similar currently, keep $request for now - they have to be refactored later anyway and then need $request. Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5 Resolves: #83939 Releases: master Reviewed-on: https://review.typo3.org/55754 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Alexander Opitz authored
Take into account empty and "off" values for the HTTPS request variable to support ISAPI with IIS. Resolves: #81837 Releases: master, 8.7 Change-Id: I5937c506d3e36a2009a8da6e66724728654b4001 Reviewed-on: https://review.typo3.org/55750 Reviewed-by:
-
Christian Kuhn authored
Property page_cache_reg1 is a poor man limited way to manipulate page cache tagging. It has been of very little use and is deprecated now. The usage in indexed_search (which always only added the default "0" to database) is dropped along the way. Change-Id: I9ea129fc6d20adb7a35a719f3d9d630aa663952f Resolves: #83905 Releases: master Reviewed-on: https://review.typo3.org/55723 Tested-by:
-
Georg Ringer authored
Move the templating code into the template instead of using a ViewHelper. Resolves: #83919 Releases: master Change-Id: I3df5fc096cbb7d53406f46abca1ab83fdaabc709 Reviewed-on: https://review.typo3.org/55735 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Mathias Schreiber authored
Resolves: #83938 Releases: master, 8.7 Change-Id: I71ddeb358cea2b24a4db46545a35ca956c6bc320 Reviewed-on: https://review.typo3.org/55756 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Christian Kuhn authored
Add a unit test to support the change from issue #83870. Change-Id: Ic8a1006c56989a1aa2ef2734e1320447875f1138 Resolves: #83909 Related: #83870 Releases: master Reviewed-on: https://review.typo3.org/55727 Tested-by:
-
Andreas Fernandez authored
Change-Id: I8a54c72090fc9e9d39fae1ddd13d8f72f691fcc0 Resolves: #83929 Related: #82414 Related: #79972 Related: #77127 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/55744 Tested-by:
-
Benni Mack authored
Output Compression should be separated from the request handling, and is now moved into a PSR-15 middleware. This change also decouples Output Compression from Bootstrap, and the Request Handler, so it can be re-used in other areas. Intentionally omitted is a proper cleanup (ob_get_clean) and an explicit write to the response object (in the middleware). That's up for later patches. The idea of this patch is to keep functionality identical for now. Resolves: #83931 Releases: master Change-Id: Ic84707cac6c858698f290069f6aa492724ce0602 Reviewed-on: https://review.typo3.org/55746 Reviewed-by:
-
- Feb 15, 2018
-
-
Benni Mack authored
In order to have the main request handler only deal with content creation, and especially to move fe_user / be_user initialization out of the RequestHandler, and to remove dependencies from Bootstrap of the RequestHandler, TSFE is now instantiated in a PSR-15 compatible middleware. Resolves: #83928 Releases: master Change-Id: I8a4dd4c10f5ea2eeb60f9870c34d04979a330826 Reviewed-on: https://review.typo3.org/55742 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Tomas Norre Mikkelsen authored
The label for the "Save and create new document" in the scheduler module, will be change to a more appropriate label "Save and create new task" Resolves: #83920 Releases: master, 8.7, 7.6 Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf Reviewed-on: https://review.typo3.org/55736 Tested-by:
-
Benni Mack authored
This patch improves the workflow readability by replacing variables, simplifying if() clauses and orderings etc. Resolves: #83922 Releases: master Change-Id: I893ad348f8976dd65bf11a117f54433b46d0d896 Reviewed-on: https://review.typo3.org/55738 Reviewed-by:
-
Susanne Moog authored
Resolves: #83924 Releases: master, 8.7 Change-Id: If9f435c64addea63793586e131da19768749857c Reviewed-on: https://review.typo3.org/55739 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Benni Mack authored
The check if the frontend is in "maintenance mode", set by $GLOBALS['TYPO3_CONF_VARS']['FE']['pageUnavailable_force'], is moved into a custom PSR-15 based middleware, effectively decoupling this logic from TSFE object. Resolves: #83917 Releases: master Change-Id: I38c42069b82ca2403df9aa4b0e66410a3dfe6404 Reviewed-on: https://review.typo3.org/55721 Tested-by:
-
