- Aug 13, 2022
-
-
Nikita Hovratov authored
The former approach in #91808 to fix scoped toggling didn't work with levelLinksPosition "bottom", as the querySelector could find another control container inside another child inline field first. Another solution, which is now possible, works with the ":scope" selector. Only nodes with a direct parent will be found this way. In addition, a new helper class is added for the top control container, as it is wrapped in another div. This enables toggling of both buttons, in case levelLinksPosition "both" is set. Resolves: #97786 Related: #91808 Related: #92382 Releases: main, 11.5 Change-Id: I67146c372d183cd647db847b3e3d83d986585577 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74928 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Aug 12, 2022
-
-
Ionel-Alex Caizer authored
Omit obsolete type=text/javascript in PageRenderer See: https://html.spec.whatwg.org/multipage/scripting.html#the-script-element Resolves: #97990 Releases: main Change-Id: I4af66f10fd8186817fd66432d96b50de4cad0a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75383 Tested-by:
-
Georg Ringer authored
Providing the exception message helps to understand and solve the issue as the exception can also be thrown by a 3rd party extension. Resolves: #97770 Releases: main, 11.5 Change-Id: I53ff25a141c3d3b522d5eabd270309dbdda7709f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74967 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Annett Jähnichen authored
Back in the old and dark days, some filesystems did not know about "special" chars. TYPO3 has the TYPO3_CONF_VARS toggle ['SYS']['UTF8filesystem'] to declare if filesytems are UTF-8 aware. This toggle is 'false' by default since ever. It triggers functionality to rename any file that contains characters like umlauts, or maybe entirely consist of "special" chars only (japanese) to something "safe". This is a usability issue since information is lost and language-specific characters are destroyed. Nowadays, any serious filesystem of course supports UTF-8. There are no issues related to UTF8filesystem=true for years. The patch now sets UTF8filesystem=true for new installations to see if anything still pops up. If that works out, we'll continue with further patches in v13 to further phase out the option entirely. Resolves: #98090 Releases: main Change-Id: Ib448d4f42c23605fd4343bcbbd1f9fdadecadc8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75378 Tested-by:
-
Michael Hitzler authored
The YouTube helper tries to fetch from highest to lowest image for possible previews. The "sd" and "hq" versions were missing while checking for an available image and got added. Resolves: #98098 Releases: main, 11.5 Change-Id: Idec13fdc5c820e6674f8ccebd610455b50d57895 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75388 Tested-by:
Albrecht Köhnlein <ak@koehnlein.eu> Tested-by:
-
Helmut Hummel authored
When using the custom element <typo3-backend-icon> with a JS framework, that renders the DOM (e.g. Vue), it can happen, that they set the properties of the custom element instead of an attribute. Since Lit does not reflect these properties to attributes by default, but the icon-element relies on CSS set on the host element that depends on the size attribute, the icon is not rendered in the correct size. See: https://web.dev/custom-elements-best-practices/ on why reflecting properties to attributes might be a good idea in some cases. Releases: main, 11.5 Resolves: #98121 Change-Id: I8435946ad6e6d92b8ec50dd7e289279261d43d5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75414 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
The icon identified by `warning-in-use` is rendered when a record is currently edited by another backend user. As one of the last remaining bitmap icons, this should be replaced with an overlay from `@typo3/icons` instead. Resolves: #98128 Releases: main Change-Id: Ifb9a37b835a97bccc7dfcc34a278d3c73e563817 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75424 Tested-by:
-
Andreas Fernandez authored
Until now, icon deprecation wasn't possible for extensions as the deprecation handling is internal to the IconRegistry. A new option `deprecated` is introduced that may contain the following data: * `since` - since when is the icon deprecated * `until` - when will the icon be removed * `replacement` - if given, an alternative icon is offered Resolves: #98130 Releases: main Change-Id: Ie95875a1d3b7de444acbd3b30e7b399b4b4f7563 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75425 Tested-by:
-
Larry Garfield authored
The Serializable interface has been deprecated, and is slated for removal entirely in PHP 9. The preferred serialization tool is the __serialize/__unserialize method pair, which is already implemented and used instead of Serializable. This patch removes the already-deprecated and vestigial Serializable interface. Serializable and __serialize() use a different string format, so the fixture file needed to be updated as well. Resolves: #98032 Releases: main Change-Id: Icd021d7d48252d2955491a97201547f42e4d20e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75306 Tested-by:
-
Stefan Bürk authored
This patch shifts some functional test executions in CI workflows to PHP8.2. Thus enabling test coverage for new PHP8.2 version in a early stage. For nightly we only can active it for `locked` runs, as prophecy/prophecy is not allowed to be installed with PHP8.2 currently. See: https://github.com/phpspec/prophecy/issues/556 Backport to 11.5 is skipped for now due some issues in "doctrine/dbal 2.x" with PHP8.2. Resolves: #98109 Releases: main Change-Id: I02c4dc4bd3cdd589330b038463ed58a384e3d70d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75404 Tested-by:
-
Nikita Hovratov authored
node-sass respectively LibSass is deprecated as stated in https://www.npmjs.com/package/node-sass Since we use Bootstrap v5 since TYPO3 v11, which itself compiles with dart-sass, the native JavaScript based sass solution, we can finally also make the switch. This is also possible, as FontAwesome is now dropped from the core. The sass-migrator was used here to migrate the majority of division operators to math.div or inverse it to a multiplication. See: https://sass-lang.com/documentation/cli/migrator Used commands: > yarn remove node-sass > yarn add sass -D > sass-migrator division **/*.scss > Build/Scripts/runTests.sh -s buildCss Resolves: #97538 Releases: main Change-Id: I17557ed98d6d30421c05b4a7d934a83654606d4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75433 Tested-by:
-
Daniel authored
If a sys_file record is directly deleted from database, some undefined array index warnings are triggered if the file is assigned to another database record. Releases: main, 11.5 Resolves: #97987 Change-Id: I2ce115024e637cffacc512528e79b1bb4059f173 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75254 Reviewed-by:
-
Oliver Klee authored
Also add a missing property that already had a getter and setter. Also drop redundant type annotations and comments. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98133 Related: #98132 Releases: main Change-Id: I912d78df2d4f2b94b622c51a632690752dbb165b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75432 Tested-by:
-
Andreas Fernandez authored
As FontAwesome was removed and all icons are rendered via the Icon API now, the CSS class `.t3-icon` became obsolete and is now removed. Resolves: #98127 Releases: main Change-Id: Iaf23ae71aa4a3856fe91f6265ccecc82e7190979 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75423 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
This reverts commit da2a1b8b. Reason for revert: The commit-msg hook now tends to throw away the message. Fully loosing a commit message is worse than a funny exit code. We revert for now and eventually come up with a different solution later. Change-Id: I87a9ba8d376e800d79c148901401995b1626fc6f Reverts: #98094 Resolves: #98094 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75452 Tested-by:
-
Anja Leichsenring authored
Set controllers to declare(strict_types=1); Resolves: #96844 Releases: main Change-Id: I9df3fd853a3669eed7c57819185dfeaabb437879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73439 Tested-by:
-
Chris Müller authored
Resolves: #98131 Related: #97701 Releases: main Change-Id: I15408037432516d67e26853b34cfaf9fa320e75a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75426 Tested-by:
-
Benjamin Kott authored
While trying to restore the full desktop functionality aka mouse and keyboard behavior on a touch-device we came to the conclusion that it feels unintuitive. On touch devices, you have by design fewer input options and differentiators than with dedicated input devices like a mouse. It feels best to disable the drag and drop behavior and enable a smooth scrolling and navigation experience. Resolves: #91755 Resolves: #86946 Resolves: #93960 Releases: main, 11.5, 10.4 Change-Id: Ic08d06283cbb2331ff49983bd7d18b446f8bd76a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75421 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
The StandardContentPreviewRenderer still contained special handling for the tt_content.select_key field, which however was already removed in #77934. The leftover is now removed together with related locallang labels. Resolves: #98125 Related: #77934 Releases: main, 11.5 Change-Id: I38ae07a4eced0cbd3f5ed3076661b70081252321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75420 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Aug 11, 2022
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #98115 Related: #92118 Change-Id: Ibcd5fa26155dbb36216422e1c806c9a4035d878f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75409 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Stefan Bürk authored
With #97989 correct workspace overlays in DataMapProcessor should be used to fix a bug. This introduced a failing default "where" if a child table is not workspace aware. The fix itself is straight forward: Query t3ver_wsid field only if the target table is workspace aware. On functional test level, a new scenario set is added to look at details when a parent table like pages or tt_content is workspace aware, but inline children are not. The new test setup "test_inline_foreignfield_non_ws" is similar to "test_inline_foreignfield", just without the frontend scenarios, which are kinda useless here, at least for now. They reveal various further inconsistencies we should take care of with further patches. For now, these tests should verify the hard "workspace column does not exist" fail can't happen anymore in the future. Resolves: #98103 Related: #97989 Releases: main, 11.5 Change-Id: Id8cb51623b206b5effd57823a28099ce7d545b7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75401 Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
- Aug 10, 2022
-
-
Sybille Peters authored
Resolves: #98119 Releases: main, 11.5 Change-Id: If5e926d002e877e674548f63b8639acf62d5bf99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75413 Tested-by:
-
Benni Mack authored
With the fix of using versioned numbered filenames for the TYPO3 Backend, a use-case "absolutely referenced, but relative to public path file" did break for Frontend inclusions of CSS or JS files. This is now overcome by only using the original bugfix in the TYPO3 Backend. Resolves: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: Iff6251bd95e1c0a93a6f5538b9f560e55ba80b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75412 Tested-by:
-
Tomasz Woldański authored
Patch extracts generating url for workspaces in order to better integrate with external extensions, so when external extension want to replace url, extension does not have to override whole handleRequest method. Resolves: #98112 Releases: master, 11.5 Change-Id: I8c8e18fbe7dfecd2ccd400681588d984ac233178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75407 Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
-
Markus Klein authored
Resolves: #98113 Releases: main, 11.5 Change-Id: Ia996d0e66f381d71699b33a42e4c8f72bf890054 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75410 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
- Aug 09, 2022
-
-
Christian Keuerleber authored
With introducing the overhaul of the TypoScript parser and the related parts like the ObjectBrowser and Template Analyzer, it has been overseen that a invalid variable has been used in a fluid partial. This patch changes the partial to use the correct variable. Resolves: #98087 Releases: main Change-Id: I9c0ec2d99b557fe4df147402e53d04d4f29f76da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75376 Tested-by:
-
Stefan Bürk authored
This patch raises "typo3/class-alias-loader" which contains some bugfixes. Used commands: > composer req "typo3/class-alias-loader":"^1.1.4" \ --no-update -d typo3/sysext/core > composer req "typo3/class-alias-loader":"^1.1.4" Resolves: #98102 Releases: main, 11.5 Change-Id: I772a40dd9676afc7721e819077f05662ce2c6bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75396 Tested-by:
-
- Aug 08, 2022
-
-
Alexander Schnitzler authored
To gather information about properties of domain objects, extbase used method DomainObjectInterface::_getProperties() which internally used get_object_vars() which does not return uninitialized properties. This leads to the inability to use such uninitialized properties in models. Hence, those properties are not reconstituted at all when converting an object instance from a database row, eventually leading to fatal errors. To mitigate this issue, extbase does now use the existing information about classes gathered via ClassSchema which gathers information via reflection (anyway). Releases: main, 11.5 Resolves: #95819 Change-Id: I00e2eb4967631ca28a5889e934fd409fd3fdef96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72005 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Ralf Zimmermann authored
The patchset https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460/ has moved the business logic from the RenderViewHelper to the FormRequestHandler. Thereby the process for detecting the prototype name was changed by mistake. The result is that custom prototype names are no longer applied. This patchset restores the correct behavior. Resolves: #98023 Releases: main, 11.5 Change-Id: I5d59e56c0c071879ad60321dd9d82a56cde94172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75288 Tested-by:
Daniel Gohlke <daniel.gohlke@extco.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
Stefan Bürk authored
Raise `typo3/cms-styleguide` to have needed bugfix for `doctrine/dbal` 3.4.x already in composer lock state available. Used command: > composer req --dev typo3/cms-styleguide:"~12.0@dev" Resolves: #98101 Releases: main Change-Id: I29f3ff695518cfb9117263bd618d155f372ddefa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75393 Tested-by:
-
Kevin Appelt authored
Resolves: #98078 Releases: main, 11.5 Change-Id: Ic177eeb9581c1513076e2e3301f29c0f97de5cd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75372 Tested-by:
-
Thomas Maroschik authored
Scenario: Given is a cluster of containers/servers that run multiple instances of the same TYPO3 instance. A load balancer round robins requests to those instances. Problem: A backend user logs in and gets a broken backend. No CSS and JavaScript is loaded. Requests to those resources return HTTP 404 errors. Analysis: TYPO3 concatenates assets on the fly per backend module when they are requested and saves them to a local temporary folder. As requests are routed to different containers on every request, the probability of hitting an container/server where the resulting asset is not yet generated, is very high (basically always). The only way to circumvent this, is to put the backend in debug mode, which has other unwanted side effects. Solution: Deactivate asset compression/concatenation altogether for the backend. As most servers deliver HTTP2/3 nowadays, the performance impact should be minimal. By skipping unnecessary processing and allowing browser caching, performance could be even increased. Resolves: #97936 Releases: main, 11.5 Change-Id: Ic696f4a3618e5bed3388ab0262ce2867d334723f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75175 Tested-by:
-
- Aug 07, 2022
-
-
Georg Ringer authored
To avoid a type error the method `EditDocumentController::generatePreviewCode` must also allow null as return value because the called method `PreviewUriBuilder::buildImmediateActionElement` can return null as well. Resolves: #98071 Releases: main, 11.5 Change-Id: Icb021503f8dc6417baa9f2c2f883ec426f92dfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75351 Tested-by:
Thomas Anders <me@naderio.de> Tested-by:
Matthäus Gundlach <mgu@dauskonzept.de> Tested-by:
-
Rémy Daniel authored
When sql strict mode is enabled on the database server, if a value has a wrong data type for the database column, the INSERT or UPDATE query will fail. This happened during a t3d import: relationships are lost. This patch fixes the issue by using the TCA default value for the field. Resolves: #89103 Releases: main, 11.5 Change-Id: I7e995f10359c6935f6b9a50b1150c31e63937ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75385 Tested-by:
-
Simon Schaufelberger authored
Resolves: #98094 Releases: main, 11.5, 10.4 Change-Id: If84f67d6ac91aeaa47849067e21bef6b13854f3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75386 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
Tomas Norre Mikkelsen authored
This adds back the cursor pointer when hovering toggle checkboxes, common checkboxes and radio-buttons. Resolves: #97836 Releases: main, 11.5 Change-Id: Ib4083b95ec76f0909a31788d3e07a3321b8d63ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75127 Tested-by:
-
Andreas Fernandez authored
Any usage of FontAwesome has been removed with #97877 already. This patch removes the integration of FontAwesome from the TYPO3 backend, including the `FontAwesomeIconProvider`, the font files, and any CSS. The polyfill extension is available via Composer via ``` composer require friendsoftypo3/fontawesome-provider ``` and in the TER soon. Resolves: #98089 Related: #97877 Releases: main Change-Id: I28968bc45a43a244b82fe9a888e10d958d42cf1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75342 Tested-by:
-
- Aug 06, 2022
-
-
Andreas Fernandez authored
To make datetimer picker buttons focus the belonging textfield, the buttons were rendered as `<label>` which is a very dirty hack, leading to clitching buttons. To solve this, the `@typo3/backend/global-event-handler` module is now capable of focussing a specific element after clicking a trigger element. Resolves: #98054 Releases: main, 11.5 Change-Id: I828785267e6a8c25f3ed7c17221e903cd4cc3220 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75331 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Xenia Thiem authored
Resolves: #97248 Releases: main, 11.5 Change-Id: I2f9e3f9f2d530c5e416d57ec7e6b2d68a2b85531 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75382 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Chris Müller authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186 the Fluid-based page view layout was introduced. However, a leftover setting from the development of this feature remains in the TYPO3_CONF_VARS setting: BE|fluidPageModule. Instead, a feature flag was used to switch to the deprecated page view layout. See also the comment in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63186/50/typo3/sysext/core/Configuration/DefaultConfiguration.php#1078 Resolves: #98095 Related: 90348 Releases: main, 11.5 Change-Id: I8ed24782b53673dc7759bf158fe02186f84c16c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75387 Tested-by:
-
