- Jun 13, 2024
-
-
Garvin Hicking authored
Extbase reserves a couple of keywords for internal use: * action * controller * format (resolving fluid templates for HTML, json, ...) * __trustedProperties * __referrer The notiation "__" (and "@" for sub-arrays) is indiciative of being reserved keywords, however action/controller/format are not. These are now mentioned specifically in the Fluid ViewHelper "arguments" parameter, so that they can show up in the auto-generated documentation. This should help to prevent integrators and developers from advertly using an argument like "format" as a custom variable/property name. Efforts have been made to document this also here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4525 https://github.com/TYPO3-Documentation/TYPO3CMS-Exceptions/pull/155 Resolves: #102246 Releases: main, 12.4, 11.5 Change-Id: I55a306aaa0ba783f9202350d198c9fdf08f5a997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84674 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Jun 12, 2024
-
-
Christian Kuhn authored
> Build/Scripts/runTests.sh Before: Memory: 469.06 MB After: Memory: 373.02 MB Reason: phpunit executes data providers early and keeps data sets in memory. The "xml parser big content" tests create megabytes of data kept in memory. Moving the data generation from data providers to the test execution reduces overall memory usage significantly. Resolves: #104076 Releases: main, 12.4, 11.5 Change-Id: I0ad49824fc1d4c309158b74474853d36af22ffb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84670 Reviewed-by:
-
- Jun 11, 2024
-
-
Georg Ringer authored
The string "false" is cast to true and therefore 0/1 must be used in examples. Resolves: #99211 Releases: main, 12.4, 11.5 Change-Id: I5519cd1917b81c1dbb90fbb6746541735e4940ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84633 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Hader authored
Change-Id: Ia5b8b0ec65a4d99829ba087011242c7a17937d1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84598 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I75c50c5c69438aeaf3d59e818c60610dba859b36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84597 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84594 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Christian Weiske authored
The mask extension[1] automatically generates column definitions in TCA, and they do not have a 'label' key in the TCA columns definition. In TYPO3 v11.5.37, the link validator report page crashes with the following error: > (1/1) #1476107295 TYPO3\CMS\Core\Error\Exception > PHP Warning: Undefined array key "label" > in [...]/linkvalidator/Classes/Report/LinkValidatorReport.php line 559 In TYPO3 v12 the problem does not occur anymore. This patch simply checks if the label key exists before it is used. [1] https://github.com/Gernott/mask Resolves: #104032 Releases: 11.5 Change-Id: Icca6f102883b09b3fec182158e625b959988db33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84592 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84551 Tested-by:
-
- Jun 07, 2024
-
-
Georg Ringer authored
Backport parts of #102907 to avoid exceptions because of undefined array key access. Resolves: #103997 Releases: 12.4, 11.5 Change-Id: I35e159bd8728fd84a43b58b27dc2a291fd11fe2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84469 Reviewed-by:
-
Charles Krüger authored
A few minor spelling mistakes and uppercase notation is changed with this patch. Releases: main, 12.4, 11.5 Resolves: #103993 Change-Id: Ie71257dcd94e008bff2fd29ca6152152019eedae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84467 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 06, 2024
-
-
Garvin Hicking authored
The directory to reference removing Documentation-GENERATED-temp breaks out of the current working directory scope and could possibly delete files in a completely unrelated directory. Also, it does not remove the actual temporary files. Resolves: #103989 Releases: main, 12.4, 11.5 Change-Id: I685a398aa0d5abee3177ab3def4e271d493d59ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84465 Tested-by:
-
Garvin Hicking authored
The use of the backtick operator inside the help output leads to an error message: Build/Scripts/runTests.sh: line 175: --: command not found on macOS (probably others, too). This patch replaces the backticks with normal quotes. Resolves: #103988 Releases: main, 12.4, 11.5 Change-Id: Ib6809dc6943a98e4d45d04f4ec02601e830518cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84463 Tested-by:
-
Andreas Kienast authored
With Chrome 125, changes in the drag&drop handling were introduced [1] that trigger a text selection when dragging nodes from the page tree toolbar. In the `dragstart` handler, the default action is now prevented. [1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action Resolves: #103877 Releases: 12.4, 11.5 Change-Id: Iad75db78bba3e7b5ad01a568dcab2eb770f1c4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84509 Tested-by:
-
- Jun 05, 2024
-
-
Benjamin Franzke authored
Workaround a PHP issue which will produce an open_basedir restriction warning if `is_dir()` is used on a regular file when the trailing slash is provided. Resolves: #103943 Releases: main, 12.4, 11.5 Change-Id: Iaa83658113ff8abb0ab8051b519f76135effd627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84437 Tested-by:
-
Christian Kuhn authored
Sometimes - for unknown reasons - a session gets lost in acceptance tests. Tests then hang in BE login waiting for BE load and fail with a timeout. We now catch this timeout and relogin, and also enable cookie debug output to increase chances to fix the real issue. Resolves: #103981 Related: #103086 Releases: main, 12.4, 11.5 Change-Id: I0b10118968933b52523bbee8f8f608db60ad884e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84502 Tested-by:
-
- Jun 03, 2024
-
-
Stefan Bürk authored
The `symfony/yaml` package provides the `yaml-lint` commandline tool to lint yaml files. This change introduces yaml file linting checks using the symfony tool, differencing `Services.yaml` from other yaml files. Resolves: #103931 Releases: main, 12.4, 11.5 Change-Id: I9442b38c439fb5f2d5507ca0ab70235b2dfd194a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84482 Tested-by:
-
- May 27, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator and removes the null default value for the first parameter, which mitigates both issues. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103927 Releases: main, 12.4, 11.5 Change-Id: I0ba574769e5b95852379aa30f03d45715aec2055 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84363 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84361 Tested-by:
-
Stefan Bürk authored
`\TYPO3\CMS\Core\Tests\Unit\Database\ConnectionTest` containes code to mock Connection methods conditionally, based on their existance surrounded by a `@todo` comment to remove this, when `doctrine/dbal` has been required with 2.11.0 as minimal version. The version raise has been done already a long time ago, however the removal of this conditional test mock has been missed. This change removes the conditional mocking now. Resolves: #103929 Releases: main, 12.4, 11.5 Change-Id: I4cc2d5942149f69e044c25379c82388f1c4b9f45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84423 Tested-by:
-
- May 25, 2024
-
-
Georg Ringer authored
The configuration `foreign_table` of the type `select` is optional. Add a check to avoid PHP warnings. Resolves: #103825 Releases: main, 12.4, 11.5 Change-Id: I65925bae287a0ed340c67923ac4e4a2c72ce9d28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84394 Tested-by:
-
Anja Leichsenring authored
The test setup used a dataProvider and in order to get it's own setup right, it reverses and resets leftover instances from the previous run. It is way easier to split the test setup according the admin flag, that decides about the resets, and run on a clear dedicated environment. Additionally, the system under test is in itself a mocked instance, which is neither necessary in this case, nor generally recommended. The mock has been resolved. Resolves: #103901 Releases: main, 12.4, 11.5 Change-Id: If40ef38a0e0fc2e73dd5f0bc8caff923cc48d661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84393 Tested-by:
-
- May 22, 2024
-
-
Christian Kuhn authored
Less jobs while keeping general pipeline times low. * Simplify runner cache configuration * sqlite pre-merge 3 instead of 5 jobs * sqlite nightly 4 instead of 6 jobs * merge checkIntegrityPhp to general integrity job * merge checkGruntClean to general js job * merge php lint jobs into one * avoid composerInstall for unitJavascript * merge acceptance install jobs into less jobs * update acceptance test matrix to run less jobs in nightly while still catching many configuration permutations in addition to pre-merge Note backports are similar but deviate in details. Change-Id: I832543e002824977a98d3ffb35c3d08355b1f5be Resolves: #103869 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84347 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- May 21, 2024
-
-
Ayke Halder authored
Use all available CPUs with `Build/Scripts/runTests.sh -s lintPhp`. Note podman CI is configured with a cpu-share to prevent starving other jobs when one is greedy, so this change is ok with CI, too. Resolves: #103864 Related: #103851 Related: #102385 Releases: main, 12.4, 11.5 Change-Id: I1cb7079f119677b36d6f4004398ae24bd8c5d284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84319 Tested-by:
-
- May 17, 2024
-
-
Wouter Wolters authored
Use parallel runner to use more than 1 CPU. composer update \ composer/semver \ symfony/polyfill-mbstring \ symfony/polyfill-php80 \ symfony/polyfill-php81 composer require --dev friendsofphp/php-cs-fixer:^3.57.1 Resolves: #103851 Releases: main, 12.4, 11.5 Change-Id: I59b5e2566a385792cad1b6c11b9b84b63fd21b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84290 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
- May 14, 2024
-
-
Andreas Kienast authored
The label for the delete action was encoded twice, leading to text issues in case special characters are involved. This commit makes use of `GeneralUtility::implodeAttributes()` to solve this issue properly. Resolves: #103827 Releases: main, 12.4, 11.5 Change-Id: Ia9f7ba5adf46b470a33b9065e49b8599a24fdfad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84275 Tested-by:
-
Oliver Hader authored
Change-Id: I0ef0594cc0d3aefbacdc3e3bcbcaad685513b745 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84269 Tested-by:
-
Oliver Hader authored
Change-Id: I5602a1ef868b9ebbdf0a8ffafae3650cfb845181 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84268 Reviewed-by:
-
Benni Mack authored
The "frame" parameter is no longer evaluated in the showpic eID as it allowed uncontrolled resource consumption. This parameter was actually never used by ContentObjectRenderer and existed since the initial commit and is therefore put behind a feature flag. Resolves: #103306 Releases: main, 13.1, 12.4, 11.5 Change-Id: I87019e58c078c8ccafc0b7ce42fe28b49dc068e4 Security-Bulletin: TYPO3-CORE-SA-2024-010 Security-References: CVE-2024-34358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84256 Reviewed-by:
-
Oliver Hader authored
Resolves: #103303 Releases: main, 13.1, 12.4, 11.5 Change-Id: I2842cefd5dfc0aff920e61b5fd16f029db8ada4c Security-Bulletin: TYPO3-CORE-SA-2024-009 Security-References: CVE-2024-34357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84255 Tested-by:
-
Benjamin Franzke authored
Encode non prepared output of BackendUtility::getRecordTitle. The string returned by getRecordTitle is only HTML encoded if the third parameter (`$prep`) is set to true, ensure that non-prepared usages are encoded on render. Resolves: #103782 Releases: main, 13.1, 12.4, 11.5 Change-Id: I96b9530d118a21163d6679ebf7120aa40c7ac7b6 Security-Bulletin: TYPO3-CORE-SA-2024-008 Security-References: CVE-2024-34356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84254 Tested-by:
-
- May 11, 2024
-
-
Christian Fries authored
When addressing flexform fields in TSconfig, the dots of the field names have to be escaped with a backslash. Releases: main, 12.4, 11.5 Resolves: #103786 Change-Id: I6af70fcb80e9e155ba8259ec216c5199600c5a78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84200 Reviewed-by:
-
- May 10, 2024
-
-
Christoph Lehmann authored
In advanced query the operator "is in list" makes value be an array. Then switch the field to a non-array field type, and you get the following TypeError: ``` htmlspecialchars(): Argument #1 ($string) must be of type string, array given. ``` This resets the array value to an empty string. Resolves: #103487 Releases: main, 12.4, 11.5 Change-Id: Ifc6ef7e90d49a05ecb4b6d4869eea13c151b1b2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84188 Tested-by:
-
- May 06, 2024
-
-
Willi Wehmeier authored
The folder containing the charset conversion table files should have the unicode license.txt file. The license file is from https://unicode.org/license.txt Resolves: #103796 Releases: main, 12.4, 11.5 Change-Id: I2577fea6e1b5326cd45da622ec6fbbc563bc140a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84120 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 03, 2024
-
-
Oliver Hader authored
Commands: composer req 'enshrined/svg-sanitize:^0.18.0' composer req 'enshrined/svg-sanitize:^0.18.0' \ -d typo3/sysext/core --no-update Resolves: #103722 Releases: main, 12.4, 11.5 Change-Id: I9a20a46b27b3abbfd18f7ca6027e4def9ce5b59b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84138 Tested-by:
-
- May 02, 2024
-
-
Stephan Bauer authored
An error was previously shown and is now removed if no backend type is selected. Releases: main, 12.4, 11.5 Resolves: #103766 Change-Id: Ia83552de40abffb880244e8b0eb0f4c28f0e6637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84113 Tested-by:
-
- Apr 23, 2024
-
-
Oliver Hader authored
Given a static route argument mapper is used - for instance one that allows values in the range of 1 to 100 - then generating an URL from a route with an out of scope `&value=5000` was still generating an URL. However, HTTP request to that URL would result in an 404 error. This change skips routes using out of scope values during the URL generation process to avoid pointing to invalid resources. Resolves: #103400 Releases: main, 12.4, 11.5 Change-Id: I11e12f29e294ec86bec948d3a922d4a56b231771 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84003 Tested-by:
-
- Apr 16, 2024
-
-
Georg Ringer authored
`DateTimeImmutable::setTimestamp()` requires the timestamp to be an integer. Resolves: #103588 Related: #99627 Related: #98045 Releases: main, 12.4, 11.5 Change-Id: I2dba1b3836063872fa04ea38d58b5bd499a8f7d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83757 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
- Apr 15, 2024
-
-
Andreas Kienast authored
Resolves: #103615 Releases: main, 12.4, 11.5 Change-Id: I11f609625051f7dc6418596229bed49f282bc842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83759 Tested-by:
-
- Apr 10, 2024
-
-
Christian Weiske authored
`getEmptyObject()` does not call `getInstance()` which initializes the property, which is needed since PHP 8.0. TYPO3 v12 and later are unaffected, because the Container class has been removed there. Resolves: #102278 Releases: 11.5 Change-Id: I5f05b40990a2214cb86f2779b048149b2c931a2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83707 Tested-by:
-
- Apr 08, 2024
-
-
Stefan Bürk authored
`Build/Scripts/runTests.sh` is the monorepo main dispatcher of script and tools to ensure same working state across developer host system and installation by using well defined containers. This mitigates issues with missing dependencies or wrong version of tools on develper machines. Until now local installation of `node` and `npm` in the matching version was mandatory to work with the node ecosystem like manage dependencies, executing node based tools or the build chain for CSS and TypeScript/JavaScript. This change adds now a `npm` dispatcher to `runTests.sh` similar to the `composer` command dispatcher introduced with #103045 to allow executing npm commands and defined scripts in `package.json` in a well-defined environment and removes the hard-requirement of installing it locally for new contributors. Added `runTests.sh` suite: * ./Build/Scripts/runTests.sh -s npm -- <npm-command-arguments> which allows now to using npm commands always with the correct npm and node version defined for the mono-repository state. Some examples: ./Build/Scripts/runTests.sh -s npm -- audit ./Build/Scripts/runTests.sh -s npm -- ci ./Build/Scripts/runTests.sh -s npm -- run build ./Build/Scripts/runTests.sh -s npm -- run watch:build ./Build/Scripts/runTests.sh -s npm -- install \ --save bootstrap@^5.3.2 Resolves: #103552 Related: #103045 Releases: main, 12.4, 11.5 Change-Id: Ie9de71f24dfd4805a98be7dc1b1604e5d0146eec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83664 Tested-by:
-
