- Jan 18, 2024
-
-
linawolf authored
If you happen to have inconsistent data in the config.yaml like: ``` routes: - route: robots.txt type: staticText source: 'EXT:my_sitepackage_mysite/Resources/Public/robots.txt' ``` Currently a PHP type error is thrown instead of a proper exception. Resolves: #102773 Releases: main, 12.4 Change-Id: If16a93b851237c9d39893cd3e56fa9693986721d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82478 Tested-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Jan 16, 2024
-
-
Oliver Bartsch authored
In case a plugin, using the `list` CType has an item group configured, which is not defined in `list_type>config>itemGroups`, EMU::addPlugin() tries to get the label from the `CType>config>itemGroups` definition. This does now properly work by using the correct array access in the if clause as well as the correct fallback value in case the defined item group does not exists in `CType>config>itemGroups`. Resolves: #102841 Related: #102826 Releases: main, 12.4 Change-Id: If50fc533b6b3c107e21d73b7b0b6380c45807093 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82477 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Hader authored
Change-Id: I60ef2b390e55d5544f599d82f8c71b64093ede8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82467 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: Id818722727dd70ecccf819231901c8ba2946049f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82466 Reviewed-by:
-
Benjamin Franzke authored
The example value '-t -i' for `transport_sendmail_command` is incorrect, as an executable is expected to be provided, not just command flags. Since this option is not needed for SMTP at all, it is dropped from this example. Releases: main, 12.4, 11.5 Resolves: #102837 Change-Id: I99569f23339ae68077edf16aaa59873aa84ba24d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82475 Tested-by:
-
- Jan 14, 2024
-
-
Anja Leichsenring authored
The label has been added, so the output of the help section for the command will now provide basic information about the option. Resolves: #102833 Releases: main, 12.4 Change-Id: I72e82f1516eaf960ce572b8e920be6bcaa747663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82474 Reviewed-by:
-
Thore authored
Exception message is wrong. The file did not move, the path is empty in itself or due to error in getFileAbsFileName. Releases: main, 12.4 Resolves: #102829 Change-Id: Ia10cc4a3511d042eecba9d06b34a501ab1998182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82473 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Nikita Hovratov authored
Fix comment about obsolete type user with dbType json. Resolves: #102832 Releases: main, 12.4 Change-Id: I390a1a7d3a7fe4d511f361efae4c2735f9b34c4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82472 Tested-by:
-
- Jan 12, 2024
-
-
Stefan Bürk authored
Doctrine DBAL 3.7.0 introduced a performance issue [1] which has been already fixed by the Doctrine Team [2]. This change updates the `doctrine/dbal` composer constraint to ensure that this performance issue is gone. Note: The monorepo composer.lock already containted the 3.7.2 bugfis release, therefore this has not been detected in casual core development. This update is to mitigate the performance issue at all costs for TYPO3 users. As a sideeffect, this should put `composerInstallMin` nightly function tests on speed again. Used command(s): > composer require --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update \ "doctrine/dbal":"^3.7.2" ; \ composer update --lock [1] https://github.com/contao/contao/issues/6409 [2] https://github.com/doctrine/dbal/pull/6202 Resolves: #102830 Releases: main, 12.4 Change-Id: If8b09f9556f11cc0fda4690f81343fc6c5d5e476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82449 Reviewed-by:Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Benni Mack authored
When using DataHandler->log, the format changed to using an associative array as $data, whereas the message then contains PSR-3 compatible log strings. This was handled in TYPO3 v12 but a few places around Workspaces were missed. This patch adapts these places. Resolves: #102827 Related: #97556 Releases: main, 12.4 Change-Id: Id871d65a52243489d7434025850438e0f7aeb670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82391 Reviewed-by:
-
Benni Mack authored
With TYPO3 v12, the SelectItem API was introduced to allow an associative array for registering items in TCA select. However, it was forgotten to be added in registerPlugin and addPlugin, which is now supported as well to be consistent around TYPO3 Core, and the new API. As an addition, Extbase plugins can now also add a description in order to have feature parity with Core API. Core plugins such as indexed search now utilize description and group, moving "EXT:indexed_search" plugin into the forms group for consistency reasons. Resolves: #102826 Related: #99739 Releases: main, 12.4 Change-Id: Ifcfc5f8ce482fab3203fe6a9591cc152d0a4261a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82390 Tested-by:
-
- Jan 11, 2024
-
-
Nikita Hovratov authored
Resolves: #102812 Releases: main, 12.4 Change-Id: I43ea655938b8e4e691359bd22113c4f02ea71036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82389 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Andreas Kienast authored
This commit updates all `lit` packages to their respective latest version. Executed commands: npm install --save \ @lit/reactive-element@^2.0.3 \ lit@^3.1.1 \ lit-html@^3.1.1 \ lit-element@^4.0.3 npm install --save-dev \ eslint-plugin-lit@^1.11.0 npm run build Resolves: #102816 Releases: main, 12.4 Change-Id: Ic0a3908b128174953ea10aadf5da1bff1d477868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82438 Tested-by: -
Benni Mack authored
Resolves: #101397 Releases: 12.4 Change-Id: Ic8a46c8121b779afbe50f8845ff819a42c604e6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82430 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Kienast authored
This commit updates `typescript` and its `eslint` and `terser` friend packages to their respective latest version. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.18.0 \ @typescript-eslint/parser@^6.18.0 \ @typescript-eslint/typescript-estree@^6.18.0 \ eslint@^8.56.0 \ grunt-eslint@^24.3.0 \ terser@^5.26.0 \ typescript@^5.3.3 npm run build Resolves: #102788 Releases: main, 12.4 Change-Id: I18132539bbe088f7c6025e0a461649244b0641e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82429 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jan 10, 2024
-
-
Stefan Bürk authored
With #102479 support for persisting datetime_immutable object has been ensured and covered with a functional test. However, using a empty string as default for a not nullable datetime field is invalid for MariaDB and MySQL which seemed to work until now in test executions. Something has changed, but had no luck to find any traces in the mariadb, mysql or corresponding docker hub changelogs and commits explaining this. The TYPO3 default TCA schema creates nullable fields with a null default for `date, datetime and timestamp` anyway, and therefore we now use that for the test case table structure. It make sense to test a valid structure if working state is expected. Note: It seems that core ci is not blocked by this yet, however local execution are broken. To verify with and without the change use following command(s): > Build/Scripts/runTests.sh -u > Build/Scripts/runTests.sh -s functional -d mysql \ typo3/sysext/core/Tests/Functional/Database/ Resolves: #102807 Releated: #102479 Releases: main, 12.4 Change-Id: Ide32b3f9dc4b049ff5c3982997c85a0bb01e2fce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82388 Tested-by: -
Oliver Bartsch authored
In case an invalid link type is used in a link field, the link browser does no longer throw an exception but instead displays a flash message with the corresponding information. Additionally, an undefined array key access is resolved, which might happen e.g. in case such invalid link is being analyzed by link validator. Resolves: #102804 Releases: main, 12.4 Change-Id: I5ad35ff46360cc4b27556b8e2c75da69ecbe76d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82387 Tested-by:
-
- Jan 09, 2024
-
-
Torben Hansen authored
The title of a file reference container is currently wrapped to multiple lines, depending on the length of the title and the current screen resolution. This change removes the fixed column width of the dt element. Additionally, the debug information is now on the same line as the title, which is the same behavior as for other inline elements in TYPO3. Resolves: #102066 Related: #99873 Releases: main, 12.4 Change-Id: Ic2b7d8b008a3dd4a95dce0f55228fd89e9b243af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82386 Tested-by:
-
Oliver Bartsch authored
Due to the major update of the `chart.js` package to v4, corresponding `legend` configuration of the BarChartWidget and the DoughnutChartWidget needs to be migrated. Resolves: #102759 Releases: main, 12.4 Change-Id: Iced423d184a86b334390cad21319bf088a8369a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82385 Tested-by:
-
Nikita Hovratov authored
This patch replaces all hard-coded occurrences with a class property, allowing to set the table name as a constructor argument. The page view could be way more flexible if it would allow to render grid column items of other inline tables the same way as for tt_content inside previews. This is done at the back of the mind to enable easy Content Blocks backend previews for inline children. Resolves: #102792 Releases: main, 12.4 Change-Id: I29ee892f1e3dbcb56cd0988039d1996ebf7ba157 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82414 Tested-by:
-
Stefan Bürk authored
The `\TYPO3\CMS\Core\Service\OpcodeCacheService->isClearable()` method checks for existence of opcache function and if they are listed in the `disable_functions` configuration. It seems, that in some environments both methods are missing and not listed in the disabled methods. Even if this sounds odd when the opcache extension is installed but both methods are not available, we add it to the check to avoid the missleading error message: Call to undefined function TYPO3\CMS\Core\Service\opcache_reset() Resolves: #102734 Releases: main, 12.4, 11.5 Change-Id: Icc17a276e8881f502a687db7ca57fc05ecb8981e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82383 Tested-by:
-
Oliver Bartsch authored
Replace the hard-coded `sys_language_uid` name with the actually configured `languageField` value. Resolves: #102758 Releases: main, 12.4 Change-Id: I74d0624c0b79b3085247d5d58f091857ff228411 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82382 Tested-by:
-
Andreas Kienast authored
This commit updates the `flag-icons` and its related build packages `filesize` and `sharpen` to their respective latest version. See changelog at [1]. Executed commands: npm install --save-dev \ filesize@^10.1.0 \ flag-icons@^7.1.0 \ sharp@^0.33.1 npm run build [1] https://github.com/lipis/flag-icons/blob/v7.1.0/CHANGELOG.md Resolves: #102780 Releases: main, 12.4 Change-Id: Ife74d3679d18ec374e40140183c69f912e5b1439 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82406 Tested-by: -
Andreas Kienast authored
The supported node version is raised to 18.19, see https://nodejs.org/en/blog/release/v18.19.0 for further details. Resolves: #102787 Releases: main, 12.4 Change-Id: I9a199b748b9c3859188fa7ae7809526afe4fda43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82381 Reviewed-by:
-
Stefan Bürk authored
New `core-testing-*` images has been build and released. [1] This change update used image version to: * core-testing-nodejs18:1.1.0 * core-testing-nodejs18-chrome:1.1.0 * core-testing-apache24:1.2.0 Additionally, the allowed npm engine in `Build/package.json` is set accordingly. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/614aa2cc6173a49195a74772fb22fbcf0b3d25f2 Resolves: #102782 Releases: main, 12.4 Change-Id: I639f446e46b21fe2969a107eace39f9977eee933 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82380 Tested-by:
-
- Jan 08, 2024
-
-
Andreas Kienast authored
This commit updates `luxon` to 3.4.4. See changelog at [1]. Executed commands: npm install --save luxon@^3.4.4 npm install --save-dev @types/luxon@^3.4.0 npm run build [1] https://github.com/moment/luxon/blob/3.4.4/CHANGELOG.md Resolves: #102777 Releases: main, 12.4 Change-Id: I15419f8693779b8a51eebd2fb9a3e3d822a247c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82398 Tested-by: -
Andreas Kienast authored
This commit updates the JavaScript testing suite, including all related dependencies. As a new requirement, `@types/mocha` is installed as well. Executed commands: npm install --save-dev \ @open-wc/testing@^4.0.0 \ @web/dev-server-esbuild@^1.0.1 \ @web/dev-server-import-maps@^0.2.0 \ @web/test-runner@^0.18.0 \ @web/test-runner-playwright@^0.11.0 \ @types/mocha@^10.0.6 \ sinon@^17.0.1 npm run build npm run test Resolves: #102778 Releases: main, 12.4 Change-Id: Ic2e044a98a1d2536b75420b6b17ef98923d5b6bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82395 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save sortablejs@^1.15.1 npm install --save-dev @types/sortablejs@^1.15.7 npm run build Resolves: #102776 Releases: main, 12.4 Change-Id: I8a9969d87c87b8df708e9e7d7d9cb08a86ae7e54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82393 Tested-by: -
Peter Kraume authored
Resolves: #102772 Releases: main, 12.4 Change-Id: I483a54dc85e0505b336634c55709c543075a3b13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82379 Tested-by:
-
Oliver Bartsch authored
Some controllers / modules are not registered as dedicated modules but only as route, e.g. FormEngine. This is now respected by the start module evaluation, making the redirect feature working again for those use cases. Resolves: #102743 Related: #102665 Releases: main, 12.4 Change-Id: I1398d7aacdcd5d8a3c433fdb21f8710e34668d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82378 Tested-by:
-
- Jan 07, 2024
-
-
Torben Hansen authored
When working with a `FileReference` object, it is currently not possible to delete the file reference with the `delete()` method, since it has never been implemented. The `delete()` functionality can however be useful when working manually with file references. This change implements the missing functionality. Resolves: #102770 Releases: main, 12.4 Change-Id: I5fd8a26f9e4b98de1a6f7553be0da6b53f3bab1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82377 Tested-by:
-
- Jan 06, 2024
-
-
Benni Mack authored
This change does not render a page translation anymore if it was deleted (t3ver_state=2). It also enables the dropdown to create a new page translation but then DataHandler does not allow this anymore. This patch needs more work in DataHandler for "delete translation in WS + create a new translation in WS" Resolves: #98544 Releases: main, 12.4 Change-Id: Ie3a786f28faaf13c4165667ff8fc8a6d98f6e6db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82376 Tested-by:
-
Stefan Bürk authored
Symfony 7 removed deprecated code paths [1][2] and therefore started using strict `in_array()` check for the `in` and `notIn` condition in the expression language. With #102746 the usage of symfony 7 has been allowed, which itself introduces breaking changes. It is optional to upgrade to symfony 7 and therefore breaking changes has been respected and excludes from the TYPO3 policies regarding breaking changes as it is not enforced. This change modifies two tests to assert results based on the used symfony version. [1] https://github.com/symfony/symfony/pull/50867 [2] https://github.com/symfony/symfony/commit/7050bc82dd25c540958 Resolves: #102766 Related: #102746 Releases: 12.4 Change-Id: I0624f33ff270ba793054d0ff84810beee1a98c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82358 Reviewed-by:
-
Stefan Bürk authored
This change upgrades the `typo3/cms-styleguide` version to pull in required changes for `symfony 7 compat`. The culprit was a missing method return type for the funny `kauderwelsch` command execute method. [1] Used command(s): > composer require --dev "typo3/cms-styleguide":"^12.0.3" Note: `ext:styleguide` has been integrated into the core monorepo starting with v13, but older core version still uses the dedicated package and needs to be updated manually. [1] https://github.com/TYPO3-CMS/styleguide/commit/5d2515e051af91a9a2fc Resolves: #102767 Releated: #102746 Releases: 12.4 Change-Id: Ib903f3927e5591e396966466dadb5bef45f5a604 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82359 Tested-by: -
Anja Leichsenring authored
New phpstan find some questionable null fallback occurences, that are not obvious. Add a baseline for now. > composer req --dev phpstan/phpstan:^1.10.51 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102756 Releases: main, 12.4 Change-Id: I3eef057d4fd04fe92f813bad7e1873718f6da765 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82357 Tested-by:
-
- Jan 05, 2024
-
-
Oliver Bartsch authored
Using `treatIdAsReference` it's also possible to pass a file reference uid to the ThumbnailViewHelper. To allow processing such reference, the original file is now fetched to call `process` on it. Resolves: #102571 Releases: main, 12.4 Change-Id: If2f9cad99045d19c6dcc4b95bba6b7de71405956 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82375 Reviewed-by:
-
Christian Rath-Ulrich authored
In the file list module, a file thumbnail does not contain alternative text. To exclude these thumbnails from screen readers and thus improve accessibility, an empty `alt` tag is set. This applies to both the list and tile view. Resolves: #102416 Releases: main, 12.4 Change-Id: Iaf0ce6736f669c0852f96c022fa55c128aecdb9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82374 Reviewed-by:
-
Oliver Bartsch authored
It's unlikely but possible that the `languageField` of a record does not use `sys_language_uid` as name. This is now properly respected in DataHandler. Resolves: #102757 Releases: main, 12.4 Change-Id: Icdb2b599e6ada75c3562c59a41f2b2449ec61d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82373 Tested-by:
-
Oliver Bartsch authored
An additional check is applied to prevent an InvalidArgumentException for cases where `checkPid_value` contains an empty string. Resolves: #102751 Releases: main, 12.4 Change-Id: I906837e75ab505af1e46f55eeccd068c24005e98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82372 Tested-by:
-
- Jan 04, 2024
-
-
Benni Mack authored
PHP-CS-Fixer rule `array_indentation` is activated to have consistent indentation of arrays. In addition, a full run of php-cs-fixer without caches shows also affected areas where comments did not apply properly. Resolves: #102753 Releases: main, 12.4, 11.5 Change-Id: I759149606c4b042f1ac4329d4f5b7166d591456b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82334 Tested-by:
-
