- Dec 15, 2019
-
-
Alexander Stehlik authored
This brings back the optgroups in the CType and list_type fields for normal editors. Additionally some tests for checkAuthMode are added. Releases: master, 9.5 Resolves: #89707 Change-Id: Ib3e6dbf3598ad767910161225a31ad2db939b3d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62342 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Claus Due authored
The name "getName" will be reserved in Fluid 3.0 and is ambiguous. This patch renames that method to become "getFieldName" which is less ambiguous and conflict free. Additionally the ViewHelper is changed so it no longer accesses deprecated property AbstractViewHelper-> viewHelperVariableContainer, instead accessing the ViewHelperVariableContainer via $this->renderingContext. Resolves: #89861 Releases: master Change-Id: Iea474625917293afe67326f765c6a77f7fbe9b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62541 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
This a pre-patch to clean up the functionality of the SystemEnvironmentBuilder, which was originally introduced as part of the Bootstrap logic in 6.0. However, a few cross-concerns can be cut in TYPO3 v10: - Calling the deprecated GeneralUtility::presetApplicationContext() is not needed anymore, as it can be populated on-demand when the deprecated GeneralUtility::getApplicationContext() method is called via Environment API. This way, the ApplicationContext initialization can be put directly in the Environment API initialization call. - The static "isFunctionDisabled" method with a nasty runtime cache is only used in one place in backend, so does not belong to "building system environment", and is therefore removed. - The now unused "exitWithMessage" protected method is removed, removing a dependency to the HttpUtility class. Resolves: #89943 Releases: master Change-Id: I31156b1a1ded306d99bcf2d51de43bc919a0b3e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62628 Tested-by:
-
Sybille Peters authored
The linkref functions return the URLs as they are displayed in the BE form. This will return '&' as '&' HTML entity. Linkvalidator should correctly decode the HTML entity. Resolves: #89488 Resolves: #89682 Releases: master, 9.5 Change-Id: I17b421354d45297423437373b92a93dfbe53d2d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62634 Tested-by:
-
Ron Gebauer authored
An incorrect slash has been removed in multiple extension paths. The slash could lead to exceptions (e.g. within the form framework's `PersistenceManagerException` configuration), as those paths cannot be resolved, Additionally, a proper role has been added to some of those paths. Releases: master, 9.5 Resolves: #89942 Change-Id: I70f5e67d5cc7f58e66507242158e565cd8c70720 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62626 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Sybille Peters authored
Content has been migrated to "TYPO3 Explained" Reduce the content to a stub and add link. Resolves: #89949 Releases: master, 9.5, 8.7 Change-Id: I4c69c8a1f74bea223110b9b6a07e035a03183d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62641 Tested-by:
-
pfuju authored
As the new additional file processors registration also uses the DependencyOrderingService the value of `before` must be an array instead of a string. Releases: master Resolves: #89931 Change-Id: I8eea65c56f68ae94cddb239ac9e08c18a59ee036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62610 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Claus Due authored
The getter/setter methods related to controller name and action name will be removed in Fluid 3.0. An equally valid solution is to specify the template path and filename, which also avoids the lookup logic in Fluid from running and further increases the failsafe operation of this controller. Resolves: #89859 Releases: master Change-Id: I8a3422681bef4b8ada043877ffa3c57eba82d8be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62539 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
To increase usability for editors when using External URL links, the "target" field is moved right below the "Target URL" field. In addition the Target URL field has an increased size, to match the others. Resolves: #79317 Releases: master Change-Id: I9aec38780713df006f98be370e4fadd5c61118aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62633 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Stefan Neufeind authored
The funtionality was named titleTag before. But the new API is called PageTitle API. Resolves: #89940 Releases: master, 9.5 Change-Id: Idd42c5c5f53d999351c787ac7edb474795132f48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62625 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Dec 14, 2019
-
-
Anja Leichsenring authored
In order to spread computing load more evenly trough the test plan, stages receive a shuffled mix of all available jobs with a maximum of 25 mssql related functional test jobs. Resolves: #89946 Releases: master, 9.5, 8.7 Change-Id: I368530899c709bd93d455078606f978a2626679c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62635 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Dec 13, 2019
-
-
Benni Mack authored
When working with the "pages.l18n_cfg" bitset flag, there is an option "default translation", which commonly refers to language with sys_language_uid=0. In most other cases, also in various documentation pieces, the naming is "default language" instead of "default translation" which is more correct in this case. All places are now properly named "default language" and no "default translation" is there anymore, making the functionality more consistent. Resolves: #89924 Releases: master, 9.5 Change-Id: Ibe9ad9371615119eff7535cb45d0f25b858d04da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62602 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Cleanup code by removing unused imports in various classes. Also changes the corresponding ExtensionScanner tests because they are counting the line numbers which changed by removing the imports. Resolves: #89926 Releases: master, 9.5 Change-Id: I588a3aa778a342c6c1154bb431cd325497fd4d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62604 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Due to the INTL/ICU bug, which we have seen on various places, Guzzle, which does not cover our edge cases yet, ran in the same issue as our Core versions earlier in 2019. See https://github.com/guzzle/guzzle/issues/2448 https://github.com/guzzle/guzzle/pull/2454 For the time being, lets mark guzzle as incompatible until Guzzle has solved the issue and released a new version, so we can loosen the conflict constraint. Related: #87953 Resolves: #89904 Releases: master, 9.5, 8.7 Change-Id: If64fb9472d046f020c850cd0551beeaf78796b60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62606 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
sqlserver is a special race that welcomes high memory servers as its habitat. However, we are short on resources and need to offer a very small amout of RAM for a living which already acts as server cruelty. While we're on it, it gets a nice bed to put some data on the RAM disk in the hope its job gets done at least quickier. Resolves: #89935 Releases: master, 9.5, 8.7 Change-Id: Ic06f4b7071ed1d16ec9d0cd5a0a57f05dde171f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62611 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Dec 12, 2019
-
-
Andreas Fernandez authored
The top toolbar items now use our AJAX API instead of $.ajax(). Resolves: #89897 Releases: master Change-Id: I134ea97f2038097d486947f30545304e47a31dff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62578 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add chosen-js@^1.8.7 --dev grunt build Resolves: #89884 Releases: master Change-Id: I242b8925f108d3bfa26191f1c58ea24a1149f0ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62609 Tested-by:
-
Benni Mack authored
Resolves: #89925 Releases: master, 9.5, 8.7 Change-Id: I3449606aa143c23dd656dd566c87aec08ae19425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62603 Tested-by:
-
- Dec 11, 2019
-
-
Chris Müller authored
The code-block directive needs two colons to be rendered correctly. Resolves: #89922 Related: #89463 Releases: master Change-Id: Ida99628710cc3558a0dbdc39272e788c390ca154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62600 Tested-by:
-
Richard Haeser authored
A PSR-14 event is introduced to make it possible to control the hreflang tags that will be rendered. Additionally the class HrefLangGenerator is migrated to be a listener to the new event. Resolves: #86614 Releases: master Change-Id: I51a5a79da6996148e62301c793b0ad257aada102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Andreas Fernandez authored
The AJAX API fails to send a request if the API receives a non-absolute URL like /typo3/index.php?foo=bar, since the domain is missing. To fix this issue, the origin of the triggering request is added as well as `base` argument of URL(). Resolves: #89893 Releases: master Change-Id: Ice61a71fc8d4627e6d0b3b9d0f5ab524000361ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62576 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Alexander Schnitzler authored
As a prepatory work for a better static code analysis all ampersands have been removed from doc block params. The doc block must not reflect whether a variable is passed by value or reference. Releases: master Resolves: #89912 Change-Id: Ibead2ec2db6487e32bcd5fc271a6566bab46d255 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62594 Reviewed-by:
-
Jan Stockfisch authored
Shows error flash message while `exposeNonexistentUserInForgotPasswordDialog` is set to `1` Resolves: #88111 Releases: master Change-Id: I193e2ca22c45a83450aa4f0e44e3dce46696b16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62482 Tested-by:
-
- Dec 10, 2019
-
-
Alexander Schnitzler authored
As the StringClassNameToClassConstantRector would convert string class names that are deliberately defined as string, this rector has been disabled. Releases: master Resolves: #89899 Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581 Tested-by:
-
Oliver Bartsch authored
As the extension configuration field `backendLogo` isn't resolved by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`, it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage) not possible to add a path with a leading slash. As this is neither explicit allowed nor disallowed, this unifies the behavior by removing a possible leading slash from the defined path before it gets resolved as it's already the case for the other fields. Resolves: #89636 Releases: master, 9.5 Change-Id: I3f7a72f1005bc403c72b837cf66e5303962a8a42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62293 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Rasmus Larsen authored
IPLock breaks modern IPv6 setups because of the Fast fallback aka. Happy Eyeballs algorithm that can cause users to jump between IPv4 and IPv6 arbitrarily. Enabling lockIP should be a very conscious decision, not a default. Resolves: #89869 Releases: master Change-Id: I4b0fde1f767bfca613276d4763b91d9feb86ea27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62559 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Michael Binder authored
This Patch allows the usage of an HMENU with special = directory and the Fallback Type 'Free mode' Resolves: #88344 Related: #89368 Releases: master, 9.5 Change-Id: Ib7f53b4e061b6387e6b29b2545696a3eb2d015a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62527 Tested-by:
Tobias Gaertner <tobias.gaertner@benaja-websolutions.com> Tested-by:
-
Benni Mack authored
In order to use the final LTS distributions from Symfony for our latest stable, we need to set proper platform requirements for the root composer.json. Our packages rely on the settings so the base package can properly raise dependencies. Symfony has the requirements due to other PHP bugs (fixed very early already), however using the tarballs in 7.2.0 / 7.0.0 would still work, as the symfony changes only fix issues we dont rely on. v10: 7.2.5 v9: 7.2.5 v8: 7.0.8 Used composer commands: composer config platform.php 7.2.5 composer update --lock Resolves: #89882 Releases: master, 9.5, 8.7 Change-Id: Ib51ec076e643581603fced3ed0daa0de0aadb12c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62565 Tested-by:
-
Alexander Schnitzler authored
In two places, TYPO3\CMS\Frontend\Page\PageRepository had been used instead of TYPO3\CMS\Core\Domain\Repository\PageRepository. As this will eventually fail in the future, the wrong usage has been fixed. Releases: master Resolves: #89901 Change-Id: I5799bcb93486e3c8aa4a71fe4ad03cfce34948d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62586 Tested-by:
-
Alexander Schnitzler authored
In order to let rector process tests, the autoloading of all processed classes needs to be intact. In TYPO3 there were a bunch of classes whose namespace were a bit wrong according to PSR-4 and there were some class that didn't fit the PSR-4 standard at all. Classes that could easily be fixed have been fixed. All others have either been registered via a class map in composer.json or they have been excluded from the processing of rector. This change does not apply rector rules to tests, it only enables rector to operate on tests due to fixed autoloading. Releases: master Resolves: #89900 Change-Id: Iaa4a5bb2677a5a9af374d780423d962dcc09ade2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62583 Tested-by:
-
- Dec 06, 2019
-
-
Benjamin Franzke authored
The GeneralUtility $container instance should only be set/used in functional tests as we a) can not reset the instance (which means other unit tests are affected) and b) should mock/inject dependencies in unit tests. TreeDataProviderFactoryTest is therefore changed to to use GeneralUtility::addInstance() (which is intended for unit tests) instead of GeneralUtility::setContainer(). Change-Id: I9fc0e76077cc1cc2a6935d025b97309efc315f4f Releases: master Resolves: #89890 Related: #89733 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62573 Tested-by:
-
Benni Mack authored
Since TYPO3 v10.0, all links generated by TYPO3 contain a cHash if - there are arguments that are not mapped within the routing - there are arguments that are not explicitly "excluded" from cHash (e.g. fbclid) - there are arguments that are not internal (L,id,MP). The PageArgumentValidator middleware now always evaluates the arguments properly at every request and decides to disable caching or throw a 404, if an incoming request does not have a cHash or an invalid cHash. Through the middleware, any plugin is automatically checked for the cHash, and it does not matter anymore for plugins, so it does not matter for integrators or template authors as well as cHash is managed internally by TYPO3 Core now (with no way to disable it, for security reasons). All functionality regarding cHash that can be dropped: - CacheHashEnforcer and Extbase option - TSFE->reqCHash() can be marked as deprecated - the option within PiBased Plugins is now irrelevant as well. This change jointly decouples cHash evaluation from any other part than Url Generation (= PageRouter) and Resolver (PageArgumentValidator), finally streamlining all logic of cHash functionality. Resolves: #89868 Releases: master Change-Id: I7a694fbc95fa1ea4dc85b12a94b0a06b3722fd11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62267 Tested-by:
-
Alexander Schnitzler authored
In order to simplify the request/response handling in Extbase and to prepare the introduction of PSR-7 compatible request and response objects, the web versions of Extbase's request and response have been deprecated. All relevant logic has been moved into the base classes to stay api compatible and not introduce a breaking change. Along with the simplification of the request and response objects, quite a lot of instance checks have been removed to ease the transition to having a public api that is defined by interfaces and not concrete implementations. Releases: master Resolves: #89673 Change-Id: Ie920ae7d38e6de3167ff57f93fa6e98af2936d9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62317 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade datatables grunt build Resolves: #89888 Releases: master Change-Id: I73ea78f4d217c2846b0c79cf0e5ad06aea1a8e9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62572 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add sortablejs@^1.10.1 --dev grunt build Resolves: #89886 Releases: master Change-Id: I871faaca63f19bf7fe2e782d6741cf3e476156b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62571 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade requirejs grunt build Resolves: #89887 Releases: master Change-Id: I5b2347ebec049e1663a3684ce4246c323228befb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62569 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add moment@^2.24.0 moment-timezone@^0.5.27 --dev grunt build Resolves: #89885 Releases: master Change-Id: I6a6a7122fb1a0a343206c04c5cc3ce6a9a891d02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62570 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade typescript grunt build Resolves: #89889 Releases: master Change-Id: I1152fbbc89b30cae9ba34f1fa11494c071a7fe4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62568 Tested-by:
-
Andreas Fernandez authored
In order to become independent of jQuery, a new API to perform AJAX requests is introduced. This API implements the fetch API available in all modern browsers. Resolves: #89738 Releases: master Change-Id: Ibdc1a7047b29402dea21b6dd7a48217b9afb849e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62372 Tested-by:
-
Oliver Bartsch authored
Move title and description of the clear cache error notification to a xlf file to make it translatable. Resolves: #89447 Releases: master Change-Id: I925773de216ee8283336981b2cff2bd9a087a927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62269 Tested-by:
-
