- Aug 15, 2014
-
-
Lars Trebing authored
When directly comparing CAST(... AS CHAR) with a CHAR field (including VARCHAR and TEXT) whose collation isn't the same as that of the database connection, MySQL gives an error like this: > Illegal mix of collations (utf8_general_ci,IMPLICIT) and > (utf8_unicode_ci,IMPLICIT) for operation '<>' Wrapping the right side of the comparison in CAST(... AS CHAR) as well keeps the data unchanged while ensuring that both sides have the same collation. Change-Id: Icaec66412d6b6441ae30065ffb92565991e9a1e4 Resolves: #36754 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/32117 Reviewed-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Aug 14, 2014
-
-
Oliver Hader authored
Remove new-line at end of file that has been introduced by accident in commit:7ef6d2c8 Releases: master Change-Id: I0a18755d16aaef4496b21183f870dffbd86ee2c1 Reviewed-on: http://review.typo3.org/32158 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Hader authored
The retrieval of file references in BackendUtility is currently bound to the thumbCode() method but is useful for other components as well. Resolves: #60054 Releases: master, 6.2 Change-Id: Id92bdeaed24d8924285a640f905ffd55db21da4d Reviewed-on: http://review.typo3.org/31287 Reviewed-by:
-
Oliver Hader authored
The record details view renders record icons for both live and versioned record. However, this representation is shown rather stand-alone and can be combined with the accordant headers. Resolves: #60015 Releases: master, 6.2 Change-Id: I2f468a06271f335c491d90d825f7bcef7a9db9f6 Reviewed-on: http://review.typo3.org/31254 Reviewed-by:
-
- Aug 13, 2014
-
-
Andy Grunwald authored
Resolves: #60878 Releases: 6.3 Change-Id: I2cc8ec067adcc66bdd589104d03f20c385e52e99 Reviewed-on: http://review.typo3.org/32071 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Benjamin Mack authored
On every Frontend request, the original media wizard provider of EXT:cms is loaded, by fetching the MediaWizardProviderManager and then an object of MediaWizardProvider is loaded and held in memory, as this is not needed, but only on pages where a media is used. This change moves the instantiation of the providers to the time when it is needed. Further modification would be to add the registered wizards to TYPO3_CONF_VARS[FE][mediaProviders] and use them directly in the MEDIA object, so the MediaWizardProviderManager class could be deprecated. Releases: 6.3 Resolves: #56336 Change-Id: Id466d41fef019449d820b6faec3946ec1c951488 Reviewed-on: http://review.typo3.org/28046 Reviewed-by:
-
Oliver Hader authored
Extend install tool suhosin checks by * suhosin.get.max_name_length=200 * suhosin.post.max_name_length=200 * suhosin.request.max_varname_length=200 Resolves: #60356 Releases: 6.2, 6.3 Change-Id: I382e44832918799df58a912e95cd4b0c3f0b81a3 Reviewed-on: http://review.typo3.org/31637 Reviewed-by:
-
Oliver Hader authored
The defaultMailFromName setting is not used for sending the test mails in the install tool. Resolves: #60758 Releases: master, 6.2 Change-Id: I35e1b887de6b06bb5f301e037d6d412c18ac0b37 Reviewed-on: http://review.typo3.org/31966 Reviewed-by:
-
Christian Weiske authored
Using fluid's <f:debug> to get dumps of json_decode()d objects does not work currently. The DebuggerUtility shows only properties obtainable via ReflectionClass, which does not work for stdClass objects. The patch introduces special handling of stdClass objects, using the properties that actually exist in the object. Change-Id: I3845178f6defdbceae4b867f45e5080f23443766 Fixes: #60912 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/32108 Reviewed-by:
-
Andreas Fernandez authored
Updating the field "current_version" fails with some DMBS because $uidsOfCurrentVersion has too many elements. This patch chunks the array into multiple parts and updates the uids in each part. Resolves: #60859 Releases: 6.2, 6.3 Change-Id: If63f855b250bf7c9b6cd7112f60392cfc8ccfd67 Reviewed-on: http://review.typo3.org/32065 Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Markus Klein authored
The system environment check does not properly parse the suhosin configuration option for whitelist. Fix this by changing the code to be less strict about the actual syntax of this option. Resolves: #60925 Releases: 6.3, 6.2 Change-Id: I6797a313cedaaf1895cf7b4fddaae9811341006b Reviewed-on: http://review.typo3.org/32122 Reviewed-by:
Daniel <typo3dev@outlook.com> Tested-by:
-
Oliver Hader authored
On publishing a delete placeholder all other versions shall be deleted as well, since the original record will be deleted after that action. However, this is only valid for the live workspace and using the legacy version behavior there. DataHandler::deleteVersionsForRecord() calls BackendUtility::selectVersionsOfRecord(), but without the additional, but required, $workspace argument. Thus, all other versions in other workspaces are deleted as well. The SQL query to determine versions needs to be limited to either the live workspace (for legacy versions) and the current workspace. Resolves: #60249 Releases: master, 6.2 Change-Id: If90511dc4ac2bc3dde6e58570e6bf10e4ac949db Reviewed-on: http://review.typo3.org/31589 Reviewed-by:
-
Oliver Hader authored
If deleting an IRRE child reference, the nesting leving in the workspace module is not shown correctly. The reason for that is, that the sys_refindex entry points to the live id of the deleted child record. This change takes care of correct visualization only, but does not touch the sys_refindex behavior in this case. Resolves: #59853 Releases: master, 6.2 Change-Id: I09970d12ba10e528c150275952ec4c9ff8333a0a Reviewed-on: http://review.typo3.org/31591 Reviewed-by:
-
Oliver Hader authored
Having a record in live workspace with an accordant localization leads to the fact that actions to the default language also have an impact to all localizations. In a workspace, first deleting the localization, then deleting the record of the default language, ends up in actually having reverted the previous deletion of the localization. The solution is to check for delete placeholders in DataHandler::deleteL10nOverlayRecords(). Resolves: #59113 Releases: master, 6.2 Change-Id: I888c83a58d591f57bc2ea75a49fa603a56a7f722 Reviewed-on: http://review.typo3.org/31142 Reviewed-by:
-
Oliver Hader authored
After some workspace actions being performed in the workspaces module in the TYPO3 Backend, the page tree does not get updated: * discarding a single workspace version * performing mass actions which output warnings Resolves: #59828 Releases: 6.2, master Change-Id: Ic9fb6613e8647ed351246ea18fcb3696e60ef7b2 Reviewed-on: http://review.typo3.org/31091 Reviewed-by:
-
- Aug 12, 2014
-
-
Christian Kuhn authored
composer.json is configured to fetch latest phpunit 4.x branch. Since 4.2 was just released stable, it will be used now. phpunit 4.2 now relies on Ocramius/Instantiator to create mocks that do not call a constructor during instantiation. This project was created to cope with a recent security fix in PHP unserialize() that rendered the old way of creating those mocks invalid. The instantiator project however has issues with PHP versions 5.3 and 5.6 that lead to some failing tests and need further investigation. To not run into this during our next merges, the patch nails phpunit to 4.1.x for now. Change-Id: I5feb8346e0713fefe6c8fa899c76d3e040dd1973 Resolves: #60923 Releases: master, 6.2 Reviewed-on: http://review.typo3.org/32115 Reviewed-by:
-
Wouter Wolters authored
When using toggleButton in "Test setup" a JavaScript error is thrown because the scrolling handler can only be used if the fixed footer is available. Add a check to prevent this JavaScript error. Resolves: #60577 Releases: 6.3,6.2 Change-Id: Ie7628e83280f6af032b364586cdfb6b386663d9d Reviewed-on: http://review.typo3.org/31828 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Aug 06, 2014
-
-
Benjamin Mack authored
As IE6 is not supported for the TYPO3 backend anymore, the IE6-specific styles for HTMLarea can be safely removed. Resolves: #60770 Releases: 6.3 Change-Id: I11e91f705c49be9f2ead48c0d741242acda6cbb6 Reviewed-on: http://review.typo3.org/31978 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 04, 2014
-
-
Anja Leichsenring authored
Usage of $TYPO3_CONF_VARS is discouraged, instead $GLOBALS['TYPO3_CONF_VARS'] should be used. The hint in next to the install tool login mask spells the discouraged version, which is corrected with this patch. Change-Id: Ia7ded107a9b5670c0bc35da92993e84ad45c167e Releases: master, 6.2 Resolves: #60639 Reviewed-on: http://review.typo3.org/31882 Reviewed-by:
-
- Aug 02, 2014
-
-
Jo Hasenau authored
Before fetching related records from a foreign table, we must ensure that there is a uid to be considered, since otherwise we will fetch any record having a 0 value for that field. There are method calls in the core, that don't provide a uid, so the default value 0 is used, i.e. when fetching children of translated gridelements, causing memory outage when tt_content is > 10000 records. Resolves: #60494 Releases: 6.3, 6.2 Change-Id: I1105964f98f79074bb37dc1921180b493fac4bc6 Reviewed-on: http://review.typo3.org/31781 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
- Aug 01, 2014
-
-
Mattias Nilsson authored
When using the upgrade wizard for RTE filelinks and the record is not an array it throws an exception. To give the end user a better experience an additional condition for checking that the variable is an array is added. Resolves: #58898 Releases: 6.3, 6.2 Change-Id: I94ae6cc7272a63fd208267bf375b629cb5a4b2cc Reviewed-on: http://review.typo3.org/31931 Reviewed-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
Aske Ertmann <aertmann@gmail.com> Reviewed-by:
-
- Jul 31, 2014
-
-
Andreas Wolf authored
This is the first step of replacing Prototype usage. Change-Id: I6599c3ce7eea493e2bfaa29312775bf1659ded69 Resolves: #58475 Releases: 6.3 Reviewed-on: http://review.typo3.org/29834 Reviewed-by:
-
- Jul 30, 2014
-
-
Tomita Militaru authored
While persisting an object, the DataMapper is asked for the plain value of a property, the TypeHandlingUtility::isCoreType() method is using "is_subclass_of()" to check if the given input is an instance of \TYPO3\CMS\Core\Type\TypeInterface. Unfortunately, when passing a string into "is_subclass_of" it tries to instantiate an object of that name. This will trigger the class autoloader. Even worse, when the string contains a special char (like an umlaut) the class cache will throw an exception (#1233057752). Thus persisting an object with special chars in a property value is not possible at the moment. This change fixes the issue by calling TypeHandlingUtility::isCoreType() only if $input is an object. Resolves: #53425 Releases: 6.3 Change-Id: I8b97499f2d90e26ba2a5dec411de266948fdf005 Reviewed-on: http://review.typo3.org/25349 Reviewed-by:
Tobias Liebig <tobias.liebig@typo3.org> Tested-by:
-
- Jul 28, 2014
-
-
Markus Klein authored
The Install Tool check the PHP configuration for the maximum file upload size within the checkMaximumFileUploadSize() method. This method issues an error message in case the values do not fit. The error message outputs the values in MB which might give a wrong indication to the user, as the values seem to be equal although the check complains they are not. Provide better output by giving those numbers in KB rather than MB, which will show diverging numbers correctly then. Resolves: #60627 Releases: 6.3, 6.2 Change-Id: I5faa4ceb4d7279278182716c31bf6d6dcb851052 Reviewed-on: http://review.typo3.org/31873 Reviewed-by:
Christian Hünniger <huenniger@mellowmessage.de> Tested-by:
-
Ernesto Baschny authored
Splits up the old curlProxyServer correctly, stripping "http://" and potentially trailing slashes. Resolves: #45834 Releases: 6.3, 6.2, 6.1 Change-Id: Ibfefb927b5fd3fe900170870e1093027d4fe34b5 Reviewed-on: http://review.typo3.org/31867 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- Jul 27, 2014
-
-
Dmitry Dulepov authored
When labels were extracted to translation files, a error was made that changed the meaning of the admin panel entry. But the code was not modified to reflect the change of the meaning. Thus the admin panel shows that the page is cached when it is actually not cached and vice versa. Additionally, it shows 0 and 1 for the "Page cached" entry. This should be "yes" or "no", not numbers. Change-Id: I2519593e7da08b71ccdd5d7dc3dd6ced7ecac3ac Resolves: #56265 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/27835 Reviewed-by:
-
Sascha Egerer authored
When you search for an extension in the Extension manager and then click on the "Update Now" button to load the newest list from the TER, the spinner was not displayed. Also fixed some invalid HTML stuff and repositioned the spinner. Resolves: #60600 Releases: 6.3, 6.2 Change-Id: I670d821248d14c0c1038b5995fc7daef2ead42d8 Reviewed-on: http://review.typo3.org/31845 Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
Helmut Hummel authored
Currently when TYPO3 is configured to do language fallback and a record is translated in language A, but not in language B and language B is requested, then this record is excluded. This is the case because of a wrong subselect condition. Extbase selects records in the requested translation or if no translation is available in the default language. However the check if translation is available looks for *any* translation not only for a translation in the requested language. Thus the record from the default language is not selected at all if there are translations available in any other language. Solution is to change the subselect condition to check for the currently requested language. Releases: 6.1, 6.2, master Resolves: #60613 Change-Id: I8ebd68e1f5741d3557910ae2f8c2d19474548d01 Reviewed-on: http://review.typo3.org/31859 Reviewed-by:
-
Susanne Moog authored
The signal emitted in the ConfigurationManager of the ExtensionManager misses crucial information (the extension for which the configuration was written) and is therefor useless at the moment. Add the extension key to the signal so that it may be used. Change-Id: I21d22b10852e9842d9d077eb5dd49ec4518ca4ed Fixes: #60609 Releases: 6.3 Reviewed-on: http://review.typo3.org/31773 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- Jul 26, 2014
-
-
Stefano Kowalke authored
The help command prints informations about a specific command. This text is taken from the doc comment by reflection. Currently the parser expects that type, variable name and comment are separated by exactly one space, according to our CGL. Relax the parsing to allow multiple whitespace characters (including tabs) as separators when fetching the comment for an argument, to support other coding styles. Resolves: #59843 Releases: 6.3, 6.2 Change-Id: Id0a9c0ec00bf442adcbd428088744419200a69a0 Reviewed-on: http://review.typo3.org/31106 Reviewed-by:
-
Christian Kuhn authored
For better documentation of important changes a new file structure is introduced that substitutes the old NEWS.md file. Some recent changes are already added with this change as examples, but all patches since 6.2 release need a post-merge review to see which further patches need documentation. In future, changelog files for important changes should be provided together with the patch that introduces the change. Resolves: #60186 Resolves: #59741 Resolves: #59740 Releases: master Change-Id: I6e154262ed49542a5b15e7c68313c9f11dea5fe5 Reviewed-on: http://review.typo3.org/31853 Reviewed-by:
Ernesto Baschny <ernst@cron-it.de> Tested-by:
-
Andreas Wolf authored
Change-Id: I5fe2f79ba233e114fb2bfb87c1100eeb8dccbc41 Resolves: #58475 Releases: 6.3 Reviewed-on: http://review.typo3.org/29835 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benjamin Mack authored
There are several places in the TYPO3 Form Engine where the styling information about tables (valign) is hard-coded. The patch removes that, styling is done via CSS. Resolves: #56261 Releases: 6.3 Change-Id: Ibcc9bb7df3cf05e791eae7f16d91e0afa60ab65d Reviewed-on: http://review.typo3.org/27833 Reviewed-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
-
- Jul 25, 2014
-
-
Wouter Wolters authored
TypoScript TemplateService contains some hard coded TS that is always present. The two defaults config.extTarget and config.uniqueLinkVars are now moved to EXT:frontend and registered with the usual API call. styles.insertContent is removed since it was always hidden in the object browser and probably never used by anyone. Change-Id: I8d0fd7c91e0c3b7ac19bcf1e435bb911b597e525 Resolves: #42543 Related: #60567 Releases: 6.3 Reviewed-on: http://review.typo3.org/20279 Reviewed-by:
Benjamin Mack <benni@typo3.org> Tested-by:
-
Anja Leichsenring authored
When an exception is expected in DependencyUtilityTest, the correct exception is tested by text. The change of wording of some of those exceptions caused the related test to fail. Testing for the exception code instead of the text opens the possibility to adapt display messages, while the exception code stays unchanged and stabilizes tests against false positives. Change-Id: Ib1365c8d7166e522690bb9f8842adc8eb27f635b Resolves: #60583 Relates: #53572 Releases: 6.3, 6.2 Reviewed-on: http://review.typo3.org/31835 Reviewed-by:
-
Benjamin Mack authored
FE Login still uses TypoScript with a manual inclusion of the original file and then the original class name. plugin.tx_felogin_pi1 = USER_INT plugin.tx_felogin_pi1 { includeLibs = EXT:felogin/pi1/class.tx_felogin_pi1.php userFunc = tx_felogin_pi1->main } This way it is impossible to XCLASS the new namespaced class "FrontendLoginController" without also changing the USER_INT userFunc path. In order to remove the deprecation, we need to change the class name - no-brainer. Resolves: #60063 Releases: 6.3 Change-Id: If09e5a3fdc3317623d5ea1de9af04cb04e606656 Reviewed-on: http://review.typo3.org/31290 Reviewed-by: -
Benjamin Mack authored
Renames the folder "resources" to "Resources" and moves the JS files into "Resources/Public/JavaScript". Resolves: #60582 Releases: 6.3 Change-Id: Id549c4d006e8690b49b7800399fca95410ee641c Reviewed-on: http://review.typo3.org/31832 Reviewed-by:
-
Christian Kuhn authored
There is a config to define the used "contentTable" which is set by cms extension to tt_content. Using tt_content is hardcoded at many places and probably no one ever set this option to something different than "tt_content". The option is dropped now. Resolves: #60570 Releases: 6.3 Change-Id: I039e7f5c9e0562c54ce671dc7e7a2ac807f8076e Reviewed-on: http://review.typo3.org/31831 Reviewed-by:
-
Susanne Moog authored
The wording of a TYPO3 dependency error currently suggests installing another TYPO3 version to make an extension usable - that does not make sense. Change the error message so it's clear that it's the extensions' support that is missing. Change-Id: I7a5f7acde7bebc9c3f7acda92e2522ffb979d478 Resolves: #53572 Fixes: 6.3, 6.2 Reviewed-on: http://review.typo3.org/31825 Reviewed-by:
-
Susanne Moog authored
Transparent turns black unless you specify a different color because transparent = unset color = 0 = black. We should fix this by adding the "-opaque white -background white -flatten" parameters for the convert action done by the install tool. Change-Id: I5dd5c41852a33159752702b68ce0a297b33cf569 Releases: 6.3, 6.2 Fixes: #60570 Reviewed-on: http://review.typo3.org/31816 Reviewed-by:
-
