- Jul 23, 2019
-
-
Oliver Hader authored
Change-Id: Ic8975554d38eef468af5454152a0200e21eb962d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61339 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Benni Mack authored
Change-Id: I4b576a1651703f7d404dac7127f9ad373310be58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61338 Tested-by:
-
Benni Mack authored
When adding exports into fileadmin, the files are stored in a temporary folder, which is located in typo3temp/var/transient/ - this folder does not need to be accessed via FAL, as it also adds some issues when this file is not inside the document root, for this reason, the code is adapted to work with the native File System directly, and when moving to fileadmin/user_upload/_temp_/impexp/ then FAL is used again. Resolves: #88815 Releases: master, 9.5 Change-Id: I633a5dbda595bef73b7420ad511e03c0f7054972 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61336 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Jul 22, 2019
-
-
Guido Schmechel authored
To prevent unwanted entries, the autocomplete attribute in the Install tool is added with the `off` property. Resolves: #88709 Releases: master, 9.5 Change-Id: I3c0a343fd76170f6cc37e5e87ad9a5d5d9a52fb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61331 Tested-by:
-
Anja Leichsenring authored
Change-Id: Id4f981b3d6b62601ae4f3c7a56b3153d1884f669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61328 Tested-by:
-
Benni Mack authored
In order to keep the the extension list in the database small, the repository data is limited to TYPO3 v8 or later. Resolves: #88814 Releases: master Change-Id: I1632e269c748541b7a6b8eca763d2938c29c0509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61335 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Benni Mack authored
This patch adds some sentence dots, and adapts various places about deprecations of 10.0 which didn't make into TYPO3 v10.0. Resolves: #88813 Releases: master Change-Id: I7f7e7037dd09bc1a1b8857e3dfbba3c315eb5712 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61334 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benjamin Franzke authored
The Mailer class used by EnvironmentController::mailTestAction() requires the EventDispatcher to be available. Provide it by configuring EventDispatcher and ListenerProvider in a ServiceProvider, which enables usage from the failsafe install-tool container. Note: Event listeners that are registered using symfony tags will still be added to the ServiceProvider instantiated ListenerProvider in non-failsafe mode. The symfony generated factory will look like: $this->services['TYPO3\\CMS\\Core\\EventDispatcher\\ListenerProvider'] = $instance = \TYPO3\CMS\Core\ServiceProvider::getListenerProvider($this); $instance ->addListener( 'TYPO3\\CMS\\Core\\Mail\\Event\\AfterMailerInitializationEvent', 'TYPO3\\CMS\\Core\\Compatibility\\Slot\\PostInitializeMailer', NULL ); Resolves: #88806 Releases: master Change-Id: I4775cc04af3d62ae08c43d762f51af31858cac2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61329 Tested-by:Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Susanne Moog authored
The dependency of AdminPanel initialisation and TSFE has been dissolved. Furthermore, the AdminPanel initialisation has been better integrated into the PSR-15 middleware process by providing modules with an option to manipulate the request object during initialisation. Resolves: #88807 Releases: master Change-Id: I9db2d3056d8216e15ff3303a7667ff7a4d8016e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61323 Tested-by:
-
Georg Ringer authored
Show the console command and arguments in the backend of symfony commands. Resolves: #88788 Releases: master, 9.5 Change-Id: Ief0abb4404c14dbfa85eb4acddcb74e796ba0272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61316 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Alexander Schnitzler authored
This patch adds classes to the ReST file that lists classes that switched to strict mode during the development of TYPO3 10.0. Releases: master Resolves: #87941 Change-Id: Ieb8a83ef04035c94fd84d3825676cd50a68eb8a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61313 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Mathias Brodala authored
Also output a report message in case of unsupported hash algorithm. Resolves: #88794 Releases: master, 9.5 Change-Id: I1ba4efd321f4d2d5bc35b65bb7caac0581fe0a39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61318 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jul 21, 2019
-
-
Markus Klein authored
A check is added to abort the search for a recycler folder if a storage is not browsable. An editor wouldn't be able to recover the file anyways as this requires browsing the storage. Resolves: #88632 Releases: master, 9.5, 8.7 Change-Id: Ie59b53c8b17434bb162de7c52a756d7ea3ceb88d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61153 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Julian Geils <j_geils@web.de> Reviewed-by:
-
Oliver Hader authored
Setting `addQueryString.method` of typolink could be used like shown below in order to transform HTTP POST parameters into according GET parameters. typolink { parameter = 123 addQueryString = 1 addQueryString.method = POST } In terms of correctly using HTTP verbs it's bad practise in general to treat GET and POST equally, besides that documentation already mentioned potential side-effects like accidentally exposing sensitive data submitted via POST to proxies or log files. That's why values POST, GET,POST and POST,GET are not allowed anymore for `typolink.addQueryString.method`. Maintaining functionality - if required at all - has to be done using domain specific logic in according controllers or middleware implementations. Resolves: #88755 Releases: master Change-Id: I6ecfdd2ee98251b64093c1a13f9371beea862ddd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61295 Tested-by:
-
- Jul 20, 2019
-
-
Benjamin Franzke authored
Context is stateful as Aspects dependent on the (currently dispatched) request type (frontend/backend/installtool/CLI). Reqest-dependent arguments can not be injected during service creation; therefore the Context class is now created without default aspects and enhanced by the application classes (on demand). Note: The UserAspect constructor is adapted to use an explicit stdClass allocation instead of an immutable array casted to an object for the (fallback) pseudo user. This is to avoid php segmentation faults in functional tests (and also random unit test runs). The segmentation faults would be triggered due to the constructor change in the Context class, which now uses ondemand instead of preemptive Aspect creation. Background: immutable arrays are stored on stack. The cast to an object probably didn't relocate this memory to the heap which then causes segmentations faults when the static memory area (on stack) is exceeded. Releases: master Resolves: #88793 Change-Id: Ib165f85b66b34e8025e28ef483260463f1e2c826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61274 Tested-by:
-
Benjamin Franzke authored
https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834 changed the method getSwitchableControllerActions to be called getControllerConfiguration. It was forgotten to update one mock in AbstractConfigurationManagerTest which caused the test to be skipped with a warning. Resolves: #88808 Related: #88496 Releases: master Change-Id: I7624a274db13e16fc2002468b1eee0459713de93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61330 Tested-by:
-
- Jul 19, 2019
-
-
Markus Klein authored
TYPO3's Logging Framework (especially LogLevel and LogManager) are not PSR-3 compatible, as it uses integers as constants and not strings, as defined in PSR-3's interfaces. This makes TYPO3 incompatible to use custom loggers, or to interop with other logging systems. The patch changes the logging API to depend on PSR-3 interfaces but strives for maximum compatibility. Resolves: #88799 Releases: master Change-Id: Ib41840cc87035c2323087877bac07e62c439482e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61156 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
A TypoScriptAspect has been introduced to handle Context depending TypoScript settings. As a first step, the property `forceTemplateParsing` has been moved to this aspect and deprecated in both TSFE and TemplateService. Additionally, this is another step to resolve the interdependance between AdminPanel and TSFE. Resolves: #88792 Releases: master Change-Id: I77e7548a51534e96ad0656810163267e6c373d3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61312 Tested-by:
-
Frank Naegler authored
This patch enables the labels for the export buttons which are hard to distinguish in case both appear side by side. Resolves: #88804 Releases: master, 9.5 Change-Id: Ie9a72823fcc1788ca10ae93f267c408a8da90212 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61326 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by: Daniel Windloff Tested-by:
-
Frank Naegler authored
This patch adds a type cast to fix broken export of tables. Resolves: #88803 Releated: #88662 Releases: master Change-Id: I9fe725ddadf2a9d63d3c8af8005a453a68dc46cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61325 Tested-by: Daniel Windloff Tested-by:
-
Andreas Fernandez authored
The php-cs-fixer rules have been adjusted by the following settings: - no_empty_phpdoc: Remove empty phpdoc blocks without any information - no_null_property_initialization: Remove initial null value from class properties - modernize_types_casting: Replace old-school `*val()` function calls with proper type casts Resolves: #88802 Releases: master Change-Id: Id2cfa849553d918e0461bafd09b3960bdf5ff700 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61324 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Daniel Windloff authored
Some properties and methods are not used any more. They can be removed. Resolves: #88779 Releases: master Change-Id: I2f3d41803360eee692e9e6ce4b8b1a0cd76f559d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61306 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
-
Susanne Moog authored
The public internal property of TSFE "fePreview" has been deprecated in favor of a dedicated aspect handling the frontend preview flag. As a first step, the frontend preview aspect only contains a boolean flag holding the current preview state - but it might be extended with additional information on the preview mode at a later point. This is also a first step to remove the TSFE dependencies from the AdminPanel initialisation process. Resolves: #88791 Releases: master Change-Id: I2994d69d824b1b107a3a878b87c9dd2f7daf3ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61311 Tested-by:
-
- Jul 18, 2019
-
-
Benni Mack authored
Due to e50b1c1a the TypoScriptFrontendController requires four objects as constructor arguments while keeping maximum compatibility by fetching fallback information from the current PSR-7 object or setting data from the legacy arguments. The constructor is cleaned up with special initialize methods for readability. Resolves: #88747 Related: #88717 Releases: master Change-Id: I734d1184780b8bfdf0e9638aca75c6a4fc0f7e2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61289 Tested-by:
-
Alexander Stehlik authored
A new IpLocker class replaces the lock functionality in AbstractUserAuthentication. The new class is capable of locking to IPv4 and IPv6 addresses. Resolves: #21638 Releases: master Change-Id: I0075a9e49690e31c938abf7242c1f088c73bb37d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/52947 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Jul 17, 2019
-
-
Anja Leichsenring authored
Also, some improvements are made to sentence structure, tenses and syntax highlightning. Resolves: #88748 Releases: master, 9.5 Change-Id: I932dabbfc404de7c3dc4f3cef1ccb50c2fd94f72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61291 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
-
Benni Mack authored
When Page-based slug handling + routing was introduced, the initial PageRouter class turned big very quickly. Especially managing the possible pages that could match was initially based on the candidates principle that could be moved / exchanged later-on. For this to happen the initial step is to move this to a separate PHP class called "PageSlugCandidateProvider". As seen in the patch, all calls to the database related to retrieving pages (DB + PageRepository) are moved into PageSlugCandidateProvider. Resolves: #88575 Releases: master Change-Id: I14b3ebccf439613cc9aa7943d1a44d0892cf04e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61050 Tested-by:
-
Oliver Hader authored
codeblock -> code-block Resolves: #88790 Releases: master, 9.5 Change-Id: I51f30b30ef7344e1b66bd5ed354d3bfe60074a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61309 Tested-by:
-
Alexander Schnitzler authored
During the creation of Extbase itself, the configuration of controllers and their available/callable actions has been called switchable controller actions. This terminology has later also been used to configure an alternative controller configuration defined via typoscript or flexforms. As of today the term "switchable controller actions" is only used for the latter. The core, however, still uses this terminology for both the default controller configuration and the overrides. To clarify the terminology, the default configuration has been renamed to just "controller configuration". Releases: master Resolves: #88496 Change-Id: I718e2fe03d3560a57b17fc584479aff559d105e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60834 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87629 Change-Id: I40d79cb6178886a6fc46edaf6c75fa900bf4ffc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59625 Tested-by:
-
Dmitry Dulepov authored
TYPO3 prevents files from being deleted by the user when there are references to it in the sys_file_reference table. However if the file is referenced without using this table, the file is still deleted without any warnings. An example is a link to the file in a bodytext of a text content element. Thus it is possible to accidentally delete a file, which is referenced on the site in multiple places and create broken links. This change makes sure that such direct references (without using sys_file_reference) also prevent the file from being deleted. Resolves: #88462 Resolves: #77866 Releases: master, 9.5, 8.7 Change-Id: Ib8c45863d75ae430c801173658cf058f850ca982 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60846 Tested-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
Since Context API was introduced in TYPO3 v9, PageRepository is highly decoupled from $TSFE->sys_page, and fully works standalone. It is also used in various places where TSFE is not needed, or required, but also in places of EXT:core. Especially parts like RootlineUtility, which depends on PageRepository very much, cannot live without it. I propose to move this highly important PHP class into EXT:core, in order to allow to decouple EXT:frontend even further from EXT:core. The FQCN is moved from - \TYPO3\CMS\Frontend\Page\PageRepository to - TYPO3\CMS\Core\Domain\Repository\PageRepository It can be assumed to use PageRepository for any use-case and actually reduce usages towards BackendUtility::get... by using this API more and more. Further adaptions could be to reduce the logic within PageRepository and move this into QueryBuilder and assimilate especially the "versionOL" behavior. Resolves: #88746 Releases: master Change-Id: Id8225100ac60bd77fc7e1303efb4c46b741d3415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166 Tested-by:
-
- Jul 16, 2019
-
-
Guido Schmechel authored
To prevent the truncation of new values via TCEForm, the field length is increased to 255. Resolves: #88722 Releases: master, 9.5 Change-Id: I982c20302be216c1819da9efc468f8a7b2be0add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61283 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benni Mack authored
HTML5 defines that <script tags do not need "type=text/javascript" as additional attribute. TYPO3 Backend is fully HTML5, so all parts can be removed there. For Frontend, when having config.doctype = html5 (or empty), then the attributes do not get added anymore as well. If necessary, for Frontend rendering the attribute can be added in HTML5 by specifying includeJS.myfile.type = text/javascript in TypoScript. As this modifies Frontend output, it is considered breaking. Also see W3C specification: https://www.w3.org/TR/html52/semantics-scripting.html#element-attrdef-script-type Resolves: #88772 Releases: master Change-Id: I26ca4361e84cae680eedbf6855e209a6311c33da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61300 Reviewed-by:
-
Benni Mack authored
The new PSR-14 standard for dispatching Events (that is: to extend a Framework without having to modify a frameworks' code) adds a EventDispatcher object that can dispatch Event objects to EventListeners. In PSR-14 every dispatched event is an object. It uses PHP class names as identifiers for events. Class hierarchies may be used to group events. A ListenerProvider object collects available listeners from an extension and allows to listen and/or modify data provided by the Event object. The current implementation relies on a custom TYPO3-specific ListenerProvider that is configured using Symfony's Dependency Injection tags. As an example the Mailer-postProcInitialization signal/slot is replaced by an Event. This first patch introduces the feature, and does not deprecate anything yet. The most important part is that new Events can use this API instead of Hooks in TYPO3 v10. Short-Term goal is to deprecate SignalSlot dispatcher in TYPO3 v10, and migrate all signals to the EventDispatcher. Resolves: #88770 Releases: master Change-Id: I3649ddb9b9340640199279e6af3c040bffc397fe Signed-off-by:
-
Daniel Windloff authored
Collapse single tables in multi table view of the DatabaseRecordList is invoked via javascript and its state is saved via AJAX. Remove the leftover code, which allows to set the collapse state via _GP('collapse'). Resolves: #88753 Releases: master Change-Id: Ibd02364c54563b76caf6e4f36ae9c8853b1d99c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61294 Tested-by: -
Benni Mack authored
ResourceCompressor allows to only concatenate files given in a given "baseDirectory" as separate option, which was used to only include files that are registered via TBE_STYLES for backend purposes. The functionality is removed to always concatenate all CSS files in TYPO3 Backend. A heavy dependency to DocumentTemplate of ALL backend functionality using PageRenderer is therefore removed. Resolves: #88758 Releases: master Change-Id: I07e2f15a3dd2298371db87ce2723ded0f6a56f31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61296 Tested-by:
-
- Jul 15, 2019
-
-
Johannes Seipelt authored
Fix the translation key typo as suggested to show the correct error message if the password does not match the confirmation Resolves: #88691 Releases: master, 9.5 Change-Id: I8524bf7faee507782d79633d3b5afd9a0077ad6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61292 Tested-by:
-
Susanne Moog authored
Resolves: #88765 Releases: master Change-Id: I26ca496a954b44f8cb08d770ecd544d35583ee6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61299 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Benni Mack authored
The following database fields from "tt_content" have been removed: * tt_content.spaceBefore (now used via space_before_class) * tt_content.spaceAfter (now used via space_after_class) Resolves: #88744 Releases: master Change-Id: I2da1645b94b68fadb2945c2f1708809e2e9cbab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61286 Tested-by:
-
