Skip to content
Snippets Groups Projects
  1. Jul 07, 2023
  2. Jul 06, 2023
  3. Nov 20, 2022
  4. Feb 20, 2022
  5. Feb 16, 2022
    • Christian Kuhn's avatar
      [!!!][FEATURE] Avoid BackendTemplateView · 25773e86
      Christian Kuhn authored
      Class BackendTemplateView has been a temporary solution
      to simplify the implementation of the "TsConfig template
      override" feature into smaller patches.
      
      With ModuleTemplate and general view works being mostly
      done in the backend, BackendTemplateView should be
      removed again.
      
      The patch removes all usages switching nearly all views
      to BackendViewFactory, which removes the explicit
      dependency to Typo3Fluid ViewInterface since the
      EXT:core ViewInterface is not directly bound to Fluid
      anymore.
      
      Using BackendViewFactory has the additional advantage
      that templates which don't use ModuleTemplate because
      they're hook usages or some other "sub-view", can now
      be overridden with TsConfig, too.
      
      Using BackendViewFactory also makes the dependency to
      ServerRequestInterface explicit. The patch thus hands
      $request around at some more places where $request was
      only an indirect dependency before.
      
      One special @todo area is FormEngine, which is unable
      to have dependency injection (for BackendViewFactory)
      due to its manual constructor arguments. The patch
      falls back to Typo3Fluid TemplateView in those cases.
      The FormEngine API should be adapted with another patch.
      
      Change-Id: Ie8959dada4dc6fd30e04d87fea6004e74cbe5990
      Resolves: #96904
      Related: #96730
      Related: #96513
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73518
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarBenjamin Franzke <bfr@qbus.de>
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarBenjamin Franzke <bfr@qbus.de>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      25773e86
  6. Jan 13, 2022
  7. Nov 25, 2021
  8. Nov 23, 2021
  9. Apr 15, 2020
  10. Apr 14, 2020
  11. Apr 13, 2020
  12. Mar 22, 2020
  13. Jan 16, 2020
  14. Feb 17, 2019
  15. Feb 16, 2019
  16. Oct 01, 2018
  17. May 13, 2018
  18. Mar 29, 2018
  19. Feb 16, 2018
  20. Dec 27, 2017
  21. Nov 30, 2017
  22. Mar 30, 2017
  23. Mar 28, 2017
    • Wouter Wolters's avatar
      [TASK] Streamline return tags in phpdocs · eb049dba
      Wouter Wolters authored
      The TYPO3 Core currently has no guidline how to handle phpdoc
      comments regarding @return annoations related to "void" and "null".
      
      In practice, these annotations have no additional value if no additional
      documentation is given.
      
      With this change, the php-cs-fixer will remove any unnecessary linebreaks
      within the comments above the @return annotation, as well as remove completely
      empty phpdoc comments because the @return annotation is removed.
      
      Please be aware, that once PSR-5 is accepted, this coding standard
      within the TYPO3 Core will change again, where there are currently
      some further proposal details like inheritance information.
      
      Resolves: #80454
      Releases: master
      Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
      Reviewed-on: https://review.typo3.org/51686
      
      
      Reviewed-by: default avatarNicole Cordes <typo3@cordes.co>
      Tested-by: default avatarNicole Cordes <typo3@cordes.co>
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      eb049dba
  24. Feb 15, 2017
  25. Nov 05, 2016
  26. Oct 29, 2016
  27. Oct 18, 2016
  28. Oct 10, 2016
  29. Aug 30, 2016
  30. Jun 10, 2016
  31. May 28, 2016
  32. May 27, 2016
  33. Nov 20, 2015
  34. Oct 21, 2015
  35. Oct 09, 2015
  36. Oct 05, 2015