- Apr 16, 2014
-
-
TYPO3 Release Team authored
Change-Id: Ib8f3b0d555fad430262e8e864dcd40b9e7fa2ee0 Reviewed-on: https://review.typo3.org/29521 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Jigal van Hemert authored
If the end of a result set is reached some drivers produce NULL. This must be changed into FALSE to be compatible with the non-DBAL version of these functions. Resolves: #57957 Releases: 6.2, 6.1 Change-Id: I664dd10735f88754c74e20ecd5c07fad5ef2b78d Reviewed-on: https://review.typo3.org/29513 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Stefan Neufeind authored
Followup to: https://review.typo3.org/28625 No use-statement for MathUtility in 6.1 yet. Change-Id: Iffa9c7cd9ab41831e34c40d7b3ada530ba73ac9c Resolves: #24925 Resolves: #24871 Releases: 6.1 Reviewed-on: https://review.typo3.org/29507 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny
-
- Apr 15, 2014
-
-
Benjamin Mack authored
It's not possible to create a backend selectbox that is mandatory with only 1 item selectable. Releases: 6.2, 6.1 Resolves: #24925 Resolves: #24871 Change-Id: Idaef6475f61c70cd8c3f6074ccd0b0195d90c581 Reviewed-on: https://review.typo3.org/28625 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
Marc Bastian Heinrichs authored
The SoftReferenceIndex parses and rebuilds typolink tags, but the support for the title attributes was missing. This leads to lost title attributes on typolinks in exports from impexp. Resolves: #56580 Releases: 6.2, 6.1, 6.0, 4.5 Change-Id: I9bf5c02b79ae4c9024322f0da99dcca37b678daa Reviewed-on: https://review.typo3.org/28169 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Marc Bastian Heinrichs authored
According to the fixes for the normal TCA fields of type "group" internal_type "file_reference" in #49538 and #56353, this needs also to be fixed for the FlexForm fields: handle the internal_type file_reference as an db reference to sys_file. Resolves: #56991 Releases: 6.2, 6.1, 6.0 Change-Id: Ie66c86c1bf3f0386d23259d0aee6706564beace3 Reviewed-on: https://review.typo3.org/28797 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Marc Bastian Heinrichs authored
If an record with a field of type "group", internal_type "file" should be indexed in the ReferenceIndex an SQL error exception gets thrown. So the relation to the file isn't represented in the refindex. Thus those files are also missing in exports created with system extension impexp. This is caused by wrong array keys and incorrectly storing a file relation as DB relation since merge of FAL. Resolves: #56353 Resolves: #56352 Releases: 6.2, 6.1, 6.0 Change-Id: I78211efcb6bf3032811ef0b0e20ed7f98f9fa8fb Reviewed-on: https://review.typo3.org/28795 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Marc Bastian Heinrichs authored
The field "link" of the table "sys_file_reference" handles links. To make the SoftReferenceIndex, which is used by impexp and linkvalidator, work right, the “softref” key "typolink" should be registered. Resolves: #57010 Releases: 6.2, 6.1, 6.0 Change-Id: I95cb8dbfa0c6d84926cd57d1fe4e4dad93e9c21a Reviewed-on: https://review.typo3.org/28800 Reviewed-by: Marc Bastian Heinrichs Tested-by: Marc Bastian Heinrichs
-
Ernesto Baschny authored
Upgrades prototype from 1.6.0.3 to 1.7.1 and scriptaculous from 1.8.2 to 1.9.0. Solves the problem with sorting IRRE elements in IE9+, for example. Resolves: #51768 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I5ea11b2e926ae0f23d1c6d85a0ff5ba24995eebb Reviewed-on: https://review.typo3.org/29471 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Apr 12, 2014
-
-
Marc Bastian Heinrichs authored
On detaching related objects the foreign_match_fields needs to be cleared. Resolves: #47694 Relates: #45337 Releases: 6.2, 6.1 Change-Id: I6d74201afc437a2b0e2a73022bc71ed0cd1dd2d4 Reviewed-on: https://review.typo3.org/29430 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Wouter Wolters authored
sql_free_result throws a fatal error when called with a boolean. According to the method description boolean is an allowed type. Check if $res is an object. Change-Id: I6f7cdbb42c07869a320510e9b0b779f2b7cf6b70 Resolves: #50378 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/29413 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Apr 07, 2014
-
-
Markus Klein authored
Add a missing isset() check whether a setting has been overridden by user TSconfig. Resolves: #57690 Releases: 6.2, 6.1 Change-Id: Id1290b2af85061051ce0cedff4a0be96a91c4dce Reviewed-on: https://review.typo3.org/29247 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Apr 05, 2014
-
-
Stefan Neufeind authored
So far the entries "Hide/Unhide" and "Visibility settings" always showed up in the ClickMenu. We need to check via excludefields if the other has any right to change such a field or hide the icons. Change-Id: Ib86fbd6d30f2cc0ec52e506d5fa2f12c95a2f178 Resolves: #55683 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/28364 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Apr 04, 2014
-
-
Oliver Hader authored
This file is a modified and updated version like it has been releases with every package in the past. Since these files have been taken from git.typo3.org/TYPO3CMS/Distributions/Base.git, which is target to be cleaned up, the file is explicitely put to old branches as well. Resolves: #57656 Releases: 6.1, 6.0, 4.7, 4.6, 4.5 Change-Id: I3b696895deaf03b2f630e12f1bd7b17b649b985c Reviewed-on: https://review.typo3.org/29168 Reviewed-by: Stefan Neufeind Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Nicole Cordes authored
The class name is submitted in a hidden form and is susceptible to XSS. The patch introduced htmlspecialchars to prevent XSS possibility. Resolves: #57603 Releases: 6.2, 6.1, 6.0, 4.7, 4.5 Change-Id: I4979e66f28a581e168c56d91327a1bbe2672448d Reviewed-on: https://review.typo3.org/29150 Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind
-
- Apr 01, 2014
-
-
Marc Bastian Heinrichs authored
EnvironmentService is a service and gets injected in different classes, thus it has to be a Singleton. Resolves: #57518 Releases: 6.2, 6.1 Change-Id: Ia8a3b8882be27c0f45569af818964036f0a9b16d Reviewed-on: https://review.typo3.org/29043 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Mar 31, 2014
-
-
Alexander Opitz authored
As TBE_EDITOR is defined as object in jsfunc.tbe_editors.js we should change the check here. Otherwise no eval user functions will be called. Resolves: #57296 Releases: 6.2, 6.1 Change-Id: Ie1b701dcbf465827bc336233c2523f4df1dde9ba Reviewed-on: https://review.typo3.org/28810 Reviewed-by: Alexander Opitz Tested-by: Alexander Opitz Reviewed-by: Nicole Cordes Tested-by: Nicole Cordes
-
- Mar 26, 2014
-
-
Markus Klein authored
BackendUtility::thumbCode() tries to retrieve the extension of a file object that might be NULL. Add a check for having a valid file object. Resolves: #54394 Releases: 6.1 Change-Id: Ia97fbb5fd3d9bd53c0d776a93969f9d059eebc4a Reviewed-on: https://review.typo3.org/26446 Reviewed-by: Oliver Klee Reviewed-by: Stefan Neufeind Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 24, 2014
-
-
Xavier Perseguers authored
Fixes: #57238 Releases: 6.2, 6.1, 6.0 Change-Id: Icca7e1637387e2ad31a1368abcd59b1bd443255f Reviewed-on: https://review.typo3.org/28706 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Mar 23, 2014
-
-
Benjamin Mack authored
When rendering the module menu icons, the menu items on the top level (Web, File, User, Admin) don't have an icon, however the getModuleIcon functionality processes them, and checks for getimagesize() even though no image is added. To overcome this, the function needs to be modified slightly to only call getimagesize if there is actually an icon. Releases: 6.2, 6.1 Resolves: #57179 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Stefan Neufeind Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers Change-Id: I1fdede253c00df9c36bb7063edf0b5bf320bb20e Reviewed-on: https://review.typo3.org/28668 Reviewed-by: Benjamin Mack Tested-by: Benjamin Mack
-
Stefan Neufeind authored
Parsetime is output either if config.debug is set or if FE-debug is activated in LocalConfiguration. Allow to explicitly override (set to 0) the debugging in TS for cases where you want to output page-objects like a JSON-page or so where Parsetime leads to problems. Change-Id: Ie5588218694219c13f136b5ac928e697ca472cfb Resolves: #57202 Releases: 6.2, 6.1 Reviewed-on: https://review.typo3.org/28667 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 19, 2014
-
-
Benjamin Rau authored
Fixing several typos and slips of the pen in the PageBrowsing ViewHelper. Without fixing all of them the page browsing ViewHelper is not functional properly, that´s why i want to submit them at once and also supply the fix for it. That are these errors: * Undefined but used class property prefixId * Overwriting instead of appending content to already defined variable * Not using UpperCamelCase for extensionName in Localization Utilty * Accidentally using wrong variables * Defining variable in for-loop which could be defined outside also * Using undefined variable freeIndexUid Resolves: #55340 Releases: 6.2, 6.1 Change-Id: I708a7af4876eba0e69fa666694315e0babcf6800 Reviewed-on: https://review.typo3.org/28539 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Xavier Perseguers authored
When a column is defined as a multivalued static enumeration: 'somecolumn' => array( 'exclude' => 0, 'label' => 'Some label', 'config' => array( 'type' => 'select', 'items' => array( array('Option 1', 1), array('Option 2', 2), array('Option 3', 3), array('Option 4', 4), ), 'size' => 4, 'maxitems' => 4, 'eval' => '' ), ), it is not possible to query the domain model using operation "contains": $value = 2; $query->matching( $query->contains('somecolumn', $value) ); Releases: 6.2, 6.1 Fixes: #56205 Change-Id: If898db7f355ad931d1c8b55febc2f59f19b0f38b Reviewed-on: https://review.typo3.org/27787 Reviewed-by: Alexander Opitz Reviewed-by: Wouter Wolters Reviewed-by: Stefan Froemken Tested-by: Stefan Froemken Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-on: https://review.typo3.org/28471 Reviewed-by: Xavier Perseguers Tested-by: Xavier Perseguers
-
- Mar 14, 2014
-
-
Christian Reiter authored
Make sure RootlineUtility::enrichWithRelationFields() respects the setting of $TCA[$table]['ctrl']['enablecolumns']['disabled'] when fetching foreign data for the rootline. Otherwise hidden relations from sys_file_reference are added to the rootline and cause exceptions in the frontend, instead of being ignored. Resolves: #56150 Releases: 6.2, 6.1 Change-Id: I21917fec1407a10818058da8ea879b0bb39441a4 Reviewed-on: https://review.typo3.org/28400 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
- Mar 13, 2014
-
-
Stanislas Rolland authored
Method doLanguageAndWorkspaceOverlay of Extbase\Persistence\Generic\Storage\Typo3DbBackend should not attempt to get a parent record if the overlays are in a separate table (most probably pages_language_overlay) by checking whether $GLOBALS['TCA'][$tableName]['ctrl']['transOrigPointerTable'] is set. Resolves: #56855 Releases: 6.0, 6.1, 6.2 Change-Id: I2cb53bc4733ee626ca0ae92e5dd91073d88ecc9d Reviewed-on: https://review.typo3.org/28362 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring
-
Patrick Broens authored
In the page module using the "Languages" view, the buttons "add a new element at this place" are wrongly aligned. This patch fixes this issue by adding a div which controls this alignment by CSS Change-Id: I9de8a47368682ed0b33c2ebfa0a590402c1ca8ef Resolves: #56720 Releases: 6.1, 6.2 Reviewed-on: https://review.typo3.org/28276 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Markus Klein authored
Add missing checks if type column exists in a row. Resolves: #56830 Releases: 6.2, 6.1 Change-Id: Ifafdb0c51266c76620696c6d94471b3efddba112 Reviewed-on: https://review.typo3.org/28350 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Frans Saris authored
Upload action was taken care of, but the ajax handler can be just for all commands that ExtendedFileUtility->processData can handle. This change checks the result set and flattens data only when needed. Resolves: #56084 Releases: 6.2, 6.1 Change-Id: Ic1a0bd9084b9eb206b9b53960890d22d2a9c56f5 Reviewed-on: https://review.typo3.org/27863 Reviewed-by: Frans Saris Tested-by: Frans Saris Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 12, 2014
-
-
Ludwig Rafelsberger authored
Each entry in the New Content Element wizard is tested to be valid, i.e. the tt_content_defValues defined by that entry must be allowed for the current BE user. Also, an entry may not select values that are removed via TSconfig. Setting TCEFORM.tt_content.[column].keepItems acts as a whitelist of allowed values for *that* column. But the validity checks are done hardcoded against the *CType* column. Resolves: #23864 Releases: 6.2, 6.1 Change-Id: I5b6578f35552bd571fc822ac72f8f5fe12fe11f7 Reviewed-on: https://review.typo3.org/28307 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 10, 2014
-
-
Benjamin Serfhos authored
The DataHandler function checkRecordInsertAccess() does now check the configuration for the root level. Resolves: #52386 Releases: 6.2, 6.1 Change-Id: I1810ea847e631ea6b242346a0271f491fd60fdf9 Reviewed-on: https://review.typo3.org/24164 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 08, 2014
-
-
Lorenz Ulrich authored
If "Stop Page Tree" is set for a page, it is possible to set temporary DB tree mounts in the element browser/link browser. If such a tree mount is set, a notice is displayed right above the tree. This notice is necessary to cancel this temporary mount. Currently the ElementBrowser misses this notice when used for e.g. header_link. Change-Id: I942aad0e54d17ceb793008850f0563bb416503be Fixes: #43885 Releases: 6.2, 6.1, 6.0 Reviewed-on: https://review.typo3.org/28181 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 07, 2014
-
-
Stanislas Rolland authored
Problem: IE raises a syntax error when it encounters html comments in the JavaScript code. The html comments are added by the page renderer. Solution: There is no need for the page renderer to wrap inline javascript as html comments. Resolves: #55457 Releases: 6.2, 6.1 Change-Id: Iae180a73778ca3bb1c9934c887315b969888b10d Reviewed-on: https://review.typo3.org/28130 Reviewed-by: Stanislas Rolland Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Plattner authored
Missing size property on group-type fields causes various problems, like missing controls (move to top and move to bottom) or misbehaving JS. Adding a default size ensures that a forgotten size property does not break everything. Additionally the size property is added to the sys_collection table, since all Core tables should be cleanly defined. Resolves: #23552 Documentation: #56627 Releases: 6.1, 6.2 Change-Id: Idafb1912f9702fddf85b7c2c222f408419e50ecf Reviewed-on: https://review.typo3.org/28129 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Mar 05, 2014
-
-
Stefan Froemken authored
After submitting an invalid form twice, extbase tries to create the related submodel instead of edit. This is because of the missing __identity part for the related submodel Resolves: #46185 Releases: 6.0, 6.1, 6.2 Change-Id: If3ec15b9eff0fc8d9a7dc682518cbfd72bb4665b Reviewed-on: https://review.typo3.org/28051 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
Alexander Opitz authored
While initializing the installer it can happen that Exceptions are thrown. As there is no ExceptionHandler initialized yet, we get a white page and the Fatal error will be logged. Mostly it is the problem that typo3conf and/or typo3temp isn't writeable. But it might something else which throws an exception. This patch catches the exception in the initializing process and shows a page in the layout of the installer. It shows the exception message, a first hint for the maybe write permissions problem and a link with the exception number. Resolves: #11771 Releases: 6.1 Change-Id: Ib99860054b727907a9a84bdfd3e35fe3f2eebe00 Reviewed-on: https://review.typo3.org/23219 Reviewed-by: Markus Klein Tested-by: Markus Klein Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Mar 03, 2014
-
-
Markus Klein authored
SearchController::compileSingleResultRow() causes double htmlspecialchars() call on $title. This patch removes the general htmlspecialchars() call since $title will be escaped in linkPage() anyway. The only place which requires escaping has the call added now. Resolves: #56262 Releases: 6.2, 6.1, 6.0 Change-Id: Ic94fe7fe7d2145fc539adcdf21faf42c33f5b32e Reviewed-on: https://review.typo3.org/27998 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
- Feb 28, 2014
-
-
Christian Weiske authored
Extbase logged a code smell with a severity of 1320177676 instead of 1 ("notice"). Change-Id: If28c2d66713bdedb3094af22f8f7a00a504d995d Resolves: #56378 Releases: 4.7, 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27953 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters
-
Christian Weiske authored
Adjust the @return documentation of authUser() to match the actual implementation in TYPO3\CMS\Core\Authentication\AbstractUserAuthentication Change-Id: I2d94cdfee6c58de80c7ec2be2b644b5fcd6c9a97 Resolves: #56421 Releases: 6.0, 6.1, 6.2 Reviewed-on: https://review.typo3.org/27943 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
The security fix introduced a bug that the title is encoded every time the link wizard is opened, leading to multiple encoded strings. Solution is to not encode it centrally but encode it just before using it in the JavaScript context. Fixes: #41413 Releases: 4.5, 4.7, 6.0, 6.1, 6.2 Change-Id: I6b08db290d5457761edc4506105672d79840764d Reviewed-on: https://review.typo3.org/27853 Reviewed-by: Markus Klein Tested-by: Markus Klein
-
- Feb 27, 2014
-
-
Markus Klein authored
This reverts commit b0c54dca. The 401 header code is used with HTTP based authentication schemes, based on RFC 2617. This is not the case here. Resolves: #55966 Reverts: #51803 Releases: 6.2, 6.1, 6.0, 4.5 Change-Id: I81e0e2bb428a9da69155fc597933bd9f023cf226 Reviewed-on: https://review.typo3.org/27898 Reviewed-by: Markus Klein Tested-by: Markus Klein
-