- Aug 23, 2021
-
-
Wouter Wolters authored
The methods are now called statically but are not statically defined. Use $this instead. Resolves: #94894 Releases: master Change-Id: I2b1d5efc21af49ce447368440cbcbe5fabc94ffe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70601 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Alexander Nitsche authored
This change introduces a new CLI command "impexp:export" which allows to export the TYPO3 page tree based on a fine-grained configuration. Both CLI commands "impexp:export" and "impexp:import" no longer offer option shortcuts to improve the clarity of the command when the user does a quick search. Resolves: #84718 Releases: master Change-Id: I00d87f94544d1abfa0d547639b67afb8a8eea112 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70393 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Alexander Nitsche authored
Running the functional EXT:impexp tests causes the EXT:impexp/Tests/Functional/Fixtures/Folders/fileadmin/user_upload folder to grow larger. This is due to export files being created that have not been cleaned up after the tests have run. In addition, completely delete the default import/export folder in ImportExport::removeDefaultImportExportFolder(). This method is currently only used in tests. Resolves: #94937 Releases: master Change-Id: I55d821ec18689172a73e0f290f1e155fae64d3cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70683 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Bartsch authored
AbstractTreeView defines the current "scriptUrl", to build links in the backend. Since this class may also be called via CLI, e.g. by EXT:impexp, missing `instanceof` checks are added to prevent a null pointer exception. Resolves: #94947 Related: #93158 Releases: master Change-Id: I795effd17d42944ae0ab32b1ab10cd632ca7c31e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70689 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
-
Oliver Bartsch authored
The workspace JavaScript component tries to fetch the workspace listing on accessing the backend module. Since #94819 this results in a JavaScript TypeError since the provided selector for the progress bar component, used as indicator for the ajax request, might not exist. This is now fixed by checking if the the workspace is actually accessible prior to initiating the ajax call. Resolves: #94946 Related: #94819 Releases: master Change-Id: I0c77564acc197a57e2999f4439daf28ba3fd333c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70724 Tested-by:
-
Oliver Bartsch authored
FormEngine allows to edit multiple records at once. This view can e.g. be accessed using the recordlists' "Edit marked" button. Since the "language switcher" only affects the first displayed record, it is now not longer rendered, when in "edit multiple" view. To improve readability of the code, all those places now use the same "speaking" method. Resolves: #94900 Releases: master Change-Id: Iae0ccd69616324fed915dbc0bb781c4edc95971b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70618 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
The multi record selection component is now also used in the recycler module. This increases consistency, as custom checkbox logic could be removed. Also the recyclers' JavaScript implementation of the selection actions is simplified. To interact with the multi record selection component, some events are used. This also means, the functionality stays the same, while most of it is now handled by the Multi record selection component. Resolves: #94926 Releases: master Change-Id: I57d91d070bfa75c01d4cb87dfd0c5576d111dcfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70678 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
Components, using the multi record selection, introduced in #94906, usually do not have to change any checkbox state manually. The multi record selection component is taking care of it. However, there might be cases when a consuming component needs to change checkbox state on its own. An example is the workspaces module, which may changes checkbox state of child records when their parent record got changed. See: #94404. To prevent the components from overriding each other, the multi record selection now respects a special data attribute `manually-changed`. If set on a checkbox element, the multi record selection component will not touch this checkbox, while executing its (mass) actions. Resolves: #94948 Releases: master Change-Id: I35b07ca45cab4b96d3eea93ff45426702a1532d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70713 Tested-by:
-
Oliver Bartsch authored
Resolves: #94942 Releases: master, 10.4 Change-Id: I59685f499f9a86e266b6b012a88e80bdef4d3c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70685 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Aug 20, 2021
-
-
Oliver Bartsch authored
The multi record selection component is now also used in the workspaces module. This increases consistency, as custom checkbox logic could be removed. Furthermore are the actions now shown above and below the listing, similar to the recycler module. Thanks to additional labels, it's now also clear what each action is for and which records are affected. Resolves: #94935 Releases: master Change-Id: I65d275f79390deaf30b9468f40b34856b7aee8d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70682 Tested-by:
-
Henrik Elsner authored
Add a missing semicolon and a comment to a code example. Resolves: #94933 Releases: master, 10.4 Change-Id: I0c028b72e111591cdd8ac33e76d7aaff18543363 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70686 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
- Aug 19, 2021
-
-
Oliver Bartsch authored
This does a few follow up changes to increase consistency and allow further use cases. * Introduce a wrapper class to prevent jumping of the multi record selection actions and to unify the space between the actions and the record listing * Introduce new event listener for the actions, allowing JavaScript modules to influence the display based on their custom logic * Allow defining the actions multiple times on the same page (e.g. above and below the records listing) * Move "Selection:" label to EXT:core, while using it in both, filelist and file selector now Resolves: #94928 Related: #94906 Releases: master Change-Id: Ia1c972e8d5005d895476ad7e7322e39b37036669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70679 Tested-by:
-
- Aug 18, 2021
-
-
11nd11 authored
The label of the select field 'allowedFileMounts' in the form wizard has been optimized. Now, the label is more readable and less technical. Resolves: #91627 Releases: master Change-Id: Iee18a47901a6d1c63184c68d5c4a888c3d4f0e15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70540 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Ralf Zimmermann authored
Adds the forgotten breaking rst for the ticket https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528/ Resolves: #94911 Releases: master Change-Id: I1a0e9c1b074b377febd655cc96a1a1033b56fc35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70652 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Nikita Hovratov authored
In case the URL is at the very end of a string and there are no space characters that follow, the preg_split has failed with a backtracking error. By declaring the last capturing group as optional, this error is fixed. Resolves: #94920 Releases: master Change-Id: Id846840d910f38612d9b9185b4ed307a62422d4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70676 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Jochen Roth authored
With #94778 the backend logo has been scaled down to fit into the topbar. This worked but also led to issues with smaller, such as the default TYPO3 logo, as those were now stretched. This is now fixed by removing the "height: auto" property. Resolves: #94914 Releases: master Change-Id: Id3321bf739d0b064b7113ff6a152a088860f44f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70672 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Aug 17, 2021
-
-
Nikita Hovratov authored
Resolves: #94909 Releases: master, 10.4, 9.5 Change-Id: I68b5f28f761e5eb096d8580e7c7291b479f144b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70641 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
A new component "MultiRecordSelection" is added. It's used first for the filelist module as well as the file selector. It simply adds a consistent way of selecting multiple elements (records) and to perform actions on this selection. Therefore, the checkboxes are always displayed at the beginning of each record row. The checkbox actions, such as "check all" are available in the header row of the same column via a dropdown menu. The actions to perform on the selection, e.g. "delete" or "import", appear once a record is selected. For the filelist module, this means those actions are decoupled from the clipboard, making it easier for editors to work with multiple records. This also introduces the "Edit marked" action to the filelist module, which allows to edit the metadata of all selected files at once. Resolves: #94906 Releases: master Change-Id: Id9e2915203049235fc4b503d33a4f1a77646c133 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70515 Tested-by:
-
Nikita Hovratov authored
In a case, where the search term is empty (by removing the search term manually for example) and a node is currently selected, the loader placeholder is now removed. This is the only case, where the method "resetFilter" is not called. Resolves: #94464 Releases: master Change-Id: Iad0deca5c9793cd0823d62c3864bc63e0fb40288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70182 Tested-by:
-
- Aug 16, 2021
-
-
Oliver Hader authored
composer req typo3/html-sanitizer:^2.0.9 composer req typo3/html-sanitizer:^2.0.9 \ -d typo3/sysext/core --no-update Resolves: #94883 Releases: master, 11.3, 10.4, 9.5 Change-Id: I997ddc423ffcb216927e3ba807e303e604174ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70614 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
As a result of TYPO3-CORE-SA-2021-013, new `htmlSanitize` behavior - when invoking `ContentObjectRenderer::parseFunc` - is enabled per default, in case it was not declared otherwise. That also happened when no processing configuration was given (or could be resolved). Without having any configuration, it was obviously not possible to disable `htmlSanitize`. Fluid's `HtmlViewHelper` can be used with an empty `parseFuncTSPath` (e.g. `<f:format.html parseFuncTSPath="">`) - due to missing (empty) configuration, sanitization was enabled per default in `parseFunc`. With this change, property `htmlSanitize` either needs to be enabled or disabled explicitly - otherwise deprecation logs will be generated, if not given, the fall-back behavior is inferred from new feature flag `security.frontend.htmlSanitizeParseFuncDefault`. Invoking `ContentObjectRenderer::parseFunc` without any configuration behaves like before TYPO3-CORE-SA-2021-013 was applied - it just does not process anything. Resolves: #94786 Releases: master, 11.3, 10.4, 9.5 Change-Id: I4aee54d712ce4758f6c9c2e64a43f80b6c076406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70404 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Oliver Hader authored
`ContentObjectRenderer` and `AbstractMenuContentObject` are still relying HTML event attribute `onclick` to open new client window instances, which were (correctly) removed by HTML sanitizer. In order to keep the functionality, exceptional declarations have been added, and `vHWin=window.open(...)` substituted by `openPic(...)`. Resolves: #94866 Releases: master, 11.3, 10.4, 9.5 Change-Id: I961746b3776d12f302933ebb775ab215bdcd85ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70551 Tested-by:
-
Krzysztof Gutkowski authored
The label_alt field in TCA is a comma separated list of database columns, so it needs to be exploded before being passed into a database query. Resolves: #83268 Releases: master, 10.4 Change-Id: I5daf07acd3ee2d409d970ac896408bec2e0abe33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70057 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- Aug 14, 2021
-
-
Andrzej Kołbuc authored
* "Make query" vanished from the interface since #94121 due to a broken type comparison on $this->queryConfig. * Date fields now properly load date pickers. Resolves: #94862 Resolves: #94884 Related: #94121 Releases: master Change-Id: I69602722bb7ee83bd616b3e6d175725bd9a70907 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70539 Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #94888 Related: #94577 Releases: master Change-Id: I6f1405b0de857b050799ff521b88e617f0307858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70589 Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Tested-by:
-
Benni Mack authored
The error handler now uses LogLevel constants in various places, except for sys_log where the severity is manually resolved. Resolves: #94783 Releases: master Change-Id: I6e7fd00510e59c0bc3c661bb21dd42453a5c835e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70285 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Torben Hansen authored
Since the introduction of `ForwardResponse` in Extbase in #92815 password rules and hash validation in the PasswordRecoveryController did not always lead to the expected forward of the request, since initialize*Actions in Extbase do not handle a potential response. This patch moves the existing validation logic to the corresponding controller actions, so `ForwardResponse` objects can be handled properly. Also, all Extbase actions now return PSR-7 responses where suitable. Resolves: #93869 Releases: master Change-Id: Ide7877d40205f86a5a4f7bfe058857d821224438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69677 Tested-by:
-
Andreas Fernandez authored
The method `FormEngineUtility::getIconHtml()` is used in various places, e.g. when rendering icons of a SelectIcons field wizard. If many icons are loaded, the rendering process may take some time, depending on the user's internet connection. To improve the initial rendering speed, the icons are now lazy loaded. Resolves: #94877 Releases: master, 10.4 Change-Id: I1ffb395124a7d9793188c7acdb039c3da698d41c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70573 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Georg Ringer authored
A new feature flag enables indexed_search to remove the documents from the index if the page or content is changed in the backend. Resolves: #94577 Releases: master Change-Id: I871978d15366c8d7ac560c82a29702678701db2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69914 Tested-by:
kharaf <k.haraf@macopedia.com> Tested-by:
-
Roman Büchler authored
This part handles: - EXT:belog - EXT:beuser Resolves: #94878 Releases: master Change-Id: I6f54188d340c6992fa798dfb67f56d8ea3315704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70576 Tested-by:
-
- Aug 13, 2021
-
-
Wouter Wolters authored
Method is marked deprecated since v10 and can be removed in v11. Resolves: #94781 Releases: master Change-Id: Ibd1211289365ddde5b29de0006f2e1116112d7e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70400 Tested-by:
-
Wouter Wolters authored
diff-format option has been removed. udiff is the default now since v3. composer u friendsofphp/php-cs-fixer composer/xdebug-handler php-cs-fixer/diff composer req --dev friendsofphp/php-cs-fixer:^3.0 Resolves: #94856 Releases: master Change-Id: I33470fc49b4355130e73326c85323a1848fe3562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70516 Tested-by:
-
Wouter Wolters authored
The following core extensions are handled: * EXT:scheduler * EXT:seo * EXT:setup * EXT:t3editor * EXT:workspaces Resolves: #94850 Releases: master Change-Id: Ia3e7138a2c4babbcf4428a9a3e5d64de81262687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70503 Tested-by:
Marcin Sągol <marcin@soee.pl> Tested-by:
-
Wouter Wolters authored
Several unused variables are found that can be removed without problems. Resolves: #94793 Releases: master Change-Id: Ibf87fc95fbfe6da1b0dc7ba9e5939d7e738fa867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70410 Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
-
Wouter Wolters authored
Test methods are not allowed to have a prefix "test". Use the annotation "@test" in phpDoc instead. Integration into pre-merge and nightly gitlab-ci suites. Note we now have multiple tests based on nikic/php-parser. Those should be rewritten to use one parser instance with multiple visitors to scan php code only once. The exception code checker should be rewritten to use the parser, too. This will be done with a dedicated patch. Resolves: #94859 Releases: master Change-Id: I43ba692eaf2a342a2e0ed3d8978386ea5719183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70524 Tested-by:
-
Jochen Roth authored
The "create new element" button in the form editor was cut off. This is fixed by calculating the height minus the doc-header height. Resolves: #94773 Releases: master Change-Id: I7dfc891138473592c76562c6802430a4311739a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70394 Tested-by:
-
Jochen Roth authored
On each keystroke the animation for validators was triggered. This is now fixed by removing the animation on an active form element. Resolves: #94775 Releases: master Change-Id: I78d454df081c035c5858f32bb0bd3a8b01679a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70395 Tested-by:
-
Oliver Hader authored
New `<f:sanitize.html build="default">` view-helper is introduced which directly invokes processing of `typo3/html-sanitize` package. An optional view-helper argument `build` allows using a defined preset, or a fully qualified class name of a builder instance as alternative, which has to implement `\TYPO3\HtmlSanitizer\Builder\BuilderInterface`. In contrast to `<f:format.html>`, this does NOT invoke `lib.parseFunc`, and does NOT rely on TypoScript configuration being loaded and parsed. Resolves: #94825 Releases: master, 11.3, 10.4, 9.5 Change-Id: Id0720120fea7d5d517a8c61d10bdbb6b03658adf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70457 Tested-by:
-
Andreas Fernandez authored
To be more consistent: * Rename "-s install" to "-s acceptanceInstall" * Rename "-s cglAll" to "-s cgl" * Rename "-s lint" to "-s lintPhp" Apart from that, the cgl checker also lints the files before checking cgl. The explicit pre-merge lint jobs are thus obsolete in pre-merge. We keep "lint everything" for nightlies to be sure. Resolves: #94769 Releases: master Change-Id: Ie7b409f3b2485a8792199e4ad2eaec8565daf253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70340 Tested-by:
-
Björn Jacob authored
Resolves: #94882 Releases: master Change-Id: I3f398731cb2bd313efae0f8f7f75032fb4220ca7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70583 Reviewed-by:
-
