- Jun 21, 2024
-
-
Jasmina Ließmann authored
The redirects overview table has been revised to improve the UX. Previously, the table fields took up as much space as their content allowed. Redirects with a long source and/or destination path stretched the table rows, which caused unwanted horizontal scrolling. The patch now fixes this and sets a maximum width for these fields. Furthermore, the "Status Code" and "Protected" fields are now also managed as separate table columns. The record icon is now placed first after the multi-record selection checkbox, as with other tables used in the system. Further actions, such as viewing the redirect and resetting the hit counter, have been moved to a separate button group. Resolves: #104166 Related: #93912 Releases: main Change-Id: I5844e1e95ea9f3b1e9a2b06ca91dce9db3cf495e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84805 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
Recent phpunit versions improved memory handling a lot, core tests no longer need to unset test case properties manually. The patch improves a couple of tests to get rid of manual unset() in tearDown() by either simply removing the calls, or by refactoring class properties away altogether, which reduces mental load when reading tests. Resolves: #104176 Releases: main Change-Id: I2717799a56c1298db2d6b5b36af4d262376b188e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84819 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. The JS component is also migrated to a proper custom element (web component). Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84749 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
-
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84545 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84489 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84785 Tested-by:Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
This change allows to explicitly set includeRecordsWithoutDefaultTranslation = 0 in TypoScript. Resolves: #93881 Releases: main, 12.4 Change-Id: Ieef59efa320f401345c0c40c2514f988bd1d6715 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84798 Tested-by:
-
Georg Ringer authored
Add the configuration example to the full demo of list properties. Resolves: #100852 Releases: main, 12.4 Change-Id: I77afff52cd51d0c527e6f4a9b569accc3e60dab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84790 Tested-by:
Stephan grass <grass@mai-multimedia.de> Tested-by:
-
Benni Mack authored
This change * simplifies allowTags and denyTags in lib.parseFunc by comparing with in_array rather than "inList()" for EVERY tag! * Remove superfluous if() statements - GeneralUtility::get_tag_attributes always returns an array - substr does not return "false" but an empty string since PHP 8.0 Resolves: #104170 Releases: main Change-Id: I1980ab3b8ea6fd4a836782475dd4c61b07f50ed3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84814 Tested-by:
-
Marcin Sągol authored
Adjust request token header name to match the value defined in RequestToken::HEADER_NAME. Fix code example. Releases: main, 12.4 Resolves: #104167 Change-Id: I8e78c0385962b8bdc085a6cc2896794930a96238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84813 Tested-by:
-
Christian Kuhn authored
A missing whitespace makes a code block being eaten away by doc rendering. Resolves: #104169 Related: #104153 Releases: main Change-Id: I0f9516c6de08c3b1625582debc3c65120ea5fe03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84815 Tested-by:
-
Georg Ringer authored
The IP anonymization task uses its own configuration and doesn't allow a fallback to the configuration defined in the settings. Therefore the misleading text is removed. Resolves: #97161 Releases: main, 12.4 Change-Id: If569c0ee75fd58ed2e069387776e9c15f7b41d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84811 Tested-by:
-
Jonathan Kieling authored
the array of translation files was not sorted by key descending. Resolves: #95212 Releases: main, 12.4 Change-Id: Ieb9d98af33cbe0d1a5ef34cb2993a247d0821031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84787 Tested-by:
-
- Jun 20, 2024
-
-
Garvin Hicking authored
The `PackageArtifactBuilder` takes care of publishing `Resources/Public/...` directories of installed TYPO3 extensions into the public directory. In case this publishing fails, now a warning message is presented, so that action can be taken. Now also an info message is shown, when an extension does not have a Resources/Public directory. This message is only shown with increased verbosity, since this can be intentionally like so. Further cleanup is preformed and code that does not apply any more since composer installers v5 is required, is removed. Last but not least, asset publishing is now decoupled into a dedicated method, that receives installed packages as input and returns resulting messages as output. Future refactoring of the publishing code into a distinct class is kept for a future change. Resolves: #103898 Releases: main, 12.4 Change-Id: I6636a024490a0cb3c5e77f6f935f63094035d489 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84383 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Weiske authored
When a scheduler task throws an exception, an error is logged. The log message does not tell us the reason for the failure: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2 Up to TYPO3 v10, this message did include more information: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2, > Code: 56, OpenSSL SSL_read: Connection reset by peer, errno 104 This behavior was changed (probably unintentional) with patch "[BUGFIX] Make logger usage PSR-3 compliant" https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Besides the task class and UID, the log message now contains the exception code, message, file and line. Example: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 6, > Code: 500, "FailTask fail message" > in /var/www/typo3/vendor/[...]/Classes/Command/FailTask.php#19 Resolves: #103799 Related: #94356 Releases: main, 12.4 Change-Id: I179f059e551966944288b6fda6f2a26a4daace3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84152 Tested-by:
-
Kevin Appelt authored
Resolves: #104097 Related: #101621 Releases: main Change-Id: Ib7265a64477dd99f4c511eb859e7e4859564c3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84700 Tested-by:
-
Christian Kuhn authored
phpunit 11.2.5 comes with further memory consumption improvements that obsolete some hacks we've had in typo3/testing-framework. Raise both. > composer u sebastian/exporter > composer req --dev phpunit/phpunit:^11.2.5 > composer u typo3/testing-framework Resolves: #104164 Releases: main, 12.4 Change-Id: Ib1c9d55833f7a950f98e2f902f8864eae289a6c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84800 Tested-by:
-
Georg Ringer authored
The CategoryCollection might be called without an existing category uid which must not lead to an exception to notices. Resolves: #99989 Releases: main, 12.4 Change-Id: I6c0bb34d9f5b460f73b8c2933994d94b54d8f01f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84624 Reviewed-by:
-
Jasmina Ließmann authored
Several minor adjustments have been made to the toolbar items to improve the UX and accessibility. This includes, among other things, the following: * Setting a correct heading hierarchy and adding some role attributes. * When a bookmark has been assigned to a group, the section with the remaining ungrouped bookmarks now displays a corresponding heading. * The form for editing bookmarks now has form labels and static input labels have been replaced. * When no documents are currently open or have been used recently, the section headings are now displayed with corresponding info texts. * Links to perform actions are now displayed in button style. Resolves: #104129 Releases: main Change-Id: I43030a078df4424f1a99c2020b347cfce498c949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84738 Tested-by:
-
Mathias Brodala authored
Releases: main, 12.4 Resolves: #103984 Change-Id: I8c105e3c3cdb37991e91015d8929d022224d8dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84510 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Andreas Kienast authored
Resolves: #104080 Releases: main Change-Id: I83b5f8dfabb32b584300066ea52a97b5917ca6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84677 Tested-by:
-
Jasmina Ließmann authored
If a user does not have access to the module or no page is selected when using the module, a corresponding info box will now be displayed. Resolves: #104148 Releases: main, 12.4 Change-Id: I3603063ce84f3db8ce5dae508df3b44f59fa94a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84778 Reviewed-by:
-
Oliver Bartsch authored
The URL path to the extensionmanager backend module is now "/module/tools/extensionmanager" to be in line with the other "admin tools" backend modules. The module identifier is also changed and a corresponding alias is added. Resolves: #104156 Releases: main Change-Id: I140496dcabc29f09b28d276a84a8a96676058898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84792 Reviewed-by:
-
Georg Ringer authored
If the permissions are already ok, better return an OK FlashMessage instead of throwing an exception. Resolves: #103728 Releases: main, 12.4 Change-Id: I280b1de894dcb78bc222ff1f585ff37627408e5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84575 Reviewed-by:
-
Georg Ringer authored
As twitter has been renamed to X, the labels in the page settings are adopted too. As the meta tags itself are still using twitter, also the database fields keep their name. Resolves: #103224 Releases: main, 12.4 Change-Id: I1cf5d5f3a0fd64ba1a3402f88b9e460c32ab4ead Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84789 Tested-by:
-
Georg Ringer authored
As the editor doesn't know anything about the name "colPos" the text is changed. Resolves: #99014 Releases: main, 12.4 Change-Id: I758f53896b3a16f8d8b9ac94c9290ac9cebf9d21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84527 Reviewed-by:
-
Georg Ringer authored
Implement what is already commented by removing all restrictions when comparing given username with all existing usernames. Even the username of a deleted or disabled user must not be reused. Resolves: #100729 Releases: main, 12.4 Change-Id: I85c314b2c4f6c8539e344e64371c631f29ab9db0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84783 Tested-by:
-
Christian Kuhn authored
The patch adds an important.rst explaining details around MySQL / MariaDB "row size too large" and options to handle it. Resolves: #104153 Related: #101553 Releases: main Change-Id: I8727982e144ddefdeea3bb9c8c06179d2b414390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84784 Reviewed-by:
-
Benni Mack authored
The URL path to the form backend module is now named "/module/manage/forms" instead of "/module/web/FormFormbuilder" which was just a leftover from the pre-routing logic in Extbase modules. Resolves: #95093 Releases: main Change-Id: I9509ed13b9e34a12ecf89e63aca8c90dfbc2365e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84788 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Jun 19, 2024
-
-
Sascha Egerer authored
The ContentObjectRenderer catches \Exception's that occur during the rendering of a content element. However, since PHP 7, there is a \TypeError exception that occurs, for example, if the given type does not match the declared type. Because \TypeError is not a subtype of \Exception, these errors are not caught in the production context, and instead of not rendering a single content element, the whole page is not rendered. Since all types of \Throwable are essentially errors that will interrupt the rendering process, the catch block must accommodate all of these, not just implementations of \Exception. Resolves: #102044 Releases: main, 12.4, 11.5 Change-Id: If6218f013caf21d7fcd2c0d0d5b6b51c3bf9963e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81573 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Mogens Fiebrandt authored
When implementing a custom ImageViewHelper to manipulate the image with the GifBuilder, after processing instructions has been applied, the processed image in the typo3temp/assets/images folder was a 1x1px sized image. This happened because the ContentObjectRenderer::getImgResource() returned null instead of an ImageResource, when the path of a processed file was passed as $file argument. It turned out, that the return of ResourceFactory::retrieveFileOrFolderObject() also can be an instance of ProcessedFile. So that the @return annotation had to be expanded by this class. The change in ContentObjectRenderer::getImgResource() now handles paths of processed files properly. Resolves: #103872 Releases: main Change-Id: Ie67b77b680a339054bcf99d522234cb1d10e2ca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84337 Tested-by:
-
Andreas Kienast authored
The method `Utility.updateQueryStringParameter()` from the module `@typo3/backend/utility.js` was introduced in TYPO3 v8 as a bugfix for highlighting in the old ExtJS-based page tree. With removal of ExtJS in TYPO3 v9, the method became unused since then. Since a safe removal of the method cannot be guaranteed as this point, it is therefore deprecated. Resolves: #104154 Related: #74180 Releases: main Change-Id: I90f0ff4c997ab31d690ff6f518f38ffb186058dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84786 Reviewed-by:
-
- Jun 18, 2024
-
-
Daniel Gohlke authored
The configuration top.TYPO3.settings.ShowItem.moduleUrl must be set so that info-window.js can use it to load the content for the modal. Resolves: #104147 Resolves: #99467 Resolves: #99695 Releases: main, 12.4, 11.5 Change-Id: I9dcf4e04e6c87a965ddfa6d2f3044cd74759a530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84779 Tested-by:
-
Philipp Kuhlmay authored
This patch provides some examples for the type=uuid in ext:styleguides 'basic' table including a generator for this type. Resolves: #104117 Related: #100171 Releases: main Change-Id: Ifbf0abe28c6730e31c922992bbeadebe587c71a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84724 Reviewed-by:
-
Jochen Roth authored
Currently, the notification/alert container does not allow scrolling when multiple notifications exceed the viewport height and it is not possible to clear all displayed notifications. This has been changed to allow scrolling within the container. On top of this, it is now also possible to focus the container using tab and scroll up and down using the arrow keys and clear all notifications with a single click. Resolves: #104069 Releases: main Change-Id: I6f4c27bff84942a3f161310da85a04957648218d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84659 Reviewed-by:
-
Oliver Bartsch authored
When using the "columnsOnly" mode to render just a subset of available fields of a record, while the subset includes a field of TCA type "slug", FormEngine needs to also render configured generator fields. Otherwise the slug fields won't work as expected, e.g. when recalculating. However, since it might be confusing for an editor to get fields rendered, which were not selected, are those fields now rendered as hidden fields. This is done by adding those fields to a hidden palette while omitting duplicates and performing sanitization. Resolves: #104115 Releases: main, 12.4 Change-Id: Ia31571bae9913028e81df910462d76dc4314644c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84721 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Long VARCHAR() fields tend to eat up quite a bit of "65k bytes maximum row size" space, especially with utf8mb4. The patch changes TCA type="input" fields longer than 255 chars from VARCHAR() to TEXT (65k bytes). This looks like a sane tradeoff between limits and storage efficiency. Extension authors who need or want to override default TCA schema details for whatever reason, can of course do so by defining something specific in ext_tables.sql. Resolves: #104146 Related: #101553 Related: #104098 Releases: main Change-Id: I4a0b38e84ac1f12c9605c48188c6f28b400c59ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84774 Reviewed-by:
Oliver Wand <wand@itaw.de> Tested-by:
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launched in the initial readyState (`loading`), that means an initial `interactive` must be understood as: `DOMContentLoaded` has already been fired as state is `interactive` We should actually avoid waiting for `complete` entirely, as document readyState `interactive` means "ready" in terms of document parsing. We're not interested in images or async scripts that are still loading and want event listeners to be registered as early as possible. With this improvement applied we can also drop the (now) unneeded `load` event-listener, as we are no longer skipping interactive state (this made the `load`-listener necessary previously). Note that the `load` workaround was previously needed for IE<=10 as those versions set `document.readyState` to `interactive` prior to the `DOMContentLoaded` event. This applied workaround becomes a race condition once `load` never happens and that is the case with a recent google chrome regression which causes iframe documents to never "complete": https://issues.chromium.org/issues/347724924 2) Drop the timeout logic. It is no longer needed now that we only need to wait for `DOMContentLoaded` – which will always fire (or already fired) – instead of the `load` event. 3) Avoid creation of new promises for every invocation of the ready-method. A promise can be reused without side effects by multiple consumers. This avoids creating a lot of event listeners (and previously timers). 4) Remove unneeded document and window references. Releases: main, 12.4, 11.5 Resolves: #104135 Related: #104139 Change-Id: I42c86961405f8a5c346c17ea429a288a85d58f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84742 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benni Mack authored
Resolves: #103212 Releases: main, 12.4 Change-Id: If285a5cb1bb418ef7671ca6894827a059e5c1cb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84741 Tested-by:
-
Christian Kuhn authored
This was a VARCHAR(255) before #104098, which considers TCA 'max' property and thus reduced it to VARCHAR(80). To avoid upgrade issues, 'max' is now increased to 255, which makes it a VARCHAR(255) again. Resolves: #104143 Related: #101553 Related: #104098 Releases: main Change-Id: I96f36ed1259473550ae4bd29b646b1d23f74b706 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84772 Reviewed-by:
-
