- Jul 05, 2023
-
-
Benni Mack authored
This change now checks for a records' sys_language_uid field before doing overlays, and is only doing overlays when the incoming record has a "sys_language_uid" -1 and was properly overlaid. Resolves: #100931 Resolves: #101229 Releases: main, 12.4 Change-Id: I73acaf02de950312d1728936a92b6603ff62eb77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79775 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Jochen Roth authored
Currently, the RTE did not validate when required=true was set. This has been changed to update the source on change which triggers validation again. Resolves: #100838 Releases: main, 12.4 Change-Id: I3bc9a9c43d23d8334f3f5694ef52f626d12c424c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79776 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Mario Lubenka authored
Until TYPO3 CMS 10.4 the ValidatorTask could be used without sending the validation report via email. The task could be used to re-crawl all links and update the reports in the module only. This behaviour is restored by sending emails only if an email address is set. Resolves: #97431 Releases: main, 12.4, 11.5 Change-Id: I63197605c272f56449f933abd08d0c05bd7a7661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79772 Tested-by:
-
Benni Mack authored
When a page translation of type=shortcut (doktype=4) contains a different value than its original page, the proper target URL is now resolved correctly upon link creation and link resolving in TSFE. This additionally fixes flaws in the behavior of first subpage in cases where the first subpage differs between languages. Resolves: #98565 Resolves: #98566 Resolves: #87815 Releases: main, 12.4 Change-Id: If44033affc1cde1f59d5ccab97d75cffd01d2ad0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79751 Tested-by:
-
Benni Mack authored
When using TSconfig like this: mod.web_list.tableDisplayOrder.pages { after = tt_content } which creates a circular dependency with the original TSconfig, the list module does not crash anymore but shows a warning instead. Resolves: #98072 Releases: main, 12.4 Change-Id: Ifcc3890fc6283a8c4f20b8b959a41bec5108893c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79750 Tested-by: -
Benni Mack authored
Resolves: #99838 Releases: main, 12.4 Change-Id: I41833544e3fe77340d1d82223eb3da0182cb1322 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79749 Tested-by:
-
jakotadesigngroup authored
Nullable time fields with value null (not set) are reset to 0 on update. This changes the value from not set to midnight. It is not so problematic for date fields as there reset value, for the time being, is null also. But this behavior is wrong anyway. Resolves: #99847 Releases: main, 12.4, 11.5 Change-Id: I080b6bb1ad00a025967d9626632ff71b8fb2193a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79748 Tested-by:
-
Benni Mack authored
Kudos to Georg Ringer for the hint. Resolves: #98600 Releases: main, 12.4, 11.5 Change-Id: I1c200b4a8835bdccc4e9dc2cf2cee423459a13c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79746 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101248 Releases: main, 12.4, 11.5 Change-Id: If7954c44729897bf807bb06dd864fdfbf7f3f7eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79744 Tested-by:
-
Andreas Fernandez authored
The Folder Browser now has a button that allows to select the currently opened browser, which is already possible in the Link Browser for pages. As a side-effect, this allows the selection of file storages again. Resolves: #100789 Releases: main, 12.4 Change-Id: Ifa30c7cc1f65a2b313f689f5c06c41734408f403 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79742 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Josef Glatz authored
This patch adds missing translation strings for the search located in: DB Check > Full search > Raw search in all fields The heading of the result section is also only shown if result markup is available to the view from now on. Resolves: #99967 Releases: main, 12.4 Change-Id: I5c5269148b98189079a6efd7246048225a8b4b67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79743 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Florian Schöppe authored
The indexed_search extension uses a truncated md5 hash for building a word index. The truncation greatly increases the probability for collisions. These collisions are the root cause for the problems that are described in the related issues. The best solution would be to either use full-length hashes or no hashes at all. As this is not possible without changing the database schema and rebuilding the whole word index, this patch prevents the exceptions caused by the hash collisions. This is done by removing all words with colliding hashes before the word index is updated. Note that this patch just makes it possible to index page contents that contain hash collisions (words with colliding hashes) again. The affected words are obviously not added to the word index and though won't yield results when searched for. Resolves: #101249 Related: #84541 Related: #90977 Related: #87138 Releases: main, 12.4, 11.5 Change-Id: I5bf7d562ee42f63a5eeb99381b252018439bfaab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79741 Reviewed-by:
-
Oliver Hader authored
The backend login refresh dialog is now passing a request-token (which is required in `AbstractUserAuthentication`), which is fetched via AJAX before actually submitting the login credentials as well via AJAX. Resolves: #101209 Releases: main, 12.4 Change-Id: I0d3d8a927b7f02791d990eefb2faf98be8aa2efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79727 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benni Mack authored
This change adds an additional guard clause check to avoid SQL errors when an invalid row is entered. Resolves: #98189 Releases: main, 12.4, 11.5 Change-Id: Iecb12b9c6ef97fb603c8b720d5e2be7433543637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79738 Reviewed-by:
-
Susanne Moog authored
With the refactoring to attributes, RowUpdaters failed to be fetched from the UpgradeWizardService, as they present upgrade wizards in the registry but are not registered via the UgradeWizard service locator. To fix this gracefully, we avoid using the service locator for row updaters, falling back to the identifier. A next step (feature) would be the introduction of a dedicated attribute and service locator for RowUpdaters. Resolves: #100539 Related: #99586 Releases: main, 12.4 Change-Id: I2be4400b51f1ecef8059c3c22cf5da01090883dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79653 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Josef Glatz authored
Streamline total amount text for backend groups and backend user listing. Also correct wording is applied, depending on the number of records displayed. Resolves: #99966 Releases: main, 12.4 Change-Id: Ie96dfc1148d4eafcc4418b7187645bf4831262f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79736 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101238 Releases: main, 12.4 Change-Id: I3ff0ea07c5b4121d3b585215b13b4834de7838b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79735 Reviewed-by:
-
Stefan Bürk authored
`ext:redirects` allowed to redirect to absolute target path. With #97159 the target field TCA type has changed and did not allowed to enter a path identifier since then. This change lets the `LinkService` resolve a path identifier not matching a file or folder as type `URL` and restore the ability to create path based redirect target links. Additionally, it's now possible again to link directly `/` again in link fields or RTE fields (#97693). The underlying solution is that "old-school" links to files (before FAL) to e.g. "fileadmin/mydownload.exe" is now actually treated as an external URL, and not as a automatically detected file anymore. Resolves: #101083 Resolves: #97693 Related: #97159 Releases: main, 12.4 Change-Id: Ib6a1503137b1c424c55aa3785f6c5d260b5a3aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79734 Tested-by:
-
Elias Häußler authored
The `PageErrorHandlerInterface` is often implemented in case a custom error handler is used in site configuration. Static code analysis may complain about missing iterable types in implementations. Thus, we now provide the iterable types to ease the implementation effort in TYPO3 projects. Resolves: #100004 Releases: main, 12.4 Change-Id: I9734ce09c091f6d0e6f68d19019e8d77d1ffc685 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79733 Tested-by:
-
Benni Mack authored
When a link href is empty or invalid, TYPO3 now does not crash anymore. Resolves: #100958 Releases: main, 12.4 Change-Id: I768d43b72a3abd55af06cd9750ac8a400bc41d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79732 Reviewed-by:
-
Florian Schöppe authored
Added tests for: - indexing contents and words - a basic search - metaphone search Resolves: #97732 Releases: main, 12.4 Change-Id: Id56e09f129de4bd13092f584e97eedc9fd326b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79691 Tested-by:
-
Susanne Moog authored
The cache identifier for file mounts only consisted of storage id and path. In rare cases (with same name file mounts with different read-only settings) this lead to rendering an arbitrary folder instead of the mount with the "higher" access rights. The read_only field is now taken into account when generating the runtime cache identifier. The file module already takes care of using the write file mount if both read-only and not read-only exist. Resolves: #99103 Releases: main, 12.4 Change-Id: If4c62b6e0dd8fd5a8e6e8581b072a4f22e27f075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79690 Tested-by:
-
Stefan Bürk authored
Creating redirects for `SysFolder`,`Spacer` and `Recycler` on slug changes does not make sense as they are not reachable in the frontend. Updating child pages if they start with the orignal slug however is a wanted behaviour following the normal page type behaviour. Resolves: #99624 Releases: main, 12.4 Change-Id: I8c93c9ceb858c0e0c0eda32ae8f6c58af652b7e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79695 Reviewed-by:
-
Thomas Hohn authored
The following classes were marked as @internal in TYPO3 11 since the feature was experimental. This should have been removed with TYPO3 12. The @internal has now been removed for: \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderInterface \TYPO3\CMS\Core\Authentication\Mfa\MfaProviderPropertyManager \TYPO3\CMS\Core\Authentication\Mfa\MfaViewType Resolves: #101237 Related: #100224 Related: #93526 Releases: main, 12.4, 11.5 Change-Id: Iad9b3337a595c2ee1b9162f4cd1463d3c45881f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79715 Tested-by:
-
Stig Nørgaard Færch authored
This makes the groupHomePath and userHomePath features available again. Releases: main, 12.4 Resolves: #101188 Change-Id: I2d3ebc283b4ed72f0e2885c203c0ad2123c9a357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79687 Tested-by:
-
Andreas Nedbal authored
Prepared nodes were not properly handled in the category element, causing the indetermination state recalculation to never trigger properly. Using the nodes from the nodes-prepared event fixes this issue. Resolves: #98689 Releases: main, 12.4, 11.5 Change-Id: I63f9618c596cdad343d4af8393120eabae3fdbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79688 Reviewed-by:
-
- Jul 04, 2023
-
-
Oliver Hader authored
VariableProcessor::addHash() is called to convert URI path variables that don't comply with certain rules to a hash, which does. First of all, variables must not exceed a certain length of 32, second of all, variables must only contain word characters aka "\w" or "[A-Za-z0-9_]". So whenever a variable is too long or contains invalid characters, it is converted to an md5 hash which complies with both rules. It has been reported that the checks, whether to generate a hash and the hashing would have a very noticable performance impact. This change introduces as specific runtime cache for VariableProcessor that is shared with any other new instance. This way, the necessity whether a hash is required and the hash representation of a value can be resolved from this cache. For instance, this would speed up scenarios that are enerating large product lists and generate, when every invocation with a new UID would have triggered a new hash check and assignment. Resolves: #100974 Releases: main, 12.4 Change-Id: I19e1d138a79792cc05a6a908f1ee5f87236a65bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79710 Tested-by:
-
Christian Eßl authored
The new save notification currently lists all changes separately, when editing records in EditDocumentController. This leads to a huge notification box, when saving many records at once. The behaviour is now changed so that if more than 10 records were edited, a more generic message is shown instead: "x records have been successfully saved." Resolves: #100223 Releases: main, 12.4 Change-Id: Ic3db6a1937de8eb288a7ded0bce3e1a88f10cb1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79686 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Oliver Bartsch authored
Maintaining the "disallowed" list in TCA for type=file previously was only respected in the DataHandler but the restriction was not displayed neither in FormEngine nor in the FileBrowser. Additionally, the file extension filter did not restrict available files to select and the list was also not used by the DragUploader. All those places are now unified. Resolves: #101231 Releases: main, 12.4 Change-Id: Iab187e8d9787469016e2110306e35ae4192f6323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79709 Reviewed-by:
-
Jochen Roth authored
This adds missing form engine inline language labels, used e.g. for the "unsaved changes" modal. Resolves: #98718 Releases: main, 12.4 Change-Id: Ifb8964bf40b8cc410cb46c36fc82c6d4572a05ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79685 Tested-by:
-
Krzysztof Gutkowski authored
Currently, when switching the 'Show fluid debug output' in AdminPanel, the relevant frontend caches weren't flushed, causing pages to be rendered using the old ViewHelper namespace configuration, so that the debug viewhelpers weren't added/removed, depending on the value. This commit makes the caches get flushed when the option is changed. Resolves: #99883 Releases: main, 12.4 Change-Id: I495d678bce2128f538b46f79485fdab67581a29f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79684 Reviewed-by:
-
Andreas Nedbal authored
The hint when changing a slug previously was a combination of utility classes and with color changes in a recent Bootstrap version, it became barely readable. Resolves: #101222 Releases: main, 12.4 Change-Id: I594c995f23c99d81b0d5e2d619e63f811c36576a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79683 Tested-by:
-
Manuel Glauser authored
Rendering image '<source>' elements using the IMAGE content object (layoutKey 'picture') no longer have the document root path prepended in the 'srcset' attribute. Resolves: #100867 Related: #95379 Releases: main, 12.4 Change-Id: Id49b0f9a41dd9760e25fc17386cae805f66083e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79682 Tested-by:
-
Tim Horstmann authored
Additionally switch $nextActive to boolean Resolves: #100995 Releases: main, 12.4 Change-Id: I0e41835f42753595480afb16182c446991157ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79681 Tested-by:
-
Stefan Bürk authored
With #89091 pages with slugs containing trailing slash have been enabled to be resolved when requested with trailing slash in the request uri and have been a logical follow-up of #86055. In between an issue with language fallback chain have been found, which allowed that a valid translated page could be resolved with the default language slug even and reported as #88715 and #96010. These issues have been solved with https://review.typo3.org/c/Packages/TYPO3.CMS/+/75101 which partly broke the original implemented behaviour for pages with trailing slash slugs requested without a trailing slash. This change now ensures pages are resolved containing a trailing slash in their "slug" like "/my-page/subpage/" if requested without the trailing slash like "https://domain.tld/my-page/subpage". Additionally, tests are added to cover this case along with other possible cases. This should detect future regressions. The docblock return annotation for `PageRouter::matchRequest()` is changed to the correct returned value, removing ignore pattern for the phpstan baseline instead of increasing the counter. Note: This change ensures that a page can be resolved in any constellation with trailing slash in record slug/not in record slug and requested with trailing slash/not requested slug. In both cases, already working and the now fixed variant are serving both potential duplicate content - if no correct cannonical url is provided. Tackling the duplicate issue should be done in a dedicated change for both cases. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100990 Related: #96010 Related: #88715 Related: #89091 Related: #86055 Releases: main, 12.4, 11.5 Change-Id: I9f26c4500e2f812e8727b4b565570fcc579bf3e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79679 Tested-by:
-
Torben Hansen authored
With #100255 it has been ensured, that the translate ViewHelper uses the site language locale. For backend context, the locale is resolved from `$GLOBALS['BE_USER']->user['lang']`. In case of the backend login or password reset form , the evaluated preferred browser language is however not set to the global `BE_USER` object, when no user is logged in. As a result, some labels in the fluid views are always rendered in the default language. This change sets the preferred browser language to the `BE_USER` object in the backend login controller and the reset password controller, when no backend user is logged in, so label translation is now consistent again. Resolves: #101166 Related: #100255 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: If3ba886c4e8be19990c45cc48c7001a128535f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79678 Reviewed-by:
-
Daniel Siepmann authored
Some checks might return a message why images can't be generated. Those checks didn't return success which prevents processing by JavaScript, leading to endless "Loading" state within UI. All responses now properly return success = true in order to be processed by JavaScript. Resolves: #100893 Releases: main, 12.4 Change-Id: I720893a0b01a26a7b77bdcb16c02295eed3ae595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79680 Tested-by:
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79675 Tested-by:
-
Georg Ringer authored
The deleted records should be sorted by the timestamp descending instead of by the uid ascending because in most cases one of the recently deleted records should be restored. In addition, a comparison is fixed as a drive-by change to have compatible types. Resolves: #100252 Releases: main, 12.4 Change-Id: I67ce8134ea498782b476381716559e92f9867059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79677 Reviewed-by:
-
Oliver Bartsch authored
Since #97330, a form engine elements label might not be represented by a <label> tag, but by using a <legend> tag. This patch now ensures that those elements are also correctly considered within form engine validation. Resolves: #101221 Related: #97330 Releases: main, 12.4 Change-Id: Iac4ef9b198bd7a7b8c75e53b83e45117be348c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79636 Reviewed-by:
-
