Resolves: #84426
Releases: master
Change-Id: I2de52b5ddaacdfb9f8e29a11009ef7db3d9e1c46
Reviewed-on: https://review.typo3.org/56297


Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

The function GeneralUtility::sysLog() is deprecated and all calls
are replaced with direct calls to according Logging API methods.

The usual configuration options of the Logging API allows to
define all sorts of destinations for log entries, including
the syslog facility as well as file targets.

Resolves: #82430
Releases: master
Change-Id: Ief3f3f14fd10a3ae90b9df4a5e4e7456c2f7619c
Reviewed-on: https://review.typo3.org/54090


Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

Direct assignments are usually 2x faster and often more readable
when pushing one value only.

Releases: master
Fixes: #80283
Change-Id: I16fc1938f74550d1a3d9f9c0cbafe85dc2ff1c5b
Reviewed-on: https://review.typo3.org/52049


Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686


Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>

As decided during T3ACME we will use the short
array syntax in master. The 7.6 branch will also be done
to make backporting easier.

Resolves: #77692
Releases: master,7.6
Change-Id: I37e9484b1012fc9161148257a842054c24d162ba
Reviewed-on: https://review.typo3.org/49651


Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>

In our efforts to achieve a better interoperability
with other PHP projects, the PHP code base of the
TYPO3 Core switches to the PHP coding guideline
standard PSR-2.

See http://www.php-fig.org/psr/psr-2/ for more
information.

Resolves: #70515
Releases: master
Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5
Reviewed-on: http://review.typo3.org/43918


Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>

Make all calls to GeneralUtility::sysLog use extkey "core"
instead of "Core".
Use constants for severity levels.
Fix wrong parameters (message instead of extension key).

Resolves: #68088
Releases: master
Change-Id: Iea44cff529b9d609f0815311e86e9549c20f83df
Reviewed-on: http://review.typo3.org/41170


Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>

Resolves: #67786
Releases: master
Change-Id: I5b8e088c8a6d33117aca9189ff1f6606b2ca7592
Reviewed-on: http://review.typo3.org/40693


Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>

This makes sure exception details thrown in Extbase scheduler tasks
can be shown by the Scheduler.

Resolves: #49071
Releases: master, 6.2
Change-Id: Ic703568715bf92523a9cbd0dcab6c5606ea278bb
Reviewed-on: http://review.typo3.org/36985


Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

At the moment in some classes you can find an empty line between the
copyright comment and the first PHPdoc bock comment. In some other
classes there is no such empty line.

This commit adds an empty line between those comments if there is no
empty line.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
( \* The TYPO3 project - inspiring people to share!\n \*/\n)(/\*\*\n \*)

Replace:
$1\n$2

Resolves: #63828
Releases: master
Change-Id: I1d921921a3f60a62c29de3300b25b5df36a43b0a
Reviewed-on: http://review.typo3.org/35390


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

This regular expression was used to replace PHPDoc style comments
with ordinary comments:

Search:
/\*\*(\n \* This file is part of the TYPO3 CMS project.)

Replace with:
/*$1

Resolves: #63328
Releases: master
Change-Id: Ic8f11dbfefee94a19657c8fe8426c81d1cb435d8
Reviewed-on: http://review.typo3.org/35103


Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>

Since PHP 5.5 is a requirement, calls with the objectManager
should use the ::class construct instead of a string argument.

Resolves: #63112
Releases: master
Change-Id: Iedbb896607adddce2b23ab67f990fa2296c0d1bb
Reviewed-on: http://review.typo3.org/34414


Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Since PHP 5.5 is a requirement, calls to GeneralUtility::makeInstance()
should use the ::class construct instead of a string argument.

Releases: master
Resolves: #61788
Change-Id: Ia2efc5a4cb7ecea80b8a1c8e5ff7b5d6fa9a07ce
Reviewed-on: http://review.typo3.org/32913


Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>

* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param

Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577


Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>

This patch replaces the copyright/license header in PHP files with a
new, simplified one. The new header does not show the year figure, nor
an author name, and refers to the LICENSE.txt file for the full
copyright information. License is: GPL2 or any later version.

This is a multi-part commit due to the huge number of changed files.
See issue #59784 for further details.

Resolves: #59784
Releases: 6.3, 6.2
Change-Id: I1eacf9bf4537776e850d091d9d50bc72f8c2b20d
Reviewed-on: https://review.typo3.org/31029
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Markus Klein
Tested-by: Markus Klein

Still some unit tests rely on TYPO3_DB, mostly through the extbase
object manager. The patch fixes most occurrences and skips two
complex tests that should be moved to functional tests later.

This should be the final patch for tests accessing TYPO3_DB.

Change-Id: I8deb0fb9c13b47c8ce4262f041744def9e6b0e79
Resolves: #56947
Related: #51436
Releases: 6.2
Reviewed-on: https://review.typo3.org/28431
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

This patch replaces most of around 1600 occurrences of
intval() and every (integer) in the whole core.
Additionally it changes GeneralUtility::intExplode to use references
and typecasting as well.
Some occurrences of strstr() together with intval() have been replaced
with strpos() as well.
And some superfluous intval calls have been removed or reduced
to a single one i.e. for protected variables or before loops.
Patch updated after Core CGL decision from 30.01.2014

Resolves: #54265
Releases: 6.2
Change-Id: Iba57ffad1f4233ffa1a9f7d3ca5bfe9d2b53f1e8
Reviewed-on: https://review.typo3.org/26740
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

"textfile" will be replaced by "text file"

Resolves: #54893
Releases: 6.2
Change-Id: Ic7ce106a016f242cc47c70539876ff9810954a9b
Reviewed-on: https://review.typo3.org/26736
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

Change-Id: Iaa92566c53301e49396fc9fb26b0b339c48d567b
Resolves: #52360
Releases: 6.2
Reviewed-on: https://review.typo3.org/24212
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

When using Command Controllers as scheduled tasks the Extbase
Scheduled Task is serialized. Some singleton properties like
'objectManager', 'commandManager' and 'taskExecutor' are serialized
leading to duplicates of this objects.

Added magic "__sleep" and "__wakeup" methods destructing and
re-constructing the above objects.

Resolves: #50723
Releases: 6.2, 6.1, 6.0
Change-Id: I0a84487a1d8885f75dd4b4eaf004bb0dc93645c2
Reviewed-on: https://review.typo3.org/23634
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

While improving the code coverage, some source code
had to be adjusted to be mockable. This unfortunetly
braught a regression into the Task class.

Releases: 6.1
Resolves: #47352
Change-Id: I7da54e882d7880c8a816a0b795fa55e53a542885
Reviewed-on: https://review.typo3.org/20115
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler

Changes "(c) 2010-2012" to "(c) 2010-2013"

Releases: 6.1
Resolves: #46840
Change-Id: I0a26a9a05cfc5697eb536016aee946ad970d82b3
Reviewed-on: https://review.typo3.org/19494
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler

Releases: 6.1
Resolves: #44638
Change-Id: Ibb522e3618b647f05a16b15fd114937ce482dcbd
Reviewed-on: https://review.typo3.org/17589
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

All files should have the same file comment with the
same copyright notice in it. Also there must not be
an author any more. Instead the Extbase Team is
mentioned as author from now on.

Releases: 6.1
Fixes: #43883
Change-Id: Ib61859a2fa853a238907df314f948da51306d7e8
Reviewed-on: https://review.typo3.org/17099
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

* whitespaces, tabs and blank line issues
* bool -> boolean
* int -> integer
* remove @scope and @entity

Fixes: #43146
Releases: 6.0
Change-Id: I0ffdde3c918920272e8b1e4d1eab199b7b3e90f3
Reviewed-on: http://review.typo3.org/16600
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind

All abstract classes should be start with an Abstract
prefix in the class name.
Adjust the abstract task class to this naming convention.

Resolves: #42803
Releases: 6.0

Change-Id: If0b62d4ff61d9aa7ce44f61a15457faeabeab2d7
Reviewed-on: http://review.typo3.org/16331
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel

Releases: 6.0
Fixes: #42469
Change-Id: I004754cb05d06d2e3b91a41bde5657bb69d0f6b4
Reviewed-on: http://review.typo3.org/16004
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler

Superfluous brackets in extbase after namespaces move

Change ("a" . "b") . "c" into "a" . "b" . "c" using the lex-pass tool.

Change-Id: I0c72e4b899db7c87b2513f8546012bbb815a7220
Resolves: #41015
Related: #40095
Releases: 6.0
Reviewed-on: http://review.typo3.org/14677
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

Fixes wrong class names in Extbase scheduler.

Change-Id: I5117f8caebfda9249499ac57c88019846c80886e
Related: #40095
Fixes: #40156
Release: 6.0
Reviewed-on: http://review.typo3.org/14058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I403aee9d244a65e51547b21dac3b1228ffd3478e

Change-Id: I916ad5a3a24864a52e945aeb66e6f997b8e6fabd

This feature allows any Extbase CommandController command to be
executed through the scheduler. Argument values are fully supported
and both action and argument names can be translated through
locallang. Task name and arguments are displayed in the Task
overview.

Change-Id: I91cf580db97da50fb34d8f9c64b453d96b21f303
Resolves: #32107