- Mar 17, 2024
-
-
Oliver Klee authored
In #88366, the caches have been renamed, e.g., from `cache_core` to `core`. Some occurrences of the old names in comments were missed at that time. This commit streamlines those occurrences to also use the new names. Resolves: #103409 Related: #88366 Releases: main, 12.4, 11.5 Change-Id: I69039160b3d3cc5da00d4f3d3e57fce755d22a63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83475 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
core-ci <typo3@b13.com>
-
- Mar 16, 2024
-
-
Oliver Bartsch authored
Resolves: #103391 Releases: main, 12.4 Change-Id: I48d55c7b66669f9836886f257aefba2171b6910e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83474 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Mar 15, 2024
-
-
Oliver Bartsch authored
Resolves: #103385 Releases: main, 12.4, 11.5 Change-Id: Ifd93dfa4049d0d3550d052fa960ae79cc5a27c34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83430 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Willi Wehmeier authored
This change makes the toggle button accessible via keyboard and sets the focus manually, so that the pagetree can be toggled via pressing space or enter on the keyboard. Resolves: #102426 Releases: main, 12.4 Change-Id: I6916cf1f19de288e961ecb0dab85c76241097d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83473 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Willi Wehmeier authored
This patch adds a label to the action-menu used by most of the core extensions. Resolves: #102548 Releases: main, 12.4 Change-Id: I57db0e4d35b439e8841d7f4281bc09b593bb9dc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83492 Tested-by:
-
Oliver Hader authored
Several tests for URI route generation are stricter and assert that either the whole URI matches, or that at least the `?cHash=` suffix is applied for the corresponding test permutations. Besides that, individual URI assertions are streamlined to use AbstractEnhancerLinkGeneratorTestCase::assertGeneratedUriEquals. Resolves: #103396 Releases: main, 12.4, 11.5 Change-Id: I65ae10fa2984021da653bac33579feb6d10a6464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83464 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Mar 14, 2024
-
-
Willi Wehmeier authored
The thumbnail images in the inline file relations have the properties alt and title set to "id=x" which is only helpful when used to show the record uid in the tooltip. For screenreader users the info in the alt attribute isn't helpful at all. That's why the alt text should be empty so the thumbnail doesn't get read out by screenreaders at all. Resolves: #103397 Releases: main, 12.4 Change-Id: I233a54705c9c81e31b8852a8454165593fa8e061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83431 Tested-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/prefer-string-starts-ends-with` [1] into account, enforcing the usage of `startsWith()` and `endWith()` over index checking in strings. [1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with Resolves: #103374 Releases: main, 12.4 Change-Id: I88640f71cbe960db2a2e2b162410ff5a79e7c55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83448 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Mar 13, 2024
-
-
Ayke Halder authored
In the backend CEs are elevated by a surrounding box-shadow. This box-shadow was clipped off on top, left and right side. Resolves: #103381 Releases: main, 12.4 Change-Id: I3052ff7ced18e509aefb2f05c6b1bde8725572b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83429 Tested-by:
-
Kevin Appelt authored
Resolves: #103392 Related: #103117 Releases: main, 12.4 Change-Id: I97f9c68b6ad1c6b3ded4c70a82dbfe20eb5a9f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83428 Tested-by:
-
Oliver Bartsch authored
This prevents the element browser from closing as soon as one file or folder was added. This restores previous behaviour, allowing the user to add multiple references without having to open the browser again and again. Resolves: #103369 Releases: main, 12.4 Change-Id: Id57ebe3ed115c0929beb06fd7dd136fe0f08e415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83458 Tested-by:
-
Willi Wehmeier authored
The "+" labelled button in the File selector modal was just labelled with the filename as the title which doesn't give any meaning to screenreader users. To show the purpose of the button to screenreader users the title has been changed to additionally describe the action. Also an aria-label with the same value has been added. This is not ideal, because some screenreaders will read out the title twice, but on the other hand other screenreaders ignore the title or the aria-label attribute. Resolves: #103292 Releases: main, 12.4 Change-Id: Ia53fd77623e3cbd3a63a48f1bd4edc457f453c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83459 Tested-by:
-
Benjamin Franzke authored
With #103197, a loading indicator was added to the context menus, which rendered a stub context-menu. The position of the context-menu needs to be recalculated once the data has been loaded (the context-menu becomes taller) in order to avoid rendering outside the visible window area. Releases: main, 12.4 Resolves: #103382 Related: #103197 Related: #103294 Change-Id: I75e3659c619d4b98c773faa4dab9bbf184471065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83454 Tested-by:
-
Michael Hitzler authored
Resolves: #102139 Releases: main, 12.4 Change-Id: I9eb3b759de4af5c322aedc96df169aa7c603add6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83427 Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/restrict-plus-operands` [1] into account, prohibiting merging of type-incompatible operands. [1] https://typescript-eslint.io/rules/restrict-plus-operands Resolves: #103378 Releases: main, 12.4 Change-Id: I267272e4f384cbcabc245cd85ea493886134b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83447 Tested-by:
-
- Mar 12, 2024
-
-
Andreas Kienast authored
The `@typescript-eslint` packages are updated for TypeScript 5.4 support. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.2.0 \ @typescript-eslint/parser@^7.2.0 \ @typescript-eslint/typescript-estree@^7.2.0 npm run build Resolves: #103370 Related: #103354 Releases: main, 12.4 Change-Id: I2c173437e1119dccb148e9eaa426cfdcdc94f682 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83426 Tested-by: -
Christoph Lehmann authored
Since #98377 it is not possible to use `f:link.page` ViewHelper in the ConfirmationFinisher template. This adds the server request to the standalone view to make it work again. Also removed wrong comment and direct usage of global request object. Resolves: #103368 Releases: main, 12.4 Change-Id: I3822cda0bb5fde9feb992696775051ec676592c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83446 Tested-by:
-
Andreas Kienast authored
With #103197, a loading indicator was added to the context menus. However, due to the nature how the context menu component registers itself, we run into conflicting event handling. We have to silent any subsequent handlers on the same event, therefore the event propagation is immediately stopped. This aligns the event propagation behavior with the modernized tree in TYPO3 v13. Resolves: #103379 Related: #103197 Releases: 12.4 Change-Id: I87ae7ac815d3271788a164258ab2208fe5e57e6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83441 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/no-array-delete` [1] into account, prohibiting element removal from an array via `delete`. The problem with `delete` is that the element to be removed is in fact replaced with an `empty` slot, effectible keeping the array's size. Using `splice()` [2] is the preferred way to remove elements from an array. [1] https://typescript-eslint.io/rules/no-array-delete/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice Resolves: #103375 Releases: main, 12.4 Change-Id: Ic742a43d44cbd8c5cc323f629cc82ad606a9858f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83443 Tested-by:
-
Oliver Hader authored
The new methods AbstractUserAuthentication::getUserName() and AbstractUserAuthentication::getUserId() can be used to resolve the corresponding values (instead of using the $user->user array). In addition, the pure system-maintainer checks have been moved into to central BackendUserAuthentication::isSystemMaintainer(). The term "pure" refers to ignoring the development context and not applying any fallbacks in case the setting is empty. Resolves: #103323 Releases: main, 12.4 Change-Id: Ia7db222dac32acc2ef13a34ded4545ba1aedefc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83440 Tested-by:
-
Georg Ringer authored
Resolves: #103362 Releases: main, 12.4 Change-Id: Ibbd242d886a9cedc3ec1ba055ec6887b6943bfa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83432 Reviewed-by:
-
Benni Mack authored
Change-Id: I1e193614b425f216d46a1f18a74172621af4fb2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83411 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
Change-Id: Ib2f4569e5ce62f5979fa9fb9a9d8188e93e83871 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83410 Tested-by:
-
Christian Weiske authored
When the processed files are saved in a different storage, calling `$this->getStorage()->getFileInfoByIdentifier()` on a ProcessedFile that uses the original file will fail. This patch proxies the calls to the original file if necessary, just as it is already done for e.g. exists() and getPublicUrl(). Resolves: #102267 Releases: main, 12.4 Change-Id: I862340e377eef306c906bf35bf171a82876fdc01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83423 Reviewed-by:
-
Ayke Halder authored
The commit messages line-length is documented as 72 characters. The commit-msg hook checks for 72 characters now. Before the hook checked for 74 characters. Resolves: #103363 Releases: main, 12.4, 11.5 Change-Id: I15138831a73e84f275e85a5cd88f0b33319f9c1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83424 Tested-by:
-
- Mar 11, 2024
-
-
Christian Kuhn authored
Resolves: #103360 Releases: main, 12.4 Change-Id: I6331f4ed9d061a06962d0e70affa43bc239a78a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83422 Reviewed-by:
-
Can Adrian Karadag authored
If a workspace is active, the URI for a record preview link did not consider to prefix additional arguments with a "&" separator. Resolves: #103346 Releases: main, 12.4 Change-Id: I255c557593fab44482769c19f8c91d7f1980e20d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83402 Tested-by:
-
Benjamin Franzke authored
Improve the CLI command `setup` to allow instance creation without enforcing admin user and password to be defined. This enables to create tiny test setups where no admin user is needed or where users are imported from fixtures. Resolves: #103358 Releases: main, 12.4 Change-Id: Idb5e309eb873ade7fee153a1e9b1398e4e99bfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83398 Tested-by:
-
Patrick Schriner authored
If a file relation's field config is missing the import now adds an error that makes identifying the broken TCA possible. Resolves: #103282 Releases: main, 12.4 Change-Id: I622b98fc256df2a994f0ff1477aebdd9b3953a4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83400 Reviewed-by:
-
Benjamin Franzke authored
The public URL resolution in lazy loaded TCA forms (e.g. inline records) is aligned to use the same path resolution mechanism as in PageRender. Releases: main, 12.4, 11.5 Resolves: #103296 Change-Id: I981af29b34393302c49dd16216f0baa580d60767 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83262 Tested-by:
-
Georg Ringer authored
Allow empty strings as valid input for the page id in the log module. Resolves: #103290 Releases: main, 12.4 Change-Id: I5b4cc0970db927ae1510124d30348059016165a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83396 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.1.1 \ @typescript-eslint/parser@^7.1.1 \ @typescript-eslint/typescript-estree@7.1.1 \ eslint@^8.57.0 \ typescript@^5.4.2 npm run build Resolves: #103354 Releases: main, 12.4 Change-Id: I1c3d53002012153541cd34f9ceae546536b4aacc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83421 Tested-by:
-
- Mar 10, 2024
-
-
Lina Wolf authored
All files ending on .rst are interpreted as documents in both the new and old rendering. This leads to warnings and errors. So all files to be included are renamend to .rst.txt as is standard. Additionally include files should not include the Includes.rst.txt as it is already included in the main file. Those includes are removed. Resolves: #103353 Releases: main, 12.4 Change-Id: I42850eddf788fabf04e8f51b88e4f053d947a63a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83418 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- Mar 09, 2024
-
-
linawolf authored
This prevents warnings during rendering and also looks better. Resolves: #103355 Releases: main, 12.4, 11.5 Change-Id: I0a677f4f1c5ee8253538dd414fe23384ad49b6e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83419 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove superfluous genindex, it is not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backports need manual changes to the guides.xml. Resolves: #103329 Releases: main, 12.4, 11.5 Change-Id: I7ed40a0f5ce1d96003e78ac8860e6dda4c12b225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83416 Reviewed-by:
-
linawolf authored
* .gitignore files contain files that are not created during rendering * .editorconfig conatains old styling, there is a main .editorconfig with the containing the correct styling Resolves: #103352 Releases: main, 12.4, 11.5 Change-Id: Ic3189d5f10b8e6f8aa8903cd0924a4a4b4fab191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83414 Reviewed-by:
-
Chris Müller authored
Resolves: #103350 Related: #103304 Releases: main, 12.4, 11.5 Change-Id: I228f946b8bca26b5c334b352ecd48edfd72c620b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83412 Tested-by:
-
- Mar 08, 2024
-
-
Benjamin Franzke authored
With #90418 the container cache has been excluded from the regular cache-flush-pipeline. Therefore flushing has been explicitly performed when writing a new cache entry (with the intent to clean up old cache entries). Issue is: Cleaning up the entire folder by deleting the folder means a concurrent request – that is creating the same DI cache as well – will fail to write the cache when the folder is (re)moved in that moment. It turns out this cache-flush is not needed at all, since the cache identifier is stable for an TYPO3 instance, therefore a pre-flight flush can be dropped. Releases: main, 12.4, 11.5 Resolves: #103294 Change-Id: I1267d794291899e2b0d551b1725bd4a3354823bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83261 Reviewed-by:
-
Garvin Hicking authored
The Symfony CLI Command `backend:user:create` already offers shortcut options like "-u XXX" instead of "--username=XXX" as an alternative. This was broken, because the ENV/interactive fallback check only performed a check on the full option name. This check is now enhanced to also consider the shortcut. Resolves: #103134 Releases: main, 12.4 Change-Id: I33713dda5f03b96b78c6fc4fb78aa289be064330 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83376 Tested-by:
-
Chris Müller authored
Moving the code snippets into separate files has the advantage that code highlighting of the IDE is used, and errors may be spotted easier. Additionally, captions are added to the code blocks. Resolves: #103318 Releases: main, 12.4 Change-Id: Ia11a6de48176f5e8f890fddc68692cde5c7e74b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83375 Tested-by:
-
