- Jul 02, 2024
-
-
Benni Mack authored
Change-Id: Idd321771d9772715595e7bbbf648fb16ead1de61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85076 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Benni Mack authored
Due to a bug in TYPO3's packaging tool, composer.json files were malformed and are now repaired. Releases: main Change-Id: Ib489171cc0c1dc80b4cf8d3454d3d84c3f44622f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85074 Tested-by:
-
Benni Mack authored
Change-Id: I8727969ce901dcedca5aa86f8c830ca38bccf541 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85072 Tested-by:
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84781 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
TcaMigration for flex form fields lived in FormEngine related TcaFlexPrepare, and has been moved to FlexFormTools with #99756. The related tests were located within UnitDeprecated since they trigger_error(, E_USER_DEPRECATED). Those have been later removed with #101115 during v13 deprecation removals. This is bad, we do need to know if this recursive implemention works. * Move remaining FormEngine TcaFlexPrepareTest from unit to functional tests for simplified maintenance. * Use DI for TcaItemsProcessorFunctions - a class used as TCA 'itemsProcFunc' for special BE cases. * Add tests of flex form TcaMigration to functional FlexFormToolsTests. This is done using a dummy error handler to have them within casual (non deprecated) tests, which should prevent accidential removal in the future. * Move TcaItemsProcessorFunctionsTest unit tests to a functional test case for simplified maintenance. Resolves: #104287 Related: #99756 Related: #101115 Releases: main Change-Id: I8cfcdb8a42f9029d909cdde31f382541e2285096 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85050 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104278 Releases: main, 12.4, 11.5 Change-Id: Ia3a4bc344b369b8697c88ed14ac06354dd988dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85040 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Reifenscheid authored
This commits adds the following hints: * module classes needs to be set to public * module classes needs to implement the ShortInfoProviderInterface * description on how to add custom page settings * description on how to add custom module settings Resolves: #104242 Releases: main, 12.4 Change-Id: Id495359e007bf09e38a80bc1097c95946f964217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84984 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Benjamin Kott authored
We are adapting the CodeMirror implementation to also respect the current `color-scheme`, instead of purly rely on `prefers-color-scheme`. Resolves: #104279 Releases: main Change-Id: Iafcde4ee2581c68378874c32050855b1b54a8dee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85039 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Andreas Kienast authored
The code example regarding `f:constant()` is wrong, as it uses `value` as argument, but it is actually `name`, which is now fixed. Resolves: #104282 Related: #103560 Releases: main Change-Id: I848b6d1773e96c2578de70f67e75eb387ea2f72e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85043 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Benjamin Kott authored
The styleguide examples were forced into adaptive light dark mode instead of respecting the current inheritance. We are now only forcing dedicated modes when the `colorschemes` option of the CodeViewHelper is set. Resolves: #104276 Releases: main Change-Id: Iea2ceb3ad429af97a10902a3e9b4a1be9df7f653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85038 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85034 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jun 30, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104263 Releases: main, 12.4, 11.5 Change-Id: I7f132b2d3f7df9ba620b26656bbfca7fd038f32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85013 Tested-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Tested-by:
-
Christian Kuhn authored
The MockEventDispatcher unit test fixture became useless with introduction of NoopEventDispatcher. The patch removes last remains: Most simply inject NoopEventDispatcher, some others create a mock of EventDispatcherInterface and use it for event manipulation when testing $subjects that act on event results. Resolves: #104273 Related: #97449 Related: #98016 Releases: main Change-Id: I0babc60cdd3c87bf9f25a931edfd3f47f642bfae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85032 Tested-by:
-
Christian Kuhn authored
FlexFormTools is a stateless service since #102229. The - also stateless - TcaMigration dependency is now injected. Get the service injected more often and adapt a few tests to deal with this. Resolves: #104268 Related: #102229 Releases: main Change-Id: I4cca73dc90ec652a4963b56c9a6ce5e2fccccf17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85026 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Kevin Appelt authored
Use #[AutowireLocator] instead. Resolves: #104262 Related: #103437 Releases: main Change-Id: Iee77653ec3a1cf8ba1513439239834561043e240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85011 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85019 Tested-by:
-
Garvin Hicking authored
In the Admin Tools > Settings > Extension Configuration module, extensions can provide a ext_config_template.txt file. Comments inside that file dictate where and in which order a configuration option is listed. The syntax is: ``` # cat=SomeCategory//0; type=boolean; label=some config bar = 0 # cat=SomeCategory//1; type=boolean; label=other config baz = 0 ``` The parsing routine however could not properly deal with "0" entries for the input element order because checking this was using an "falsy" statement instead of allowing also "0" as a string. In this case, such a zero-based config element was not displayed. This is fixed, and an example is added to the EXT:styleguide extension configuration. Note that the error would not cause problems when either: * Another category assignment of another input element took place before, thus properly initializing the sort ordering. * The key did not use "0" as a sorting index, but anything non-falsy. * The string "cat=SomeCategory//0" was replaced with "cat=SomeCategory/0" (thus having an unset sorting key). Resolves: #102760 Related: #97816 Releases: main, 12.4 Change-Id: I6954bcf8f840d9e45372fc8fa8099381ce2b8b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85022 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104264 Releases: main, 12.4, 11.5 Change-Id: I64badf36faf69bc84f622cc9e7d5c1949c928ff1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85016 Tested-by:
-
David Mellen authored
This commit allows to use environment variables in YAML keys as well. Resolves: #99889 Releases: main, 12.4 Change-Id: I1e0272aade1188a483089412156c18e291d1ffbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84891 Reviewed-by:
-
- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85004 Reviewed-by:
-
Jasmina Ließmann authored
With #103493 a new link was introduced to edit the full record that contains a broken link. In doing so, the existing link variable was renamed, which caused the link stored on the record title to no longer work. This patch now sets the correct variable for this link again. Resolves: #104261 Related: #103493 Releases: main Change-Id: Id5087c0b92539a5ff03feb212bdabdb2bb106a0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85010 Tested-by:
-
Garvin Hicking authored
When the TCA type "group" or "folder" is rendered in FormEngine, under certain circumstances the HTML structure would close add `<div>` elements without opening those first. This will lead to a record not being editable, because variables are wrongly transferred due to the browser-rendering of wrong HTML nesting levels. This behaviour is an edge case and only happens with this TCA configuration: * either `config[hideMoveIcons]` is set to `true` * or `config[hideDeleteIcon]` is set to `true` Resolves: #98436 Releases: main, 12.4, 11.5 Change-Id: Ibb28c6130051b3dae92b3285df0831e84634e210 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84897 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Torben Hansen authored
With #102762, `GeneralUtility::hmac()` has been deprecated. The change also added a method call match for the extension scanner, which however refers to the wrong RST file. This change fixes the wrong RST reference. Resolves: #104260 Related: #102762 Releases: main Change-Id: I7e0fd8a871198bc66ffa13a1adb994a2c3c4ed48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85009 Reviewed-by:
-
Stefan Bürk authored
This change adds a test to ensure that an `BIGINT AUTO_INCREMENT PRIMARY KEY` field works across all databases up to the lowest maximal value across all databases: POSTGRES INTEGER 9223372036854775807 TYPO3 SQL Parser is tested also with this test along with the Doctrine DBAL baked database migration. Resolves: #104259 Releases: main Change-Id: Ie9ecdf2a5ca5fed46db3097a59b7004fe20044e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85007 Tested-by: -
Christian Kuhn authored
A rather small change to insert all relation rows at once per handled source row. This gives the database options to optimize insert operations, reduces network overhead and number of queries. My tiny dev setup on an empty sys_refindex table with a local DB gives a performance gain of about 5% with referenceindex:update, other instances will vary, but it won't be slower. This is good especially with first v13 instance upgrade, since refindex basically needs a full rebuild on first run due to the recently introduces new fields. Resolves: #104258 Related: #103748 Releases: main Change-Id: I02bac730847631dbc446110c58a625e6d9fdc030 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85003 Reviewed-by:
-
Albrecht Koehnlein authored
Add a configuration option to customize the environment check in the Install Tool for a list of `disable_functions` which are then reported as warning instead of error. With this new configuration option, a system maintainer is able to add function names to this list. Thus, the Install Tool and monitoring systems based on the environment check will not trigger errors for these functions anymore. Since a warning will still be emitted, the fact of a "special configuration" itself will not be lost. Resolves: #91783 Releases: main Change-Id: I50332c53fceda04d003ab0b67bf0a640c5c82866 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65032 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
- Jun 28, 2024
-
-
Christian Kuhn authored
With DataHandler being DI aware, it's now rather simple to make peripheral classes DI aware. The patch uses new TcaSchemaFactory for TCA information and switches other service dependencies to DI as well. Resolves: #104257 Related: #104002 Related: #104253 Related: #104240 Releases: main Change-Id: I354769cee0925a4c5075cbabf662c123cb247668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84981 Tested-by:
-
Stefan Bürk authored
The SchemaMigratorTest currently works on a fully populated database, which makes the tests more brittle than they should be. The patch uses a preparation in testing-framework to let TF create a database, but not populate it with tables, which stabilizes the tests. > composer u typo3/testing-framework Resolves: #104256 Releases: main Change-Id: I6699d0e4e831bc72468afd453a83886133e124b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84942 Reviewed-by:
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85000 Reviewed-by:
-
Christian Kuhn authored
DataHandler is now DI aware and gets a bunch of services injected. We're not injecting any potentially possible service blindly - we're omitting stateful ones, and declare some common classes readonly along the way to make this more clear. The DataHandler unit test receives a slightly bigger update to deal with this properly. This needs a raise of TF, which had a `new DataHandler()` in one place: > composer u typo3/testing-framework Resolves: #104253 Related: #104245 Related: #104241 Related: #104240 Releases: main Change-Id: Ie1e296b9884d8299ce699ed525fdd2b69d460ebd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84993 Tested-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84997 Reviewed-by:
-
Christian Kuhn authored
filter() retrieves 'DataHandler|DatabaseRecordList $dataHandler' as argument to call $dataHandler->deleteAction on it. DatabaseRecordList and extending classes have no such method. Resolves: #104248 Related: #98479 Releases: main Change-Id: I2fd425c5503a546e6cbf8ed3dae94145e2cb85d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84994 Reviewed-by:
-
Oliver Bartsch authored
Instead of calling the PageDoktypeRegistry in the TcaFactory, the PageDoktypeRegistry does now initialize the TCA for registering the allowed record types for the default doktype on-demand. Resolves: #104234 Releases: main Change-Id: Iefe400fe24e890af8a748d0894aa3f914eec4ad5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84945 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Philipp Kuhlmay authored
This adds an example on how to use a custom icon inside the Infobox Fluid-Viewhelper. Resolves: #104123 Releases: main Change-Id: Ie1fd9f2c13fb426f7c3d3243fe29ebcc8921f046 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84929 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104247 Releases: main, 12.4, 11.5 Change-Id: I71d8f59eaba6dd22b00f8eb7400f2b49d748e430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84990 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104246 Releases: main, 12.4, 11.5 Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84987 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #104244 Releases: main Change-Id: I9619e380bc32f7966ff6804390207312f9e7da3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84986 Reviewed-by:
-
Christian Kuhn authored
PagePermissionAssembler is a DataHandler related helper that calculates the permission fields of page records. The patch removes pollution of __construct() by manual arguments: $GLOBALS['TYPO3_CONF_VARS'] is runtime static and can just be used when needed. This avoids a class property, making the class stateless. Minor further clean ups, an improved comment, and an @todo that we should consider changing the API. Resolves: #104245 Releases: main Change-Id: I85d125612af02b54627a4c9efd525d4349ce868c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84985 Reviewed-by:
-
Oliver Bartsch authored
This unifies the paths to backend modules below "system", such as "webhooks" or "scheduler". Additionally, the module identifier of the "Backend Log" module is changed to "system_log", matching the usual naming convention. A corresponding module alias is in place and usages are adjusted. Resolves: #104165 Releases: main Change-Id: Idc4f86eb03943e68c3f4c896e42524edffdc7696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84806 Tested-by:
-
