- Sep 11, 2023
-
-
Torben Hansen authored
Currently, extbase `ConfigurationManager` is directly used in ext:felogin for the password recovery functionality. With this change, `ConfigurationManagerInterface` is used instead of `ConfigurationManager`, so DI can decide which implementation of `ConfigurationManager` should be used. Resolves: #101894 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I0a09e88b3d778f3da850fbd753d5ef43cdbb9f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80953 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Aug 17, 2022
-
-
Torben Hansen authored
Since ext:felogin already uses strict type declarations for function arguments and return types, various parameter- and return-type declarations in PHPDoc comments can safely be removed. With this patch the following changes are applied: * removed superfluous @param type declarations * removed superfluous @return declarations * removed non-thrown @throws annotations * added missing function type declarations in tests Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98139 Releases: main, 11.5 Change-Id: I47749a748e808f6801928951397ed0bff8d6a115 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75439 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jul 25, 2022
-
-
Torben Hansen authored
This change adds type definitions for all class properties in ext:felogin. Resolves: #98009 Releases: main Change-Id: I0c8c504a4b669e7a3e7d2f47c87a5847db59cb07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75271 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Jul 09, 2022
-
-
Torben Hansen authored
With this change constructor property promotion is used in ext:felogin where possible. Also 2 superfluous overrides of EventDispatcherInterface have been removed, since the property is already inherited through ActionController. Resolves: #97805 Releases: main Change-Id: I48ac97fe86dc068db023e247039ab38669c868e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74974 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Sep 24, 2021
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 18, 2020
-
-
Tobi Kretschmann authored
Resolves: #90729 Resolves: #90578 Releases: master Change-Id: I9ce6b678addcc9e65e7e4e7b70e3187d91b7456a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63886 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Dec 03, 2019
-
-
Benni Mack authored
Some changes were made: - Upgrade Wizard works - Visibility on RedirectHandler is sorted out - TreeUidListProvider is removed - cObject does everything already, less dependencies - PasswordChangeEvent is actually executed now (and works!) - RedirectConfiguration now has a factory - Do not use ConnectionPool as dependency as it contains state - Most "final" and "private" were put back to "protected" (as the rest of core) - except events - Additional hmac check in Repository - Add lifetime validation of hash in changePassword action as well Resolves: #89828 Related: #84262 Releases: master Change-Id: I813a2fc86c8e4f61fd923467aa761246187af901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62516 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
- Nov 28, 2019
-
-
Jan Stockfisch authored
A new Extbase-based plugin is added to TYPO3's Extension "felogin" which can be used as a toggle with custom templates based on Fluid, instead of marker-based templates. A new feature toggle is added to the Settings module for Site Administrators to switch to the newly added felogin extbase plugin, or continuing using the pibase plugin, e.g. for upgrading purposes. Resolves: #84262 Releases: master Change-Id: I9d281912373a078e0403f52b27483dd3e04785f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61900 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
