- Jan 16, 2023
-
-
linawolf authored
Resolves: #99542 Releases: main, 11.5 Change-Id: Ifa05cc27825bc4c89dd9b08f66c03505270fd815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77388 Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
Avoid heavy mocking in tests by utilizing Functionals incl. PackageManager and Caching Framework. Resolves: #99553 Releases: main Change-Id: Ie569e87c0710a50ce09cc60f3d9a1773d39d4b4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77391 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Elias Häußler authored
When authenticating and fetching user records, appropriate methods normally pass around either the full database record or `false` in case the user does not exist or could not be authenticated. The expected types are now added to all relevant methods in authentication services. Resolves: #99544 Releases: main, 11.5 Change-Id: Ib45440a39e64b5ac5a1f1c4799e2f59cb13526bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77385 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
PageRenderer has some speciality but also code duplication from LanguageService and can be simplified this way, avoid additional parsing states. This way, LanguageService can be used more instead of handling language dependencies manually as before. Resolves: #99540 Releases: main Change-Id: I4416b349351ee629012bee8ad518c20b9efd7ed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77378 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Georg Ringer authored
The text about the time restriction inside the logging module can be removed because: - if no time filter is used, it takes place in the UI by giving the information that the search starts 1970 - if the filter is used, the information can be found inside the filter, just like for all other filter options Resolves: #99539 Releases: main Change-Id: Iccdf83f5a607b0260baa44603fef0b80c57fcec4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77382 Reviewed-by:
-
Christian Kuhn authored
The patch comes with a couple of changes for the TypoScript IncludeTree construct: * Identifiers are now unique within a tree. This is needed especially in the Backend TypoScript -> Included Template files rendering: Before, showing content of single segments did not work due to duplicate identifiers. * getIdentifier() is hardened to throw an exception if not initialized: This detail is only needed for non-cache analysis purposes and identifiers don't exist when getting trees from cache in Frontend. * To allow file includes relative to a parent file include, they now have a "path" property that is properly hand over to child includes. Relative child includes now work with include_static sys_template includes as well. * RootInclude now has an identifier as well to seed child includes which include the parent identifier in their hash. * Identifier hashes and cache identifiers are built with fast xxh3 hash in favor of sha1() and json_encode() is used in favor of serialize() when hashing structures, if possible. * Identifier hashes are created in the setter instead of calling hash() in the caller. * [end] and [global] lines are now parts of the previous condition segment and don't create one-line segments anymore. * Tests are adapted to be a bit less noisy on properties we're not interested in by using another custom comparator. Change-Id: I9c03edfcf29e2887c0ef70ce1692582524333bdf Resolves: #99537 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77369 Reviewed-by:
-
- Jan 14, 2023
-
-
Torben Hansen authored
Use strict properties in all test classes and additionally remove one superfluous class doc header. Resolves: #99543 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I441edc90f94686d505f6e9afe8cdf886a12e03d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77384 Reviewed-by:
-
- Jan 13, 2023
-
-
Stefan Bürk authored
ext:redirects provides the feature to eventually update subpage slugs and automatically create redirects for changed pages. To accomplish that, a combination of two DataHandler hooks are used along with a centralized service. The service is used before the page slug change is persistent to the database. Hook execution for subpage changes are disabled, to contain all changes in one correlation for eventually reverting. With #99188 the auto-create chain has been streamlined to prepare for further changes. However, added functional tests do not reflect the real procedure properly. Because of that it has been overlooked that the direct slug change which triggers is handled by the hook works with old record, thus creating invalid page slug updates and redirects for the children pages. This change now properly combine the update data with the current record data instead of retrieving not-yet updated data from the database. Corresponding functional tests are adopted to update the records after calling the hook implementation, which reflects real procedure order. Resolves: #99506 Related: #99188 Releases: main Change-Id: Ib2fac341483b863ee20c228dfb6c8a06ea1978f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77318 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Philipp Kitzberger authored
When pressing the save+preview button for a non-page record the local PageTS is not being ignored anymore and leads the user to the right page in the frontend. Resolves: #96667 Releases: main, 11.5 Change-Id: Ibb3e9a549ca59bfd3a71649e2970d1d534c2c0e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73193 Tested-by:
Lorenz Ulrich <lorenz.ulrich@visol.ch> Tested-by:
Rémy DANIEL <dogawaf@no-log.org> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benni Mack authored
Because FormProtectionFactory now uses proper injection, this hack is not needed anymore. Resolves: #99532 Related: #98696 Releases: main Change-Id: Id743944586511352228f6187815b70561593f1a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77374 Reviewed-by:
-
Benni Mack authored
Before TYPO3 v4.0, TYPO3 had inconsistencies in its language keys, such as "ja" (= Japan) instead of "jp" (= Japanese), which was still available. However, the mapping was only used for detecting the language from the user agent, for the backend login screen, and not used since various versions. TYPO3 since at least 6.0 only delivers the correct language keys and the "old" language keys can now safely be removed, thus they are deprecated. The getter method Locales->getIsoMapping() is marked as deprecated. Resolves: #99531 Releases: main Change-Id: Ie86237fd0ac4bad460960f31e3bd3971d021de16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77373 Tested-by:
-
Georg Ringer authored
Tool Use the correct structure to be able to modify the setting `requireApprovedLocalizations` also via the UI of the Install Tool. Resolves: #99317 Releases: main Change-Id: Ifda4e47ebcf8a7cb0aaa9509ca32271a529f36bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77363 Tested-by:
-
- Jan 12, 2023
-
-
Robert Kärner authored
The path to the calling file in CompositeExpression::add and ::addMultiple is now normalized to forward slashes to work with Windows paths. Resolves: #99509 Releases: main Change-Id: Ib00a541ee08343d9483b1474590dcd80f819723a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77321 Reviewed-by:
-
Chris Müller authored
The docblocks in the LanguageService class are used for an automatically generated API documentation in TYPO3 Explained. The formatting of some code blocks can be improved. Resolves: #99528 Related: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/2590 Releases: main Change-Id: Idfb29d45f6c452e7f2a51ef81df63378b4e0b247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77367 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Christian Kuhn authored
The "pass_content" flag for TCA type="none" is a potential security risk and should be removed. A bug in the implementation did not surface the security risk until now, but instead of fixing the bug, we deprecate this toggle entirely since the toggle had no effect for a long time anyways. Resolves: #99523 Related: #99522 Releases: main Change-Id: I911f8f69bf49a21280d661d63de5aaf508bcef2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77359 Reviewed-by:
-
Christian Kuhn authored
Brings a series of rather minor fixes. > composer u typo3/cms-styleguide Resolves: #99525 Releases: main Change-Id: I8832baccaf98d5b1c4e97a1d922b5a2b712e6a05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77365 Tested-by:
-
Christian Kuhn authored
TCA "type=none" with "pass_content=false" (styleguide elements basic none_2) or without pass_content at all (styleguide elements basic none_4) double encodes the value. Testable using styleguide with some DB value like "l<u>i</u>p", which needs to be manually put into DB since none fields do not persist data using the backend. Note pass_content=true is documented to not hsc() the value at all, which is not true since TYPO3 v7, a htmlspecialchars() is still applied. Not encoding HTML is a potential security risk, so the patch now only fixes the "pass_content=false" and "not set" scenario to no longer double encode, and another patch will remove the pass_content option in v12 entirely with a TCA migration and deprecation note stating the option did not work since 2017 anyways. Resolves: #99522 Releases: main, 11.5 Change-Id: Ic19ad991d0f17925d5f56fb34126a7cf8f6e6aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77355 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christian Kuhn authored
With more and more refactoring of the backend controllers and improving controller/view separation, usages of old BackendUtility menu rendering helper methods are shrinking. The patch refactors a last usage of BackendUtility::getFuncMenu() and deprecates the method. Resolves: #99519 Releases: main Change-Id: Ibeb8db7a5b6835200f9e80c776ac606103b11e1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77331 Reviewed-by:
-
Chris Müller authored
Related: #99044 Resolves: #99524 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/259 Releases: main Change-Id: I0f1812491ca276d5df35ac04384da95a0b4f028b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77360 Reviewed-by:
-
- Jan 11, 2023
-
-
Andreas Fernandez authored
Resolves: #99513 Releases: main Change-Id: I883007318045e2e7d0ff5e9b0cc7df3d302631cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77325 Tested-by:
-
Georg Ringer authored
Resolves: #99511 Releases: main, 11.5 Change-Id: I9657a72e68ac0fea8ee8b0d75fcaa23a3cb4ce8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77323 Reviewed-by:
-
Markus Klein authored
The unit tests are adjusted to have strict type checking. The bug is actually covered with a test already, only the assertion was wrong. Resolves: #99521 Releases: main, 11.5 Change-Id: I52a1aa1a969bcc9d32df4ab6f43726bef671fe66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77353 Reviewed-by:
-
Christian Kuhn authored
File and module name: collapSe-state-persister Resolves: #99520 Releases: main Change-Id: Iad46de986389cff01c00936e4a8e9a9e91e6fc83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77352 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #98995 Releases: main, 11.5 Change-Id: I70cd2ed6ba9efe3a4e4216a61903157f1421568f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77329 Tested-by:
-
Christian Kuhn authored
Resolves: #99073 Releases: main, 11.5 Change-Id: Ib4d69ebd3258451af19616810730ecd33c31077d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77322 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Benjamin Kott authored
This is a prepatch to handle plugins and their configuration in general. Plugin names differ between CKEditor4 and CKEditor5, and there is no automatic migration of Plugin names. To keep existing configuration working, we are providing a mapping between old and new plugin names. When removing a plugin, we also need to remove the configuration associated to this plugin before passing it to CKEditor. A reasonable default for the plugin is now provided through the migration, if no configuration is set. Resolves: #99494 Releases: main Change-Id: I14d00670cbf566be7666717ff7d254ee7c4c65b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77290 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Benjamin Kott authored
The CSS preprocessing makes it easier to provide custom content CSS for the CKEditor5. The integrator does not need to take care of prefixing or scoping the custom CSS to avoid collisions with the existing backend CSS. To achieve this we are remapping body, html and :root definitions to the individual CKEditor5 instances. We are adjusting the processing of body and html element selectors to avoid accidental replacements hyphenated strings and allow combined attribute selectors. In addition, we are now replacing multi-selectors correctly. Example for an hyphenated string (ignored): - font-family: var(--bs-body-font-family); Example for an combined attribute selector (replaced): - html[dir="rtl"] Example for an multi selector (replaced): - html[dir="rtl"], body Resolves: #99445 Releases: main Change-Id: I330859b52390d02f1aa0140e9bc6e8d3123389d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77243 Reviewed-by:
-
- Jan 10, 2023
-
-
Benjamin Kott authored
The JavaScript module import map is static and only generated and loaded in the first request to a document. All possible future modules requested in later Ajax calls need to be registered already in the first initial request. We are adding a new tag 'backend.form' that is used to identify JavaScript modules that can be used within the backend forms. This will ensure that the import maps are available for these modules even if the element is not displayed directly. A typical use case for this is an InlineRelationRecord where the CKEditor is not part of the main record but needs to be loaded for the child record. Resolves: #99490 Releases: main Change-Id: Ie30e70a37abcebb0b9381b29ec9f55730a93976a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77317 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Jan Delius <me@jandelius.eu> Tested-by:
Rico Drexler <rico.drexler@gmx.de> Reviewed-by:
-
Christian Kuhn authored
Incoming TS: lib.foo = TEXT lib.foo.value = foo lib.bar =< lib.foo lib.bar.value = bar page = PAGE page.10 = CASE page.10.key.field = cache_timeout page.10.default =< lib.foo page.10.60 =< lib.bar page.10.60 is a reference to lib.bar which sets the sub property 'value' to 'bar'. lib.bar itself is a reference to lib.foo which sets 'TEXT'. When the cache timeout of a page is set to '60', string 'bar' should be output. This stopped working in main since the reference resolving is not recursive anymore since #99060. The patch fixes this and adds a unit test to verify. Resolves: #99504 Related: #97816 Related: #99060 Releases: main Change-Id: I560807db326559077658b36a61a137fec6cdbcb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77313 Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Christian Kuhn authored
UserTs building has a hack for sys_note setting TCAdefaults.sys_note.author and TCAdefaults.sys_note.email. These two fields have been removed from table sys_note in 6.0, the options are useless and can be removed: The creating user uid is stored in field 'cruser', resolving to human readable names is done when rendering notes. Change-Id: I562678a516c7fc8284f82a1123035ce06bd7a188 Resolves: #99507 Related: #97816 Releaeses: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77319 Reviewed-by:
-
Oliver Klee authored
Resolves: #99414 Releases: main Change-Id: Ie9f4f9f0c4923cd4892c4686587eb2cc5bbe9d50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77203 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christoph Lehmann authored
StdWrap properties have been added to the `header` directive in `config.additionalHeaders`. It is now possible to sent dynamic HTTP headers with TypoScript, especially headers that contain paths to extension files. Example: config.additionalHeaders { 10 { header = link: <{path : EXT:site/Resources/Public/Fonts/icon.woff2}>; rel=preload; as=font; crossorigin header.insertData = 1 } } Resolves: #99340 Releases: main Change-Id: I38e743910b8ae9db09c5d685fc8845d9411f01ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77019 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Georg Ringer authored
Force the return value to be a string if the uri to a page is generated but the provided page is not existing or hidden and no child node is provided. Resolves: #99502 Releases: main, 11.5 Change-Id: Ia2300d107bed03d8cc26efdc13b48cb4fb3dbcc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77312 Reviewed-by:
-
Christoph Lehmann authored
Generating a page link leads to 2 sql queries. The first query is about a general lookup and frontend group access check. The second occurs through PageRouter::generateUri(). By passing a fully resolved and possibly overlayed page record (as object) to generateUri() instead of a pageId the second query can be omitted. Since generateUri() is public we need to make sure the page record is completely resolved and overlayed in order to reuse it. This is done with the new Page object. Resolves: #97492 Releases: main, 11.5 Change-Id: I307d6e5f53d6581deb494aa123f25bde0a7ff263 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74450 Reviewed-by:
-
- Jan 09, 2023
-
-
Benjamin Kott authored
In Firefox the editor loses the text selection information after opening the Link Browser. Instead of using the references, we are now passing the selection start and end positions to the link browser to restore the text selection. Resolves: #99284 Releases: main Change-Id: I2f9e985c07c20ae59a83d22d0ff6e231ed4706e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77276 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Benjamin Kott authored
Non-breaking spaces and soft hyphens are now visible in the editor to help the editor to identify them visually. Keyboard shortcuts are now working for non-breaking spaces and soft hyphens and use more common defaults: - ctrl+shift+space for non-breaking space - ctrl+shift+dash for soft hyphen Please note that MacOS use different shortcuts: - alt+shift+space for non-breaking space - alt+shift+dash for soft hyphen The SoftHyphen plugin for CKEditor is now deprecated and replaced with a new Whitespace Plugin that handles non-breaking spaces and soft hyphens. Loading the SoftHyphen will trigger a console warning. Resolves: #99454 Releases: main Change-Id: I2a1c5edfd7e95f85c060746795231fda56b56f8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77255 Tested-by:
-
Benjamin Kott authored
Most of the CSS is already available through the Backend CSS. We are removing most of the outdated special stylings from previous CKEditor versions. Resolves: #99466 Releases: main Change-Id: I4a6ab0e289d526b4fb4645256b15968c61f2de57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77259 Reviewed-by:
-
- Jan 08, 2023
-
-
Chris Müller authored
To ease the access for extension developers the migration of chart widget configuration is described in the dashboard documentation. Related: #99150 Resolves: #99483 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/268 Releases: main Change-Id: I6d94fc02de16a374e942cf765b3f1c861fd25e71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77282 Tested-by:
-
Chris Müller authored
Related: #91082 Resolves: #99487 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/22 Releases: main Change-Id: Ia6a5d1660a2bc2d615e499ccc09b441faf100d29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77286 Tested-by:
-
Chris Müller authored
Related: #97326 Resolves: #99488 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/32 Releases: main Change-Id: I2b68d3fb47cad1e8c9835714c376a09a14875b40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77287 Reviewed-by:
-
