- Aug 30, 2023
-
-
Robert Kärner authored
This patch fixes two issues when generating symlinks to the public extension resources (Public/Resources) into the _assets folder during Composer installation. First, directory symlinks can't be created the same way on Windows as on Unix platforms. The creation requires elevated rights, and the required command is named differently as well. Junctions should be used on Windows instead, because they do not need elevated privileges to be created. When installing a TYPO3 extension via Composer, its Resources/Public folder is getting symlinked to the publicly accessible _assets folder. Until now, this process only used the Unix specific functions provided by Composer. It did not create any symlinks on Windows based installations, without generating any error message. This patch adds the same checks and platform-specific functions used by Composer when symlinking packages from a local path repository. The second issue that has been addressed is the naming ...
-
- Aug 29, 2023
-
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80733 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Aug 28, 2023
-
-
Oliver Klee authored
This fixes an issue in the acceptance tests where `null` is passed to `GeneralUtility::xml2array()` (which expects a `string`). Having an early check for an empty string also avoids pointless XML parsing (which should help performance a bit). Resolves: #101757 Releases: main, 12.4, 11.5 Change-Id: Ifc4406536c273baca9acdda7a0af7a91594f57bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80680 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Klee authored
The new versions find some more possible problems, and also improve performance. > composer req --dev phpstan/phpstan:^1.10.32 > composer req --dev phpstan/phpstan-phpunit:^1.3.14 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101756 Releases: main, 12.4, 11.5 Change-Id: I23429a98b25ce340405b8b9dc384869526c6f920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80708 Tested-by:
-
- Aug 23, 2023
-
-
Andreas Fernandez authored
When a backend user is created via the Install Tool, a notification is rendered to tell the system maintainer that the action was successful. However, the original patch mixed up the title and the message, which is now fixed. Resolves: #101741 Related: #91461 Releases: main, 12.4, 11.5 Change-Id: Ie25efa0476a118cfaa99a54d3cb4fe27ca5ef8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80676 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
This patch makes use of `PathUtility::getAbsoluteWebPath()` in EXT:indexed_search's SearchController which is suitable for calculating asset paths in both, Composer and non-Composer scenarios. Resolves: #101727 Releases: main, 12.4, 11.5 Change-Id: I88f487b1fdf88b404fc51a3d5d6131dba5483cdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80674 Reviewed-by:
-
Dominic Petit authored
Allow to save a phone link with a comma or a semicolon. Resolves: #101721 Releases: main, 12.4, 11.5 Change-Id: I54e19fbfb2b1b184db4454a19728f08e70cddc4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80655 Reviewed-by:
-
Sybille Peters authored
If there is not a newline before and after the list, the list may not be formatted correctly. A newline was added before and after lists in .rst files. Additionally, some lines beginning with "- " (which would result in false positives when checking) were modified so that list checking can be performed more easily in the future. Lists can be checked for example by using the following regular expressions: find typo3/sysext/*/Documentation -name "*.rst" | while read i;do grep -B1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" grep -A1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" done https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/ \ WritingReST/CommonPitfalls/Lists.html Resolves: #101715 Releases: main, 12.4, 11.5 Change-Id: I8dca5634ae3dcd7e702197cb72b43d79a05f3f5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80652 Reviewed-by:
-
- Aug 22, 2023
-
-
Timo Gurr authored
On recent MariaDB versions >= 10.6 utf8 is an alias for utf8mb3 while until MariaDB 10.5 utf8mb3 was an alias for utf8. https://mariadb.com/kb/en/unicode/ Resolves: #101719 Releases: main, 12.4, 11.5 Change-Id: Ida8a5b89fd99f9ff196d496ddb34d55c9657daf5 Reviewed-by:
Timo Gurr <timo.gurr@gmail.com> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80616 Tested-by:
-
- Aug 18, 2023
-
-
Simon Gilli authored
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.1.3 composer req typo3/html-sanitizer:^2.1.3 composer req typo3/html-sanitizer:^2.1.3 \ -d typo3/sysext/core --no-update Resolves: #101705 Releases: main, 12.4, 11.5 Change-Id: I3e3152663b7b7804b01c8cd9b28393132efab628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80592 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 16, 2023
-
-
Andreas Fernandez authored
Google Chrome (and other browser vendors will probably follow) deprecates the unload event with Chrome 117 [1] and encourages using the Page Lifecycle API [2] instead. This patch replaces any usage of the `unload` event with the `pagehide` event that is available for all supported browsers [3]. [1] https://developer.chrome.com/en/blog/deprecating-unload/ [2] https://developer.chrome.com/blog/page-lifecycle-api/ [3] https://caniuse.com/mdn-api_window_pagehide_event Resolves: #101662 Releases: main, 12.4, 11.5 Change-Id: I675b180e855d8fb1070a84f5ba865e9250b2c0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80560 Reviewed-by:
-
- Aug 15, 2023
-
-
Thomas Hohn authored
Fix undefined array key 0 in `InlineRecordContainer` by adding a null coalescing operator and handling `$uid` properly. Resolves: #101682 Releases: 11.5 Change-Id: I510c4af4dacfd9b1fb8110bf43b192c87918450f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80548 Reviewed-by:
J�rg B�sche <typo3@joergboesche.de> Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Aug 14, 2023
-
-
Thomas Hohn authored
Fix undefined array key "pages" in FileContentParser by adding a null coalescing operator. Resolves: #101450 Releases: main, 12.4, 11.5 Change-Id: Idc3bba5d5ab5516689925fadec86e6fac5978e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80544 Tested-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80496 Tested-by:
-
- Aug 08, 2023
-
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80474 Tested-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80368 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80473 Tested-by:
-
- Aug 07, 2023
-
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80430 Tested-by:
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80429 Tested-by:
-
Thomas Hohn authored
Added a null coalescing operator when assigning value to $editUid. Resolves: #101602 Releases: 11.5 Change-Id: Ie19fa72032c57c824322a319deafc441fdb9319e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80427 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 06, 2023
-
-
Rémy DANIEL authored
Linkvalidator extension has a couple of known issues, especially with external link checking. Those issues are now documented, so integrators can acknowledge them and implement counter-measures. Resolves: #101597 Releases: main, 12.4, 11.5 Change-Id: I00dc01243426fc56c21a4bd11815c3009e3dd3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80365 Reviewed-by:
-
- Aug 05, 2023
-
-
Rémy DANIEL authored
If the svg-tree component is embedded in an iframe, and if the iframe src get changed by navigating to another url, pending AjaxRequest will be cancelled by the browser, without letting us the opportunity to properly catch the thrown error. As a workaround, we register an unload event on the iframe's window, and mute notifications to the user. Resolves: #101340 Releases: main, 12.4, 11.5 Change-Id: I8572fde4bf278481a32a459f802af69356ce28a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80414 Tested-by:
-
Gordon Brüggemann authored
Resolves: #99725 Releases: main, 12.4, 11.5 Change-Id: I4682cbe57b4908e13c219c5be4b0810c0d348bf1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80413 Tested-by:
-
- Aug 04, 2023
-
-
linawolf authored
The 5th parameter of ExtensionUtility::registerPlugin is thegroup and not `ExtensionUtility::PLUGIN_TYPE_CONTENT_ELEMENT` Fixes the name to the correct function and adds example code. Resolves: #101575 Releases: main, 12.4, 11.5 Change-Id: I05a344ee11aaa8a9b3187a11528e2e506f47756d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80355 Tested-by:
-
Anja Leichsenring authored
Releases: main, 12.4, 11.5 Resolves: #101574 Change-Id: I6617e9c31a20b84269ae708d177b4ebf81ba97d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80316 Tested-by:
-
Stefan Bürk authored
Resolves: #101552 Releases: main, 12.4, 11.5 Change-Id: If9f12fa195f119b715e163c578188d8634b68b50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80317 Tested-by:
-
Christian Spoo authored
parent::__construct() of MemcachedBackend calls setCompression() which determines compression based on state of $this->usePeclModule. This property needs to be set before parent::__construct() is called. Resolves: #99495 Releases: main, 12.4, 11.5 Change-Id: Ibc6c3a2378c5187748b4394d440232600de193e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80388 Reviewed-by:
-
Tobias Liebig authored
This test checks lowlevel things like usergroup to be changed by GeneralUtility::fixPermissions(). Various tests in this area have been disabled on Windows already. They are problematic in macOS driven docker as well since macOS heavily messes around with access rights. We give up on this now, and reduce the details test checks of GeneralUtility::fixPermissions() a bit by removing that test. Resolves: #101568 Releases: main, 12.4, 11.5 Change-Id: I36e781302285dc1966633723abdc8f15bf84ef06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80383 Tested-by:
-
- Aug 03, 2023
-
-
Simon Schaufelberger authored
While the backend already renders preview images of for example YouTube videos in the media module, it doesn't show the preview image anywhere else, for example in the page module and the Media elements within a "Text and Media" content element. This patch shows the generated preview image within the page module and the "Text and Media" content element as well. Resolves: #95454 Releases: main, 12.4, 11.5 Change-Id: I4e404cf41627d5ee9ac165ee46817a456dbecaa8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80372 Tested-by:
-
Stefan Bürk authored
Update the typo3/testing-framework to pull in a needed correction as preparation for functional tests with PHP 8.3. Used command(s): > composer require --dev \ typo3/testing-framework:^6.16.9 Resolves: #101538 Releases: main, 12.4, 11.5 Change-Id: Id26531be8c49a9b1ee9624c178342659b28d3eab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80302 Tested-by:
-
- Jul 31, 2023
-
-
Christian Kuhn authored
Creating reports.xml in acceptance tests and feeding this to gitlab has been added with issue #96628 in the hope to be useful for finding frequently failing ac tests. The gitlab UI however buries this, it's de facto impossible to make use of this information. We drop this definition again. Resolves: #101514 Related: #96628 Releases: main, 12.4, 11.5 Change-Id: I91f13f402f0b9f72f2ca41252db93bb1714efcd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80288 Tested-by:
-
Christian Kuhn authored
When select fields with db relations allow pages records, the DatabaseBrowser tries to render an icon from the page row. uid of that row may be an int, which needs to be cast to string to be fed to htmlspecialchars(). Resolves: #101513 Related: #100819 Releases: main, 12.4, 11.5 Change-Id: I52ee031cb0eb09f41ae8ecb6d7005f03e65de3bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80285 Tested-by:
-
Oliver Klee authored
This method promises to return an int, but actually returns a float. Also add a regression test. > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101499 Releases: main, 12.4, 11.5 Change-Id: I85ca63c9b32717641d5926b16ee25e32eeb69310 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80273 Tested-by:
-
Nikita Hovratov authored
The labels of inline FileReference fields were not concatenated but overwritten, in a loop since #92427. This patch corrects the concatenation and adds line-break divs, otherwise the strings are on a single line. Resolves: #99873 Related: #92427 Releases: main, 12.4, 11.5 Change-Id: I368cd0d2cbf7e9ed7fdd1d003f869cc894d6f13e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80265 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jul 30, 2023
-
-
Christian Kuhn authored
Add some waitFor() to the drag&drop tests and give the filter test a generic wait which hopefully stabelizes this one a bit as well. Resolves: #101494 Releases: main, 12.4, 11.5 Change-Id: I73d4d2415f4e100bed7f1d7e5ead1036d157af93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80258 Reviewed-by:
-
Christian Kuhn authored
Similar to #101491, the other Application/Frontend acceptance tests get same treatment to wait for the "View webpage" icon being visible, before trying to click it. Resolves: #101492 Related: #101491 Releases: main, 12.4, 11.5 Change-Id: Ie8dd5338a6773baf8850fec0713dcd917699fbfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80254 Tested-by:
-
Christian Kuhn authored
Fails locally occasionally. The additional explicit waitForElement() before clicking the elemnt stabilized it. Resolves: #101491 Releases: main, 12.4, 11.5 Change-Id: I4072daa0e949d3480f399e99a2f35d8ef889eded Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80251 Tested-by:
-
Torben Hansen authored
Add several type casts to avoid notices. Resolves: #101486 Releases: main, 12.4, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I87f02e129d91ae9902ad74f306f11915d12037b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80246 Tested-by:
-
Christian Kuhn authored
This one was still flaky. Properly waiting for the element should finally fix this, this patch now had a huge number of successful runs locally, while it failed repeatedly without. Resolves: #101487 Related: #101440 Releases: main, 12.4, 11.5 Change-Id: I2cf4b3e878caf430ead27340694a169f98e710e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80243 Tested-by:
-
- Jul 29, 2023
-
-
Benjamin Franzke authored
Resolves: #101480 Related: #101453 Releases: main, 12.4, 11.5 Change-Id: I62e7166a6ceceb6e8c6c0d0aa5393def72c75346 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80239 Tested-by:
-
