- Oct 19, 2020
-
-
Daniel Goerz authored
BackendUtility::wrapClickMenuOnIcon() has a boolean flag to let the method return an array with tag parameters instead of a fully build HTML tag as string. As this are two completely different things and cause problems when analysing return types it should not be done in the same method. Calling BackendUtility::wrapClickMenuOnIcon() with the 7th and last argument $returnTagParameters set to true has been deprecated alongside the 5th and 6th arguments that are already unused. Resolves: #92583 Releases: master Change-Id: Ia536aa3a52085e4ebe7956997b505047340102e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66161 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
In previous TYPO3 versions (due to historic reasons) the frontend groups were always resolved within TSFE when a page and the rootline was resolved. However, this left the actual Frontend User, which is initialized at the very beginning of a frontend request, in an incomplete state: A user was (correctly) found and "logged in", but the groups were resolved at a later point. This was due to the fact that the Admin Panel allowed to "include hidden records" which also considered fe_groups, and thus be set later-on. This change now moved the resolving of the groups (and setting the right frontend.user aspect) right after the user resolving. This means that the groups are now available much earlier, and not bound to the TSFE instance anymore, allowing to use Middlewares much more professionally without depending on TSFE for custom Routing / APIs. Future options: It would even be possible to filter out PageRouter pages that are not available, which would make the Router itself faster. Resolves: #92562 Releases: master Change-Id: Ia522697433049b0e549f3c65caf6757053ff37e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66066 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Tymoteusz Motylewski authored
FrontendUserRepository::fetchUserInformationByEmail now returns empty array when there is no user with given email. Resolves: #92601 Releases: master, 10.4, 9.5 Change-Id: Iad1d862de9e7c59879b4cfebdf15bc0d8e7fde55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66174 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
In the past, the API methods: * PageRepository->versionOL() * BackendUtility::workspaceOL() returned the PID of the moved record in a workspace in the field _ORIG_PID and the live record value in "pid". The methods "fixVersioningPid()" were used to return the moved PID (of the versioned records) and set the "_ORIG_PID" to the value of the live record. This inconsistency can be overcome by simply using workspaceOL returning the newly moved location as "pid" and keep the "_ORIG_pid" of the live record for later purposes. This way, fixVersioningPid is not needed anymore, if workspaceOL/versionOL is applied. TYPO3 Core is not using the fixVersioningPid methods anymore now and they are marked as deprecated. As this is a breaking change ("behavior of overlay and value of _ORIG_pid") an RST explains the new behavior. Resolves: #92598 Releases: master Change-Id: I618d282d490b386e1a75caae3ab657f1605e3cb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66169 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Mohsin Khan authored
Add the possibility to provide custom Error messages to the RegularExpressionValidator. In some cases the default message will not suffice in supporting the user to fill in a valid value. It is now possible to equip a validator with static or translatable messages, like e.g. "Invalid Mobile Phone Number Format". Resolves: #91719 Releases: master Change-Id: Ib423202feb6aa043cb3d48b3c805db3044ffc416 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64940 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
This drops all left over calls that suppress the refindex integrity checks in DataHandler functional tests, except those within ManyToMany tests: This area needs more work before the reference index can be fixed. Two bugs indirectly related to the reference index are fixed along the way, those can't be separated as standalone patches: * When a translated page is deleted in workspaces, the DataHandler deleted live records on this page, too. This is fixed by adding a proper db restriction. This also fixes the reference index state in this scenario. * When publishing a delete placeholder that has inline children, workspace delete placeholders are created for the children, which is wrong. This happens because the user is not set to the live workspace during the publish operation. Temporarily changing the user workspace to live not only fixes the reference index, but does not create the bogus inline children placeholder records anymore, too. Change-Id: I897f6a93b1d5a579bfa5c52e93e65119a018e4aa Resolves: #92589 Related: #92467 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66152 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
David Steeb <david.steeb@b13.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Currently, Extension Manager allows to upload files in t3x format, via the GUI, which was actively disabled by extensions.typo3.org a few years ago. The Core does not handle t3x files by users anymore, and currently only handles t3x files within the TerRemote class now. Resolves: #92590 Releases: master Change-Id: I2976487f2b6c96b4a9bf1e1a64dfe1265314fa65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66171 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92581 Change-Id: I2c8bdca108c75e0d8eb862fec66630e9dca1a1ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66160 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Resolves: #92597 Related: #90234 Releases: master, 10.4 Change-Id: I2b98f6ad8cc707231b5f8981954cb963db903864 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66173 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The 'Make textareas resizable' setting is quite ancient. The patch drops this option from the user settings and enables 'growing' text areas by default. To prevent text areas from growing indefinitely, the user setting 'max height' with a default of 500px is kept. Change-Id: I0497c6823b96b077c05d25a2e63ae58c079400b7 Resolves: #92582 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66162 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Since the move placeholder code is gone, some variables / methods are still "cryptic" and some comments are outdated. This change modifies some places to make the code more readable for its current state. In addition, the RootlineUtility code is now more focussed and explained on the move pointer retrieval. Resolves: #92592 Releases: master Change-Id: I651bcad138cffc9fc0bdfe2d21a9a7666b93e4ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66172 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
The "cMR" flag is removed, which indicated some functionality called "condensed mode" which existed in TYPO3 v3+v4, and was removed some time in TYPO3 v4.x development. The flag serves no purpose for over a decade now and is removed. Resolves: #92591 Releases: master Change-Id: Ib9a26293009d32a8d8ac67fded589a828483606e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66153 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Oct 18, 2020
-
-
Benni Mack authored
When using workspaces, the computed field "_ORIG_pid" is the same value as "pid" when using the workspace-related methods * PageRepository->versionOL() * PageRepository->fixVersioningPid() * BackendUtility::workspaceOL() * BackendUtility::fixVersioningPid() The field "_ORIG_uid" which keeps the UID of the versioned/workspace record, is still set. Resolves: #92571 Releases: master Change-Id: I53fc4a00915d070f2f45495b51269ebf21d27637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66138 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Daniel Siepmann authored
Saving the integritycheck scheduler task a second time without providing a site identifier will lead to an empty string being stored. As the underlying code cant handle an empty string as identifier, this patch streamlines the input handling and assures that null is provided instead which means "all sites". Resolves: #92428 Releases: master, 10.4 Change-Id: I91e17ca73c9f0c5e76a74ab77883f340da22ea8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65920 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Gerdes <markus@madaxel.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Markus Gerdes <markus@madaxel.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- Oct 17, 2020
-
-
Sybille Peters authored
Remove whitespaces from example because they make the example confusing. When cropping, whitespace is not trimmed away. Add some minor explanations. Resolves: #92505 Releases: master, 10.4 Change-Id: Ie29167c49b45648ee328ee2b52fd105acf217885 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66155 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
- Oct 16, 2020
-
-
Andreas Fernandez authored
This patch replaces the bootstrap-datetimepicker with flatpickr which is pretty lightweight. Since this datetimepicker also has some sanity validation on board, much custom datetime parsing in FormEngine can and has been removed, including magic date manipulation by using addition or subtraction. The year format for momentjs has been changed from `YYYY` to `Y` as well to support years < 1000. Currently the datepicker is not able to select a date < 100. By manual selection, the picker jumps back to 1999 and not to 99 as expected. Resolves: #91606 Releases: master Change-Id: Id723c5200c797019f6de0ed5a4c15b2137a32995 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64833 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Xavier Perseguers authored
When a UserAspect is constructed without any associated AbstractUserAuthentication user (first constructor argument is null) as created during Application bootstrap within \TYPO3\CMS\Frontend\Http\Application::initializeContext(), the alternative list of group uids needs to be made accessible. This implies that method getGroupIds() should only check for a BackendUserAuthentication for a special handling and not do the erroneous check that it could alternatively be a FrontendUserAuthentication. Resolves: #92489 Releases: master, 10.4 Change-Id: I0342c86939fdcf03239c20fe95ae020d3d7bfc6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66053 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Christian Kuhn authored
With #92467 'live' DataHandler tests have been extended to verify the reference index is clean after operations. The patch enables this check for most of the workspace related functional tests. This proofs most scenarios are ok when it comes to workspaces and reference index. Some workspace functionals disable this integrity check by setting $this->assertCleanReferenceIndex = false; since reference index is still buggy in some cases. Most cases are related to broken mm relation handling and in scenarios where a live page is deleted and a workspace version exists. Those cases will be fixed with further patches. Change-Id: I543715c6b8c6b9feb182248b30b05a49f62b43e1 Resolves: #92572 Related: #92467 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66149 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Oct 15, 2020
-
-
Helmut Hummel authored
When creating a new image file the indexing process must not try to extract width and height, when the file is empty to avoid warnings. Resolves: #92455 Releases: master, 10.4, 9.5 Change-Id: I6e906285c2767c8997c77df258ce6fe085e12790 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65968 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Simon Gilli authored
This patch ensure the message send loop breaks after a message was sent successfully. The doSend() method is rewritten to increase the readability. Also a minimal unit test is added to verify the functionality of the FileSpool. Resolves: #91764 Releases: master, 10.4 Change-Id: I5fce3c98fc302739da071f0a5f1f16de61eb198b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66139 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Gerdes <markus@madaxel.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
This also deprecates two GeneralUtility methods which do not belong in this class, and makes the API more understandable and better documented. Resolves: #92551 Releases: master Change-Id: Ibb8b02ae11c76f3f7f65bf0a3eb22c82e94127e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65749 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Since TYPO3 v10 the history is connected via the correlationId in DataHandler and the setHistory() method does not need the third argument anymore. This change removes the third argument, and removes the only two usages in Workspaces. The method is marked as internal, and the argument has no value. For this reason, we can remove the method argument. Resolves: #92569 Releases: master Change-Id: I298e24b81336dbddfd477f0881f752f99300a894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66144 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Chris Müller authored
The patch removes the visual quote style in "searchFields.[key]". It also clarifies that the "User-Agent" header is meant. Additionally, the "Default" values are inserted where missing so that it is rendered correctly within the table-row container. Resolves: #92567 Releases: master, 10.4 Change-Id: I8d22ab7ea73058c6b2f41c1c7a74bef38e5be813 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66142 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Oct 14, 2020
-
-
Christian Kuhn authored
The 'you can not delete pages that have sub pages' user settings restriction has been annoying ever since. Users who actually want to delete a full tree were annoyed by this flag if they did not had it and had to rely on an administrator action to actually give it to them, and had to delete pages on a one-by-one base meanwhile. Clever admins thus often enabled that flag by default. It was meant as a feature to prevent casual users from commiting accidential harm to a site tree. There are better ways to achieve this goal however: Admins can set proper access rights for important key pages preventing editors from deleting them. Furthermore, a better 'prevent editors from doing harm in live' way is available by using the workspaces extension. And, in case of accidental deletion, admins can always resurrect full page trees using the recycler extension. The patch drops the 'recursive delete' option from specific user settings and always allows deleting pages including sub pages. Resolves: #92560 Releases: master Change-Id: I8401edc10daece7f83d0c5f85f99129616fac957 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66136 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The IP-locking functionality is disabled in TYPO3 v10 by default due to IPv4/IPv6 hopping ("Happy eyeballs"), however the per-Backend-User option is now removed, as it effectively needs custom enablement. IF IP locking is needed for the backend, this is now configurable only on a per-installation basis. If needed, it is recommended to implement this feature, which was disabled by default (which depends on a feature, which is disabled by default) as a custom extension. Resolves: #92559 Releases: master Change-Id: I9b9b70dab4d3240bd72d8b3979140fc1a5a46811 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66093 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Oct 13, 2020
-
-
Benni Mack authored
This field was used for sys_action, which is not part of TYPO3 Core anymore. Instead, this should be part of the records' history. Resolves: #92558 Releases: master Change-Id: I775d6d6f7318359b62d5338cb8ee986dfe93ef08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66092 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The "all versions" view of the extension manager, displaying details on any given extension, is extended to also show the extension constraints, similar to the display in TER. Furthermore a warning is shown for TYPO3 and PHP dependencies if they do not match the current version. Resolves: #92538 Releases: master Change-Id: I918dfd1d80eb4fffcc633278f742429dfdfdea47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66102 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Simon Gilli authored
The interface Symfony\Component\Mailer\Transport\TransportInterface expects a RawMessage and an optional Envelope if it's not already part of RawMessage. Currently an instance of Symfony\Component\Mailer\SentMessage is sent which is not compatible. This patch changes this behavior to send the original message and the envelope like already done in the MemorySpool. Resolves: #92053 Releases: master, 10.4 Change-Id: I2eb1a6a40c192ac433c6cc112b05432018411312 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66058 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Gerdes <markus@madaxel.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Markus Gerdes <markus@madaxel.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Since the removal of t3ver_state=3 move placeholders, the db field t3ver_move_id is obsolete and can be dropped. The patch drops field creation from DefaultTcaSchema for workspace enabled TCA database tables and removes the field from all functional test related CSV fixuture files. Change-Id: I3f1a0e07c415bc6bf3e44d4b30358561123ec9d8 Resolves: #92555 Related: #92497 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66111 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
Build/Scripts/checkIntegrityCsvFixtures.php --fix destroys field content that contain double quotes. Quote them properly. Resolves: #92554 Releases: master, 10.4, 9.5 Change-Id: Ib82974580a232eb4320303b3729b1ab1fda90c97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66110 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
A couple of bug fixes and backwards compatible preparations for upcoming core master patches. composer require --dev typo3/testing-framework ^6.4.6 Change-Id: Idd0f43c3b0ff6f3118a5d83556309482c1cd4a13 Resolves: #92552 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66108 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stephan Großberndt authored
This patch changes the behaviour when searching by username in the backend module "SYSTEM"->"Backend users": Before a LIKE search on the backend user UID was done, this leads to an SQL error at least on PostgreSQL, thus from now on searching in UID is only done if the term is an integer and then only returns exact matches instead of returning user with uid "1" and "10" when searching for "1". Resolves: #92520 Releases: master, 10.4, 9.5 Change-Id: I9820cae2a81b85dba68ba9bb00aeaa52cd2647eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66087 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Thomas Löffler authored
A couple of functions in PageRepository allow to define the fields to be selected. Because the `uid` is used internally to further process the selected row, this field is mandatory and must be present in a custom fields list. This fact is now documented in all corresponding PHPDoc blocks. Resolves: #91421 Releases: master, 10.4 Change-Id: I957da54a8fd399e375cd601e89a735821d04c3f0 Signed-off-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64506 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Oct 12, 2020
-
-
Benni Mack authored
Workspaces ("Element-based versioning") previously had - due to the "pid=-1" logic until TYPO3 v10 - a so-called "MOVE PLACEHOLDER". This was indicated by t3ver_state = 3, all relevant fields: * t3ver_state = 3 (move placeholder) * t3ver_oid = 0 no connected live record, it allowed fetching these records with one query together with live records as db restrictions t3ver_oid > 0 * t3ver_wsid = workspace UID * t3ver_move_id = UID of the live record * pid = new PID the version was moved to * sorting - when a record was moved within page with activated sorting Other record fields were not important. However, when moving a record, the value from TCA ctrl section "shadowColumnsForMovePlaceholders" was used to fill in gaps from the live record. The ACTUAL versioned record was indicated by t3ver_state = 4, the so-called "MOVE POINTER". In previous version until TYPO3 v10, it's PID field was set to -1, but since TYPO3 v10, it has the same PID as the "MOVE PLACEHOLDER". Characteristics of the move pointer as of TYPO3 v10: * t3ver_state = 4 (move pointer) * t3ver_oid = UID of the live record * t3ver_wsid = workspace UID * t3ver_move_id = 0 * pid = PID the version was moved to * sorting - same value as the live record (not evaluated until now) * All other fields with optionally modified content Both move placeholder and move pointer did not know each other directly. Fetching the move pointer for a move placeheldor (or the other way around) involved the live record, leading to many queries. The patch obsoletes the move placeholder records, moving necessary information to the move pointer: It now contains the updated sorting and is considered in the Database Restrictions to be fetched. In general, when publishing, the moved record now behaves identical to the other versioned types. This makes the internal code much easier, creates less DB queries on read + write and leads to less DB records in the database. The change removes creation of move placeholders, and considers the move pointers when evaluating sorting and PID in DataHandler. Read functionality from BackendUtility and PageRepository don't need an additional step to fetch the live version of a move placeholder anymore. An upgrade wizard takes existing move placeholders (state=3), updates pid+sorting (PID generally not needed, just to be sure) of the move pointer (state=4) and then deletes the move placeholder. TCA definition $TCA[my-table][ctrl][shadowColumnsForMovePlaceholders] is not needed anymore and removed by an auto TCA migration. Finally, workspace enabled tables do not need the t3ver_move_id field anymore: The live record UID is already in t3ver_oid field for state=4 records, just like with all other versioned records. The field will be fully removed with a separate patch in order to keep the actual CSV tests readable for this patch. Resolves: #92497 Releases: master Change-Id: I206336aec8be8a324fefdfd69f648f5a298c6ad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65797 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Both Domain\Model\Extension and Domain\Model\Dependency now have factory methods to avoid using the ExtensionModelUtility to build objects in an atomic state. This marks the ExtensionModelUtility class obsolete, which resolved dependencies and built Dependency objects. The Dependency object is now not an AbstractEntity anymore, but more of a type ValueObject. However, since the Dependency object knows about the min/max version constraints, this logic is now shifted into this class, making the DependencyUtility much smaller in logic. Resolves: #92547 Releases: master Change-Id: I7116d0d2c4f0d08b4a503f48b75ab50bfc675d21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66100 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
With the new possibility to add more pages.doktype variants since TYPO3 v10, the DB field "pagetypes_select" is not large enough for let's say 50 custom page types. The DB field should be extended to allow any kind of custom doktypes to be selected. Resolves: #92548 Releases: master, 10.4 Change-Id: I2a13df7f1095a48187cdfa4acee04c623e3a088b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66103 Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
Matthias Stegmann <matthias.stegmann@b13.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Desiree Lochner <desiree.lochner@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
David Steeb <david.steeb@b13.com> Reviewed-by:
Matthias Stegmann <matthias.stegmann@b13.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Desiree Lochner <desiree.lochner@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Tymoteusz Motylewski authored
Add index on the felogin_forgotHash field of the fe_login table to speed up db queries send when user requests password reminder. Resolves: #92485 Releases: master, 10.4 Change-Id: I100557a82fe352eb6c078df65c6f8b81a1e92802 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66055 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Daniel Goerz authored
Resolves: #92536 Related: #92532 Releases: master Change-Id: Ib11897a1427cea1d60d82961294cfad743471487 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66101 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
A feature which was built for the introduction package back then, which allowed to ship a modified / custom extension as dependency, where one could put another extension in EXT:my_ext/Initialisation/Extensions/another_ext is removed, as this special case is a) not needed anymore b) not following any rules of being conformant for "dependency hell" c) specific for dependency handling of TYPO3 (non-composer) Resolves: #92532 Releases: master Change-Id: I7e7d8681a81e184835122ae221971e5eab435778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66097 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Oliver Bartsch authored
In #92457 a new field `remote` was introduced to `tx_extensionmanager_domain_model_extension`. As it was not added to the corresponding TCA, accessing the value through the extbase model throws an exception when installing an extension in Extension Manager. It's therefore now added to the TCA, enabling the automatic extbase mapping. Resolves: #92533 Relates: #92457 Releases: master Change-Id: I685ce04d18f7c623372ac809cc5a339fc64e31c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66099 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-