- Jan 10, 2020
-
-
Benni Mack authored
Using Class constants instead of constants that are defined during runtime has the following benefits: - Naming can be made more consistent (and separated) - Speeding up requests where the constants are not needed - Benefit from Opcaching of class loading instead of dynamic runtime definition - Testing framework has less "bootstrap" to do This affects the following constants: - TYPO3_copyright_year - TYPO3_URL_GENERAL - TYPO3_URL_LICENSE - TYPO3_URL_EXCEPTION - TYPO3_URL_DONATE - TYPO3_URL_WIKI_OPCODECACHE The constants are now deprecated. In addition, the "Typo3Copyright" class is now called "TYPO3Information". Resolves: #89866 Releases: master Change-Id: I607c90cb281179bda9875504d258daefd3471868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
With Dependency Injection, the new PSR-14 based EventDispatcher, built into TYPO3 Core should never be exposed to our core code, since we should always reference the EventDispatcherInterface. We do this in almost all cases, except for a few places where we introduced PSR-14 before DI. Resolves: #90034 Releases: master Change-Id: I59e74333360c98b3c2e16c1b3df6fbd8bbf450f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62778 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change cleans up some RelationHandler code: - Working with true boolean inside RelationHandler for getValueArray() - RelationHandler->MM_oppositeFieldConf is an array, but declared wrongly as string (since forever!) - detecting the MM_oppositeTable property should not need a $tmp variable, but using a direct assignment - and unset() is not needed due to PHP7s memory management - internal $isSet flags should be boolean, instead of a number Resolves: #90066 Releases: master Change-Id: Ifff2a016a7be945ba6a1dd265e06b1e52bee5de7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62830 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Georg Ringer authored
The method inet_pton returns false if the provided IP address is invalid. This needs to be checked to avoid errors. Resolves: #90059 Releases: master, 9.5, 8.7 Change-Id: Ic3c7955eb64aff723b31862ef9c7c95e31a098b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62833 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
During the TYPO3 v9 install tool refactoring, a simple PHP array syntax mistake did not correctly set the fluid variable "systemInformationCgiDetected" which always resulted in not running in a CGI environment. The change adapts the array variable assigment. Resolves: #87320 Releases: master, 9.5 Change-Id: I2368ff033a6318d67c9153be20816d13ad8bd08d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62837 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Michael Schams <typo3@2018.schams.net> Reviewed-by:
-
- Jan 09, 2020
-
-
Helmut Hummel authored
The AbstractTask always had methods setScheduler and unsetScheduler to avoid serialization of the scheduler instance. These methods are called by the scheduler API before serializing (unset) and after unserializing (set). Use these methods in favor of the __sleep and __wakup calls to avoid issues with third party subclasses that implement these methods and to make sure tasks that are already serialized with an outdated logger instance are properly updated on next run without the need to clean them up manually. Releases: master, 9.5 Resolves: #86941 Resolves: #87780 Change-Id: I140973fa952c5c41b8eac966ba3b541420ec060b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60306 Tested-by:
-
Benni Mack authored
The symfony/mailer instance needs an email address in the form of new Address($emailAddress, $name); The MailUtility::getSystemReplyTo() returns a strange (Swiftmailer-like) syntax, which was implemented wrong when migrating to Symfony/Mailer. The change switches the constructor arguments to be used in the correct order ($email, $name). Resolves: #90040 Releases: master Change-Id: I2f2bfc67b47fdd1327895c96bd27b2d481805a1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62836 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
The BasicFileUtility was very important before the FAL API was introduced in TYPO3 v6. Since TYPO3 v10, the last important parts have been removed, which is why the PHP class is now marked as internal. In addition, several internal methods have been removed, the "setFileExtensionPermission" method is still there in order to avoid PHP Fatal Errors so extensions can stay compatible with TYPO3 v9 and TYPO3 v10. Resolves: #90020 Releases: master Change-Id: I1c6903f914722c5ddca79dd16f5766984f8c10db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62764 Tested-by:
-
Benni Mack authored
To optimize TYPO3 for Opcaching and speeding up performance, as well as simplyfing the bootstrap (also for the testing framework) the constants * TYPO3_version * TYPO3_branch are moved to a new PHP class "Typo3Version". This reduces the necessity to define the constants, and since TYPO3 Bootstrap continues to use the class, the constants are defined in the constructor for TYPO3 v10, and will be removed in TYPO3 v11. Resolves: #90007 Releases: master Change-Id: I18942023c0e234a328d45f724a6b3092c801982c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62740 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Benni Mack authored
LinkAnalyzer now stores the response as JSON instead of PHP serialize. A fallback mechanism when unpacking uses unserialize() as fallback to keep records in the database. Resolves: #89944 Releases: master Change-Id: Ic3a2ba058d916936cc5c46a0a8e279bc07bfe60c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62631 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
- Jan 08, 2020
-
-
Benni Mack authored
RelationHandler->dbPaths was added in 2003 by kasper, but NEVER ever used since then in TYPO3 Core, or does it serve any purpose. So this property can safely be removed. Resolves: #90065 Releases: master Change-Id: I361925e68e1025436799ceb97c7e1156d45e250a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62829 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Hader authored
* avoid assigning and forwarding multiple variables * preparation for further enhancements of view helpers * Uri UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest) and to 1/3 a simple additionalParams case * Link UnitTest case mostly tested TypoLinkCodecService (it was a FunctionalTest) Resolves: #90022 Releases: master Change-Id: If65e42d4ca8085855f3f335d1eb2604be9a36fe0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62775 Tested-by:
-
- Jan 07, 2020
-
-
Chris Müller authored
The maximum line length of documentation files (80 characters) should be reflected in the .editorconfig as described in https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/GeneralConventions/CodingGuidelines.html#line-length Resolves: #90054 Releases: master, 9.5 Change-Id: Ib1c3f2f2fbae999b7d157949f1a59876c2ff451d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62818 Tested-by:
-
- Jan 06, 2020
-
-
Oliver Hader authored
Resolves: #90057 Releases: master, 9.5 Change-Id: Ifee8153c4f49b7fdde544a51bc19ee7d6e21b323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62821 Tested-by:
-
Naderio authored
Correct formatting of codeblock in "Link Browser" description. Releases: master, 9.5, 8.7 Resolves: #90058 Change-Id: Ifbfff20a38cadef84e7e9c500fb846f2bbdccd3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62822 Tested-by:
Rudy Gnodde <rudy@famouswolf.com> Tested-by:
-
Oliver Hader authored
Permutations are currently used in test cases - however it would be possible to make use of this functionality in regular sources as well. That's why corresponding methods are moved into a new PermutationUtility implementation. Resolves: #90055 Releases: master, 9.5 Change-Id: I05d978ada2021c7db1b7abeb8a21a825472ae8cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62819 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Dec 31, 2019
-
-
Sybille Peters authored
The <be:link.editRecord> and <be:url.editRecord> now have an option argument "fields" which can be used to limit the edit form to only these fields (instead of the entire record). The fields should be passed in a comma separated list. Resolves: #89644 Releases: master Change-Id: I28913c072578aacd1da95c3bacebea35f8958bac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62298 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Michael Schams authored
Symfony version 5 expects an integer as the return value from Command::execute() in the Command class. This bugfix returns 0 to satisfy Symfony version 5 requirements. Resolves: #90032 Releases: master Change-Id: Id759707091f6695388b19b9d081beaf8c137c3cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62780 Tested-by:
-
Benni Mack authored
The change of issue #90019 introduced a mis-spelling in hte variable naming, where the variable was named "$tscPid" but the original code was "$tscPID" which should be used as well. Resolves: #90041 Releases: master Change-Id: Idaad179968fb4b0953f7b12a8c7660793797cf02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62812 Tested-by:
-
Oliver Hader authored
TYPO3 backend does not need PHP session handling since it has its own session handling implementation. Resolves: #90024 Releases: master Change-Id: I9d8ccaf38c62b86d3b6945b2c631a2602b4aa73f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60173 Tested-by:
-
Benni Mack authored
TYPO3's page permissions are based on five fields and a bitset. - perms_userid - perms_groupid - perms_user - perms_group - perms_everybody For permissions of a page there is - show page ("show") - edit page properties ("edit page") - edit page contents / records ("edit content") - delete page ("delete") - create new subpages ("new") In addition, these can be pre-set globally or via PageTSconfig. The DataHandler currently uses a mix between strings and integers for defining these values. A new PagePermissionAssembler class builds together the page permissions now, allowing to thin out certain parts of DataHandlers responsibility. The following properties and methods are now deprecated: - DataHandler->defaultPermissions - DataHandler->pMap - DataHandler->setTSconfigPermissions() - DataHandler->assemblePermissions() The methods - DataHandler->doesRecordExist() - DataHandler->recordInfoWithPermissionCheck() should only be called with integers as permission argument in the future. Resolves: #90019 Releases: master Change-Id: I3724cb8661fe2b7cc5e1f8ab34d17dd4fa68c11b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62763 Tested-by: -
Herman Kremer authored
The populate page slugs functionality in de upgrade wizard does not work correct for pages with multiple title adjustments. Realurl keeps for every page title change a record in tx_realurl_pathdata. In order to get the latest change a order should be added to the query in getSuggestedSlugs. Resolves: #89964 Releases: master, 9.5 Change-Id: I4b7fad14fc559e6c9e8a4fb6f6a2a112a290d7e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62754 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
-
- Dec 30, 2019
-
-
Benni Mack authored
With TYPO3 v8.6, the new Content Types for menus were introduced where each menu type is not stored in the database field "menu_type" anymore, but moved to a separate "CType" property. This change was breaking, however some left-over code was there but never removed. The code does not do anything anymore but handle the special "menu_type" cases like in Page Module CType Previews or categorization handling. FYI: This is a pre-patch to streamline the category API. Resolves: #90035 Releases: master Change-Id: I180fc5b1e2d33f74cf05d2565ab11049cc361c49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62785 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
Tests should use getAccessibleMock() in all cases so our testing API is used consistently everywhere. The tests also show that some changes could be made without having accessible proxies nowadays. Resolves: #90037 Releases: master Change-Id: I4a3f2948d9f645d736949fed4161cd91b1f3df0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62789 Tested-by:
-
Anja Leichsenring authored
Tests can use the core function StringUtility::getUniqueId(), after both functions provide the same service. Resolves: #90021 Releases: master Change-Id: I57fc362e3e93b1aa963ea497f210144cab5cea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62774 Tested-by:
-
Alexander Schnitzler authored
php bin/rector process A couple of rectors have been disabled due to different reasons: - Rector\Php71\Rector\FuncCall\CountOnNullRector This rector has been disabled as it creates rather long and complex structures to avoid calling count on null. This rector will be enabled as soon as TYPO3 uses at least PHP 7.3 which introduces a "is_countable" method. - Rector\Php71\Rector\Assign\AssignArrayToStringRector This rector has been disabled as it does not work properly. The default types of parameters have been changed although their types could properly be inferred by a doc block or by value assignments. - Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector This rector has been disabled as it does not work properly. A bug report is filed and to be found here: https://github.com/rectorphp/rector/issues/2454 - Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector This rector has been disabled as it does not work properly. It removed arguments in tests, especially when using prophecies. Releases: master Resolves: #90002 Change-Id: I6ed14d38cc697a23104286db57535d6a3c0dbf62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62751 Tested-by:
-
Benni Mack authored
With PHP 8 on the horizon, TYPO3 Core should be prepared to also disallow files with the file extension ".php8" for uploading. Resolves: #90023 Releases: master, 9.5, 8.7 Change-Id: I670755c5ae09ccf6ffd49c4b91b4617956f76ad7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62776 Tested-by:
-
- Dec 28, 2019
-
-
Benni Mack authored
Resolves: #90027 Releases: master Change-Id: I0783db5e26ceaba836a618f6dfce104080a4762d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62777 Tested-by:
-
Stephan Salzmann authored
The example claims to result in'.../detail/...', site configuration needs to reflect that. Releases: master, 9.5 Resolves: #90017 Change-Id: I3d6d133294763ee0e3e089c102a325a70ca3e1ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62772 Tested-by:
-
- Dec 27, 2019
-
-
Tymoteusz Motylewski authored
Releases: master, 9.5 Resolves #90025 Change-Id: I8e155f7f15bf291bddf11c74cead8c68c91de49f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62198 Reviewed-by:
-
Tizian Schmidlin authored
`TYPO3\CMS\Core\Routing\PageRouter::getPagesFromDatabaseForCandidates` looks-up candidates for the page using the `slug` field (and also sorts by this value). This has some serious impact on the website performance on systems with lots of pages. In order to optimize this, an index should be set. Releases: master Resolves: #88896 Change-Id: I1aecca781db9562243a15341819b3ce261708836 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61403 Tested-by:
-
Christian Eßl authored
Several parts of the core use the regular expression /date|time|int/ to test, if an 'eval' TCA configuration of a field contains one of these evaluation strings. This regex would however match any other string that contains one of those words. This patch fixes this behaviour by matching only the exact words. Resolves: #40347 Releases: master, 9.5 Change-Id: I2af1e3bf5b5cc4056f0e3875645c549a01e6dbd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61885 Tested-by:
-
Susanne Moog authored
Resolves: #89842 Releases: master, 9.5 Change-Id: I42ffcc313290867d0410265f4c900225ceb554e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62545 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benni Mack authored
The flag for TYPO3's supported galacian is now added with the "gl.png" flag. TYPO3 core previously had the "greenlandic" ("kl") named under the same file, which was now renamed. Resolves: #89929 Releases: master Change-Id: Ia267dbf7f3e4a2bec67d6534bf26eddc4aaf71b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62759 Tested-by: -
Anja Leichsenring authored
The function in testing-framework provides a string that is target to be used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it to produce a random userId, which needs to be an integer. If the randomly produced string contains not only numbers, the cast operation converts the uid to 0 and therefor prevents a DB query from execution. This prevention results in a not consumed mock object, which in turn causes a integration test failure. Resolves: #90018 Releases: master, 9.5 Change-Id: I559041591a600a04da86e8b4a85cf5e6dd176475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62773 Tested-by:
-
Tobias Gaertner authored
For upgrading from an old versions where EXT:realurl was used the PopulatePagesSlugs upgradeWizard is in place. It now also respects the tx_realurl_pathsegment field in generatorOptions. The workflow is now, that it takes the page:tx_realurl_pathsegment field and if empty falls back to page:title. Resolves: #89069 Releases: master, 9.5 Change-Id: Ia9c6367d46713a8a1a609ef13c6bbd8878ec6bed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62748 Tested-by:
-
Michael Telgkamp authored
Add keyboard interaction acceptance tests for the pagetree interactions. Currently testing Home key, End key, navigation with Up and Down keys, opening a selected entry with Enter and collapsing and expanding of subtrees with Left / Right keys. Resolves: #89832 Resolves: #89955 Releases: master Change-Id: Ibe3c83fe6142296e333a66e68d67e283e2000957 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62521 Tested-by:
-
Anja Leichsenring authored
The extension does not exist for TYPO3 versions above 8, so the report must not exist either in these versions. Resolves: #89963 Releases: master, 9.5 Change-Id: I0de6b2646253a755b554b48dadabbfcb2bc1b795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62674 Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Tested-by:
-
Oliver Hader authored
Resolves: #90016 Releases: master, 9.5 Change-Id: Id7fc792515cfc333118105ae832c2f283e455535 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62770 Tested-by:
-
Anja Leichsenring authored
The trigger will cause the plan to be executed after merge, which is not needed because nightly plans take care of it. Resolves: #89972 Releases: master, 9.5, 8.7 Change-Id: Iafc32174d2234439915c2e741020c4626391f98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62721 Tested-by:
-
