- Jul 23, 2018
-
-
Anja Leichsenring authored
The removed test was skipped for a long time, and its intended guarding against the usage of objects in extbase requests does not apply. Resolves: #85610 Releases: master Change-Id: Icf401ff50badba4d8d33405d86708ec7af157516 Reviewed-on: https://review.typo3.org/57649 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Jul 22, 2018
-
-
Christian Kuhn authored
Executing functional tests on mssql has been disabled a while ago since the daemon crashed frequently: The server can not run on tmpfs volumes that we usually use to speed up database operations. sql server uses O_DIRECT i/o system calls which tmpfs does not support. Find details at https://github.com/Microsoft/mssql-docker/issues/12 We now run mssql tests on hard disks again, but enable them only as nightly since they are too slow as pre-merge tests. Change-Id: Iefc61670dcf74012fcdaada8e5b771538e7cf8c3 Resolves: #85614 Releases: master Reviewed-on: https://review.typo3.org/57641 Tested-by:
-
Ioulia Kondratovitch authored
In content elements of form_formframework, the order of finisher options offered for overriding will be in accordance with the order defined in FormEditorSetup.yaml. Resolves: #85435 Releases: master, 8.7 Change-Id: Ie506858bc363c62af02a123b27c84cb9754dbda3 Reviewed-on: https://review.typo3.org/57420 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
Update comments in the code not to mention tce_db.php. The tce_db.php entry point is gone since v8. The SimpleDataHandlerController is responsible for pushing data from request to DataHandler. Resolves: #85600 Releases: master, 8.7 Change-Id: I6d323a9aab77ab67ff811970ff3c0f47dbf84340 Reviewed-on: https://review.typo3.org/57636 Tested-by:
-
Anja Leichsenring authored
The test was skipped, its guarded functionality does not exist. Change-Id: I683a3be8ace5556052e948ca9d35eedcadd79c29 Resolves: #85612 Releases: master Reviewed-on: https://review.typo3.org/57652 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
- Jul 21, 2018
-
-
Benni Mack authored
An unused if() statement removes the last occurrence of this method, so it can be deprecated. Resolves: #85554 Releases: master Change-Id: Ica80f66f7fdce4d72c8d97d0405360c307ca14dd Reviewed-on: https://review.typo3.org/57593 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Jul 20, 2018
-
-
Christian Kuhn authored
typo3.org git/gerrit show flakiness lately. To not torture the poor servers with our pesky testing so much we switch the git clones to github/TYPO3/TYPO3.CMS and hope merges are mirrored over there more quickly and they sustain our testing load easily. Resolves: #85606 Releases: master, 8.7, 7.6 Change-Id: I772d945a3bf697172cb26edb761f01e6cb8da4bf Reviewed-on: https://review.typo3.org/57643 Tested-by:
-
Ralf Zimmermann authored
Define the "label" property for tt_content form elements within the form setup to allow saving tt_content form elements. Resolves: #85578 Releases: master, 8.7 Change-Id: I490a43692a9f54ef843e9362d0f700a9e5552106 Reviewed-on: https://review.typo3.org/57616 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Benni Mack authored
Also config.concatenateJsAndCss TypoScript is replaced with concatenateCss and concatenateJs since TYPO3 v6.0, and can now be deprecated. Resolves: #65578 Releases: master Change-Id: I23ee9637a3c880c67a93a6f9771a9bfab5ed6ac3 Reviewed-on: https://review.typo3.org/57629 Tested-by:
-
Wouter Wolters authored
Resolves: #85479 Releases: master Change-Id: I576ab5fb6a7937016497a93d3b4dd025478e81bd Reviewed-on: https://review.typo3.org/57468 Tested-by:
-
Benni Mack authored
The field "uid" is never fetched, so no count() is possible in the DB count query. Resolves: #85252 Releases: master, 9.3 Change-Id: I9a3f1cb13bf20dcbe4bfb5451afd465e5981ecb4 Reviewed-on: https://review.typo3.org/57634 Reviewed-by:
-
Benni Mack authored
The method is just a wrapper for PageRepository->enableFields() which should be used instead. Resolves: #85558 Releases: master Change-Id: I5fd18ef3e101325bc95f4d0147899d961f5898f6 Reviewed-on: https://review.typo3.org/57598 Tested-by:
-
- Jul 19, 2018
-
-
Christian Kuhn authored
Bring back backend acceptance test execution as pre-merge and nightly tests. They are hopefully more stable now and we'll test if they survive the hard pre-merge load without being too flaky.. The patch changes the bamboo plan specs accordingly but disables a couple for FormEngine related detail tests that need further investigation. The patch also fetches a new patch level of testing-framework to have proper ac path definition of the ac splitter script: composer update typo3/testing-framework Change-Id: Iffcfd60391ba60d5ab2196a00a5bd0a4a93fff7f Resolves: #85599 Releases: master Reviewed-on: https://review.typo3.org/57635 Tested-by:
-
Markus Klein authored
Resolves: #85238 Releases: master Change-Id: Ie47e1ba0a4f0ba3e5e1a8d62bc137cabd3ae4d1e Reviewed-on: https://review.typo3.org/57125 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Reviewed-by:
-
Benni Mack authored
The TYPO3_OS constant is deprecated with the introduction of Environment API. Resolves: #85597 Releases: master Change-Id: Ie0f844d2d024f2a3f6acdf5af24debead6ba836b Reviewed-on: https://review.typo3.org/57632 Tested-by:
-
Benni Mack authored
Resolves: #85598 Related: #85553 Releases: master Change-Id: Ib5c0a6850c79880eac0eb47dab957083ca328e2b Reviewed-on: https://review.typo3.org/57633 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Ramon Zöllner authored
Fixed Link to Extension-Scanner Docs Releases: master Resolves: #85595 Change-Id: I181b34497db5d0f2807c035d6228f6fb9f2f31a4 Reviewed-on: https://review.typo3.org/57631 Reviewed-by:
-
Benni Mack authored
The default value for - PageRepository->getPageOverlay() - PageRepository->getPagesOverlay() should be "null" and not some magic "-1" usage. Resolves: #85553 Releases: master Change-Id: Ic665c4a563e6496678ab944c80901db26f2b72ba Reviewed-on: https://review.typo3.org/57591 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Oliver Hader authored
When determining the SaltedHashingMethod of a salted hash check only SaltedHashingMethods which are marked as available. Resolves: #85526 Releases: master, 8.7 Change-Id: I72ca88ce35c891dc149d0628543d30b6c4122407 Reviewed-on: https://review.typo3.org/57520 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jul 18, 2018
-
-
Markus Klein authored
Resolves: #85236 Releases: master Change-Id: Iad1047b7a91adee4d0dcad766d5116bea27e34ce Reviewed-on: https://review.typo3.org/57198 Tested-by:
Jürgen Venne <venne@schaffrath-digital.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Michael Giek authored
The source page redirects now also with get-parameters to the target page. Resolves: #85538 Related: #85488 Releases: master Change-Id: Ibc1ae6afdbe11065156201e8118838203e427cf3 Reviewed-on: https://review.typo3.org/57569 Tested-by:
-
Christian Kuhn authored
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Andreas Fernandez authored
Since our code does not work with doctrine/dbal 2.8.0 we for now pin to the previous minor release. A hidden dependency to doctrine/collections is also removed by using the ExpressionBuilder constant instead. Used command: composer require doctrine/dbal ~2.7.0 Resolves: #85575 Related: #85552 Releases: master Change-Id: Icc8d41c566cf39d15a4eae500b8b216a44689dce Reviewed-on: https://review.typo3.org/57613 Reviewed-by:
-
sascha307050 authored
Releases: master,8.7 Resolves: #85589 Change-Id: I965f559b0307bd477e8f64340a12513a9827842d Reviewed-on: https://review.typo3.org/57624 Reviewed-by:
-
Stefan Neufeind authored
In composer-mode the autoload-information can't be dumped. A FlashMessage is shown as a notice. But the message itself was left empty and instead a message-title was given which is not shown in the backend. Resolves: #85515 Releases: master Change-Id: Ie8e59fb5272f1a1682b19652ac991e5dbee6a4e3 Reviewed-on: https://review.typo3.org/57511 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
Tymoteusz Motylewski authored
When PID of the parent record has not changed, child records should not be moved/sorted. Little background helping reviewing the patch: The 2 important changes are made in DataHandler.php line 4603 and DataHandlerHook.php around line 346. In both cases the condition is added checking if the destination PID of the record is the same as current one. In that case, processing of the IRRE children is skipped. All the changes made in the .csv files are reflecting that. To validate them one can compare the content of the csv files with LiveDefaultElements.csv datasets. For example, check that sorting values in file: core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv are the same as in the: core/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv In the Workspaces related datasets, you will see that there are no move placeholders for IRRE children any more (and versioned records have 0 instead ...
-
Felix Althaus authored
Use :=getEnv() in TypoScript to read values from environment variables. Resolves: #85146 Releases: master Change-Id: I6c480627e4b07f76f4d8887df0db9d95fd75e6d9 Reviewed-on: https://review.typo3.org/57115 Tested-by:
Hannes Lau <office@hanneslau.de> Tested-by:
-
Oliver Hader authored
ModuleMenu and Viewport initialization need to be defered to ensure that DOM is available in order to apply further behavior in mentioned client implementation. Resolves: #80312 Releases: master, 8.7 Change-Id: I9581a7f2164050f73683928b8f2ebe1d69a6d5e7 Reviewed-on: https://review.typo3.org/57526 Tested-by:
-
Peter Kraume authored
This patch improves the usability of the new Settings module by moving the extension configuration card in the first place since this will probably be the most used card in the Settings module. Resolves: #85546 Releases: master Change-Id: I21aa5bcccacd49b0ab6a67c5bf87812f295b0c49 Reviewed-on: https://review.typo3.org/57584 Reviewed-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Marco Huber <mail@marco-huber.de> Tested-by:
-
Wouter Wolters authored
Resolves: #85293 Releases: master Change-Id: Ifabbb20c1ef4ad482df676fe9999dcbdf18eb704 Reviewed-on: https://review.typo3.org/57249 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
-
Stefan Neufeind authored
The description so far says fieldnames are prepended. Resolves: #85507 Releases: master Change-Id: I06fccdc2aee70a95e64cb14adccba0e24a22c1cb Reviewed-on: https://review.typo3.org/57499 Tested-by:
-
Benni Mack authored
The unused method TypoScriptFrontendController->getUniqueId() is marked as deprecated, as this method conceptually should go into a custom service with a singleton pattern or a runtime cache, but not within TypoScriptFrontendController. Resolves: #85555 Releases: master Change-Id: Ib3af4b32e3c03d90b832ee725dcf9846af92f9ba Reviewed-on: https://review.typo3.org/57597 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Mathias Brodala authored
Change-Id: I9f396da2084880b3dd813c8d7f0777c36ac989d9 Resolves: #84414 Releases: master Reviewed-on: https://review.typo3.org/56331 Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Tested-by:
-
- Jul 17, 2018
-
-
Christian Kuhn authored
bamboo php 7.2 has apc & apcu support again. Two unit tests fail. These two however don't make much sense in the first place since they md5(internal-knowledge). Remove them. Resolves: #85584 Releases: master Change-Id: I5f1e1589189866508e684a7ca1bb6cae87d22fad Reviewed-on: https://review.typo3.org/57621 Reviewed-by:
-
Christian Kuhn authored
The bamboo containers need a better passwd mapping per agent to set a proper home directory, otherwise ssh tasks may fail. Resolves: #85582 Releases: master, 8.7, 7.6 Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c Reviewed-on: https://review.typo3.org/57618 Tested-by:
-
- Jul 16, 2018
-
-
Tymoteusz Motylewski authored
It's based on tt_content and categories. Releases: master, 8.7 Resolves: #85493 Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599 Reviewed-on: https://review.typo3.org/57474 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
Resolves: #85552 Releases: master, 8.7 Change-Id: I1056a5825fd79df4c495894970721713b10728cd Reviewed-on: https://review.typo3.org/57603 Reviewed-by:
-
Christian Kuhn authored
Our unit tests should not rely on running daemons, there is a functional test environment to take care of this. The patch turns redis cache backend unit tests into funcitional tests and adapts the unit test setup to no longer start dependencies. Resolves: #85565 Releases: master Change-Id: I8d81209ed339d35af11bb06fb7cb191845b6b587 Reviewed-on: https://review.typo3.org/57607 Tested-by:
-
- Jul 15, 2018
-
-
Christian Kuhn authored
A new bamboo agent infrastructure has been deployed that significantly changes how tests are executed: The agent docker containers are now "stupid" and no longer bundle specific php versions or daemons. Instead, they can run own containers to start needed daemons for specific jobs and execute needed php commands in ad-hoc containers that provide the required php version. Daemons needed for single jobs are defined in a docker-compose.yml file provided by core itself. This docker-compose.yml file can not be used directly for local test execution since it has to fiddle quite a bit with docker volume mounts, networks and executing users that is specific to the bamboo environment. However, another yml file can be added later to ease local test execution in a similar way. The patch rewrites the bamboo plan pre-merge and nightly specs of core master to use the new infrastructure and brings a couple of minor changes to tests that rely on a running memcached or redis to retrieve the daemon host from an environment variable. There will be separated patche for older core versions. Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af Resolves: #85563 Resolves: #36934 Releases: master Reviewed-on: https://review.typo3.org/57522 Tested-by:
-
Jigal van Hemert authored
In CommandTest::testGetDescription() now also LF is used as line ending, just as in the tested function. Resolves: #85509 Releases: master, 8.7 Change-Id: I907e24b19d87d94a3fb1b3cbee9947d68358e5cc Reviewed-on: https://review.typo3.org/57501 Tested-by:
-
